Kiu/xenadmin
1
0
Fork 0
mirror of https://github.com/xcp-ng/xenadmin.git synced 2024-11-24 22:06:59 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
7,169 Commits 11 Branches 48 Tags 186 MiB
5416fc7514
Commit Graph

183 Commits

Author SHA1 Message Date
Alexander Schulz
a49162d9a1 removed xenserver specific code: updates, patches, rolling upgrades, yum repos, help manager 2024-01-01 20:08:28 +01:00
Konstantina Chremmou
22e1973023 Corrected positioning of DVD ISO list control. 
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
 2023-11-14 17:03:49 +00:00
Konstantina Chremmou
e28aa63aa5 The user could not create DVD from the Console TabPage while the same operation was possible from the VmStorage TabPage. 
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
 2023-11-01 10:49:59 +00:00
Danilo Del Busso
c1bb907a77
Remove useless lock around RemoteConsole calls 
If a different thread accesses this code, the assertion will throw a Fatal error before hitting the content of the `lock`.

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-08-17 15:42:52 +01:00
Danilo Del Busso
212543f4c0
Improve readability of ConnectToRemoteConsole in XSVNCScreen 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-08-17 15:24:57 +01:00
Danilo Del Busso
23391e7293
Improve variable naming in RdpClient.cs 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-27 13:43:29 +01:00
Danilo Del Busso
60a5580d20
Dispose of timer when creating new port polling Timer 
This avoids having too many timers running at the same time.

One could for instance update the `EnableRDPPolling` property from the `Options` dialog and start several concurrent `Timer`s

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-12 09:22:00 +01:00
Danilo Del Busso
84e294b4b7
Tidy up XSVNCScreen: fix whitespace 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:14 +01:00
Danilo Del Busso
559843f549
Tidy up XSVNCScreen: use explicit modifiers 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:13 +01:00
Danilo Del Busso
9618c11ba5
Tidy up XSVNCScreen: fix typos 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:13 +01:00
Danilo Del Busso
baea368447
Tidy up XSVNCScreen: fix missing uses of null propagation 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:12 +01:00
Danilo Del Busso
85414de2c2
Tidy up XSVNCScreen: Fix naming in file 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:11 +01:00
Danilo Del Busso
133cd456c6
Tidy up XSVNCScreen: use null propagation and conditional access 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:10 +01:00
Danilo Del Busso
4cfb129f6d
Tidy up XSVNCScreen: fix typo 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:10 +01:00
Danilo Del Busso
d28ec66a2b
Tidy up XSVNCScreen: remove cast with pattern variable 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:10 +01:00
Danilo Del Busso
56274d7298
Tidy up XSVNCScreen: merge conditional expression 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:09 +01:00
Danilo Del Busso
a55cc8ea7a
Tidy up XSVNCScreen: remove redundant type arguments 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:09 +01:00
Danilo Del Busso
d0e63e7bd7
Tidy up XSVNCScreen: remove redundant explicit delegate creation 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:08 +01:00
Danilo Del Busso
a79eaa0bcc
Tidy up XSVNCScreen: use var when possible 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:08 +01:00
Danilo Del Busso
67dd31fc44
Tidy up XSVNCScreen: remove redundant base() call 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:07 +01:00
Danilo Del Busso
2287672e44
Tidy up XSVNCScreen: use expression-bodied properties 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:07 +01:00
Danilo Del Busso
bcb3fdc00a
Tidy up XSVNCScreen: use built-in type references 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:06 +01:00
Danilo Del Busso
5ba0a42bd5
Tidy up XSVNCScreen: remove redundant initializers 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:06 +01:00
Danilo Del Busso
53fba195a7
Tidy up XSVNCScreen: remove this when unnecessary 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:06 +01:00
Danilo Del Busso
b8eb2b5549
CA-379640: Do not reset remote consoles if they're still attempting connection to a VM 
This prevents `AccessViolationException`s being called, as they're hit when two instances of `AxMSTSCLib.AxMsRdpClient9` call `Connect` on the same IP + Port combination, which results in the same memory being accessed in unmanaged code.

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:05 +01:00
Danilo Del Busso
9ea0a53447
Catch HRESULT E_FAIL exceptions for IRDPClient.Connect calls 
The `Connect` method returns `E_FAIL` if it is called while the control is already connected or in the connecting state. This can be hit when a lot of connections are being opened at the same time, and it's there as a failsafe.

Also adds `IsAttemptingConnection` as a new field

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:47:02 +01:00
Konstantina Chremmou
d7b519a53c Updated copyright notice on files. 
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
 2023-01-30 16:24:16 +00:00
Konstantina Chremmou
d0fdc5360b
Merge pull request #2980 from danilo-delbusso/bug/rdp-gray_CA-322672 
CA-322672: Do not stop polling for RDP capabilities on VMs
 2022-05-09 15:15:39 +01:00
Konstantina Chremmou
456cd93db8 A VncView is created for both VNC and RDP, so I don't see why it should be disposed of for VNC only. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-21 11:28:18 +01:00
Konstantina Chremmou
0c1541985c Check for docking should happen outside the VncView's Pause() method. 
Also, use Pascal case for property name to match C# conventions.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-21 11:28:18 +01:00
Danilo Del Busso
d17b99e6b0
CA-322672: Improve comments around RDP status checks 
`data/ts` indicates the VM has RDP enabled

`feature-ts2` is the feature flag indicating that `data/ts` is valid.

`feature-ts` is the feature flag indicating the toolstack can enable RDP remotely (by writing to `control/ts`)

the `network` object contains the IP info written by the `xenvif` driver (which needs a 1st reboot to swap out the emulated network adapter)

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-04-20 12:39:47 +01:00
Konstantina Chremmou
07f2de6786 Use C# naming conventions. Removed some code redundancies. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-12 10:32:57 +01:00
Konstantina Chremmou
c28bb4b34c CP-36392: Removed block that is never hit: 
The situation described in the comment is not applicable as scaling does
not change outside the UI thread, and OnResize() does call SetupScaling().

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-06 13:11:32 +01:00
Konstantina Chremmou
3c4808a689 Remove redundant code. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-05 10:19:13 +01:00
Danilo Del Busso
05ba1ce8a0
CA-322672: Partly tidy up VNCTabView.cs 
Apply some naming and styling conventions. Specifically, remove useless usages of `this.`, use arrow syntax for RDP fields, and remove redundant bool field initialisation

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-03-29 15:46:31 +01:00
Danilo Del Busso
1d98a298f5
CA-322672: Partly tidy up XSVNCScreen.cs 
Apply some naming and styling conventions.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-03-29 15:41:06 +01:00
Danilo Del Busso
c5d2e36564
CA-322672: Do not stop polling for RDP capabilities on VMs 
These changes keep polling open console connections to check the status of RDP capabilities.
This is necessary when installing/uninstalling VM tools on VMs. Without this, changes in the `guest_metrics` aren't spotted. Consequently, the user is not shown the option to connect with RDP until they disconnect (or the console session is disconnected), even if the VM is capable.
That is because before this, the polling for RDP changes (as performed by `connectionPoller`) was only started if the VM had RDP capabilities when first connecting to it with the console.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-03-29 15:34:09 +01:00
Darren Matthews
151841ce5e L10N : Translation Updates & Resx sync 
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
 2022-03-03 14:35:30 +00:00
Danilo Del Busso
2c5373323c CP-36392: Inherit IDisposable to avoid confusion 
Classes didn't extend IDisposable
Also used null propagation to tidy up method body

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-02-24 11:53:44 +00:00
Konstantina Chremmou
f29e267670 Some corrections and refactoring on the external console feature. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-17 14:09:34 +00:00
Danilo Del Busso
c9bb9c1f0c CA-362353: Add file existence check when launching SSH console 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-17 14:09:34 +00:00
Konstantina Chremmou
7ca120eb76 Fixed DialogResult and ButtonType for buttons (dialog was not closing on Esc or from control box). 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-06 10:50:13 +00:00
Danilo Del Busso
d27eaa3bbd CP-38529: Use pre-installed SSH clients to launch VM console 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-06 10:50:13 +00:00
Danilo Del Busso
47884376a3
CP-36392: Fix typo in VNCTabView.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:29:19 +00:00
Danilo Del Busso
38701d148e
Merge branch 'master' of https://github.com/xenserver/xenadmin into pr/2903 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenModel/Actions/GetDataSourcesAction.cs
 2021-10-27 13:24:23 +01:00
Danilo Del Busso
db2c00d54d
CP-36392: Cast operands of divisions to not lose precision 
Cast to `decimal` or `float` to keep floating-point precision

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-04 16:22:29 +01:00
Danilo Del Busso
3ffd370d81 CP-36392: Remove unused conditional structure in VNCTabView 
If check is virtually useless here

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-01 11:56:35 +01:00
Danilo Del Busso
a61f61d66f
CP-36392: Remove duplicate field in MultipleDvdIsoList.cs 
Also remove `VM` from designer

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-09-20 09:35:19 +01:00
Danilo Del Busso
157fe77f8f
CP-36392: Add comment to ignored catch blocks 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

CP-36392: Add missing comments to ignored catch blocks

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-09-20 09:35:17 +01:00
Danilo Del Busso
6aedaa7742
CP-36392: Refactor setter so that it actually refers to the field 'sendScanCodes' 
Removed private method is only referenced within the public setter

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-09-17 11:22:47 +01:00