Commit Graph

248 Commits

Author SHA1 Message Date
Danilo Del Busso
eba3305587
Prevent HostMemoryPostUpgradeCheck from running if required hotfixes are missing
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-03 16:03:17 +01:00
Danilo Del Busso
6eb09cbac4
CA-379402: Do not return Problems if the EUA check is run for upgrades to 8.2 CU1 or below
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-03 16:03:16 +01:00
Danilo Del Busso
594db56b6a CP-41573: Refresh pre-checks once EuaNotAcceptedProblem is fixed
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-06-26 10:11:19 +01:00
Danilo Del Busso
06ab09eabb CP-41573: Apply code review suggestions
- Ensure `UpgradeRequiresEUA` runs for Yangtze or greater hosts
- Group non-manual checks in same if block
- Remove unused field in `EuaNotFoundProblem`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-06-26 10:11:19 +01:00
Danilo Del Busso
6ce22f759a CP-41923: Update RPU005 to version 5.0
Also:
- Add `HostDoesNotHaveHotfixWarning` warning to EUA `Check` when necessary
- Filter our `null` EUAs before passing them to the `Problem`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-06-26 10:11:19 +01:00
Danilo Del Busso
c0f849e4fa CP-41573: Use existing generic message for EuaNotFoundProblem
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-06-26 10:11:19 +01:00
Danilo Del Busso
ffbf8e3cd0 CP-41573: Use wizard page as a parent of AcceptEuaDialog
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-06-26 10:11:19 +01:00
Danilo Del Busso
c463601e52 CP-41573: Add blocking problem if POST82X hosts cannot fetch the EUA
Also:
- Remove unused `button_click` event handler in `AcceptEuaDialog`
- Load EUAs within the `UpgradeRequiresEua` `Check` and removed the spinner from `AcceptEuaDialog`
- Remove `_errors` from `AcceptEuaDialog`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-06-26 10:11:19 +01:00
Danilo Del Busso
de6372f680 CP-41573: Check for presence of valid URI within UpgradeRequiresEUA Check
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-06-26 10:11:19 +01:00
Danilo Del Busso
5f5695057d CP-41573: Improve comparison logic for problems
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-06-26 10:11:19 +01:00
Danilo Del Busso
49b8f8e16f CP-41573: Add UpgradeRequiresEua and EuaNotAcceptedProblem
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-06-26 10:11:19 +01:00
Danilo Del Busso
34eb5ff9b0 Enable multiple IXenObjects to be associated with a Check instance
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-06-26 10:11:19 +01:00
Konstantina Chremmou
09611a806e Removed DMC deprecation banner and RPU precheck when upgrading a system with DMC VMs.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-05-05 14:43:12 +01:00
Konstantina Chremmou
5bf8559b60 Show more analytical warning.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-03-02 09:04:43 +00:00
Danilo Del Busso
43e2cecf32
CP-41737: Update copyright notices
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-28 08:07:30 +00:00
Danilo Del Busso
c13ba4082d
CP-41737: Consider upgrade version in PoolHasFCoESrWarning
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-28 08:07:29 +00:00
Danilo Del Busso
fa12c5d10c
CP-41737: Update warning UI elements
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@cloud.com>
2023-02-28 08:07:29 +00:00
Danilo Del Busso
7fa8731c59
CP-41737: Update CanRun override logic in PoolHasDeprecatedSrsCheck
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-28 08:07:29 +00:00
Danilo Del Busso
11328e86b9
CP-41737: Add FCoE SR deprecation warning in RPU wizard
Support for Software FCoE deprecation has been announced in 8.2 CU1

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-28 08:07:27 +00:00
Konstantina Chremmou
7063b3e130 CP-42155: Removed HealthCheck service and related dialogs.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-21 16:05:09 +00:00
Danilo Del Busso
6f6bddd755
CP-40842: Remove CIS upload from Server Status Report wizard (#3087)
* Remove credentials controls from `BugToolPageDestination`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* Explicitly call dispose in `BugToolPageDestination.cs`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* Tidy up code in `BugToolPageDestination.cs`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* Move `StatusReportRow` to its own file

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* Move `ClientSideDataRow` and `HostStatusRow` to own files

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CP-40842: Update order of pages in `BugToolWizard`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CP-40842: Update action and create row for packaging status report in BugTool wizard

Instead of creating a new action, this males ZipStatusReportAction inherit StatusReportAction

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CP-40842: Allow for pending `StatusReportAction` to be cancelled

This avoids the need for a running action to update the status. i.e. an action that has been registered but hasn't started running can be cancelled, too.

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CP-40842: Update content of `ACTION_SYSTEM_STATUS_SUCCESSFUL` message

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CP-40842: Add link to `labelBlurb` in `BugToolPageRetrieveData.cs`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CP-40842: Add report packaging logic to `BugToolPageRetrieveData.cs`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CP-40842: Open CIS URL when clicking on `linkLabelBlurb`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CP-40842: Report packaged data amount in `ZipStatusReportAction`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* Remove unused `using`s

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* Minor layout tweaks.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Renamed folder and namespace to match the ones for the other wizards.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Renamed wizard's private fields. Some code efficiency corrections.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Keep the row classes as private within the BugToolPageRetrieveData class.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Removed leftover unused action.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Tidy up status report messages. Use more relevant icon.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Made blurb localisable.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Renamed private fields.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Simplified the stages of the compilation of the status report.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Renamed row classes again to match the action names.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Simplify reporting the progress of the zipping action.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Recursive call is not necessary. Tweaked message.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* Sort strings

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* Update copyright notices

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

---------

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Co-authored-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
Co-authored-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2023-02-13 13:47:21 +00:00
Konstantina Chremmou
d7b519a53c Updated copyright notice on files.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-30 16:24:16 +00:00
Konstantina Chremmou
ca021b95dd CP-41433: Do not rebrand released versions.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-25 12:50:49 +00:00
Konstantina Chremmou
fbe8c60336 Merge remote-tracking branch 'upstream/feature/vtpm'
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

# Conflicts:
#	XenAdmin/MainWindow.cs
#	XenAdmin/Properties/Resources.resx
#	XenModel/Utils/Helpers.Versions.cs
#	XenModel/XenAPI/Pool.cs
2023-01-10 15:17:23 +00:00
Konstantina Chremmou
16d89ac66b CA-374160: Check for prerequisite updates shows the current version found, not the one required.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-10 15:05:33 +00:00
Konstantina Chremmou
74487155fa
Merge pull request #3053 from xenserver/master
Merge master into feature/vtpm
2022-09-16 14:27:56 +01:00
Konstantina Chremmou
d94c55533c Renamed VM method is_a_real_vm to IsRealVm.
The new name complies with C# conventions and allows distinguishing it from xapi field names.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-09-09 11:58:15 +01:00
Danilo Del Busso
8a3a24d92c
Normalise whitespace in Xenadmin/Diagnostics/Problems/*
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-08-15 16:13:44 +01:00
Danilo Del Busso
c6b50a5669
Use expression-bodied format for properties in Xenadmin/Diagnostics/Problems/*
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-08-15 16:13:39 +01:00
Danilo Del Busso
824a46d541
CP-39929: Remove ellipsing from VMProblem descriptions
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-08-03 14:58:39 +01:00
Konstantina Chremmou
6898148466
Merge pull request #3021 from kc284/remove-updates-tab
CP-39817: Removed updates tab page.
2022-06-21 10:48:46 +01:00
Konstantina Chremmou
fc925ba047 Removed unused CfuAvailabilityCheck class.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-06-16 11:21:43 +01:00
Danilo Del Busso
2798315b46
Merge pull request #3017 from danilo-delbusso/task/last-updated_CP-38583
CP-38582: Show `Last updated` field in General `TabPage`
2022-06-15 13:32:36 +01:00
Konstantina Chremmou
8beae03d35 CP-38583: suggested modifications. (And a couple of code smells).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-06-15 13:05:11 +01:00
Konstantina Chremmou
fd627e687f CP-39933: Show the names of the PV guests preventing upgrade if any are detected.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-06-08 14:01:04 +01:00
Konstantina Chremmou
59486541a5
Merge pull request #2985 from kc284/sonarqube
CP-36392: Improvement of sonarqube score
2022-04-20 10:25:23 +01:00
Danilo Del Busso
d90abfd1b6
[CHC] CA-366069 & XSI-1222: Fix incorrect capitalisation of value in Japanese version + add some case insensitive checks (#2986)
* CA-366069: Fix incorrect capitalization of value in Japanese invisible messages `resx`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-366069: Add case insensitive checks on code around usage of `ISO_UPDATE`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-366069: Remove changes in string capitalisation

Move capitalisation invariance to checks only

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-366069: Remove `ISO_UPDATE` from `InvisibleMessages.resx`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-366069: Add remaining `ToLowerInvariant()` calls

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-04-14 11:36:55 +01:00
Konstantina Chremmou
dce02a2562 Renamed AsyncAction.RunExternal to AsyncAction.RunSync so it is more descriptive.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-06 13:11:34 +01:00
Konstantina Chremmou
aaee939453 Some corrections on the DRWizard prechecks page:
- Re-arranged and re-worded controls so that this page looks more like
  the precheck page of the patching and RPU wizards.
- Do not show the failure message unless issues are found.
- Do no enable the Resolve All button unless all issues are fixable.
- Fixed crash when the required SR is present in the pool but detached.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-01 16:07:43 +01:00
Konstantina Chremmou
a91dd6398d Compacted ParallelAction and MultipleAction constructors.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-21 13:50:27 +00:00
Konstantina Chremmou
220ab25302 CA-365317: Updated warnings after disallowing connection to pre-yangtze servers.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-21 13:10:25 +00:00
Konstantina Chremmou
713bec52ce CA-365082: Do not run the PrepareToUpgradeCheck before the necessary RPU hotfix has been applied.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-14 17:32:29 +00:00
Konstantina Chremmou
00c5285411 CP-39142: Add RPU pre-check in CHCenter to warn of DMC removal.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-03 14:36:06 +00:00
Danilo Del Busso
a310fa60cf CP-36392: Remove all unnecessary using s
Ignores XenAPI

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-02-24 11:53:44 +00:00
Danilo Del Busso
f07b3d4e05 CP-37850: Update RPU005 to version 4.0
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-01-24 15:22:07 +00:00
Konstantina Chremmou
c19fb06bf7 CP-38473: Block RPU if the pool has hosts with certificate key length less than 2048
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-12-16 11:34:23 +00:00
Konstantina Chremmou
5078c4db0d CP-38086: Block upgrade for PV guests.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	Branding/Branding.resx
#	XenAdmin/Diagnostics/Checks/PVGuestsCheck.cs
#	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
#	XenAdmin/Wizards/RollingUpgradeWizard/RollingUpgradeWizardPrecheckPage.cs
#	XenModel/BrandManager.cs
#	XenModel/Utils/Helpers.cs
2021-11-15 15:49:39 +00:00
Danilo Del Busso
2f176caf46 CP-38219: Update RPU005 to version 3.0
Also exclude Yangtze or greater from hotfix check

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-09-24 11:19:36 +01:00
Konstantina Chremmou
cfbfea2830 Minor ProblemWithMoreInfo refactoring.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-09-23 10:44:43 +01:00
Konstantina Chremmou
55fd07f8ba Minor refactoring.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-09-23 10:44:30 +01:00