Commit Graph

490 Commits

Author SHA1 Message Date
Gabor Apati-Nagy
668979c29f Merge remote-tracking branch 'github_xenadmin/master' into CAR-2245_temp
Conflicts:
	XenAdmin/TabPages/GeneralTabPage.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizardModeGuidanceBuilder.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_ModePage.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_SelectServers.cs
	XenAdminTests/WizardTests/PatchingWizard/PatchingWizardModeGuidanceBuilderTests.cs
	XenModel/Network/Cache.cs
	XenModel/XenModel.csproj
2016-10-20 19:12:57 +01:00
Mihaela Stoica
8c93206ce5 CP-19218: Add restart warnings to the Precheck Page when installing hotfixes
-  If reboot is needed, display this as an info, not a warning

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-20 13:09:48 +01:00
Mihaela Stoica
07faabe1f0 CP-19218: Add restart warnings to the Precheck Page when installing hotfixes
- added a new precheck, called "Live patching status" which checks is a reboot is needed for each host. If reboot is needed, the check will display a warning, otherwise it will show a green tickbox, saying that the server does not need to be rebooted, and if live patching is used, this information will be included as well.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-19 13:10:24 +01:00
Mihaela Stoica
329f084a7e Merge branch 'CAR-2184' to master
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

Conflicts:
	XenModel/XenAPI-Extensions/SR.cs
2016-10-18 10:18:47 +01:00
Mihaela Stoica
7ec3881e05 Merge pull request #1212 from kc284/CA-157786
CA-157786: General tab for VDIs.
2016-10-18 08:01:57 +01:00
Konstantina Chremmou
08e1b2c1b7 CP-18417: Removed flag forbidding update; was added for CP-17750, but is no longer applicable.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-17 11:16:16 +01:00
Konstantina Chremmou
cff98908b3 Merge remote-tracking branch 'upstream/CAR-2226' 2016-10-17 11:07:15 +01:00
Konstantina Chremmou
7a74096d3b CA-157786: Added general tab for VDIs.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-14 13:51:51 +01:00
Mihaela Stoica
abde6e9641 CA-224567: PVS Site renaming plus some other improvements
- Renamed Add/Remove PVS Site buttons
- Added a note on the PVS Cache configuration page, regarding the recommended cache size and the allowed size for "memory only"
- Added a warning about the Site configuration not being complete until the PVS part is done as well (only visible if PVS_uuid is not set for a PVS_site)
-  Added PVS Read Caching status on the VM's general tab
- The absolute maximum allowed for a cache size is 2TB
- Changed the rubric on the Enable PVS read caching dialog

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-13 12:47:32 +01:00
Mihaela Stoica
80df4a2681 CP-17932: Ensure that the correct units are displayed for the PVS cache stats
- plus resorting Messages.resx

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-11 13:13:50 +01:00
Mihaela Stoica
34a4d44987 CA-223374: Able to unplug vCPUs from running VM when changing vCPU from two iCenters concurrently
- check the current number of vCPUs (by getting the latest value from the cache) before trying to change it.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-10 12:37:11 +01:00
Gabor Apati-Nagy
6296277317 Merge pull request #1188 from kc284/vm_migration
CA-220218, CA-205799, CA-205791 plus one or two other issues and refactoring
2016-10-07 16:18:49 +01:00
Konstantina Chremmou
81869976d9 Removed accidentally added string.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-07 15:53:38 +01:00
Mihaela Stoica
d6c735bd18 Merge pull request #1173 from kc284/migration
CA-220511, CA-187659, CA-220216 plus some refactoring and minor enhancements.
2016-10-07 10:11:07 +01:00
Mihaela Stoica
be66919627 CP-19086: Improvements to the PVS cache UI
- If the PVS site cannot be removed (it has running proxies) then popup a dialog stating the reason, instead of starting the action and failing there. We still have the same check in the action, just in case the situation changed in the meantime.
- Removed unused controls

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-03 10:51:56 +01:00
Mihaela Stoica
aebffe9b13 CP-19086: Improvements to the PVS cache UI
PVS Tab:
- Move the "View PVS sites" button inside the "Configure PVS Cache" dialog (next to Remove button) and make it per-site (showing only the PVS servers from that site)
- Remove "Currently attached" column from the VMs section
- Rename "Status" column to "Read caching status"

Configure PVS Cache" dialog:
- Make sure there is a scrollbar to accommodate all hosts in a pool
- Add a confirmation dialog when a site is removed. The action is executed when the Remove button is pressed.
- When Memory SR is selected, set the maximum value to the dom0-extra-memory..
- Allow empty configuration (but see next point): The OK button should only be disabled if the PVS site name is empty
- Add an extra option in the "Cache storage" combobox, with text "Not configured", selected by default on a new site. When this is selected, we will remove the existing entry in pvs_cache_storage and will not create a new one.
- When a PVS site is deleted (forgotten), we first delete all the associated PVS_servers, otherwise the site cannot be deleted.
2016-10-01 00:23:28 +01:00
Konstantina Chremmou
61a2c12c45 CA-205799: Fixed issue where the user was allowed to select the VM's home server
as move (halted) or migrate (suspended) destination; this was caused by using the
VM's resident_on instead of Home() host. Also, changed the disabled reason to be
a bit more generic and cover cases other than migration.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-30 13:45:59 +01:00
Konstantina Chremmou
1acc717417 CA-205791: Added detail to the action migrating a VM that's not resident on a host.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-30 13:45:52 +01:00
Konstantina Chremmou
4bf04e6279 In Move mode the text on the destination page should read "move the VMs" and not migrate.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-30 13:45:37 +01:00
Mihaela Stoica
18fb723f6a CP-18889: Implement UI changes for vCPU hotplug (#1159)
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-29 12:11:37 +01:00
Konstantina Chremmou
eb3fbe2ac8 Corrections and refactoring on VDI move/migrate:
- Allow move of multiple VDIs
- CA-187659: show better messages when batching move/migration of multiple VDIs.
- Show different tooltips for single vs. multiple VDI move/migration/deletion.
- Refactored the MoveDiskDdialog. Removed the inherited class VDIMigrateDialog and
the batching manager as it was not very different from its parent, it was registering
the events twice, and was batching migration of even single VDIs.
- Tidied up the Move- and MigrateVirtualDisk commands so they're easier to compare.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-28 09:50:43 +01:00
Mihaela Stoica
695934d907 CP-16922: Update the menu items and fix the tests
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-26 17:45:28 +01:00
Mihaela Stoica
fe6144ba70 CP-17920: Add dialog for PVS cache configuration
- this commit contains a temporary image for PVS_site

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-26 17:44:17 +01:00
Mihaela Stoica
f2b1443064 Merge branch 'master' into CAR-2184
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

Conflicts:
	XenModel/Messages.Designer.cs
	XenModel/Messages.resx
2016-09-26 13:26:31 +01:00
Mihaela Stoica
c6eab65fdf Merge pull request #1154 from kc284/master
Some corrections on VMStorage page and disk move/migrate/detach
2016-09-22 15:21:48 +01:00
mcintyre94
dd42394a25 CP-16922: Implement GUI for enabling PVS read caching (#1179)
* CP-16922: UI changes to PvsPage to replace the single configure button with a separate enable and disable one, per the design doc

* CP-16922: Intermediate checkin - command + dialog implemented, but PVS page has some layout problems.

* CP-16922:  Implement GUI for enabling PVS read caching and marking/unmarking VMs for prepopulation

Fix the broken layout by reverting MainWindow.resx (which shouldn't have changed) back to the previous commit. Also removed duplicate properties button code.

*  CP-16922: PVS Page changes, to properly display all VMs (not just ones with proxy), only populating proxy columns if there is a proxy set.

* CP-16922: Use a CommandButton for the enable button, connected to the same command as the VM main menu button, and using the table selection as its selection manager.

* CP-16922: Delete the old enable button click behaviour (because it now has a proper command), was causing the dialog to show up twice

* CP-16922: Properly list VMs by hiding those that should be hidden (in addition to non-VMs, also hide the __gui__ prefix and others covered by Show function). Also fixes a bug in NewVMGroupVMsPage discovered when fixing this - it would show VMs that should be hidden if you used the search bar.


* CP-16922: Use ButtonText on the Command to set the text on the PVS enable button

* CP-16922: Add the disable PVS read-caching command, and its associated proxy destroy action. Both based off enable equivalents (main difference is no dialog for now). Not used yet but will be in main window menu + disable button

* CP-16922: Add disable PVS read-caching to the main window menu (under enable), with the disable command attached to it


* CP-16922: Add support for disabling PVS read-caching for selected hosts via the PVS tab page by converting the disable button into a CommandButton in the same way as the enable button, using its own command + selection manager (because Selection Managers only bind to one control)

* CP-16922: Design - adding the "read caching enabled" column from the design, so that we display both whether caching is enabled and whether the VM is currently cached. If it's disabled all other values are missing.


* CP-16922: Add the PVS site column per the design to show the site a VM's PVS Proxy is on if it has a proxy


* CP-16922: Add an event handler for VMs changing so that newly provisioned VMs immediately show up in the PVS tab page


* CP-16922: Support for properly remembering the selection when the VM list is refreshed. A new method returns the list of VMs for the selected rows, and we can then check if the VM for the row being added is in this list. If there was no previous selection then we still select the first row by default.


* CP-16922: Remove prepopulate, which is being removed from the design. The next XAPI version will remove it, so just pass False as prepopulate for now, and remove the option from the dialog and PVS tab page.


* CP-16922: Improve UI appearance for a missing Storage Repository. Per the design, if there is no SR show the message None (memory only) instead of an empty cell

* CP-16922: Improved sorting behaviour. All columns (except VM name, which always uses it) use the VM tag as a sorting fallback (since they all have duplicates). New default sort which sorts by caching enabled first (yes before no), and then VM tag as a tiebreaker. Support for remembering the current sort on refresh, ie when a value changes.

* CP-16922: Refactoring to use a VM extension method to get the PVSProxy (or null if none exists) for a VM. This was used in the PVS Page + commands which are now much simpler.


* CP-16922: Move where the SelectionChanged event handler is set when refreshing the PVS table, so that the command buttons are updated correctly.

* CP-16922: Improvements to PVS read-caching dialog. Set accept/cancel buttons properly + adjust tab values, so focus acts as expected


* CP-16922: Remove the images from the menu for Enable/Disable PVS read-caching, most commands in the menu don't have one

* CP-16922: Sorting out the strings for the actions + ParallelAction calls, and moving them into the resx. Also reverting wrong MainWindow.resx changes.

* CAR-2184: XAPI changes. I've made the minimal possible changes to PvsPage to ensure it compiles, but it's had a lot of feature work (CP-16922) that supersedes this, these small changes should keep that merge painless.


* CAR-2184 XAPI: Reverse the unrelated changes, only keep the PVS ones.

* CP-16922: Merge latest XAPI changes, notably changes to Pvs_site.create

* CP-16922: Change tab show/hide logic for PVS tab, show it even if there are no PVS sites.

* CP-16922: Implement GUI for enabling PVS read caching

Design changes - remove the storage repo column and replace it with status, which is populated with a friendly version of the pvs_proxy_status enum. Also populate site list using site.name_label

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>

*  CP-16922: Implement GUI for enabling PVS read caching

Adjusting the CanExecute of Enable PVS read-caching command to require at least one PVS site to be created. Since the PVS tab can show up without any sites, we need this because we can't create a proxy without a site.

* CP-16922: Code review changes.

Tidied up messages, and ensured actions run async properly, and without exiting before their task.

* CP-16922: Code review changes.

Update dialog resx, wider combobox on dialog, update action descriptions before setting RelatedTask, add friendly message body for PVS error notifications.
2016-09-22 15:08:15 +01:00
Mihaela Stoica
a04e8dbccf Merge pull request #1123 from GaborApatiNagy/CA-150816
CA-150816: fix: G11n:I18n: Hardcode issue "Set VM other_config" on Authentication dialog.
2016-09-20 14:02:18 +01:00
Konstantina Chremmou
6bb71ffd23 Merge pull request #1124 from GaborApatiNagy/CA-174979
CA-174979: Confusing right-click add to pool menu (if you accept the defaults)
2016-09-20 13:15:36 +01:00
Mihaela Stoica
963d5211d6 Merge pull request #1174 from mcintyre94/CA-217821
CA-217821: Renaming home server to target server in VM migration wizard
2016-09-20 11:43:24 +01:00
Gabor Apati-Nagy
6742d72461 CA-174979: Confusing right-click add to pool menu (if you accept the defaults)
Removed a no longer used string from Messages.resx

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-09-20 10:43:05 +01:00
Gabor Apati-Nagy
93a7c3c7c7 CA-150816: fix: G11n:I18n: Hardcode issue "Set VM other_config" on Authentication dialog.
Changed the text to be more meaningful as agreed

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-09-19 17:50:10 +01:00
Callum McIntyre
0c5eaef042 CA-217821: Renaming home server to target server in VM migration wizard
We already renamed the column to target server, this changes the message in the case where the user doesn't choose a server on this page to also use target server.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-09-19 17:00:02 +01:00
Callum McIntyre
e28bcc76c9 CP-18417 review changes: Fix the broken test that uses the guidance builder method, and update the messages to be more consistent. 2016-09-16 13:36:03 +01:00
Konstantina Chremmou
c6004b664b CA-219461: A new disk requires VM shutdown-restart in order to appear, not VM reboot.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-12 14:34:57 +01:00
Konstantina Chremmou
6298a7e885 Do not calculate twice the VMs to move or migrate. Text improvement.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-09 18:52:38 +01:00
Callum McIntyre
129330c326 CP-18417: Modify the hotfix wizard to make it work for hosts that can't auto-update/restart from XC
Adjusted messages, and added a tooltip to the Automatic restart radio when it's disabled. Also now support standalone hosts in addition to pooled.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-09-09 15:45:38 +01:00
Callum McIntyre
9a8cb87e29 Pull down + merge master (which has changes to update wizard in live patching etc). Automerged. 2016-09-09 12:40:07 +01:00
Konstantina Chremmou
d2a3a17369 Fixed typos.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-06 14:53:46 +01:00
Mihaela Stoica
b758e0660a Resurrect CP-18011: [XenCenter] Add live patching checkbox
(reverting  8a10351c5d: Revert "Cp 18011: [XenCenter] Add live patching checkbox")

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-01 14:59:37 +01:00
Gabor Apati-Nagy
65f02fbba9 CA-174979: Confusing right-click add to pool menu (if you accept the defaults)
Changed "Unnamed Pool" to "Pool" to make the terminology clearer

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-30 15:52:33 +01:00
Gabor Apati-Nagy
0174974c93 Merge branch 'master' of https://github.com/xenserver/xenadmin into CP-18014
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

Conflicts:
	XenAdmin/Wizards/PatchingWizard/PatchingWizard.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
	XenModel/Messages.Designer.cs
	XenModel/Messages.ja.resx
	XenModel/Messages.resx
	XenModel/Messages.zh-CN.resx
2016-08-26 15:22:03 +01:00
Callum McIntyre
b7de03cd98 CP-18417:Move the pool forbidden message into the Messages class (though text isn't finalised yet) 2016-08-26 14:51:05 +01:00
Callum McIntyre
7f5390e9c4 CP-18618: If live patching fails, warn the user
If we are expecting to live patch, but at the end
hosts.patches_requring_reboot contains the patch, then warn the user that
live patching has failed for the host - and it needs to be rebooted.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-24 11:13:58 +01:00
Gabor Apati-Nagy
53619c775d Merge remote-tracking branch 'github_xenadmin/master' into REQ-156_github_master
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

Conflicts:
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_SelectServers.cs
	XenModel/Actions/ParallelAction.cs
	XenModel/FriendlyNames.resx
	XenModel/Messages.Designer.cs
	XenModel/Messages.resx
2016-08-18 12:22:40 +01:00
Callum McIntyre
2d089fa9e9 CP-18013: [XenCenter] Update host/pool updates pane
Generalising to also support pools. New CheckHostPatchesRequiringReboot method with the same behaviour as old method (return list of KeyValue warning messages). Pool updates on Ely use the union of messages from this method instead of the old one. Also localised the "{hotfix} on {server}" string per todo (hence resx changes).

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-17 10:45:11 +01:00
Gabor Apati-Nagy
3fc9c3edb6 Merge pull request #1111 from MihaelaStoica/CA-210549
CA-210551: Non-modal action progress bar on the Pre-Checks page of th…
2016-08-16 16:08:54 +01:00
Gabor Apati-Nagy
7d8d0ad837 CA-174979: Confusing right-click add to pool menu (if you accept the defaults)
Changed "New Pool" to "Unnamed Pool"

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-15 19:10:28 +01:00
Gabor Apati-Nagy
c7482b8c93 CA-150816: fix: G11n:I18n: Hardcode issue "Set VM other_config" on Authentication dialog.
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-15 17:43:20 +01:00
Callum McIntyre
05efba8b9f CA-217821: Rename command back to CrossPoolMigrateToHomeCommand 2016-08-15 16:13:35 +01:00
Callum McIntyre
3a5444ceb2 CA-217821: Specified home server in cross pool migration should behave as home server
Mostly just terminology changes from home server to target server in the CPM wizard. Changes in shared component SelectMultipleVMDestinationPage (shared with ImportWizard) to allow CPM wizard to rename the Home Server column (as it can the VM/template one - using the same pattern).

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-15 14:22:18 +01:00