Commit Graph

6 Commits

Author SHA1 Message Date
Konstantina Chremmou
34aebf2b7d XOP-444: Converted the method parsing the plugin record to a TryParse method to
prevent exceptions being thrown when the record is an invalid xml. Minor logging
improvements; improvement to certain rethrown exceptions so we don't disturb the
stack trace. Removed unecessary field initialisation and duplicate iscsi session
disposal.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-09-26 08:30:36 +01:00
Konstantina Chremmou
ed88db2df0 Fixed two potential null reference exceptions in the XenOvfTransport project and
removed uninitialised streams which we were taking care to close. Solution-wide
style: use string.IsNullOrEmpty method instead of checking separately for null
and zero length.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-09-26 08:30:34 +01:00
Konstantina Chremmou
809256c375 Made XenOvfTransport project use log4net for logging (before it was using own logging,
leftover from the time when the OVF wizards were a XenCenter plugin; the latter
was not printing output into the XenCenter.log file, thus causing us to miss info).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-09-26 08:30:32 +01:00
Konstantina Chremmou
50e95a0416 Removed unused constructors. Made XenSession a protected readonly field. Removed
field _OwnSession as it was never set to true.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-09-26 08:30:30 +01:00
Konstantina Chremmou
19a7fcdcfb Code readability: removed empty placeholders for XML documentation from the XenOvfTransport project.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-09-26 08:30:28 +01:00
Mihaela Stoica
bd36a85bff CP-4816: Initial commit to git repo
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2013-06-24 12:41:48 +01:00