Commit Graph

50 Commits

Author SHA1 Message Date
Gabor Apati-Nagy
d469d92357 CP-21176: Showing XC version in the new version alert
This way XC will display the name attribute of the XC-version which is expected to contain the LTSR string for LTSR version.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-03-14 17:27:04 +00:00
Sharath Babu
b5c96618ff CA-241844: [VMSS] Deleting a snapshot schedule raises XenCenter error
After deleting the schedule vmss will be null for that message, hence
we need to handle this case.

Signed-Of-By: Sharath Babu <sharath.babu@citrix.com>
2017-02-01 14:15:49 +05:30
Sharath Babu
ee4b2818f6 Merge remote-tracking branch 'xenserver/CAR-2205' into xenserver/VMSS
Signed-Off-by: Sharath Babu <Sharath.Babu@citrix.com>
2017-01-25 13:01:54 +05:30
Sharath Babu
af182d9e7e CA-213512: [VMSS] XC mentions VMPR instead of VMSS on failure of snapshot
Signed-Off-by: Sharath Babu <sharath.babu@citrix.com>
2017-01-23 16:25:16 +05:30
Gabor Apati-Nagy
7c0bc50b4a CA-176169: Changed copyright statements to include the comma in Citrix Systems,
Inc.

Signed-off-by: Gabor Apati-Nagy<gabor.apati-nagy@citrix.com>
2017-01-16 19:59:50 +00:00
Mihaela Stoica
f2b1443064 Merge branch 'master' into CAR-2184
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

Conflicts:
	XenModel/Messages.Designer.cs
	XenModel/Messages.resx
2016-09-26 13:26:31 +01:00
mcintyre94
dd42394a25 CP-16922: Implement GUI for enabling PVS read caching (#1179)
* CP-16922: UI changes to PvsPage to replace the single configure button with a separate enable and disable one, per the design doc

* CP-16922: Intermediate checkin - command + dialog implemented, but PVS page has some layout problems.

* CP-16922:  Implement GUI for enabling PVS read caching and marking/unmarking VMs for prepopulation

Fix the broken layout by reverting MainWindow.resx (which shouldn't have changed) back to the previous commit. Also removed duplicate properties button code.

*  CP-16922: PVS Page changes, to properly display all VMs (not just ones with proxy), only populating proxy columns if there is a proxy set.

* CP-16922: Use a CommandButton for the enable button, connected to the same command as the VM main menu button, and using the table selection as its selection manager.

* CP-16922: Delete the old enable button click behaviour (because it now has a proper command), was causing the dialog to show up twice

* CP-16922: Properly list VMs by hiding those that should be hidden (in addition to non-VMs, also hide the __gui__ prefix and others covered by Show function). Also fixes a bug in NewVMGroupVMsPage discovered when fixing this - it would show VMs that should be hidden if you used the search bar.


* CP-16922: Use ButtonText on the Command to set the text on the PVS enable button

* CP-16922: Add the disable PVS read-caching command, and its associated proxy destroy action. Both based off enable equivalents (main difference is no dialog for now). Not used yet but will be in main window menu + disable button

* CP-16922: Add disable PVS read-caching to the main window menu (under enable), with the disable command attached to it


* CP-16922: Add support for disabling PVS read-caching for selected hosts via the PVS tab page by converting the disable button into a CommandButton in the same way as the enable button, using its own command + selection manager (because Selection Managers only bind to one control)

* CP-16922: Design - adding the "read caching enabled" column from the design, so that we display both whether caching is enabled and whether the VM is currently cached. If it's disabled all other values are missing.


* CP-16922: Add the PVS site column per the design to show the site a VM's PVS Proxy is on if it has a proxy


* CP-16922: Add an event handler for VMs changing so that newly provisioned VMs immediately show up in the PVS tab page


* CP-16922: Support for properly remembering the selection when the VM list is refreshed. A new method returns the list of VMs for the selected rows, and we can then check if the VM for the row being added is in this list. If there was no previous selection then we still select the first row by default.


* CP-16922: Remove prepopulate, which is being removed from the design. The next XAPI version will remove it, so just pass False as prepopulate for now, and remove the option from the dialog and PVS tab page.


* CP-16922: Improve UI appearance for a missing Storage Repository. Per the design, if there is no SR show the message None (memory only) instead of an empty cell

* CP-16922: Improved sorting behaviour. All columns (except VM name, which always uses it) use the VM tag as a sorting fallback (since they all have duplicates). New default sort which sorts by caching enabled first (yes before no), and then VM tag as a tiebreaker. Support for remembering the current sort on refresh, ie when a value changes.

* CP-16922: Refactoring to use a VM extension method to get the PVSProxy (or null if none exists) for a VM. This was used in the PVS Page + commands which are now much simpler.


* CP-16922: Move where the SelectionChanged event handler is set when refreshing the PVS table, so that the command buttons are updated correctly.

* CP-16922: Improvements to PVS read-caching dialog. Set accept/cancel buttons properly + adjust tab values, so focus acts as expected


* CP-16922: Remove the images from the menu for Enable/Disable PVS read-caching, most commands in the menu don't have one

* CP-16922: Sorting out the strings for the actions + ParallelAction calls, and moving them into the resx. Also reverting wrong MainWindow.resx changes.

* CAR-2184: XAPI changes. I've made the minimal possible changes to PvsPage to ensure it compiles, but it's had a lot of feature work (CP-16922) that supersedes this, these small changes should keep that merge painless.


* CAR-2184 XAPI: Reverse the unrelated changes, only keep the PVS ones.

* CP-16922: Merge latest XAPI changes, notably changes to Pvs_site.create

* CP-16922: Change tab show/hide logic for PVS tab, show it even if there are no PVS sites.

* CP-16922: Implement GUI for enabling PVS read caching

Design changes - remove the storage repo column and replace it with status, which is populated with a friendly version of the pvs_proxy_status enum. Also populate site list using site.name_label

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>

*  CP-16922: Implement GUI for enabling PVS read caching

Adjusting the CanExecute of Enable PVS read-caching command to require at least one PVS site to be created. Since the PVS tab can show up without any sites, we need this because we can't create a proxy without a site.

* CP-16922: Code review changes.

Tidied up messages, and ensured actions run async properly, and without exiting before their task.

* CP-16922: Code review changes.

Update dialog resx, wider combobox on dialog, update action descriptions before setting RelatedTask, add friendly message body for PVS error notifications.
2016-09-22 15:08:15 +01:00
Konstantina Chremmou
1065ca14eb Merge pull request #1088 from MihaelaStoica/CA-217449
CA-217449 &  CA-173661 - Control domain memory alert fixes
2016-08-05 12:27:31 +01:00
Konstantina Chremmou
dbef554ac0 CA-104472: Refactoring and removal of duplicate code. This also fixes descrepancies
in the calculation of the never-expiring licence ("greater than 3653 days" in
LicenceAlert and LicenceStatus vs "greater than or equal to 3653 days" elsewhere).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-03 21:07:04 +01:00
Mihaela Stoica
bd497356f6 CA-217449: Dom0 VM properties should not be visible in XenCenter
- The "Alarm Settings" action on Alerts page should open host's properties dialog for Dom0 alerts
- Also added help id for the Control Domain Memory Usage alert
2016-08-01 12:21:19 +01:00
Gabor Apati-Nagy
b8e447afa3 CA-196315: XS65ESP1018 not showing up in XenCenter Updates (on staging)
Fixed code to treat uuids of patches case-insensitive when consuming, but not changing them (eg. to lowercase) to keep compatibility with older XAPIs.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-02-08 10:14:05 +00:00
Mihaela Stoica
fc5ebd2d40 CP-15401: Move HiddenFeatures to a new class
Signed-off-by: Mihaela Stoica <Mihaela.Stoica@citrix.com>
2016-01-28 21:43:15 +00:00
Cheng Zhang
04d3b81d92 CP-15401: Changed WarningWithInformationUrl and ProblemWithInformationUrl to cope with empty URL string
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2016-01-25 11:15:30 +08:00
Cheng Zhang
88d881b126 CP-15401: Show/Hide rdpPolling, upsell and optimize for XenApp depending on XenCenter registry keys
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2016-01-22 13:31:22 +08:00
Mihaela Stoica
6a06645b92 CP-14642: Add friendly names for the new XenServer alerts
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-11-04 12:18:20 +00:00
Gabor Apati-Nagy
bf8e2cfc77 Merge pull request #669 from agimofcarmen/CA-179502
CA-179502: Reviewed all use of MemorySizeStringMB and came to the con…
2015-09-11 12:20:40 +01:00
Mihaela Stoica
38a1633acb CP-14047: Display alerts for SR physical utilisation in XenCenter
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-09-10 15:18:26 +01:00
Carmen Agimof
4fadf796ad CA-179502: Reviewed all use of MemorySizeStringMB and came to the conclusion that all its usages must be replaced with MemorySizeStringSuitableUnits. 2015-09-10 14:36:46 +01:00
Carmen Agimof
4da67c0590 CA-147944: Use GB for VM Memory if large values
- Memory Tab uses GB units for values greater or equal to 1 GB, otherwise show in MB;
- Search Tab displays values in GB or MB in the same as the Memory Tab (e.g. 512 MB of 1 GB, 256 MB of 512 MB, 2.5 GB of 16 GB).
- The shiny bar present in the Memory Tab and in Memory Settings dialog shows the scaling in the following way: If smaller than 1 GB, then show as before, else show only labels with values multiples of half a GB.
- The units used in Memory Setting Dialog are set depending on the static_max. If it is greater or equal to 1 GB, then the units are GB, else MB. The user does not have the possibility of changing them.
2015-08-20 12:41:39 +01:00
Mihaela Stoica
8264dcaba0 Merge pull request #589 from agimofcarmen/CP-13518_II
Cp 13518 ii
2015-07-31 14:51:04 +01:00
Carmen Agimof
32461b38b9 CP-13028: Corrects the Dismiss function and provides Dismiss All/ Dismiss Selected button on the Updates Tab. 2015-07-29 13:43:47 +01:00
Gabor Apati-Nagy
b9abdc4b1a CP-12640: Create alert when logs partition is full
Adding code for "log_fs_alert"
2015-07-24 16:03:27 +01:00
Carmen Agimof
b1a2b49559 CP-13026: Changes code style and removes commented out code. 2015-07-23 13:48:30 +01:00
Carmen Agimof
f79199752a CP-13026: Provide Dismiss option on the Updates Tab. 2015-07-23 11:48:14 +01:00
Mihaela Stoica
e6784d1837 CP-10799: Ensuring sufficient disk space for service pack installation: Display hotfix installation size on the Updates page
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-02-06 12:32:29 +00:00
Gabor Apati-Nagy
f48f7c8f11 CP-9784: Recognise LICENSE_SERVER_VERSION_OBSOLETE alert in XenCenter 2014-10-02 16:04:05 +01:00
Gabor Apati-Nagy
bf1bf99bdd CP-9092: XenCenter work for Dom0 memory usage alert
-Fixing ALERT_ALARM_DOM0_MEMORY_DEMAND_DESCRIPTION string.Format parameters

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2014-08-07 13:22:45 +01:00
Gabor Apati-Nagy
c57800113b CP-9092: XenCenter work for Dom0 memory usage alert
-Adding control domain memory usage alerts

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2014-08-05 21:40:26 +01:00
Konstantina Chremmou
60bf086b3b CA-122558: Generate a license alert when the license status is expired. Fixed incorrect
timestamp for both license expiring and license expired alerts. Indentation.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2014-05-12 15:40:05 +01:00
Konstantina Chremmou
9c834d1b91 CA-126770: Fixed issue where the location column on the Updates page was showing
multiple entries after refreshing.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2014-04-28 14:27:12 +01:00
Konstantina Chremmou
f5bee7102c Refactored MainWindow to derive from IMainWindow rather than implement a field deriving
from this interface.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2014-01-22 12:39:32 +00:00
Konstantina Chremmou
b20434ba24 Refactoring: CanIgnore can be a "get" only property. Correction: dismiss new server
version alert from connections rather than ConnectionsManager.XenConnectionsCopy
(in accordance to dismissal of patch alerts).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2014-01-08 12:38:51 +00:00
Konstantina Chremmou
c8ff1bee69 CA-122558: Removed FixLinkDelegate. Use System.Action instead.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2014-01-03 11:58:42 +00:00
Konstantina Chremmou
a762442b70 CA-122558: Removed property DescriptionInvariant; after the logs and alerts rewrite
it was only used when logging and only for the updates; using the Description in
its place should be adequate. Fixed bug in the formatting of XenCenterUpdateAlert.Description
and removed duplicate logging when dismissing an alert.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2014-01-03 11:27:35 +00:00
Konstantina Chremmou
e28d3c912b CA-67866: Step 3 - Implemented filtering for the Updates list.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2014-01-03 11:27:11 +00:00
Konstantina Chremmou
cc78711c56 CA-67866: Step 2 - moved code common to XenServerPatchAlert and XenServerVersionAlert
to a base class XenServerUpdateAlert.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2014-01-03 08:51:14 +00:00
Konstantina Chremmou
0eaf776399 CA-67866: Step 1 - renamed XenServerUpdateAlert to XenServerVersionAlert to avoid
confusion (patch alerts and version alerts are both considered as server update alerts).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2014-01-03 08:37:45 +00:00
Konstantina Chremmou
a5c89e429b CA-85971: Removed method selecting control in tab by name. Retained ability only for the Name, Description and Iqn TexBox on the GeneralEditPage; in one of the other cases it didn't make a difference, in another (LogDestinationEditPage) it was causing a bug and in yet another (BootOptionsEditPage) the controls had already been renamed. Also some positioning changes.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-12-30 13:01:00 +00:00
Konstantina Chremmou
3b25591d71 CA-85971: Removed method selecting tab by name. Made all pages of VerticallyTabbedDialog private.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-12-22 17:17:04 +00:00
Konstantina Chremmou
d335372575 CA-85971: Removed method selecting tab by index.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-12-22 15:28:00 +00:00
Konstantina Chremmou
ce20127827 CA-122558: Redesign of the updates page according to CAR-107.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-12-05 12:46:39 +00:00
Konstantina Chremmou
772bc63e53 CA-122558: Some code compacting.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-12-05 12:03:34 +00:00
Konstantina Chremmou
b2e0c858e3 CP-6093: Tidying up: moved property from Alert to XenServerPatchAlert as it only
applies to the latter. Converted methods from AlertSummaryPage to one Alert and
one String extension method so they can be used more widely. Code simplification
on the Updates page.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-11-23 14:04:15 +00:00
Konstantina Chremmou
fcc627113d CP-6093: Remove update alerts from the Alerts page, part 1/3: some code simplification
and efficiency improvements.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-11-21 14:11:29 +00:00
Konstantina Chremmou
361b49066c CP-6093: Anyone outside the Alert class should not know anything about the lock
used to access the alerts list. The list itself should be private as there is a
risk to access it and forgetting to use the lock.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-11-21 12:32:27 +00:00
Konstantina Chremmou
f9b8624114 CP-5750: Currently the license alert is generated only when the license is due to
expire soon, therefore assign severity level 3 (warning).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-16 13:25:46 +01:00
Konstantina Chremmou
38ab6b8ffa CP-5750: When a License warning is generated, create an alert rather than an Action.
Removed ActionType.Alert. Removed Alerts checkbox from the Log tab.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-09 17:20:36 +01:00
Konstantina Chremmou
86234b2121 PR-1537: Moved duplicate alert comparison code from the AlertSummary and the ManageUpdates dialogs to the Alert class.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@citrix.com>
2013-07-03 12:00:00 +01:00
Konstantina Chremmou
8a7476c9c7 PR-1537: Added new virtual property Name to the Alert class. Removed time info from the Description of the XenCenterUpdate-, XenServerPatch- and XenServerUpdateAlert (not needed because it is shown on a separate column on the alert lists).
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@citrix.com>
2013-07-03 11:28:10 +01:00
Mihaela Stoica
bd36a85bff CP-4816: Initial commit to git repo
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2013-06-24 12:41:48 +01:00