Commit Graph

777 Commits

Author SHA1 Message Date
Mihaela Stoica
5879b5ae60 CA-271864: Add the host name to the precheck failure when the VM cannot be evacuated.
The other part of this ticket (add OTHER_OPERATION_IN_PROGRESS to the known errors) has already been done in commit 97a60c91.
Minor refactoring to the VMProblem class.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-08-16 11:38:34 +01:00
Konstantina Chremmou
abec5c4aba CA-284090: Added a dedicated status bar on the TabPageFeature to resemble real
life browsers and allow the user to see the status even if other actions are taking
place. Removed webClient use from the browser; instead try sequentially to navigate
to all Uris until one succeeds; this avoids sending duplicate requests and allows
the user to see all endpoints tried out. Reworked the WebBrowser event handlers
to ensure the UI reflects correctly the browser state.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-15 09:59:58 +01:00
Mihaela Stoica
56a3725b36 Corrected the title and description of VM lifecycle operations when run as Mulltiple/Parallel actions
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-08-13 17:18:53 +01:00
Konstantina Chremmou
b19d2fdeec CA-104539: Don't allow the user to make a pool into a standalone server if HA is enabled
or being enabled. Although the CLI allows it, it makes sense to disallow deleting the pool
when HA is on because XenCenter does not offer enabling HA if there is no pool there.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-10 09:50:31 +01:00
Konstantina Chremmou
65f67f2455 Ensure AdEnableAction is always shown in History. FindActiveAdAction can be private.
Show ellipsis on the join/leave button since it launches a dialog requirng user input.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-01 08:27:04 +01:00
Konstantina Chremmou
41c2eb71f6 Smarter icon/text selection and minor layout improvements, in particular icon alignment.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-01 08:27:04 +01:00
timliu55
38391c943e CA-293628 Some RPU prechecks do not mention the host the precheck has… (#2156)
* CA-293628: Some RPU prechecks do not mention the host the precheck has run on
Signed-off-by: Tim Liu <tim.liu@citrix.com>

* CA-293628: Some RPU prechecks do not mention the host the precheck has run on
Signed-off-by: Tim Liu <tim.liu@citrix.com>
2018-07-30 11:06:26 +01:00
Konstantina Chremmou
1bcbb3d454 CA-289960: If a VM does not acknowledge the need to shut down on host reboot,
include the VM's name in the message to help the user identify it.
Also, we have more instances of "shut down" than "shutdown".

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-25 09:39:04 +01:00
Konstantina Chremmou
d0c011d00c Improved error message and simplified error handling and logging to avoid multiple catch-rethrow of exceptions.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-24 10:14:57 +01:00
Mihaela Stoica
42c3a369a3 CA-293923: Use a NetworkAvailabilityChanged event to detect changes in the network connectivity and mark the download as failed when the network becomes unavailable
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-18 14:23:37 +01:00
Mihaela Stoica
9accb3c69f Merge branch 'master' into REQ-672
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

# Conflicts:
#	XenAdmin/Wizards/RollingUpgradeWizard/RollingUpgradeWizardPrecheckPage.cs
#	XenAdmin/XenAdmin.csproj
2018-07-13 13:14:36 +01:00
Konstantina Chremmou
b0f9d41381 Changed the description of the actions saving properties of XenObjects to express
explicitly what the actions do. The previous description "updating" could be
confusing when seen out of context amidst other actions on the events page,
because updating also refers to server patching.
2018-07-13 12:39:33 +01:00
Konstantina Chremmou
a55d9d3edd CA-293764: Do not suppress history for the actions applying hotfixes because
if they fail the user has no indication an error occurred.
Also, simplified the logging and error handling within the action body: failures
are logged anyway by the base class, so no special handling is necessary.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-13 12:39:33 +01:00
serenc
118eca3d61 CA-292991: Block host joining cluster with cluster network (bonded/unbonded) unless the interface is defined
Signed-off-by: serenc <seren.corbett@citrix.com>
2018-07-12 14:57:59 +01:00
Mihaela Stoica
f09683be7c CA-293669: Block the installation of an old-format patch if the pool is partially upgraded and the master is Ely or greater
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-12 14:45:23 +01:00
Konstantina Chremmou
542cf63428 Improved the RBAC message on the Patching wizard to provide more info on the
minimum required role. Do not deselect a pool on the RPU wizard if it fails
the RBAC check; let the user decide either to reconnect with more privileges
or deselect it.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-12 13:36:27 +01:00
Ji Jiang
ce3a1a6f02 CA-293686: Fix the spelling mistake
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-07-11 16:35:00 +01:00
Ji Jiang
9e8e8237e2 CA-293721: Improve host HostMaintenanceMode problem description
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-07-11 14:28:49 +01:00
serencorbett1
63d09dd117 CP-28431: Block updates/upgrades from Kolkata if clustering enabled (#2124)
* CP-28431: Block updates and upgrades from Kolkata onwards if clustering enabled
* CP-28431: Rename files and change from Pool Check to [Host] Check
* CP-28431: Change description message

Signed-off-by: Seren Corbett <seren.corbett@citrix.com>
2018-07-09 10:59:09 +01:00
Konstantina Chremmou
624a228715 Corrected the logic deciding whether a supplemental pack is applicable on a host.
(This looks like a better fix for CA-236547 too).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-08 22:43:21 +01:00
Konstantina Chremmou
c11b692958 CA-293158: Reworked the logic enabling/disabling and selecting servers depending
on the update mode, so that the right set of hosts is passed on to the prechecks
page for partially upgraded pools that are to be updated to a new version with
hotfixes. Also, corrected code that was mixing the logic of changing the enabled
 state of a row with the checked state.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-08 22:43:21 +01:00
Mihaela Stoica
7c1484d6c7 CA-293099: If the update that we are trying to apply is already applied, then show that in the wizard.
Also sort Messages.resx and call ReplaceProgressStep instead of AddProgressStep in the DownloadPatchPlanAction class (when the download is skipped)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-04 16:08:22 +01:00
Konstantina Chremmou
c2ae0a6069 Placed the CFU availability and the automated updates licence checks under the same group as requested per code review.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-04 12:09:37 +01:00
Konstantina Chremmou
69c9d942ff CA-293328: SafeToUpgradeCheck was not checking for liveness first; now this
is enforced on all host post-liveness checks.
Added missing description to SafeToUpgradeCheck.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-04 12:09:37 +01:00
Jisheng Xing
076c9dfb96 declare VMs with SR-IOV VFs as non-agile
Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
2018-07-04 12:03:03 +01:00
Konstantina Chremmou
89ddbf4007 Use "restart toolstack" instead of "restart agent" to conform with the server's menu item and the help files.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-02 17:37:52 +01:00
Konstantina Chremmou
bd9d8dfc93 CA-291030: Fixed a couple of duplicate hotkeys in the pool's menu and context menu.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-28 12:25:56 +01:00
Konstantina Chremmou
f16cc7f770 Made UploadPatchAction and UploadSupplementalPackAction report progress of uploaded bytes.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-28 12:25:56 +01:00
Konstantina Chremmou
3e71da4e0a Do not trigger the Action.Change event when the PercentComplete or the Description
are set unless the new value is actually different. Small efficiency improvements
to the DownloadPatch action and plan action.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-28 12:25:56 +01:00
Konstantina Chremmou
d3f761b070 Reworked the logging for the plan actions. (#2109)
* Deprecate set but unused Status property in favour of ProgressDescription.
* Deprecate set but unused TitlePlan property.
* Deprecated property Title in favour of ProgressDescription.
* Removed unused plan RebootHostPlanAction.
* Updated event declaration.
* Removed property Visible. The plan is to have the actions log their history as soon as some is available.
* Reworked the logging for the plan actions. The main change is the replacement of
the ProgressDescription with a stack where all the steps of an action are stored,
i.e. the action is responsible for its history, not the worker running it.
* Lock the progress history before accessing it.
* Better handling of error logging and user cancellation.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-26 14:04:51 +01:00
Ji Jiang
41e358a8fa CP-28583: Remove host-level selection in Update wizard
1) Always pool level selection of hosts, except uploading sup pack file
from disk.
2) Revert homogeneity precheck change recently. It won't happen in new version
update any more.
3) User can never update slaves to a higher version than master, so delete
master_version_not_compatible_problem.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-06-26 12:45:59 +01:00
Konstantina Chremmou
37d9bc4b3b Moved all the code for the manual upgrade into the UpgradeManualHostPlanAction and removed the IsManual property.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-25 11:31:18 +01:00
Mihaela Stoica
e8d2b9e493 CP-28279: Use different messages for RPU (for reporting success or failure)
- Also corrected the function that creates the update plan action in RPU: when running a retry, these actions shouldn't be regenerated.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-06-25 11:31:18 +01:00
Konstantina Chremmou
97a60c91da Since the reason why a VM already involved in an operation in progress cannot be migrated is known, display it, otherwise the user may wonder unnecessarily what the problem is.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-22 17:40:53 +01:00
Konstantina Chremmou
e7683fcf0b CP-28492: Evacuate the VMs before the first reboot and repatriate them after the last one.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-22 17:40:53 +01:00
Ji Jiang
6d070d3cfc CP-28425: Add automated updates license precheck in RPU wizard
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-06-22 17:20:11 +01:00
Ji Jiang
ccf6f97732 CP-28280: Add CFU availability precheck to RPU wizard comments fix
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-06-22 12:02:19 +01:00
Ji Jiang
9ae8340913 CP-28280: Add CFU availability precheck to RPU wizard
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-06-22 12:02:19 +01:00
Jisheng Xing
538e6f90a1 fix some comments 2018-06-21 14:54:47 +01:00
Jisheng Xing
cb1da504fd CA-289627: SR-IOV on NIC tab is confusing
Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
2018-06-21 14:54:47 +01:00
Konstantina Chremmou
6513abc09e The check for hosts that are unlicensed for automated updates should be on all pool hosts as there maybe individual restrictions (for example via a feature flag).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-19 17:20:08 +01:00
Mihaela Stoica
59b9b695db CP-28284: Changes following code review
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-06-19 13:34:37 +01:00
Mihaela Stoica
da2c96ad1c CP-28426: RPU wizard: add user option for automatically applying updates - changes following code review
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-06-18 16:28:28 +01:00
jishengx
cf20ac13c4 CA-289629: prompt host may need to be rebooted to enable SR-IOV (#2092)
CA-289629: prompt host may need to be rebooted to enable SR-IOV

Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
2018-06-18 12:36:12 +01:00
Joey
abe97def1e CP-28286: Support resume from a partially upgraded pool via Update wi… (#2095)
* CP-28286: Support resume from a partially upgraded pool via Update wizard

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>

* CP-28286: Fix comments of the previous commit

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-06-18 10:46:41 +01:00
Mihaela Stoica
93a154e04f CP-28282: Unit tests fix + improved message
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-06-15 16:05:37 +01:00
Mihaela Stoica
121bce92af CP-28282: Correction to the required disk space calculation
- also renamed a variable and updated the problem description to include the server name

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-06-15 14:24:29 +01:00
Mihaela Stoica
c702399d95 CP-28282: Update the disk space precheck to calculate the required space according to the new workflow (apply all hotfixes to a host before moving to the next one)
- this commit covers the post-Ely case, where updates are uploaded to storage repositories

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-06-13 17:24:33 +01:00
Mihaela Stoica
8fff0b2b10
Merge pull request #2093 from kc284/REQ-672
Separate displayed update information per pool. Minor layout corrections and removal of unused LinkLabel.
2018-06-08 16:54:11 +01:00
Konstantina Chremmou
73e7b66fa4 Do not change the page top blurb depending on the process outcome. Improved error messages.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-08 16:15:55 +01:00