Commit Graph

5141 Commits

Author SHA1 Message Date
Konstantina Chremmou
b0cdc74188 The code in the BackgroundWorker's ProgressChanged and RunWorkerCompleted event handlers does not need invoking as it's already on the UI thread.
Also, some logic simplification.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-05-29 13:50:46 +01:00
Konstantina Chremmou
89621c2bb5 Unnecessary field.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-05-29 10:47:54 +01:00
Konstantina Chremmou
18f2ff0785 Typo.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-05-29 10:46:14 +01:00
Mihaela Stoica
c2b42fa107 CA-289335: Refactoring to avoid setting the SelectedItem twice
- also avoids iterating through the combobox items again to determine which item to select

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-05-24 16:23:04 +01:00
Mihaela Stoica
54b134a2eb CA-289335: Show empty selection if the cluster network cannot be resolved
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-05-24 16:23:04 +01:00
Mihaela Stoica
a74ee3a793 CA-290064: Make the FibreChannelProbeAction an AsyncAction, because the PureAsyncAction throws an exception when collecting the API methods for RBAC checks.
An exception is thrown by the ProcessXml function if the result is an empty string, which is the case when the action is run with the RbacCollectorProxy to collect the API calls

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-05-24 13:00:05 +01:00
Mihaela Stoica
5d0b760a96 CA-288751: Fix the RBAC checks for probe_ext
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-05-24 13:00:05 +01:00
Ji Jiang
9ddb253ec0 CP-26866: Add a specific warning when creating a bond on cluster network
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-05-23 16:47:59 +01:00
serenc
29d82b1498 CP-28229: Update XenCenter to remove Cluster.network 2018-05-18 16:40:59 +01:00
Konstantina Chremmou
9a7fcde66e CA-289948: Do not show the upsell dialog if migration is not permitted due to licensing restrictions; launch the move VM dialog instead.
Also, removed unused constructor.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-05-18 16:37:12 +01:00
Konstantina Chremmou
2f2a533b46 Fixed some column sizing issues on the VM, SR and physical storage pages as well as a regression in the selection mode of the last one.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-05-17 15:45:50 +01:00
Mihaela Stoica
01c8a7ed83 CA-289150: Use a local variable to avoid calculating DistinctHosts twice
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-05-17 14:33:31 +01:00
Mihaela Stoica
2dab045441 CA-289150: Use a lock object to ensure that the hosts and connections lists are safely accessed from separate threads
This change fixes the crash with IndexOutOfRangeException in XenServerUpdateAlert

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-05-17 14:33:31 +01:00
Mihaela Stoica
5ad2aa302e CA-289959: Add null checks when resolving the updates which require reboot
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-05-17 14:24:51 +01:00
Mihaela Stoica
171284ff34 CP-28094: Rationalise device-config keys with SMAPIv1
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-05-16 17:18:12 +01:00
Konstantina Chremmou
c475861941 CA-248353: Refactoring to avoid referencing cells with hardcoded index numbers,
which makes them undiscoverable and breaks if the columns are rearranged.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-05-15 13:17:04 +01:00
Konstantina Chremmou
81115674e7 Removed DataGridView grid because we normally don't use one. Renamed columns
to make them more discoverable. Removed unused class.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-05-15 13:17:04 +01:00
Konstantina Chremmou
085b4d4f6e CA-248353: Do not use a hardcoded string or integer to reference DataGridView columns or ToolStripMenuItems.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-05-15 13:17:04 +01:00
Konstantina Chremmou
7cc1402099 CA-248353: Do not use a hardcoded string to find the status image column as
the code will break if the column on the LicenceManager is renamed. Also, do
not create the new cell before the index checks pass.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-05-15 13:17:04 +01:00
Konstantina Chremmou
6a36bf37ff The designed class should be the first one in the file, otherwise VisualStudio's designer breaks.
In this case, the CheckableDataGridViewRowEventArgs are very specialised and can be nested in the CheckableDataGridView.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-05-15 13:17:04 +01:00
Konstantina Chremmou
79684617eb CA-248353: Reference the column object directly instead of trying to retrieve it using a hardcoded string as a key.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-05-15 13:17:04 +01:00
Konstantina Chremmou
0d8f61fbb0 CA-289182: Corrections to sorting (clearer handling of null cases, non-XenObjects, logic path inconsistencies).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-05-14 14:56:42 +01:00
Konstantina Chremmou
fd2ee1922a CA-286291: Missing copyright.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-05-14 13:37:40 +01:00
Mihaela Stoica
8992e55141 CA-286291: Add the additional menu items immediately after the first item, so we don't have to wait for the WLB recommendations to be
retrieved.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-05-14 12:30:40 +01:00
Mihaela Stoica
ba8a612c01 CA-286291: Remove the ToolTip from the VMOperationTollStripManuSubItem, as the reason why the item is disabled is already included in the items's MenuText
This change improves the performance of the drop-down menu considerably, as it avoids the server calls from the Command.ToolTipText

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-05-14 12:30:40 +01:00
Mihaela Stoica
025e92bc7d CA-286291: Some more refactoring in VMOperationToolStripManuItem
(including the removal of the HostListUpdater class)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-05-14 12:30:40 +01:00
Mihaela Stoica
7ba8546929 CA-286291: Refactoring in VMOperationToolStripManuItem
- added an action for the API call that retrieves the WLB VM recommendations
- removed the thread used for updating the menu items, so that we always access the menu items on the UI thread and do only the server calls on separate threads (for WLB, getting the recommendations now is done on the new action, for non-WLB we have the `workerQueueWithoutWlb`)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-05-14 12:30:40 +01:00
Jisheng Xing
79f91ce2b4 CA-288188: correct the NICPage status when SR-IOV logical pif unplugged
Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
2018-05-14 12:14:22 +01:00
Konstantina Chremmou
0c3298fd8b CA-289153: Do not attempt updating the licence status for disconnected hosts. (#2072)
Also, no need to trigger an event when the host is null or when get_servertime
fails only to double-log it in the handling class.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-05-11 16:38:46 +01:00
Konstantina Chremmou
8ae3ceeea1 CA-289718: Refine the storage connections precheck to allow the installation of an update that has been uploaded to a local SR (#2071)
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-05-11 14:38:44 +01:00
Konstantina Chremmou
f9a7e64086
Merge pull request #2068 from xenserver/release/kolkata/master
Merge release/kolkata/master into master
2018-05-10 13:46:53 +01:00
Mihaela Stoica
7ad1f93e16
Merge pull request #2067 from vetrivelc/release/kolkata/master
L10N: CP-28097 Translation Checkins
2018-05-10 11:38:45 +01:00
Vetrivel Chinnasamy
6d442aec50 L10N: CP-28097 Translation Checkins 2018-05-10 15:29:25 +05:30
Mihaela Stoica
fcfc4cacf4
Merge pull request #2066 from kc284/release/kolkata/master2
Disable creation of SR-IOV network if the feature is disabled.
2018-05-09 13:01:19 +01:00
Mihaela Stoica
5b234d181d
Merge pull request #2065 from kc284/release/kolkata/master2
Disable creation of SR-IOV network if the feature is disabled.
2018-05-09 12:54:32 +01:00
Konstantina Chremmou
3fc14c5344 Disable creation of SR-IOV network if the feature is disabled.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-05-09 12:38:26 +01:00
Mihaela Stoica
02c4ed5a95 CA-288560: Also update the CN and JA resources
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-05-02 12:57:10 +01:00
Mihaela Stoica
4096803ee1 CA-288560: Convert CPU average frequency to GHz, when needed
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-05-02 12:57:10 +01:00
Mihaela Stoica
906af62422 CA-288560: Add friendly name and units for CPU average frequency
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-05-02 12:57:10 +01:00
Mihaela Stoica
d501d248db Resort Messages.resx
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-04-30 09:57:11 +01:00
Mihaela Stoica
01b9600c5c
Merge pull request #2058 from xenserver/release/kolkata/master
Merge changes for DO-3700 to master
2018-04-27 11:14:55 +01:00
Mihaela Stoica
4346de5eb8
DO-3700: Add -src-pkgs file pattern in the hotfix-map file
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-04-27 10:31:28 +01:00
Mihaela Stoica
782b9bb40f
DO-3700: Specify the file extensions to the hotfix-map file spec
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-04-27 10:12:50 +01:00
Mihaela Stoica
cb50546d79
Merge pull request #2057 from xenserver/master
DO-3700: Add an exclude pattern to the hotfix-map file spec
2018-04-26 16:08:29 +01:00
Mihaela Stoica
de31b24242 DO-3700: Add an exclude pattern to the hotfix-map file spec
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-04-26 16:00:44 +01:00
vetrivelc
1f4fa9b46a L10N: CA-288597 & Translation Updates 2018-04-26 10:54:18 +01:00
Vetrivel Chinnasamy
998cea2ec2 L10N: Kolkata Bug Fixes (#2052)
* L10N: UI Truncation Fixes

* L10N: Bug fix truncation issue JA

* L10N: Removed the help image in SC Wizard page

* L10N: Update to zh-CN XenWizrd Base
2018-04-25 18:19:03 +01:00
jishengx
ac9425fad0 CA-287857: judge if the status of pifOnMaster before enable SR-IOV (#2050)
* CA-287857: judge if the status of pifOnMaster before enable SR-IOV

Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>

* fix some comments

Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>

* fix comments

* fix comments
2018-04-24 17:22:18 +01:00
Mihaela Stoica
296739cfa4
CP-27751: Include new RPU003 and RPU004 plugins for CA-287020 (#2049)
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-04-23 15:39:34 +01:00
Mihaela Stoica
d72ec5a94f
CA-286291: Add null and type checks (#2048)
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-04-23 12:54:09 +01:00