Commit Graph

35 Commits

Author SHA1 Message Date
Konstantina Chremmou
dce02a2562 Renamed AsyncAction.RunExternal to AsyncAction.RunSync so it is more descriptive.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-06 13:11:34 +01:00
Konstantina Chremmou
abf4ae3f35 CP-36392 pt.1: Removed unused using directives.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-04-07 10:04:47 +01:00
Konstantina Chremmou
60fb141e57 CA-339384: Take account of thin provisioning when placing a disk on a target SR.
Also, set the required disk size to zero when the disk spinner value is invalid.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-11-18 09:24:45 +00:00
Konstantina Chremmou
a84053cf8d CA-337323 : SR.scan on the SrPicker was happening silently without any indication on the UI (enhanced fix for CA-280299).
The result was that numbers were changing suddenly; in cases of slow connections,
a user could make a selection before the scan was over.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-04 14:30:24 +01:00
Konstantina Chremmou
60da6080f9
Refactored three button dialog (#2627)
* ThreeButtonDialog simplification step1: Help name.
* ThreeButtonDialog simplification step2: Window title.
* ThreeButtonDialog simplification step3: Removed class Details.
* ThreeButtonDialog simplification step4: Removed unnecessary (and wrong) class.
* ThreeButtonDialog simplification step5: Compacted TDButton constructors.
* ThreeButtonDialog simplification step6: Removed purposeless methods.
* ThreeButtonDialog simplification step7: Refactored constructor logic.
* ThreeButtonDialog simplification step8: Icon normalisation.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-22 14:47:03 +01:00
Konstantina Chremmou
f39a715816 CP-29522, CA-302477: Added TB option to the NumericUpdown of the NewDiskDialog and fixed validation on the VDISizeLocationPage.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-14 09:24:36 +01:00
Konstantina Chremmou
73eaed6af8 Fixed some issues around the validation of SrPicker selections.
- Fixed button enablement on the IntraPoolCopy page.
- Regression on the NewDiskDialog were selection was considered valid
even if the SR was disabled.The SrSelectionChanged and SelectedIndexChanged
were fired in the wrong order. To fix this the event SrSelectionChanged
is removed (in reality after the refactoring in 5b79b1dc94
it became obsolete).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-14 09:24:36 +01:00
Konstantina Chremmou
ec79720057 Do not pass the delegates showing messages as parameters to the actions, but rather have them handle action events.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-14 09:24:36 +01:00
Konstantina Chremmou
0e57e871b9 Removed unnecessary instance class SrPickerItemFactory.
Removed comments that did not provide further info than the class name
they were documenting. Removed unused code. Launch progress dialog within
a using block.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-22 16:19:25 +01:00
Konstantina Chremmou
0567d838df Do not set the owner form within the NewDiskDialog constructor; it should be
set by the caller. Test corrections so they don't time out due to blocking
open dialogs. Some tidying up.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-14 09:45:13 +00:00
Konstantina Chremmou
5b79b1dc94 Removed the label from the SrPicker because in half of the occasions it was
hidden and in all other cases it was set by the implementing control, i.e.
the label was not reusable, hence no reason to have it in the control and risk
layout issues. This means that the SrPicker does not need to be a control
encapsulating a CustomTreeVIew, but simply derive from the latter.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-24 12:49:31 +01:00
Konstantina Chremmou
f1d5abb7a5 Replaced duplicate events ItemSelectionNull and ItemSelectionNotNull with SrSelectionChanged.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-24 12:49:31 +01:00
Konstantina Chremmou
583513f9e4 CA-202377: Removed the QueuedBackgroundWorker from the NewDisk dialog (unused)
and the vApps dialog (not particularly needed because we only query the cache
and do not make any server side calls).
Also, removed unhooked event handlers from the NewDisk dialog.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-03 13:00:27 +01:00
Konstantina Chremmou
514c33140b Converted remaining extension get and set properties of the API classes to methods
in order to prevent them from being serialised alongside the API properties.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-05 02:15:38 +01:00
Konstantina Chremmou
ae22560ce8 Converted all extension get properties of the API classes to methods in order to
prevent them from being serialised alongside the API properties. This will also
be useful for moving the API bindings out of XenModel.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-03 03:35:30 +01:00
Stephen Turner
89f51e90a1 CA-258782 Remove thin provisioning code (#1728)
* CA-258782 Remove thin provisioning code

* Revert file that shouldn't have been touched

* Remove line that was only present for debugging
2017-08-22 16:40:08 +01:00
Gabor Apati-Nagy
7c0bc50b4a CA-176169: Changed copyright statements to include the comma in Citrix Systems,
Inc.

Signed-off-by: Gabor Apati-Nagy<gabor.apati-nagy@citrix.com>
2017-01-16 19:59:50 +00:00
Konstantina Chremmou
fd3393049c Code simplification: use Action delegate instead of EventHandler since the event is not sending any objects when triggered. 2016-06-27 10:20:23 +01:00
Mihaela Stoica
3f25c5868f CP-17161: Add 'using' statement around dialogs to ensure garbage collection
- fix all ThreeButtonDialog usages (and some other dialogs that I've came across)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-20 10:49:12 +01:00
Mihaela Stoica
c48c28968d Improvements to the Storage page of New VM Wizard - changes following code review
- renamed srSpace and srInitialSpace variables
- removed unnecessary checks for thin provisioned sr
- fixed some error on NewDiskDialog.SMConfig property (smconfig was wrongly populated based on controls enablement; the conversion to long was made before converting to bytes

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-09-23 14:15:40 +01:00
Mihaela Stoica
7df999c532 Improved behavior of the SR picker in the New Disk dialog
- when the user changes the disk size (or initial allocation), the selection in the SR list should not change and the list should not be automatically resorted
- users should not be allowed to create disks larger than the SR size (the SR is disabled and an explicit reason is displayed)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-09-18 16:45:05 +01:00
Mihaela Stoica
687df9179e Hide the allocation fields in the New disk dialog if the SR is not thin lvhd
Also fixed the anchoring of the controls on this dialog.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-09-18 16:25:57 +01:00
Mihaela Stoica
f507b65126 CA-183321: Fixed the bug where the disk initial and incremental allocations values were ignored while creating new VM's disk
When creating a new VM, we no longer use vm.provision to create VM's disks, but instead we create the disks ourselves using vdi.create; this way we can specify the initial and incremental allocations for the new disks.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-09-18 15:51:17 +01:00
Carmen Agimof
549067f2d0 CP - Refactors Provisioning page in SR wizards to use the new control for allocations.
Adds tab indexing to the control for allocation and changes label names.
Corrects mistake that led to exception being thrown when the Disk Size is decreased in the the New Disk Dialog.
2015-08-28 16:44:22 +01:00
Carmen Agimof
189fc17d92 CP-13174: Arranges code and removes unused variables. 2015-08-27 10:23:09 +01:00
Carmen Agimof
0cca0fc125 CP-13174: Rename Size Property and Refactors code 2015-08-26 17:41:59 +01:00
Carmen Agimof
06b7b66357 CP-13174: Change units used for initial_allocation and allocation_quantum to MB or GB instead of percentages.
Changes allocation type from "dynamic" to "xlvhd".
2015-08-26 17:14:01 +01:00
Gabor Apati-Nagy
d705b77af6 CP-12475: XenCenter work for thin provisioning: Add Virtual Disk dialog: new fields
Add VDI page, Initial Allocation Size field: To override default to
default value behaviour it is no longer enough to enter this field - at
least a change has to be made to it's value.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2015-06-29 13:49:13 +01:00
Gabor Apati-Nagy
847eebd32c CP-12475: XenCenter work for thin provisioning: Add Virtual Disk dialog: new fields
Add New Virtual Page (VDI):
By default, the SR's default initial size allocation percentage (that may be different for different SRs) is used.
Once the user has changed the initial allocation rate, the page would only use the custom value from that point.

New SR Wizard:
Minimal change in if statement and added comment in RunNextPagePrecheck
method for LvmoHba.
2015-06-26 15:36:04 +01:00
Gabor Apati-Nagy
37330629b8 CP-12475: XenCenter work for thin provisioning: Add Virtual Disk dialog: new fields
Created SR.IsThinProvisioned property
2015-06-25 13:42:08 +01:00
Gabor Apati-Nagy
31af0f0004 CP-12475: XenCenter work for thin provisioning: Add Virtual Disk dialog: new fields
Fixed dynamic allocation based calculation on the new SR page and in the SrPicker (issue found in code review)
2015-06-25 11:46:31 +01:00
Gabor Apati-Nagy
fc0542066e CP-12641 and CP-12475: XenCenter work for thin provisioning
-Changed code, because API needs 0-100 percent values as 0..1
-Code for HBA SRs
-Changed free space check for new VDIs to condider initial disk size only
when the SR is thin provisioned

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2015-06-23 19:26:27 +01:00
Gabor Apati-Nagy
306a8b0acb CP-12641 and CP-12475: XenCenter work for thin provisioning
-New SR wizard: new page
-Add Virtual Disk dialog: new fields

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2015-06-17 09:59:21 +01:00
Gabor Apati-Nagy
3c3ef707fa CA-116505: Popup when adding CD drive to running HVM guest without tools does not get focus
Using ShowDialog() instead of Show()
Also removed unnecessary code that displayed the popup again

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2015-05-18 19:25:46 +01:00
Mihaela Stoica
bd36a85bff CP-4816: Initial commit to git repo
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2013-06-24 12:41:48 +01:00