This required refactoring the OVF.AddVirtualSystem() method to accept the
system ID as a parameter. Also, removed some unused methods that were
calling OVF.AddVirtualSystem().
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
The situation described in the comment is not applicable as scaling does
not change outside the UI thread, and OnResize() does call SetupScaling().
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Re-arranged and re-worded controls so that this page looks more like
the precheck page of the patching and RPU wizards.
- Do not show the failure message unless issues are found.
- Do no enable the Resolve All button unless all issues are fixable.
- Fixed crash when the required SR is present in the pool but detached.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Sharp turns in the graph can result in the line being drawn outside of the box.
This change makes sure the line is only rendered within the input rectangle.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
- Do not suppress failures when polling the import task.
- When the imported VM is suspended, try resuming instead of starting it.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
dev-CHCUpdates.xml contains a placeholder value for the destination URL
- Add existence check for `pdb` files in build script
This prevents script from stopping if MSBuild didn't generate any `pdb` files in `packages`
- Insert placeholders for pipeline and branding in Jenkinsfile
- Remove existence check for package `pdb`s in build script
Also simplify MSI checksum extraction from `sha356sum` call
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
- Add VS Enterprise as option for building project
Also add to `re-branding.sh` replacement list
- Bump branding version to v4.3
- Add default `UPDATES_URL` to `branding.sh`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
Apply some naming and styling conventions. Specifically, remove useless usages of `this.`, use arrow syntax for RDP fields, and remove redundant bool field initialisation
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
These changes keep polling open console connections to check the status of RDP capabilities.
This is necessary when installing/uninstalling VM tools on VMs. Without this, changes in the `guest_metrics` aren't spotted. Consequently, the user is not shown the option to connect with RDP until they disconnect (or the console session is disconnected), even if the VM is capable.
That is because before this, the polling for RDP changes (as performed by `connectionPoller`) was only started if the VM had RDP capabilities when first connecting to it with the console.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
- Corrected the logic deducing whether shutting down and restart is needed.
- Fixed crash when starting a VM without a home host.
- Also, renamed some fields for better compliance with C# naming conventions.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Mostly to remove warning from SonarQube, so exception is only thrown in DEBUG mode
Address code surrounding previously emptied setters
Avoids throwing exceptions when not needed
Move default `VerticalTabs` fields outside of constructor
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-31587 made checksum comparison case insensitive as well as culture insensative
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
* Fixes not null assertion
Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>
* Merges internal classes to be in same file
Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>
