Commit Graph

4089 Commits

Author SHA1 Message Date
Mihaela Stoica
21fe02922f Merge pull request #1048 from cheng-z/CA-213045
CA-213045: Make server backup file name rebrandable
2016-07-08 16:16:46 +01:00
Mihaela Stoica
4ea4ea8d0b Merge pull request #1061 from kc284/car-2217
Do not show the CVM's own name on its console, but rather a description including the host's name.
2016-07-08 13:36:08 +01:00
Konstantina Chremmou
f63ca812f3 When the host name changes, the teal label of the docked CVM console should change too.
Also, fixed bug where the title of the server's undocked console was truncated to
the server's name when the latter changed.
2016-07-08 13:15:15 +01:00
Mihaela Stoica
ae4670c3b1 CA-107240: VDI move window shows incorrect message for broken storage as ‘Local storage must belong to resident host’
Also fixed a similar issue, where the broken SR was selectable (Create new virtual disk from the SR Storage tab)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-07-08 11:48:29 +01:00
Mihaela Stoica
28c8ee7565 Merge pull request #1058 from Frezzle/CA-107357
CA-107357: Migrate VM Wizard allows selection of broken SRs
2016-07-08 10:34:40 +01:00
Konstantina Chremmou
7528cefce4 Do not show the CVM's own name on its console, but rather a description including the host's name. 2016-07-08 09:19:39 +01:00
Mihaela Stoica
727c7a5212 CA-203345: Exporting snapshot jams and cant be cancelled (when exporting 2 snapshots to the same file)
Replaced the call to Task.destroy() with the DestroyTask() method, which additionally sets RelatedTask to null. This ensures that we stop polling the task for its progress and report the error.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-07-07 15:27:45 +01:00
Frezzle
54a2ba7ac4 [CA-107357] Migrate VM Wizard allows selection of broken SRs
Detached SRs are no longer selectable.

Signed-off-by: Frezzle <frederico.mazzone@citrix.com>
2016-07-07 14:57:20 +01:00
Mihaela Stoica
16ebd4c496 Merge pull request #1055 from Frezzle/CP-17933
CP-17933: Add feature flag for proxy authentication
2016-07-06 13:07:11 +01:00
Mihaela Stoica
605511908c Merge pull request #1054 from kc284/car-2217
CP-17756: use new field Host.control_domain to find dom0
2016-07-06 11:48:42 +01:00
Konstantina Chremmou
336681fc6a Fixed regression introduced in previous commit. Also, the MultipleDvdIsoList on the
VMstorage page uses the default colours of the controls, hence we only need to set
them on the VNCTabView and the linklabel does not need to be public.
2016-07-06 08:55:28 +01:00
Mihaela Stoica
22236c1976 Merge pull request #1056 from GaborApatiNagy/master_batch_new2
CA-215093: Batch updates: Update progress failed in a pool of mixed state hosts
2016-07-05 17:27:32 +01:00
Gabor Apati-Nagy
bd26c7ac0e CA-215093: Batch updates: Update progress failed in a pool of mixed state hosts
Utilising default comparer on Host (This will makemaster first.)

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-05 15:37:52 +01:00
Gabor Apati-Nagy
f8a7d97890 CA-215093: Batch updates: Update progress failed in a pool of mixed state hosts
Where (in code removed by this commit) we iterated through the planActionsByHost dictionary, the hosts were iterated through in the order how the dictionary was initialized. Despite the actions were added in the right order, they then were screwed up, because the Cache.Hosts can have the hosts randomly while we want the master to be first.

To fix the bug, I changed the data structure from a dictionary to a list that has the actions exactly in the (good) order, the order they were added, eliminating the risk of the actions being retrieved in the wrong order.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-05 14:35:31 +01:00
Mihaela Stoica
06adea4f47 Merge pull request #1052 from GaborApatiNagy/master_batch_new2
CA-214063: Batch Updates: Name of the master is shown instead of the …
2016-07-05 11:04:32 +01:00
Gabor Apati-Nagy
1fe300c16d CA-214063: Batch Updates: Name of the master is shown
Removed unused field

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-05 11:00:40 +01:00
Gabor Apati-Nagy
504f73778f CA-214063: Batch Updates: Name of the master is shown instead of the pool's name on Select Servers Page
Code review changes: Showing server icon for standalone hosts instead the pool icon

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-05 10:42:49 +01:00
Frezzle
5f412549b2 [CP-17933] Add feature flag for proxy authentication
Made event handler logic clearer and more readable.

Signed-off-by: Frezzle <frederico.mazzone@citrix.com>
2016-07-05 10:40:21 +01:00
Konstantina Chremmou
e1462e34db Ignore line endings for all files (except shell scripts). 2016-07-05 08:14:47 +01:00
Konstantina Chremmou
094e4c4c4f CP-18028: For hosts with more than one control domain (dom0 and cvm at the moment) add an extra tab to display the console of the cvm. 2016-07-05 08:14:13 +01:00
Konstantina Chremmou
8991a257d2 Removed some unnecessary methods; changed visibility for controls that don't need to be public. 2016-07-04 23:05:51 +01:00
Frezzle
10261a85e9 [CP-17933] Add feature flag for proxy authentication
Added Registry.ProxyAuthenticationEnabled boolean property to enable/disable proxy authentication UI controls in Connection Options page.
Cleaned up event handler logic in Connection Options page to return from multiple/unnecessary calls to event handlers when manually changing controls through code.

Signed-off-by: Frezzle <frederico.mazzone@citrix.com>
2016-07-04 13:47:24 +01:00
Konstantina Chremmou
8de55cb90c Merge pull request #1051 from kallisti5/master
Case sensitivity fixes
2016-07-04 13:30:30 +01:00
Konstantina Chremmou
04ffdbadc5 CP-17756: Do not use the field VM.is_control_domain to find the console for the
host as it applies to other control domains too. Use the new Host.control_domain
field instead. Minor refactoring.
2016-07-04 13:22:08 +01:00
Konstantina Chremmou
56265bbfd6 CP-17756: The dom0 VM is found now using the new field Host.control_domain as
there can be more than one control domains. For older hosts return the control
domain with domid 0. Renamed property.
2016-07-04 13:21:52 +01:00
Konstantina Chremmou
94df31b878 Removed call of virtual member in the constructors. 2016-07-04 08:22:35 +01:00
Cheng Zhang
a682811ed5 CA-213045: Rework on comments to change string format
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2016-07-04 09:11:10 +08:00
Konstantina Chremmou
f320dd7881 Renamed control because Resharper was complaining about ambiguous references in
the resx files between this and homonymous control in two derived classes. Removed
reference of non-existent file from XenAdmin.csproj.
2016-07-03 19:45:40 +01:00
Konstantina Chremmou
f1b7aadc88 Fixed issue where the error message was not displayed if connection to the host console was not possible.
Refactored to hide/show error controls instead of adding/removing them. Removed duplicate null check.
Do not use a second list to track active VM consoles.
2016-07-03 17:45:49 +01:00
Konstantina Chremmou
8a8bdc21e6 Tidied up the ConsolePanel; moved designer code to the corresponding file and removed setting of virtual field from the constructor. 2016-07-01 17:47:41 +01:00
Gabor Apati-Nagy
55ff3794cf CA-214063: Batch Updates: Name of the master is shown instead of the pool's name on Select Servers Page
Fixed display issue, now showing pools (and standalone hosts at the same level), not masters.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-01 17:41:49 +01:00
Konstantina Chremmou
7d618d9e79 Merge pull request #1049 from MihaelaStoica/CA-116547
CA-116547: During Installation of Hotfix requiring restart of PV gues…
2016-07-01 09:16:29 +01:00
Konstantina Chremmou
051afb48c2 Merge pull request #1012 from MihaelaStoica/CA-209502
CA-209502: Exception while deleting multiple folders
2016-07-01 09:04:48 +01:00
Liang Dai
42f69a7ea1 CA-144951: [WLB Settings] Multiple pop-ups when navigating to Automation tab.
Signed-off-by: Liang Dai <liang.dai1@citrix.com>
2016-07-01 13:37:38 +08:00
Alexander von Gluck IV
47c65d4bcc XenAdmin/Resources: More image path case fixes 2016-06-30 23:01:52 -05:00
Alexander von Gluck IV
4d0097ce9c XenAdmin/TabPages: Case fix on WlbPage files 2016-06-30 22:51:27 -05:00
Alexander von Gluck IV
4cf4c4c33f XenAdmin/Resources: Fix case of images paths 2016-06-30 22:42:58 -05:00
Mihaela Stoica
bcc120f0b2 CA-209502: FolderAction refactoring
- created subclasses for each folder action type (create, rename, delete, move)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-30 15:41:46 +01:00
Mihaela Stoica
60c298d9e3 CA-116547: During Installation of Hotfix requiring restart of PV guests displays Dom0 in the list of VMs to be rebooted in XenCenter.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-30 12:32:41 +01:00
Konstantina Chremmou
975fe4f303 While researching the places where we use is_control_domain, I refactored some issues I noticed and were quick to fix:
- removed unnecessary casts
- no need to catch exception only to rethrow it; do not interrupt the call stack by using "throw ex"
- redundant check and value setting
2016-06-30 12:23:49 +01:00
Mihaela Stoica
1370508f45 Merge pull request #1045 from kc284/car-2217
CP-17689: Restrict maximum host failures to tolerate to the number sp…
2016-06-30 11:41:26 +01:00
Cheng Zhang
76f7946ec4 CA-213045: Make server backup file name rebrandable
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2016-06-30 10:31:10 +08:00
Gabor Apati-Nagy
de66c4403a Merge pull request #1047 from GaborApatiNagy/master_batch_new2
Merge master
2016-06-29 18:00:50 +01:00
Gabor Apati-Nagy
66be637878 Merging (upstream) master into REQ-156 branch caused a build error:
Fixed build error that was caused by changed visibility of a method.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-29 17:56:51 +01:00
Gabor Apati-Nagy
994f5b4811 Merge remote-tracking branch 'github_xenadmin/master' into master_batch_new2 2016-06-29 16:52:13 +01:00
Gabor Apati-Nagy
54257ebaea CP-17282: Unit tests to validate the Update Sequence logic
Added tests to csproj

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-29 14:01:19 +01:00
Mihaela Stoica
e8db39e0f6 Merge pull request #1046 from GaborApatiNagy/master_batch_new2
CP-17282: Unit tests to validate the Update Sequence logic
2016-06-29 13:59:38 +01:00
Gabor Apati-Nagy
eb5b01bc83 CP-17282: Unit tests to validate the Update Sequence logic
More tests following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-29 13:45:36 +01:00
Konstantina Chremmou
d35c162e76 CP-17689: Restrict maximum host failures to tolerate to the number specified by the other-config:hci-limit-fault-tolerance field. 2016-06-29 12:57:29 +01:00
Gabor Apati-Nagy
9337663adb CP-17282: Unit tests to validate the Update Sequence logic
Unit tests to test GetUpdateSequence

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-29 12:49:53 +01:00