Commit Graph

311 Commits

Author SHA1 Message Date
Mihaela Stoica
6b26093303 CA-242918: Improve the exception shown in XenCenter if the hotfix upload fails
When a TargetInvocationException is raised, its InnerException property holds the underlying exception, which is what we should display.
Also ellipsise the action description (which could be an error thrown by the upload action) that is displayed on the Upload page.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-03-16 11:41:14 +00:00
Mihaela Stoica
418d2edb7b Merge pull request #1461 from GaborApatiNagy/CA-244687_2
CA-244687: Install Updates Wizard: Automated mode: bugfix for omitted after-apply-guidances
2017-03-01 13:35:42 +00:00
Gabor Apati-Nagy
e9eeb3d595 CA-244687: Install Updates Wizard: Automated mode: bugfix for omitted after-apply-guidances
Fixes following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-03-01 13:10:45 +00:00
Gabor Apati-Nagy
15827512e1 CA-244687: XSINT71E003 asks user to restart toolstack after installing hotfixes using Batch hotfixing
This commit fixes a bug in the Update Wizard that causes XenCenter to not restart Toolstack when it should in the following case: in Automated Mode, when the update sequence for a host has an update that contains live-patch with restartHost guidance (and guidance-mandatory=false) followed by an update with Toolstack restart guidance.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-03-01 12:05:44 +00:00
Gabor Apati-Nagy
118dea1fa7 Merge pull request #1455 from MihaelaStoica/CA-245345
CA-245345: XenCenter doesn't mark a host as unapplicable when an upda…
2017-02-28 15:19:16 +00:00
Mihaela Stoica
dab5e3da05 CA-236104: Do not allow pre and post Ely servers to be selected at the same time when the user browsed for an iso update or supplemental pack.
Changes following code review

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-02-28 14:29:59 +00:00
Mihaela Stoica
33979bb1f2 CA-236104: Do not allow pre and post Ely servers to be selected at the same time when the user browsed for an iso update or supplemental pack.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-02-27 16:45:34 +00:00
Mihaela Stoica
f1470d1c53 CA-245345: XenCenter doesn't mark a host as unapplicable when an update is installed via "Select update from disk" option
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-02-27 16:43:02 +00:00
Gabor Apati-Nagy
da4140d75e Merge pull request #1443 from stephen-turner/CA-243964
CA-243964: Don't allow upload of .xsupdate files to >= 7.1 servers
2017-02-20 11:36:28 +00:00
Stephen Turner
20df8ce2fe CA-244097: XenCenter sometimes refuses .xsupdate files 2017-02-17 17:11:03 +00:00
Stephen Turner
74c567ef1d CA-243964: Don't allow upload of .xsupdate files to >= 7.1 servers 2017-02-17 16:56:44 +00:00
Stephen Turner
f3a64fc54b Merge pull request #1433 from geosharath/feature_merge
Scheduled Snapshots feature merge
2017-02-14 10:09:17 +00:00
vetrivelc
6d9273f304 L10N: Translation Changes & VMSS updates CP-20708 2017-02-14 03:27:38 +00:00
Gabor Apati-Nagy
6693570b11 Merge pull request #1428 from MihaelaStoica/CA-238265
CA-238265: Add the action title to the error message displayed on the…
2017-02-08 11:47:38 +00:00
Mihaela Stoica
ef331986c7 CA-238265: Add the action title to the error message displayed on the Install Update page of the patching wizard.
Also changed  ApplyPatchAction and ApplyUpdateAction to install a single update to a single host, so that the appropriate action title can be displayed if an action fails. And replaced 2 hardcoded strings with resource strings.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-02-06 13:04:07 +00:00
Letsibogo Ramadi
045c405f92 CA-239951 - Patching wizard allows selection of unreachable hosts
Disabled the ability to select unreachable hosts and in addition
added a try/catch block to hide error message resulting from trying
to clean up an unreachable host.

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-01-25 10:28:11 +00:00
Mihaela Stoica
b14cc05968 Merge pull request #1397 from letsboogey/master
CA-236114 - Wrong update is installed when two different updates are …
2017-01-23 12:51:03 +00:00
Letsibogo Ramadi
cdfdacd88f CA-236114 - Wrong update is installed when two different updates are uploaded in the same instance of the wizard
Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-01-23 12:36:47 +00:00
Gabor Apati-Nagy
d85cc824b5 Merge pull request #1392 from letsboogey/master
Ca-238273 - Install Update Wizard: Update still shows up in the grid …
2017-01-20 17:01:26 +00:00
Letsibogo Ramadi
8f48c99b2d Ca-238273 - Install Update Wizard: Update still shows up in the grid after it's been installed
Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-01-20 11:35:25 +00:00
Konstantina Chremmou
a59e4f4ad3 Merge pull request #1382 from GaborApatiNagy/master_CA-176169
CA-176169: Copyright statement checking
2017-01-19 15:14:25 +00:00
Mihaela Stoica
3abce40f74 CA-226900: Do not allow selection of individual pool members when installing a hotfix
Changed the rubric on the Select Servers page.
2017-01-18 10:59:35 +00:00
Gabor Apati-Nagy
978f85233c CA-176169: Added copyright statement to files which it was missing from
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-01-16 20:14:56 +00:00
Gabor Apati-Nagy
7c0bc50b4a CA-176169: Changed copyright statements to include the comma in Citrix Systems,
Inc.

Signed-off-by: Gabor Apati-Nagy<gabor.apati-nagy@citrix.com>
2017-01-16 19:59:50 +00:00
Mihaela Stoica
84df0d5f80 CA-239210: Fixed the tab order on the Select Servers page
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-01-11 11:48:58 +00:00
Mihaela Stoica
b418a8a170 CA-226900: Do not allow selection of individual pool members when installing a hotfix
This change does not apply to supplemental packs, as we should be able to install supp packs to individual hosts in a pool.
Also, if the wizard is installing an update from disk and we cannot match it in updates.xml, then we will continue to allow host selection, because we can't tell whether it is a supp pack or a hotfix.

Plus fixing the bug where the "Select All" button is enabled even when all the selectable servers/pools are selected

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-01-11 11:32:57 +00:00
Konstantina Chremmou
cbdf7d3742 Merge pull request #1334 from MihaelaStoica/CA-216752
CA-216752: Not all wizards progress through to the next page by press…
2016-12-22 09:14:29 +00:00
sri harsha tagore k
fcda47d3a0 L10N:Translations check-ins
Cherry-picked: ff6a3984d5a97313903a4d230bca15e54674976e [ff6a398]
Author: sri harsha tagore k <sriharshatagore.karpurapu@citrix.com>
2016-12-21 16:20:30 +00:00
Gabor Apati-Nagy
7ce6d50ed0 CA-236547: Unexpected error while applying hotfix on multiple Xenservers of different version
Reset both before any upload as the upload is going to set the correct one anyway

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-21 10:37:06 +00:00
Gabor Apati-Nagy
9bd776c83d CA-236547: Unexpected error while applying hotfix on multiple Xenservers of different version
Fixing the error, so the hotfix installation will fail as and where it is expected

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-19 18:00:42 +00:00
Gabor Apati-Nagy
9d5e71326c CP-20065: Change "Automatic Update" to "Automated Updates"
changed more messages following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-12 18:12:01 +00:00
Gabor Apati-Nagy
5ed6a7c8ff CP-20065: Change "Automatic Update" to "Automated Updates"
more renaming

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-10 15:01:25 +00:00
Gabor Apati-Nagy
b0ca08ae6d CP-20065: Change "Automatic Update" to "Automated Updates"
made naming more consistent

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-10 14:44:15 +00:00
Gabor Apati-Nagy
5b6bedea48 CP-20065: Change "Automatic Update" to "Automated Updates"
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-10 14:19:37 +00:00
Mihaela Stoica
508f638b3a CA-216752: Not all wizards progress through to the next page by pressing the Enter key
- Added a new method in XenTabPage which the derived classes can implement to select a default control after the page is loaded.
- Added a new wizard test that runs through the wizard by pressing the Enter key and checks if it has landed on the right page.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-12-08 14:52:21 +00:00
sri harsha tagore k
821f42e1f2 L10N:Translations check-ins 2016-12-02 20:13:49 +05:30
Gabor Apati-Nagy
9c4628f216 CA-229365: Install Update Wizard: Fixed commas in the blurb
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-25 17:40:15 +00:00
Gabor Apati-Nagy
5cd032525c CA-229009: VDI is not deleted for the updates
If batch updating fails in a pool, this code will do the clean up by
running the appropriate (next in the queue) RemoveUpdateFilesFromMaster action. In addition to Pool_update.clean(), Pool_update.destroy() will be called when needed.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-24 10:40:06 +00:00
Gabor Apati-Nagy
838303b3b3 CA-230461: NullReferenceException during batch update when no check-for-updates has been performed
Removed unneeded overload and it's usage

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-16 13:53:29 +00:00
Gabor Apati-Nagy
34169dd256 CA-230461: NullReferenceException during batch update when no check-for-updates has been performed
Much better way to update/download the CFU

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-16 12:26:26 +00:00
Mihaela Stoica
ceaa7460e4 Merge pull request #1281 from GaborApatiNagy/CA-229009&CA-229019
CA-229019 and CA-229009
2016-11-10 17:52:24 +00:00
Gabor Apati-Nagy
7790c8e51d CA-229019: XenCenter behavior on installing already uploaded update
Code review follow up commit

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-10 17:46:07 +00:00
Mihaela Stoica
bef415cc98 Merge pull request #1277 from GaborApatiNagy/CA-227719
CA-229185: XenCenter: Dundee and Creedence hosts should be disabled for Ely updates in 'Select Servers'
2016-11-10 17:20:03 +00:00
Gabor Apati-Nagy
b0588d980a CA-229009: VDI is not deleted for the updates
XenCenter will now remove VDIs that couldn't been introduced.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-10 17:18:51 +00:00
Gabor Apati-Nagy
4fad0d309a CA-229019: XenCenter behavior on installing already uploaded update
The Pool_update does not always covers all the VDIs XenCenter creates. These orphaned ones have to be deleted as well.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-10 17:15:40 +00:00
Gabor Apati-Nagy
7b6a296a68 CA-229185: XenCenter: Dundee and Creedence hosts should be disabled for Ely updates in 'Select Servers'
For ISO updates, when disabling hosts, use the filename matching logic for pre-Ely hosts as well.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-10 14:57:10 +00:00
Mihaela Stoica
a609e440f6 Merge pull request #1272 from mcintyre94/CA-228729
[CA-228729] Improve the message shown on finishing the update installation
2016-11-10 14:47:29 +00:00
Mihaela Stoica
30a5f36515 Merge pull request #1271 from mcintyre94/CA-228723
[CA-228723]  Cancelling update installation leaves the update in xapi db
2016-11-10 14:45:51 +00:00
Callum McIntyre
638d8fe9e6 [CA-228723] Use sync destroy method in the cleanup action 2016-11-09 16:32:16 +00:00
Callum McIntyre
4a2b27e8ab [CA-228729] Improve the message shown on finishing the update installation
Changed the message to Delete/Deleting/Deleted update installation files, as used in other messages.
2016-11-09 15:52:52 +00:00