Commit Graph

89 Commits

Author SHA1 Message Date
Gabor Apati-Nagy
994f5b4811 Merge remote-tracking branch 'github_xenadmin/master' into master_batch_new2 2016-06-29 16:52:13 +01:00
Gabor Apati-Nagy
9337663adb CP-17282: Unit tests to validate the Update Sequence logic
Unit tests to test GetUpdateSequence

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-29 12:49:53 +01:00
Mihaela Stoica
3f25c5868f CP-17161: Add 'using' statement around dialogs to ensure garbage collection
- fix all ThreeButtonDialog usages (and some other dialogs that I've came across)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-20 10:49:12 +01:00
Gabor Apati-Nagy
3e092f6d50 CP-17444: Show minimal hotfixes on General tab
Showing recommended* hotfixes for servers when the data is available (Check For Updates xml has been downloaded and has minimalPatches node in it for the given server version). *:Not applied ones from the minimal set.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-08 13:34:59 +01:00
Gabor Apati-Nagy
9ec512921b CP-15790: Prepare XenCenter for unit testing of Automatic Updates
Added support for defining custom update.xml location in Registry. This
can be either a local file or an URL. This will be beneficial when testing XenCenter.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-07 16:02:57 +01:00
Gabor Apati-Nagy
235ebe9b33 Merge branch 'master' of https://github.com/xenserver/xenadmin into master_batchupdate_new 2016-05-05 13:59:28 +01:00
Gabor Apati-Nagy
fdb930bb19 CP-15717: UI: Implement basic upload/precheck/patch/cleanup logic
cleaned up code

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-05-04 11:21:23 +01:00
Gabor Apati-Nagy
466f01b926 CP-15717: UI: Implement basic upload/precheck/patch/cleanup logic
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-05-04 11:06:39 +01:00
Gabor Apati-Nagy
d3914a2318 CP-15717: UI: Implement basic upload/precheck/patch/cleanup logic
intermediate commit

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-05-04 11:02:16 +01:00
Mihaela Stoica
afb60dcb0f CA-208808: The items of “Day of the week” drop-down list are not localized
- added HelpersGUI.DayOfWeekToString function

Signed-off-by: Mihaela Stoica <Mihaela.Stoica@citrix.com>
2016-04-27 14:22:50 +01:00
Gabor Apati-Nagy
0574a63de5 CP-15710: Code to Construct an Update Sequence
Using OrdinalIgnoreCase for uuid comparisons

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-03-16 13:46:58 +00:00
Gabor Apati-Nagy
25e83b72bf CP-15712: Add Automatic mode (internal parameter)
Removed Contained

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-03-16 13:41:10 +00:00
Gabor Apati-Nagy
312cd931ca CP-15712: Add Automatic mode (internal parameter)
Disableded non-required pages in the wizard
Added placeholder for new pages
Changed sequence of pages
Removed unnecessary code

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-03-16 11:38:16 +00:00
Gabor Apati-Nagy
7acbce0ca1 Merge remote-tracking branch 'github_xenadmin/master' into master_batchupdate_2 2016-03-10 14:57:29 +00:00
Mihaela Stoica
a7b5c52e1c CP-16205: Add AdditionalFeatures branding variable
We now have two branding variables, one for hidden features and one for additional features (empty by default)
2016-02-29 14:54:26 +00:00
Gabor Apati-Nagy
39ae204363 Merge remote-tracking branch 'github_xenadmin/master' 2016-02-08 10:14:25 +00:00
Gabor Apati-Nagy
b8e447afa3 CA-196315: XS65ESP1018 not showing up in XenCenter Updates (on staging)
Fixed code to treat uuids of patches case-insensitive when consuming, but not changing them (eg. to lowercase) to keep compatibility with older XAPIs.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-02-08 10:14:05 +00:00
Mihaela Stoica
20970ff122 CP-15399: Move check for updates url to Branding.cs
- InvisibleMessages.resx contains the default url for check for updates, which can be overwritten in Branding.cs
- Added an extra parameter to DownloadUpdatesXmlAction for the updates url. If this is not specified (or null), then the default one (from InvisibleMessages) is used

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-02-04 10:39:14 +00:00
Gabor Apati-Nagy
618283e051 CP-15710: Code to Construct an Update Sequence
Comments

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-02-03 12:00:41 +00:00
Gabor Apati-Nagy
459565423a CP-15710: Code to Construct an Update Sequence
Removed unnecessary reversing of lists and fixed code to start with SP. (None of these have not been causing problems, but they are not needed)

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-02-03 11:53:34 +00:00
Gabor Apati-Nagy
a8e7a199cf CP-15710: Code to Construct an Update Sequence
Extracted step6 to a new method.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-02-02 19:27:08 +00:00
Gabor Apati-Nagy
71a44aff12 CP-15710: Code to Construct an Update Sequence
This code constructs an update sequence/schedule for each host in a pool.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-02-02 19:14:59 +00:00
Mihaela Stoica
fc5ebd2d40 CP-15401: Move HiddenFeatures to a new class
Signed-off-by: Mihaela Stoica <Mihaela.Stoica@citrix.com>
2016-01-28 21:43:15 +00:00
Mihaela Stoica
a9d7d95f56 CA-196887: New function for reading registry key written by the installer
- When the installer writes HiddenFeatures registry entry, it specifies registry key HKMU, that means that it will be written in HKLM if the user selected "All Users" for installation, or to HKCU if the user selected "Just Me".
- Added a new function to read an installed key by trying CurrentUser first, then Local Machine.
This function specifies a registry view (RegistryView.Registry32) when it opens the key (On the 64-bit version of Windows, portions of the registry are stored separately for 32-bit and 64-bit applications. There is a 32-bit view for 32-bit applications and a 64-bit view for 64-bit applications).

Signed-off-by: Mihaela Stoica <Mihaela.Stoica@citrix.com>
2016-01-28 14:57:16 +00:00
Mihaela Stoica
5461838925 Merge branch 'master' into CP-15410
Conflicts:
	XenAdmin/Core/Registry.cs
2016-01-27 14:06:13 +00:00
Mihaela Stoica
2c41a4cfeb CP-15410: Show license expiry alerts
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-01-26 16:30:24 +00:00
Mihaela Stoica
f12b4765b6 CP-15409: Add read-only mode to License manager
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-01-26 14:49:02 +00:00
Cheng Zhang
6b2490dea7 CP-15401: Hide upload option by reg key
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2016-01-25 16:23:31 +08:00
Cheng Zhang
b33e579f28 CP-15401: Hide HealthCheck by reg key
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2016-01-25 13:40:45 +08:00
Cheng Zhang
7793f8547e CP-15401: Make legal notice change by reg key
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2016-01-22 16:51:37 +08:00
Cheng Zhang
e488c62175 CP-15401: Make Cross-server private network hide by reg key
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2016-01-22 14:30:28 +08:00
Cheng Zhang
88d881b126 CP-15401: Show/Hide rdpPolling, upsell and optimize for XenApp depending on XenCenter registry keys
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2016-01-22 13:31:22 +08:00
Cheng Zhang
15ef3410a3 CP-15398: Make file name and dir rebrandablei
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2016-01-19 18:40:55 +08:00
Gabor Apati-Nagy
3f9db9f98b CA-159790: [XSO-208] MeddlingActions don't show location information
Found a better solution

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-01-14 14:33:06 +00:00
Gabor Apati-Nagy
ae05d9de17 CA-159790: [XSO-208] MeddlingActions don't show location information
Updated the GetLocation extension method for ActionBase objects to return action.Connection.FriendlyName should it have no Host or Pool set up. This way we see location for MeddlingActions.
Also changed some messages (Task Names) to include "VM" in them too, because xe command line initiated VM lifecycle actions looked really misleading after the above fix in XenCenter (Eg. restarting a VM would show up as "Restarting", "server" which would suggest that not just the VM, but the host is being restarted.)

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-01-12 19:16:29 +00:00
Gabor Apati-Nagy
31c6ab0a7c Merge pull request #732 from MihaelaStoica/CA-187698
CA-187698: When restoring dismissed updates, only do it on the connec…
2015-11-11 12:26:32 +00:00
Stephen Turner
b587ab832e CP-14647: Intermediate check-in #1 2015-11-08 11:27:56 +00:00
Mihaela Stoica
817d42fb18 CA-187698: When restoring dismissed updates, only do it on the connections with sufficient privileges
- This fixes the uncaught exception raised when an unauthorized user tries to restore dismissed updates.
- Also added the roles check when dismissing updates.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-11-05 15:49:38 +00:00
Mihaela Stoica
40a634d324 CP-14641: Changes following code review
- vendor check is not needed in the functions where we check whether to warn the users about different feature levels, as the pool join is not allowed if the vendors are different
- renamed some of the functions
- feature comparison is now done eight characters at a time, converted into a 32-bit integer

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-11-04 16:33:23 +00:00
Mihaela Stoica
d650befbdc CP-14641: Add warnings on pool join if the pool and the joining host have different CPU features
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-10-30 15:52:24 +00:00
Mihaela Stoica
8702da52a1 CP-13077: Changes to the Health Check feature to work properly with RBAC
- Changes following code review: only create (and return) the action when needed

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-09-09 13:10:56 +01:00
Mihaela Stoica
53b01c425c CP-13077: Changes to the Health Check feature to work properly with RBAC
Changed all the health check actions to perform the necessary role checks
- HealthCheckAuthenticationAction: changed so it does not save the tokens, so no role checks required in this action (all the checks are performed in SaveHealthCheckSettingsAction)
- GetHealthCheckAnalysisActions: added role checks

On the Health Check Overview dialog, a pool is displayed as read-only if connected as a user with roles that don't permit changing the health check settings:
- the following actions are not available: enroll, edit settings, disable health check, request upload, get analysis result
2015-09-03 11:49:53 +01:00
Mihaela Stoica
44e18df03d CP-12156: Obtain and display the result of the CIS analysis of the last uploaded report
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-08-27 00:30:02 +01:00
Gabor Apati-Nagy
f6b632d0b6 Merge pull request #593 from agimofcarmen/CA-178243
CA-178243: When only Automatic check for XenServer updates was checke…
2015-08-04 17:30:22 +01:00
Carmen Agimof
c8e5138031 CA-178243: Refactors code, simplifying it. Now we only keep one list in DownloadUpdatesXmlAction for XenServerVersions and added a property that returns the list with the versions if Automatic check for XS version is checked and a new list which is empty when is not checked. 2015-08-04 17:28:29 +01:00
Carmen Agimof
f3e4c140a0 CA-178244: Adds condition to RemoveUpdate that checks if the list contains the given update. 2015-08-04 16:27:12 +01:00
Carmen Agimof
04b204a0d9 CA-178244: Solves the issue about duplicates in the list of updates in the Updates Tab. 2015-08-03 15:12:42 +01:00
Carmen Agimof
9de57d38c2 CA-178243: When only Automatic check for XenServer updates was checked in Updates Options, when opening XC, the grid appeared empty in the Updates Tab. This was because to get the list of XS updates, we need the list of XS versions. Created a list of XenServer versions that is used only to get the XenServer updates. 2015-08-03 15:06:01 +01:00
Mihaela Stoica
8264dcaba0 Merge pull request #589 from agimofcarmen/CP-13518_II
Cp 13518 ii
2015-07-31 14:51:04 +01:00
Carmen Agimof
b7a010b5f0 CA-178243: The Refresh button was not working correctly because of the restore button. Automatic check for updates works now when certain boxes are checked, showing the updates when the user opens XenCenter, but, the list has duplicates.
Improves the centering of the warning messages in the Updates Tab, making the picture align with the text.
Corrects bug related to the visibility of the warning about automatic checks for updates.
2015-07-30 14:58:23 +01:00