- CA-359068¨Match the whole datasource name (previously the wrong one was picked
for disk read/write latency).
- New/edit Graph dialog: differentiate between enabled/disabled datasources and
visible/hidden (known/unknown units; the latter may mean no data).
- Some refactoring.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* CA-34231: Replace negative language with `block list` in code and references
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `stop` in code and references
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `freezing` in code
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `run/ran` in code comments
Some paramater mentions have been renamed, as they will be renamed in future commits.
Excluded mentions in XenAPI/Host.cs and XenAPI/VM.cs since code is autogenerated.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# CFUValidator/CommandLineOptions/CFUCommandLineOptionManager.cs
# XenAdmin/Controls/Wlb/WlbOptModeScheduler.cs
# XenAdmin/Dialogs/Wlb/WorkloadReports.cs
* CA-34231: Replace negative language with `run` in Command.cs Run method
Used Resharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/TabPages/GeneralTabPage.cs
* CA-34231: Replace negative language with `run` in Command.cs CanRun method
Used Resharper rename utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `run` in Command.cs CanRunCore method
Used ReSharper rename utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Commands/DRConfigureCommand.cs
# XenAdmin/Commands/DRDryrunCommand.cs
# XenAdmin/Commands/DRFailbackCommand.cs
# XenAdmin/Commands/DRFailoverCommand.cs
# XenAdmin/Commands/DisasterRecoveryCommand.cs
# XenAdmin/Commands/VMGroupCommand.cs
* CA-34231: Replace negative language with `run` in Command.cs RunCore method
Used ReSharper rename utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `run` in Command.cs GetCantExecuteReasonCore method
Used ReSharper rename utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `run` in Command.cs GetCantRunReasons method
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace remaining negative language with `run` in Command.cs
Also applied to related symbols. Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `run` in methods named CanRun
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `run` in methods in CrossPoolMigrateCommand.cs
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Commands/CrossPoolMigrateCommand.cs
* CA-34231: Replace negative language with `run` in remaining Run methods
Also updated negative language in `DeleteVMCommand`
Also updated in comment in `CrossPoolMigrateCommand`
Also renamed missed instances of `CanRun`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `run` in `CanRunCore` and `RunCore`
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace remaining negative language with `run` in Commands folder
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace remaining negative language with `run` in XenAdmin/Controls folder
Used ReSharper renaming utility. Had to rename `WlbReportView.xs:RunReport()` to `WlbReportView.xs:StartRunReport()` to resolve conflict with change from `WlbReportView:ExecuteReport()` to `WlbReportView:RunReport()`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Controls/Wlb/WlbOptModeScheduler.cs
# XenAdmin/Dialogs/Wlb/WorkloadReports.cs
# XenAdminTests/UnitTests/WlbTests/WlbScheduledTaskTests.cs
* CA-34231: Replace all remaining negative language with `run` in code
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Commands/Controls/WlbRecommendations.cs
# XenAdminTests/UnitTests/WlbTests/WlbScheduledTaskTests.cs
# XenModel/WLB/WlbScheduledTask.cs
* CA-34231: Replace negative language with `supporter` or `bond member` in code strings
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `supporter` or `bond member` in Messages string
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/MainWindow.cs
# XenAdmin/Wizards/PatchingWizard/PatchingWizard_SelectServers.cs
# XenModel/Messages.Designer.cs
# XenModel/Messages.resx
* CA-34231: Replace remaining negative language with `supporter` in .resx files
Used ReSharper renaming utility. FriendlyErrorNames.resx has been excluded.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `supporter` or `bond member` in XenAdmin code
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Dialogs/NewPoolDialog.cs
* CA-34231: Replace negative language with `supporter` or `bond member` in XenModel code
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `coordinator` in CFUValidator code
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# CFUValidator/CFUValidator.cs
* CA-34231: Replace negative language with `coordinator` in solution's comments and hardcoded strings
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `coordinator` in `Helpers:GetCoordinator` method
Used ReSharper renaming utility.
also renamed similarly named method in `ObjectChange.cs`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Alerts/Types/HotfixEligibilityAlert.cs
# XenAdmin/Controls/CustomDataGraph/ArchiveMaintainer.cs
* CA-34231: Replace negative language with `coordinator` in `EvacuateHostDialog.resx`
Used ReSharper renaming utility. Excluded jp and zh resources
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Dialogs/EvacuateHostDialog.resx
* CA-34231: Replace negative language with `coordinator` in `EvacuateHostDialog.resx`
Used ReSharper renaming utility. Excluded jp and zh resource files.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Dialogs/NewPoolDialog.resx
* CA-34231: Rename missing language references for change to `coordinator`
Misc files were not saved before last commits.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `coordinator` in `Messages.resx`'s code
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Commands/HACommand.cs
# XenAdmin/TabPages/AdPage.cs
# XenModel/Actions/Network/CreateBondAction.cs
# XenModel/Actions/Network/NetworkAction.cs
# XenModel/Messages.Designer.cs
# XenModel/Messages.resx
* CA-34231: Replace negative language with `coordinator` in `ExternalPluginAction.cs`
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `coordinator` in `XenAdmin/Commands`
Used ReSharper renaming utility. Also replace negative language in missed comment in `ExternalPluginAction.cs`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Commands/AddHostToPoolCommand.cs
# XenAdmin/Commands/HACommand.cs
* CA-34231: Replace negative language with `coordinator` in `Helpers.cs`
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `coordinator` in `NetworkingHelper.cs`
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `coordinator` in `PoolJoinRules.cs`
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Dialogs/NewPoolDialog.cs
* CA-34231: Replace negative language with `coordinator` in `XenAdmin/Commands`, `Controls`, and `Core`
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Commands/AddHostToPoolCommand.cs
* CA-34231: Replace negative language with `coordinator` in `XenAdmin/Diagnostics`
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `coordinator` in `XenAdmin/Dialogs`
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Dialogs/NewPoolDialog.cs
* CA-34231: Replace remaining negative language with `coordinator` in `XenAdmin`
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/MainWindow.cs
# XenAdmin/TabPages/GeneralTabPage.cs
# XenAdmin/Wizards/PatchingWizard/PatchingWizard_SelectServers.cs
# XenAdmin/Wizards/RollingUpgradeWizard/RollingUpgradeExtrasPage.cs
# XenAdmin/Wizards/RollingUpgradeWizard/RollingUpgradeWizard.cs
# XenAdmin/Wizards/RollingUpgradeWizard/RollingUpgradeWizardPrecheckPage.cs
# XenAdmin/XenSearch/Columns.cs
* CA-34231: Replace remaining negative language with `coordinator` in `XenModel\Actions`
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenModel/Actions/Network/CreateBondAction.cs
* CA-34231: Replace remaining negative language with `coordinator` in `XenModel`
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace remaining negative strings with `main` in `Messages.resx`
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenModel/Messages.Designer.cs
# XenModel/Messages.resx
* CA-34231: Replace remaining negative string names with `main` in `Messages.resx`
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Dialogs/OptionsPages/SaveAndRestoreOptionsPage.cs
# XenModel/Messages.resx
* CA-34231: Rename dialogs to replace negative connotations with `main`
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `main` in `SaveAndResoreOptionsPage.cs`
Also updated its resx file. Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Dialogs/OptionsPages/SaveAndRestoreOptionsPage.cs
* CA-34231: Fix invalid reference in `SaveAndRestoreOptionsPage.Designer.cs` after renaming
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `main` in `EnterMainPasswordDialog.cs`
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `main` in `ChangeMainPasswordDialog.cs`
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Fix invalid reference not changed after renaming `EnterMainPasswordDialog.cs`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace remaining negative language with `main` in `XenAdmin/Dialogs`
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Update class names in HelpManager.resx
Following renaming of main password dialog. Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `main` in `Metadata.cs`
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Remove remaning negative language with `coordinator` from `Messages.resx`
Used ReSharper renaming
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Remove remaning negative language with `other pool member` from `Messages.resx`
Used ReSharper
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace remaining negative language in solution
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Remove commented out code in VNCGraphicsClient.cs
Code has only been improved partially as it's not strictly relevant to the PR
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Amend negative word replacement in XSVNCScreen.cs
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Simplify debug call formatting in NewPoolDialog.cs
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Add code mistakenly removed in MainWindow.cs
Removed as part of `f155f9c8`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Revert renaming of constant related to Windows' API
Considered external to CH Center
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Amend hotkey for Coordinator field in `NewPoolDialog`
Previous ALT+<key> hotkey was conflicting with CreatePool
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Remove unecessary whitespace in EvacuateHostDialog.cs
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Update if block to exclude unecessary else in DRFailoverWizard.cs
Not relevant to the PR, but the change is small enought to no need extra testing
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Amend typo in PoolJoinRules.cs
supporer -> supporter
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Replace missing negative language with `coordinator` in `XenAPI-Extensions/Pool.cs`
Variables and methods XenAPI-Extensions were mistakenly skipped
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Replace negative language in `XenApi-Extensions` with `coordinator/interface`
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Replace negative language in `XenApi-Extensions` with `supporter/member`
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Replace remaining negative language in `XenServerHealthCheckBugTool.cs`
This is only used to format the string
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Change line-endings to CRLF in `Page_CloudConfigParamters.cs`
Done in order to fix merge conflict into master
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Amend misc negative language renaming typos
`XenServerHealthCheckBugTool` and `XenServerHealthCheckService`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* The solution libraries do not need a config file like the applications.
In fact the config file of XenAdminTests was mostly an unneeded copy of the
XenAdmin app.config; the NUnit setting has moved to the AssemblyInfo in NUnit3.
* Removed unused XenOvfApi settings.
* The constants in the Settings were largely not configurable, hence I moved them into the code.
The ones marked with TODO will be revisited within CP-32779.
* Removed config file from library XenOvfApi. Restored broken cryptography algorithm lookup.
(The list of algorithms had been removed from the Settings within the fix to CA-350574).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
This allows removal of DelegatedAsyncAction.ResultObject, which might lead to complicated implementations.
Also: some refactoring of the other WLB retrieve recommendations actions.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Reordered the labels to reduce flickering for short actions.
- No need to fire action events in a try-catch block.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Removed wrapper delegates; call the http_actions directly.
- In case of failure or cancellation of the http_action, poll the related task
ignoring any exceptions thrown, so that any clean up code within the http_action's exception handling can run.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
This simplifies the code since the TaskPoller cannot be perceived without an AsyncAction.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Regression introduced by the changes for CA-64500. Since we initiate a VMStartAction
we need to ensure that the VM object passed to the action has a non-null Connection.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Moved the code to the ExportApplianceAction so it's easier to modify the
action's description.
- Fixed issue where the user's option for adding signature/manifest to a plain
OVF package was ignored.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Destroying a VM does not disrupt the connection, hence the use of the BestEffort
method is not warranted. After this correction, BestEffort is only used in the
DestroyedBondAction, hence I removed it completely and replaced it with simpler
exception handling in the latter class's Run method.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Ensure we read the updates.xml location anew from the registry, otherwise the
application has to be relaunched to pick a registry change. Look in both hives
HKCU and HKLM. To avoid performance impact on the UI, move the operation into
the action's Run() body.
- Some refactoring to improve OOP design and fix XmlReader leak.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Consolidated Action.PollToCompletion overloads, among others, to reduce precision loss.
- Logging the environment's stack trace is not very useful in the case of an API failure.
- Log the task's opaque_ref so it's easier to trace errors in the server side logs.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
The fix for CA-337280 moved the parsing of the probe result in the Run body of
the action, causing it to fail when the dry-run for the RBAC checks is performed.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
