Commit Graph

73 Commits

Author SHA1 Message Date
Mihaela Stoica
8230315f76 CA-286882: Shutting down large number of VMs causes XenCenter to hang
Created a new base class for the Notifications pages (Alerts, Updates, Events). This can be used in the future to host more of the common code between these pages. For now, it implements a common mechanism for showing/hiding the page and ensures that the event handlers are deregistered when the page is hidden (i.e. when the user switches to a different view) and registered again when the page becomes visible

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-08-13 17:18:53 +01:00
Ji Jiang
d0fc3be56e CA-294091: Fix two Update wizards co-exist bug
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-08-07 12:02:57 +01:00
Mihaela Stoica
6e468da70a CA-293669: In the Updates tab, show the required updates for the slaves in a partiallly upgraded pool, even when the master's version cannot be found in the c-f-u
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-12 14:45:23 +01:00
Mihaela Stoica
ad1dabd257 CA-293026: Fix the updates shown on a partially upgraded pool
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-06-28 15:37:02 +01:00
Konstantina Chremmou
fb8434819d Namespace tidy 3/several: replaced XenAdmin.Core (instances in XenCenterLib) with XenCenterLib.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-11-30 13:56:32 +00:00
Ji Jiang
2f41bbfde1 CA-267553: Fix offline XC showing up to date bug
Refactor the code.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-10-03 18:00:48 +01:00
Mihaela Stoica
e6a6a9cc83 Merge pull request #1790 from jijiang/master
CA-267553: Fix offline XC showing up to date bug
2017-10-03 17:52:35 +01:00
Ji Jiang
7fa784ba96 CA-267553: Fix offline XC showing up to date bug
Fix comments about considering whether XS version is found in updates XML file.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-10-03 15:32:57 +01:00
Gabor Apati-Nagy
a8db7bfae9 Merge remote-tracking branch 'github_xenadmin/REQ-411' into master_REQ-411_merge
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

Conflicts:
	XenAdmin/Core/Updates.cs
	XenAdmin/TabPages/ManageUpdatesPage.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
	XenModel/Messages.Designer.cs
2017-09-29 11:56:46 +01:00
Ji Jiang
a70307a3a6 CA-267553: Fix offline XC showing up to date bug
The bug is that when XC does not connect to Internet, By Server Update
page shows all the hosts up to date.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-29 10:44:50 +01:00
Ji Jiang
268b19421f REQ-534: Fix some UI text display
Based on comments from doc team:
1) Column title "Patching Status" should be replaced by "Status" in csv file
2) In View dropdown, "By Host" should be replaced by "By Server"

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-27 15:14:15 +01:00
Ji Jiang
8f03795797 Fix compilation error after rebase REQ-534 on master
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 17:11:43 +01:00
Ji Jiang
f6f17746db CA-265684: Fix bug of disabled "Export All" button
The bug is that "Export All" button is disabled when all hosts are up to
date.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:49 +01:00
Ji Jiang
026c2b8d47 CA-265410: Fix missing required updates
The bug is that required updates for slaves of pre-dundee pool don't show.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:48 +01:00
Ji Jiang
7fd18e99cf CP-24032: Updates page collapsing enhancement
Store the pool collapsing state and rebuild it after refresh.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:48 +01:00
Ji Jiang
30400790c1 CP-24032: Updates page: collapsing funtionality
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:48 +01:00
Ji Jiang
17f76870b3 CP-23967: Fix and unify sorting in different views
The commit fixes bug and unify sorting rules in ManageUpdatesPage,
PatchingWizard_SelectServers and RollingUpgradeWizardSelectPool data
grid views.

The rules are:
1) Name column sorted purely by name.
2) Other columns sorted by string value, if the same, sorted by default,
which is still in order even in reverse direction.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:48 +01:00
Ji Jiang
880bde38f6 CP-23455: Add Update btn in Updates page "By Host"
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:48 +01:00
Ji Jiang
d8ca87cd15 CP-24210: fix the patch sorting in newer version
Keep order consistency with general tab for newer version servers.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:48 +01:00
Ji Jiang
1e335de316 CP-24210: Populate "By Host" view correctly
1) Show required updates in case of versions without minimal patches
2) Hide version text in installed updates when version is Ely or above

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:48 +01:00
Ji Jiang
af9143d199 CP-23967: sort "By Host" view rows in Updates page
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:48 +01:00
Ji Jiang
b5a8282089 CP-23454: Export function in "By Host" view
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:47 +01:00
Ji Jiang
8b2bc83a12 CP-23453: Populate "By Host" view in Updates page
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:47 +01:00
Ji Jiang
66b1b52ad1 CP-23450: Add "View" btn in Updates page toolbar
1) View button has "By Update" and "By Host" options.
2) "By Host" view hides "Filter by Date", "Dismiss All" and "Restore
Dismissed Updates" buttons.
3) "By Host" view turns date filter OFF.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 14:58:04 +01:00
Mihaela Stoica
86d2acee7f Merge branch 'master' into REQ-411
Conflicts:
	CFUValidator/CFUValidator.cs
	CFUValidator/OutputDecorators/XenCenterUpdateDecorator.cs
	CFUValidator/OutputDecorators/XenServerUpdateDecorator.cs
	XenAdmin/TabPages/ManageUpdatesPage.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
	XenModel/Actions/Updates/XenCenterVersion.cs
	XenModel/Actions/Updates/XenServerVersion.cs
	XenModel/Messages.Designer.cs
	XenModel/Messages.resx
2017-08-23 16:32:39 +01:00
Konstantina Chremmou
ad7e2fa6a6 CA-257927: Changed ChangeableList.RemoveAll method to fire the CollectionChangedEvent
once for all the items to be removed, passing in their list as argument. This method,
and the method Clear calling it, are used for alerts, updates, events and connections,
hence changed the handling of the CollectionChanged event in these cases to expect
either a single item or a collection. In the case of alerts, updates and events
this means that we can rebuild the whole list instead of removing single rows which
causes the application to hang for big numbers of items.
2017-07-24 14:48:02 +01:00
Konstantina Chremmou
2504779480 CA-23158: Some layout improvements and logic changes.
- Moved the top warning out of the filter toolstrip and into the same tableLayoutPanel
as the dataGridVew to avoid hardcoding the dataGridview location in the code.
- Corrected linkLabel colour for compliance. Changed icon to match the icon
of the bottom information label.
- When checking for updates disable the linklabel instead of hiding the whole
warning to avoid empty space or the dataGridView jumping up and down.
- The check button in the middle should be available when the check link is
available.
- Avoid toggling explicitly the enabled state of controls; it can be taken
care of within the check for updates event handlers.
- Other minor layout improvements (control positioning).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-06-11 11:11:32 +01:00
Konstantina Chremmou
31b98c51e5 Refactored duplicate method.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-06-11 11:11:31 +01:00
Konstantina Chremmou
9776c1e2c2 CA-23158: On alert dismissal remove single rows instead of rebuilding the datagridview,
thus solving the resizing issue of the Actions column. Also, register an action
before starting running it.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-06-11 11:11:31 +01:00
Letsibogo Ramadi
75a325056c CA-252871 - Updates order is not preserved on Exporting updates to a file
Applies sort order of DataGridView to the unfiltered list of updates before
exporting all to file, thereby preserving the update order in the file
2017-05-26 12:54:46 +01:00
Gabor Apati-Nagy
1317e5a4e3 CP-21500: Updates wizard: Show new versions that are available as updates
In the Updates wizard:
New versions that are available as updates will be listed in the "Download Updates from Citrix" section, before any other updates.
If XenCenter is not the latest version, these rows will be greyed out, with a tooltip.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-03-23 14:05:09 +00:00
Gabor Apati-Nagy
e73b989c72 Merge pull request #1500 from MihaelaStoica/REQ-411
CP-21184: Add a check for the XenCenter version
2017-03-22 14:00:29 +00:00
Gabor Apati-Nagy
a1e3e3e76d CP-21185: Show new versions of XS and XC on the top (#1499)
CP-21185: Show new versions of XS and XC on the top

...unless not sorted by name, date, or servers.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-03-22 11:44:29 +00:00
Mihaela Stoica
b65084fdc3 CP-21184: Add a check for the XenCenter version
- On the Updates tab: for new versions, check that the version of XenCenter is at least the latest. If not, give an additional option to download a newer XenCenter (for both updates and upgrades), and not offer "Download and Install" (for updates).
- In the Patching wizard: if the update is a new version, we force the user to first update their XenCenter to the new version
- In the RPU wizard: if the server version is not the latest and their XenCenter version is not the latest from updates.xml, we assume that they want to upgrade to the latest XenServer version and we force the user to first update their XenCenter to the latest version.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-03-22 10:59:32 +00:00
Letsibogo Ramadi
ba29f1588b CA-244655 - XenCenter shows the wrong message on the Updates page when no updates are found 2017-02-24 12:12:08 +00:00
Gabor Apati-Nagy
7c0bc50b4a CA-176169: Changed copyright statements to include the comma in Citrix Systems,
Inc.

Signed-off-by: Gabor Apati-Nagy<gabor.apati-nagy@citrix.com>
2017-01-16 19:59:50 +00:00
Mihaela Stoica
1aaa310c50 Merge pull request #1287 from kc284/master
CA-145890: added new Page to the options dialog where the user can co…
2016-12-01 09:39:22 +00:00
Callum McIntyre
c512fe8542 [CA-149812] Set Dismiss All as the default option on Updates page 2016-11-17 15:35:27 +00:00
Konstantina Chremmou
2e6b2d8995 CA-145890: added new Page to the options dialog where the user can configure how
confirmations are displayed. Added checkboxes to the dialogs requesting confirmation
of dismissal of notifications so the user can opt to skip this step.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-11-17 13:35:31 +00:00
Mihaela Stoica
9ec9cf1aee CA-225057: Add a helper method for setting the Clipboard text and use in all places where Clipboard.SetText was used.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-13 16:16:16 +01:00
Konstantina Chremmou
e9ca8b529a CA-217843 best effort: Run RestoreDismissedUpdates action asynchronously to prevent UI hiccups.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-08 14:37:47 +01:00
Mihaela Stoica
3f25c5868f CP-17161: Add 'using' statement around dialogs to ensure garbage collection
- fix all ThreeButtonDialog usages (and some other dialogs that I've came across)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-20 10:49:12 +01:00
Gabor Apati-Nagy
7477c1080d Merge pull request #926 from MihaelaStoica/CA-202269
CA-202269: Hide "Subscription advantage" link on the Updates page bas…
2016-04-07 09:57:48 +01:00
Mihaela Stoica
93c22c04b0 CA-202269: Hide "Subscription advantage" link on the Updates page based on the registry key
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-04-06 07:33:18 +01:00
Mihaela Stoica
a0940ebeec CA-205181: The error message for check update truncated when the screen resolution is 1024x768
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-04-05 08:21:14 +01:00
Carmen Agimof
945020ea75 CA-181309: Dismiss button in the Updates Tab is now disabled if the list is empty. 2015-09-02 17:54:29 +01:00
Carmen Agimof
5f95c9b6a0 Changes name of function, from someOrAllUpdatesAllowed to someOrAllUpdatesDisabled. The same change was applied for someButNotAllUpdatesAllowed. 2015-07-31 14:43:14 +01:00
Carmen Agimof
b2c4133e9e Improves design of the Updates Tab. 2015-07-30 18:00:06 +01:00
Carmen Agimof
b7a010b5f0 CA-178243: The Refresh button was not working correctly because of the restore button. Automatic check for updates works now when certain boxes are checked, showing the updates when the user opens XenCenter, but, the list has duplicates.
Improves the centering of the warning messages in the Updates Tab, making the picture align with the text.
Corrects bug related to the visibility of the warning about automatic checks for updates.
2015-07-30 14:58:23 +01:00
Carmen Agimof
bb5c2078dc CP-13518: Centered correctly the warning message in the Updates Tab. 2015-07-29 19:11:13 +01:00