Commit Graph

25 Commits

Author SHA1 Message Date
Konstantina Chremmou
efb855a6e9 Modifications around VncView disposal:
- Do not dispose of the activeView when pausing the console (which happens
  when we move away from the console tab.
- When setting a new source, remove and re-add the activeView only when
  it has changed.
- Dispose an unneeded view immediately instead of starting a timer.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-21 11:28:18 +01:00
Konstantina Chremmou
456cd93db8 A VncView is created for both VNC and RDP, so I don't see why it should be disposed of for VNC only.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-21 11:28:18 +01:00
Konstantina Chremmou
0c1541985c Check for docking should happen outside the VncView's Pause() method.
Also, use Pascal case for property name to match C# conventions.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-21 11:28:18 +01:00
Konstantina Chremmou
3601ada1f6 Reduced the public interface of the console panel.
Methods exposing internal functionality like the timers should not be public.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-21 11:28:17 +01:00
Konstantina Chremmou
63c170310d Use Pascal case for method names to match C# conventions.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-21 11:28:17 +01:00
Danilo Del Busso
f908abe28d CP-36392: Refactor useless for loop into if statement in ConsolePanel.cs
For loop is acting as if block

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-10-01 11:56:36 +01:00
Konstantina Chremmou
6e5cb325f3 CP-35899, CP-36202: Show the driver domain console tab on the corresponding SR.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-03-02 11:57:50 +00:00
Konstantina Chremmou
5244c91658 Help refactoring.
- Removed DebugHelp. The user settings are normally not meant for debugging code.
- Moved HelpId logic from the main window to the tab pages.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-25 15:02:05 +01:00
Konstantina Chremmou
2c884ea47f CA-311146: Copy the results of a linq query to a list to prevent
enumeration on modified collection (it also improves efficiency).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-02-26 11:18:53 +00:00
Mihaela Stoica
61ee71dac1 CA-290536: Fix XenCenter uncaught exception in VM console when losing host connection
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-08-06 15:14:24 +01:00
Konstantina Chremmou
ae22560ce8 Converted all extension get properties of the API classes to methods in order to
prevent them from being serialised alongside the API properties. This will also
be useful for moving the API bindings out of XenModel.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-03 03:35:30 +01:00
Letsibogo Ramadi
27918a1c02 CP-20881 - Implement RDP console resize when toggling the full screen mode
In addition to ticket requirements, the console size is updated when the console is:
- resized in undocked mode
- resized manually by dragging window edges
- resized by dragging the panel splitter

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-03-01 17:48:42 +00:00
Gabor Apati-Nagy
7c0bc50b4a CA-176169: Changed copyright statements to include the comma in Citrix Systems,
Inc.

Signed-off-by: Gabor Apati-Nagy<gabor.apati-nagy@citrix.com>
2017-01-16 19:59:50 +00:00
Konstantina Chremmou
094e4c4c4f CP-18028: For hosts with more than one control domain (dom0 and cvm at the moment) add an extra tab to display the console of the cvm. 2016-07-05 08:14:13 +01:00
Konstantina Chremmou
8991a257d2 Removed some unnecessary methods; changed visibility for controls that don't need to be public. 2016-07-04 23:05:51 +01:00
Konstantina Chremmou
04ffdbadc5 CP-17756: Do not use the field VM.is_control_domain to find the console for the
host as it applies to other control domains too. Use the new Host.control_domain
field instead. Minor refactoring.
2016-07-04 13:22:08 +01:00
Konstantina Chremmou
94df31b878 Removed call of virtual member in the constructors. 2016-07-04 08:22:35 +01:00
Konstantina Chremmou
f1b7aadc88 Fixed issue where the error message was not displayed if connection to the host console was not possible.
Refactored to hide/show error controls instead of adding/removing them. Removed duplicate null check.
Do not use a second list to track active VM consoles.
2016-07-03 17:45:49 +01:00
Konstantina Chremmou
8a8bdc21e6 Tidied up the ConsolePanel; moved designer code to the corresponding file and removed setting of virtual field from the constructor. 2016-07-01 17:47:41 +01:00
Stephen Turner
b587ab832e CP-14647: Intermediate check-in #1 2015-11-08 11:27:56 +00:00
Gabor Apati-Nagy
aefed11165 Revert "CA-149867: Invoke on MainWindow instead of various controls"
This reverts commit 92f0499911.
2015-04-16 14:17:02 +01:00
Gabor Apati-Nagy
92f0499911 CA-149867: Invoke on MainWindow instead of various controls
We observed that some threads can reach deadlock-ish state after they have Invoked into a control's UI thread. When it happens they are all in a waiting for join or in sleep state for very long time, although there should not be any deadlock situations.
It seems this has something to do with multiple parent controls and with which control we invoked on. This should not make a difference, because we have got one UI thread (for MainWindow) they should wait for, but we have seen it does.

The solution that fixed this issue was to invoke on the MainWindow instead of various controls (see a4fe507adf ).

This changeset is changing all our Invokes to invoke into MainWindow
instead of a control itself. (MainWindow's UI thread is the only UI thread
all Control is using in XenCenter)
This changeset should be in place until we have found the root cause or the exact reason for the above.
2015-04-08 15:16:10 +01:00
Konstantina Chremmou
e9b6c0699b CP-6137: Work in Console tab for vGPU (PR-1675)
# HG changeset patch
# User Mihaela Stoica <Mihaela.Stoica@citrix.com>
# Date 1384254998 0
#      Tue Nov 12 11:16:38 2013 +0000
# Node ID 6b3fc3d7a54e58e92ecfe714d19c8dc26b7a0565
# Parent  2cc90cb50e7ff2566f9d0833ad17735922d3f0c9

- Only close the inactive VNC consoles (not RDP) after an interval

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-11-14 12:33:02 +00:00
Konstantina Chremmou
3ad946f20e CP-6137: Work in Console tab for vGPU (PR-1675)
# HG changeset patch
# User Mihaela Stoica <Mihaela.Stoica@citrix.com>
# Date 1384179685 0
#      Mon Nov 11 14:21:25 2013 +0000
# Node ID 37666849a54470e0da04b8d14c17940f8b580636
# Parent  c845562d67f5216b2e3d52d68dcc54d78ff49ce1

- Add timers for closing the inactive VNC connections after an interval

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-11-14 12:24:57 +00:00
Mihaela Stoica
bd36a85bff CP-4816: Initial commit to git repo
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2013-06-24 12:41:48 +01:00