Also, remove obsolete lines that delete touch files (they are not created any more).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Handle validation for OVF files with a name different from the containing
OVA package. Other corrections to wrong validation logic.
- Show validation warnings on a dialog that can be turned off.
- Clean up extracted files after an OVA package has been imported.
- Plus code refactoring and simplification.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Do not leave out bytes if the number read is odd, which can happen if the file is smaller than the buffer used.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Corrected the scope of two OvfApi settings as a result of the test run.
Also, sync-ed settings and app.config for XenOvfApi and XenOvfapiTransport.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* CP-27819: Manually setting the ToolsVersion to 15.0 (VS2017) in all .csproj files for consistency and to attempt to enforce consistency of dev environments with the explicitness of the msbuild scripts as used in the build environments.
Auto updated as many of the .sln and .csproj files as VS2017 was willing to do https://docs.microsoft.com/en-us/visualstudio/ide/reference/upgrade-devenv-exe?view=vs-2017 and included changes to the gitignore to ensure that the update report and backup files are not included in the repo.
* CP-27819: Tidying up by removing FileUpgradeFlags, OldToolsVersion and UpgradeBackupLocation nodes from the .csproj files as they are produced as hints for how to revert project upgrades for which we can use version control.
* CP-27819: Removing redundant "ManifestCertificateThumbprint" and "ManifestTimestampUrl" nodes from project files "mk\sign.bat" has been used for this purpose for some time now.
* CP-27819: Updated readme to reflect that VS2017 is now in use.
Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
1. Add count check
2. Refine the code by linq (both export & import)
3. Create new desc rather than using the generic one
4. Add backward compatibility when importing
Signed-off-by: Tim Liu <tim.liu@citrix.com>
* CP-26884: add network-sriov info in OVF file when exporting vm
Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
* CP-27199: Block VF assignment to VM according to recommendations
Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
* fix some comments
* revert the Messages.resx
and only update the necessary fields from the OVF values; this is preferrable
to using the constructor from the Hashtable because the latter requires
unnecessary conversions to and from strings, and also fields missing from the
Hashtable are reset to null. Hardcoded strings are also error prone: the VBD
class does not have any field such as 'attachable' or 'vm_name_label' and the
fields 'storage-lock' and 'status-code' are in reality called 'storage_lock'
and 'status_code'.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
instead of using the constructor from the Hashtable because this requires
unnecessary conversions to and from strings, and also fields missing from the
Hashtable are reset to null. Hardcoded strings are also error prone: the VBD
class does not have fields such as 'attachable' or 'vm_name_label'.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
instead of using the constructor from the Hashtable because this requires
unnecessary conversions to and from strings, and also fields missing from the
Hashtable are reset to null. Hardcoded strings are also error prone: the VDI
class has the field 'sharable', not 'shareable'.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
instead of using the constructor from the Hashtable because this requires
unnecessary conversions to and from strings and also fields missing from the
Hashtable are reset to null.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
it's obvious what it is. The Session's uuid will be deprecated from the API bindings.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
prevent them from being serialised alongside the API properties. This will also
be useful for moving the API bindings out of XenModel.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
