Commit Graph

65 Commits

Author SHA1 Message Date
Konstantina Chremmou
7352ae1d38 Fixed broken help button on the ThreeButtonDialog.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-06 11:27:32 +01:00
Konstantina Chremmou
8a6a579402 CP-20425: Use static images everywhere an image is assigned programmatically.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-18 07:49:27 +01:00
Konstantina Chremmou
e42bc54be4 CA-187276: Re-enable "Open SSH Console" button after VM restart
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-07 09:25:54 +01:00
Konstantina Chremmou
60da6080f9
Refactored three button dialog (#2627)
* ThreeButtonDialog simplification step1: Help name.
* ThreeButtonDialog simplification step2: Window title.
* ThreeButtonDialog simplification step3: Removed class Details.
* ThreeButtonDialog simplification step4: Removed unnecessary (and wrong) class.
* ThreeButtonDialog simplification step5: Compacted TDButton constructors.
* ThreeButtonDialog simplification step6: Removed purposeless methods.
* ThreeButtonDialog simplification step7: Refactored constructor logic.
* ThreeButtonDialog simplification step8: Icon normalisation.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-22 14:47:03 +01:00
Konstantina Chremmou
fc1cbf636e Simplified signature of connection events.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-12-06 11:17:46 +00:00
Konstantina Chremmou
0ed05e4c6c Removed option to enable RDP polling as it only applies to pre-6.5 hosts which are not longer supported.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-02-06 09:25:38 +00:00
Konstantina Chremmou
eef3320eca Removed code applicable to servers earlier than dundee since connection to them is now blocked.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-02-06 09:25:38 +00:00
Gabor Apati-Nagy
9b6806de1b CP-26048: Improve the fix for CA-271775 (console tab)
Reserved space for the warning message that is displayed if the XC machine is running an older version of the RDP control

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-12-13 10:48:23 +00:00
Gabor Apati-Nagy
5b2ef0e7eb CA-271775: Showing an info message if XC falls back to an earlier RDP version
Eg. Windows 7 users (pre-updates)

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-11-13 16:51:56 +00:00
Konstantina Chremmou
ae22560ce8 Converted all extension get properties of the API classes to methods in order to
prevent them from being serialised alongside the API properties. This will also
be useful for moving the API bindings out of XenModel.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-03 03:35:30 +01:00
Mihaela Stoica
42df02734a CA-249856: Fix console position and focus rectangle drawing on resize
Also ensuring that if the UpdateSessionDisplaySettings function (which we use for resize) is not supported, then we display the console centered in the parent window and with scrollbars if needed

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-04-25 14:07:29 +01:00
Letsibogo Ramadi
29a683afc3 CA-245546 - Only the active RDP console is resized when the main XenCenter window is resized 2017-03-03 17:29:19 +00:00
Letsibogo Ramadi
27918a1c02 CP-20881 - Implement RDP console resize when toggling the full screen mode
In addition to ticket requirements, the console size is updated when the console is:
- resized in undocked mode
- resized manually by dragging window edges
- resized by dragging the panel splitter

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-03-01 17:48:42 +00:00
Gabor Apati-Nagy
7c0bc50b4a CA-176169: Changed copyright statements to include the comma in Citrix Systems,
Inc.

Signed-off-by: Gabor Apati-Nagy<gabor.apati-nagy@citrix.com>
2017-01-16 19:59:50 +00:00
Konstantina Chremmou
565f95291d CA-100083 (part of): Set minimum width of the main window's tab control to 40% to
avoid buttons on the console tab overlapping. Removed some panels from the console
tab to reduce control nesting.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-17 01:23:55 +01:00
Konstantina Chremmou
4cdb24dd29 CA-215575: Corrected regression as requested per code review: the full screen
console should appear on the same monitor as the main form.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-06 10:32:49 +01:00
Konstantina Chremmou
9b7f90ccb4 CA-215575 plus refactoring: The connection bar does not need to manipulate anything
other than strings. Moved settings of the FullScreenForm from the VNCTabView to
the former class. The FullScreenFormof the VNCTabView is only initialised as
FullSCreenFrom so no casts are necessary. The FullScreenForm is responsible for
updating the connection bar text with the value obtained from the vncScreen everytime
the name of the connection changes. Also reduced visibility of certain members.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-24 13:51:50 +01:00
Konstantina Chremmou
a9a1cd6b9c Tidied up: the vncScreen should notify the parent vncTab when the rdp warning needs
to be shown. It is complicated to have the one control call a method in the other
which checks the state on the first control.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-24 11:48:42 +01:00
Konstantina Chremmou
38ca217bc3 Tidied up: moved the full screen message from the VNCTabView class to the more relevant
FullScreenHint class.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-24 01:38:51 +01:00
Konstantina Chremmou
ea60eaa24e Merge pull request #1065 from xenserver/CAR-2217
Request to merge CAR-2217 into master
2016-07-11 14:11:00 +01:00
Konstantina Chremmou
f63ca812f3 When the host name changes, the teal label of the docked CVM console should change too.
Also, fixed bug where the title of the server's undocked console was truncated to
the server's name when the latter changed.
2016-07-08 13:15:15 +01:00
Konstantina Chremmou
7528cefce4 Do not show the CVM's own name on its console, but rather a description including the host's name. 2016-07-08 09:19:39 +01:00
Konstantina Chremmou
336681fc6a Fixed regression introduced in previous commit. Also, the MultipleDvdIsoList on the
VMstorage page uses the default colours of the controls, hence we only need to set
them on the VNCTabView and the linklabel does not need to be public.
2016-07-06 08:55:28 +01:00
Konstantina Chremmou
8991a257d2 Removed some unnecessary methods; changed visibility for controls that don't need to be public. 2016-07-04 23:05:51 +01:00
Konstantina Chremmou
04ffdbadc5 CP-17756: Do not use the field VM.is_control_domain to find the console for the
host as it applies to other control domains too. Use the new Host.control_domain
field instead. Minor refactoring.
2016-07-04 13:22:08 +01:00
Konstantina Chremmou
94df31b878 Removed call of virtual member in the constructors. 2016-07-04 08:22:35 +01:00
Mihaela Stoica
3f25c5868f CP-17161: Add 'using' statement around dialogs to ensure garbage collection
- fix all ThreeButtonDialog usages (and some other dialogs that I've came across)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-20 10:49:12 +01:00
Hui Zhang
784804c8d8 CP-13124: Invoke Putty, SSH to VM and run docker command.
1. Run 'docker attach' if user clicks 'View Console' button.
2. Run 'docker logs' if user clicks 'View Log' button.
3. Make IPAddressForSSH a property of VM for common usage.

Signed-off-by: Hui Zhang <hui.zhang@citrix.com>
2016-02-14 15:14:44 +08:00
Mihaela Stoica
3c956f28ac CP-14780: Revert Windows Update changes (part2)
Revert "Merge pull request #708 from GaborApatiNagy/master_windows_update"

This reverts commit fe03f1382f, reversing
changes made to 423065a2c8.

Conflicts:
	XenAdminTests/TabsAndMenus/MainMenuGeorge.cs
2015-11-10 13:13:23 +00:00
Gabor Apati-Nagy
7b7bcb0aa5 CP-14379, CP-14461, CP-14462, CP-14463, CP-14464, CP-14465, CP-14467:
Implementing Upgrading VMs to Windows Update

New screen features:
-Create skeleton of the Upgrade VM dialog
-Implement a Go To Console link (just a link that opens a vm console)
-Implement logic to show the right status for a VM (includes rules to
get the states). Includes updating the dialog whenever the status changes.
-Add status texts to Messages, proper text on the UI
-Add stub methods to VM class in XenAPI-Extensions to r/w states from
Guest Agent
-UI: Implement rules what vms to display, checkbox rules, read only vms,
and when to enable the Upgrade button
-Implement Upgrade button (writes state for GA, mounts ISO) + maximum
parallel executions/actions

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2015-10-16 12:47:00 +01:00
Carmen Agimof
4d625de0a2 CA-181342: Now the user can mount or eject ISO images from Console. 2015-09-08 15:47:44 +01:00
Gabor Apati-Nagy
165b1e96de CA-172444: Consistency should be followed for behavior of all buttons in same page
Making the "Open SSH Console" button visible but disabled instead of hiding it in the following cases:
-VM is suspended
-VM is running, but we do not know any IP address (eg no Tools installed on it)

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2015-06-10 16:03:57 +01:00
Mihaela Stoica
d2dedaec40 Merge pull request #458 from cheng--zhang/CA-169170
CA-169167: Screen resolution is less than the default value after switch to remote desktop
2015-06-04 13:19:57 +03:00
Gabor Apati-Nagy
fd7407c127 CA-153347: Send Ctrl-Alt-Del is available for non-running VMs (title edited)
Reverted previous fix 7608caafd7, because
managed to find the root cause of this issue: commit ce3bec1231.
Instead of reverting the latter completely, this commit fixes the regression by removing unnecessary calling of UpdateButtons().

Note: The button will still be enabled for dom0 console.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2015-06-02 15:10:24 +01:00
Gabor Apati-Nagy
87c3811b45 Revert "CA-153347: Send Ctrl-Alt-Del is available for dom0 console and for non-running VMs"
This reverts commit 7608caafd7.
2015-06-01 15:33:17 +01:00
Cheng Zhang
239486c598 CA-169167: Screen resolution is less than the default value after switch to remote desktop
Auto switch to RDP should be taken after VNC connection got the correct screen resolution.
Also not enable “enable RDP button” before VNC connection get the correct screen resolution.

Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2015-05-20 15:31:02 +08:00
Mihaela Stoica
3bae352e33 Merge pull request #465 from GaborApatiNagy/CA-153347
CA-153347: Send Ctrl-Alt-Del is available for dom0 console and for non-running VMs
2015-05-15 16:12:23 +01:00
Mihaela Stoica
e470cf01f5 Merge pull request #459 from GaborApatiNagy/master_CP-11957
CP-11957: ssh console: Add UI elements to launch ssh
2015-05-15 16:11:54 +01:00
Gabor Apati-Nagy
de6f92f39f CP-11957: ssh console: Add UI elements to launch ssh
-changed exception logging format
2015-05-15 15:52:57 +01:00
Gabor Apati-Nagy
7608caafd7 CA-153347: Send Ctrl-Alt-Del is available for dom0 console and for non-running VMs 2015-05-15 14:18:01 +01:00
Gabor Apati-Nagy
4ea97fb162 Merge pull request #450 from MihaelaStoica/CA-68578
CA-68578: Shutting down a Linux guest with VNC console causes password d...
2015-05-14 10:45:51 +01:00
Gabor Apati-Nagy
1463279c00 CP-11957: ssh console: Add UI elements to launch ssh
Added logging for ERROR_PUTTY_LAUNCHINGERROR_PUTTY_LAUNCHING
2015-05-08 13:56:22 +01:00
Gabor Apati-Nagy
90a16d005e CP-11957: ssh console: Add UI elements to launch ssh
Fixes following the code review
2015-05-08 13:50:14 +01:00
Gabor Apati-Nagy
e53be2d67b CP-11957: ssh console: Add UI elements to launch ssh
If there is at least one IPv4 address, we use that even if it is not the first we have seen (by looking at the VIFs)
2015-05-07 12:11:17 +01:00
Gabor Apati-Nagy
af38c2fdf0 CP-11957: ssh console: Add UI elements to launch ssh 2015-05-07 11:42:31 +01:00
Cheng Zhang
1862120117 CA-169170: “Switch to Remote desktop” button should not be disabled in Cream when Windows VM installed with latest PV tools.
Check current XenServer Version, if current version is greater than Cream and PV tool installed, do not disable control button.

Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2015-05-06 10:53:23 +08:00
Mihaela Stoica
7ff4bb9138 CA-68578: Shutting down a Linux guest with VNC console causes password dialog to pop up
- store the empty vnc password after a successful login, to avoid displaying the login dialog box on a subsequent reconnection attempt
- abort the vnc connection attempt if we notice that vncIP is null and switch back to the default console

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-04-30 11:37:39 +01:00
Gabor Apati-Nagy
aefed11165 Revert "CA-149867: Invoke on MainWindow instead of various controls"
This reverts commit 92f0499911.
2015-04-16 14:17:02 +01:00
Gabor Apati-Nagy
92f0499911 CA-149867: Invoke on MainWindow instead of various controls
We observed that some threads can reach deadlock-ish state after they have Invoked into a control's UI thread. When it happens they are all in a waiting for join or in sleep state for very long time, although there should not be any deadlock situations.
It seems this has something to do with multiple parent controls and with which control we invoked on. This should not make a difference, because we have got one UI thread (for MainWindow) they should wait for, but we have seen it does.

The solution that fixed this issue was to invoke on the MainWindow instead of various controls (see a4fe507adf ).

This changeset is changing all our Invokes to invoke into MainWindow
instead of a control itself. (MainWindow's UI thread is the only UI thread
all Control is using in XenCenter)
This changeset should be in place until we have found the root cause or the exact reason for the above.
2015-04-08 15:16:10 +01:00
Cheng Zhang
0adbf80b1c CA-165464: Switch to RDP connection on VM with RDP enable if automatically switch selected
This code change is to set “switchOnTabOpened” in below condition:
1.	XenCenter have “Automatically switch to the Remote Desktop console when it becomes available" selected
2.	VM have RDP enabled.
3.	XenServer Version is Cream or greater.

Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2015-03-24 13:40:28 +08:00