Commit Graph

6507 Commits

Author SHA1 Message Date
CitrixChris
f0f0de0076
CA-364330 wraps cyptoexception in try catch to show appropriate message (#2968)
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
2022-03-10 14:16:13 +00:00
Konstantina Chremmou
00c5285411 CP-39142: Add RPU pre-check in CHCenter to warn of DMC removal.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-03 14:36:06 +00:00
Konstantina Chremmou
dec2eead15 Renamed methods so they describe better what they do.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-03 14:36:06 +00:00
Konstantina Chremmou
b2dc968ab1 CP-38895: Check version annotations when using API fields or methods.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-03 14:35:45 +00:00
Darren Matthews
151841ce5e L10N : Translation Updates & Resx sync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2022-03-03 14:35:30 +00:00
Danilo Del Busso
101d6f0a00 CP-36392: Use value in empty setters
Mostly to remove warning from SonarQube, so exception is only thrown in DEBUG mode

Address code surrounding previously emptied setters
Avoids throwing exceptions when not needed
Move default `VerticalTabs` fields outside of constructor

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-02-24 11:53:44 +00:00
Danilo Del Busso
2c5373323c CP-36392: Inherit IDisposable to avoid confusion
Classes didn't extend IDisposable
Also used null propagation to tidy up method body

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-02-24 11:53:44 +00:00
Danilo Del Busso
a310fa60cf CP-36392: Remove all unnecessary using s
Ignores XenAPI

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-02-24 11:53:44 +00:00
Darren Matthews
c7c60849b3 L10N : Resx Sync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2022-02-24 11:53:31 +00:00
Konstantina Chremmou
d0944cf19c A new row should be added only when it is not found.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-23 12:38:02 +00:00
Konstantina Chremmou
a342adc859 CA-364152: Do not calculate completed percentage if there are no actions to run.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-23 12:38:02 +00:00
Konstantina Chremmou
ff76729940 Hide the client update button by default. Added null check.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-21 15:56:06 +00:00
Danilo Del Busso
a578b6924c CA-361078: Parse OVFs without a Limit element in the vCPUs section
VMWare OVFs don't export the value

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-02-18 10:28:38 +00:00
CitrixChris
59e45f40c6
Update alert test fixes (#2953)
* CP-31587 made checksum comparison case insensitive as well as culture insensative

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* Fixes not null assertion

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>

* Merges internal classes to be in same file

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>
2022-02-18 10:24:33 +00:00
Konstantina Chremmou
8493ee5e90 CA-363819: Fixed issue where VM network usage data were not shown on the Search TabPage.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-17 13:17:57 +00:00
Konstantina Chremmou
29189873a3 CA-363610: OVF import: fixed upload of OS fixup ISO.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-17 13:17:57 +00:00
Konstantina Chremmou
493ed4cabe CP-38526/XSI-1055: Improved import performance for OVF/OVA packages with .vhd disks.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-17 13:17:57 +00:00
Konstantina Chremmou
df6f1ba65b CP-38832: Bumped branding library version to v4.2.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-17 13:17:49 +00:00
Konstantina Chremmou
99452959c3 Further tweaks as per code review.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-17 12:52:30 +00:00
Konstantina Chremmou
b050adaeaa Some corrections and tidy up.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-17 12:52:30 +00:00
Christophe25
0d9a204661 CP-31587 moves validate msi exception messages to messages.resx. Sets update client button to hidden on launch.
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
2022-02-17 12:52:30 +00:00
Christophe25
5845bab13f CP-31587 Implements reviewer's comments.
Moves dialog strings to messages.resx. Corrects button colours, hides update client option to avoid highlighting when disabled. Revmoves unessessary comments.

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
2022-02-17 12:52:30 +00:00
Christophe25
d8b1d5737d CP-31587 added comfirmation dialog to manageupdates page
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
2022-02-17 12:52:30 +00:00
Christophe25
755411a970 CP-31587 implements confirmation check before updating client
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
2022-02-17 12:52:30 +00:00
Christophe25
75f9b402ec CP-31587 added a checksum check to download and install client action
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
2022-02-17 12:52:30 +00:00
Christophe25
c1c8c3d1c3 Adds updates check started/completed event handlers
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
2022-02-17 12:52:30 +00:00
Christophe25
0a0533a59f CP-31587 improved DownloadAnUpdateClientAction
Made variables more accurate, removed unnessessary code

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
2022-02-17 12:52:30 +00:00
Christophe25
aa59e8f475 CP-31587 Created new download and install action that downloads the file from updates.xml url and stores in in temp folder with progress dialog
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
2022-02-17 12:52:30 +00:00
Konstantina Chremmou
edfcf036d2 CP-38832: Try again bumping xencenter-pipeline to v4.3.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-14 14:35:59 +00:00
Konstantina Chremmou
7771471522 Use Write-Host when we just want to log output on the console.
Write-Output passes data further down the pipeline.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-14 14:35:59 +00:00
Konstantina Chremmou
ca37331c8d CA-362709, CA-362711: Reworked the logic for allowing full disk copy when creating a VM from a snapshot or custom template.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-14 14:35:51 +00:00
Konstantina Chremmou
9af52bdcbf CP-39053: Bumped branding library version to v4.1.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-09 11:25:50 +00:00
Konstantina Chremmou
321389455e Refactoring: compacted Role.ValidRoleList() and Role.CanPerform() overloads.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-03 11:59:17 +00:00
Konstantina Chremmou
6aec4ea281 CP-38893: Make internal roles unavailable for selection.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-03 11:59:17 +00:00
Konstantina Chremmou
50dd22f4da CA-362868: POOL_CA_CERTIFICATE_* alerts are issued on the certificate and not on the pool.
Also, moved the function retrieving the XenObject from the alert to the Message class extensions.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-01-31 14:56:12 +00:00
Konstantina Chremmou
d6f91526d2 Restored friendly name and description for CVSM.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-01-31 14:56:12 +00:00
Konstantina Chremmou
c506c5e47c Reverted pipeline library to v4.2.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-01-28 14:19:34 +00:00
Konstantina Chremmou
713a61cead Updated C# SDK (xapi 22.5.0-1.xs8).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-01-28 14:19:34 +00:00
Konstantina Chremmou
1580a89594
Merge pull request #2931 from kc284/settings
Minor refactoring; null check; tidy up
2022-01-27 13:34:20 +00:00
Konstantina Chremmou
bae03aff8b Fixed issue where the settings from previous installations were not imported. Added more documentation.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-01-24 19:55:38 +00:00
Danilo Del Busso
2bc25d72d5 CP-38814: Add friendly names to new xapi alerts
vm_migrated
vm_snapshotted
vm_snapshot_reverted
vm_checkpointed
vm_paused
vm_unpaused

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-01-24 15:46:37 +00:00
Danilo Del Busso
d7f1853562 Bump C# SDK to modified version of xapi 21.3.0/1.xs8
SDK update does not contain the removal of `evacuate` overloads

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-01-24 15:46:37 +00:00
Danilo Del Busso
7f38f71a6e CP-38832: Bump xencenter-pipeline to v4.3
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-01-24 15:23:40 +00:00
Konstantina Chremmou
8f9afafb7a Use Tick() when setting both the PercentComplete and the Description to avoid firing OnChanged() twice.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-01-24 15:23:02 +00:00
Konstantina Chremmou
1225e98225 Improved logging and reporting percentage when importing an XVA.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-01-24 15:23:02 +00:00
Konstantina Chremmou
b4afd3ce4c CA-261979: Use utf-8 encoding for logging (or on localised systems the log files may contain illegible characters).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-01-24 15:22:28 +00:00
Danilo Del Busso
f07b3d4e05 CP-37850: Update RPU005 to version 4.0
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-01-24 15:22:07 +00:00
Konstantina Chremmou
ba8cf7f782
Merge pull request #2934 from xenserver/feature/CP-38483
CP-38483: Unbundle putty from  Citrix Hypervisor Center
2022-01-24 15:21:32 +00:00
Konstantina Chremmou
f29e267670 Some corrections and refactoring on the external console feature.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-01-17 14:09:34 +00:00
Danilo Del Busso
c9bb9c1f0c CA-362353: Add file existence check when launching SSH console
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-01-17 14:09:34 +00:00