All currently supported versions of the product support 255 VBDs,
see https://docs.citrix.com/en-us/xenserver/7-0/downloads/config-limits.pdf
When a VM is imported through XCM it may not have recommendations,
and XenCenter falls back to the default, which is 16.
Then adding another disk shows an error that the maximum number of disks was reached,
which contradicts our support statement of 255 disks.
Signed-off-by: Edwin Török <edvin.torok@citrix.com>
- Removed wrapper delegates; call the http_actions directly.
- In case of failure or cancellation of the http_action, poll the related task
ignoring any exceptions thrown, so that any clean up code within the http_action's exception handling can run.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
This simplifies the code since the TaskPoller cannot be perceived without an AsyncAction.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Stop rethrowing exceptions.
- Added some checks.
- Renamed method XenCenterUUID to GetXenCenterUUID to match the methods
SetXenCenterUUID and RemoveXenCenterUUID.
- Replaced check via static string list with a string switch block.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Also, try plugging PBDs only for the host in question (other hosts are not necessary,
as the PBDs are re-checked for any previously evacuated VMs before repatriation).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Regression introduced by the changes for CA-64500. Since we initiate a VMStartAction
we need to ensure that the VM object passed to the action has a non-null Connection.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Moved the code to the ExportApplianceAction so it's easier to modify the
action's description.
- Fixed issue where the user's option for adding signature/manifest to a plain
OVF package was ignored.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Destroying a VM does not disrupt the connection, hence the use of the BestEffort
method is not warranted. After this correction, BestEffort is only used in the
DestroyedBondAction, hence I removed it completely and replaced it with simpler
exception handling in the latter class's Run method.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Ensure we read the updates.xml location anew from the registry, otherwise the
application has to be relaunched to pick a registry change. Look in both hives
HKCU and HKLM. To avoid performance impact on the UI, move the operation into
the action's Run() body.
- Some refactoring to improve OOP design and fix XmlReader leak.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Consolidated Action.PollToCompletion overloads, among others, to reduce precision loss.
- Logging the environment's stack trace is not very useful in the case of an API failure.
- Log the task's opaque_ref so it's easier to trace errors in the server side logs.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
The fix for CA-337280 moved the parsing of the probe result in the Run body of
the action, causing it to fail when the dry-run for the RBAC checks is performed.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* Hid properties from the designer and renamed them because they give the wrong impression.
* Fixed some inefficiencies around the NetworkComboboxItem.
- Move NetworkComboBoxItem into the NetworkComboBox class.
- Moved XenAdmin.Dialogs.NetworkComboBoxItem into the VIFDialog class and made it
private to avoid ambiguousness with the public XenAdmin.Controls.NetworkComboBox.NetworkComboboxItem.
- Create a NetworkComboBoxItem only if needed and assign its name at construction time.
- Add method to select a NetworkComboBoxItem and property to return the SelectedNetwork.
* CA-339233: Do not allow selection of networks while they're locked.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Improvements to progress reporting (CA-65894).
- Added some logging.
- Use the connection cache instead of making server calls.
- Moved some methods to the string utilities and added unit tests.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Previously this was not possible due to XenModel-XenOvfTransport cyclical references.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
