Commit Graph

628 Commits

Author SHA1 Message Date
Konstantina Chremmou
11ce488062 Merge branch 'master' into feature/hyperman
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	Jenkinsfile
#	scripts/xenadmin-build.sh
2021-02-17 14:51:13 +00:00
Konstantina Chremmou
307b97e1d6 Refactored the Command Enabled|Disabled Tooltip to avoid multiple calculation of whether the command can be executed.
Also, use CommandButtons instead of normal buttons on the SrStorage TabPage.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-02-10 23:44:21 +00:00
Konstantina Chremmou
e7e6fb3234 CP-35350 preliminary work: Removed images that are not displayed anywhere on the UI.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-12-02 12:34:09 +00:00
Konstantina Chremmou
61d77cada4 CA-343956: Corrected action performed by the Attach Disk context menu item. Show grip on the Attach Disk dialog.
The dialog is launched non-modally, hence showing the grip automatically has no effect.
Also, made the dialog slightly bigger.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-11-03 11:33:16 +00:00
Darren Matthews
a9016bc14e L10N : Translation Update and RESX resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2020-10-13 13:56:55 +01:00
Konstantina Chremmou
f3da384a6a Configuring HA on the TabPage should offer the same UX as when using the Menu Items.
- Use CommandButtons on the HA TabPage for configuring/disabling HA.
- Added menu item to disable HA.
- There is no point in hiding the buttons on the HA TabPage when the corresponding
  menu items are available. They should rather offer the same user experience.
- Added RBAC page to the HaWizard to avoid unnecessary SR scanning only to be told
  that one cannot proceed.
- Show RBAC error dialog if the user does not have permission to launch the
  EditVmPriorities dialog.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-06 11:27:32 +01:00
Konstantina Chremmou
aec6b395ff CA-343956: Fixed issues on the VM storage TabPage:
- Disabled button tooltips did not disappear when the DataGridView selection was cleared.
- The disabled Activate/Deactivate button had no tooltip for template disks.
- Minor improvement to the tooltip of the Delete button.
- The Add button was using the enablement logic of the AttachVirtualDiskCommand.
- Use CommandButtons to avoid logic duplication.
- Hide the CommandButton.Command from the designer as it's mostly assigned programmatically.
- Increased the minimum width of the non-autosizable columns so they remain visible.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-02 11:59:55 +01:00
Konstantina Chremmou
a01824b836 Fixed alignment of icons on the View dropdown on the Snapshots TabPage.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-02 11:59:55 +01:00
Konstantina Chremmou
2bb1cd5c5c CA-343781: Fixed error visibility when the check for updates fails. Corrected error image size.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-09-08 10:34:08 +01:00
Darren Matthews
c75ab40ef8 L10N : Translation Updates and Resx Resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2020-09-01 14:26:40 +01:00
Konstantina Chremmou
e3896239df CA-339305: XenCenter was hanging when update alerts were removed very fast, and other issues:
- Use a plain list to store update alerts and, where possible, fire a collection
  change event only after a bulk change and not every time a single object is added
  or removed.
- Fixed issue where dismissed updates were stored in the config of all connected
  pools, even of those where the update did not apply.
- Corrected RBAC checks for update dismissal.
- Fixed enabled state of dismiss buttons.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-08-21 16:08:20 +01:00
Konstantina Chremmou
2e66ec9133 Merge remote-tracking branch 'upstream/master' into feature/REQ-819
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Dialogs/OptionsPages/SecurityOptionsPage.cs
2020-08-11 13:35:39 +01:00
Konstantina Chremmou
e0864cd99c CA-342526: Ensure the update list has been populated and the specified update has been selected before stepping into the next page.
Also, reduced visibility of the methods moving between wizard pages to avoid
creating complex situations.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-31 10:54:49 +01:00
Konstantina Chremmou
a076cc59a2
Dialog deletion (#2701)
* Replaced LicenseWarningDialog with a simple WarningDialog.
* Replaced VcpuWarningDialog with a simple WarningDialog.
* Replaced RemoveCrashdumpsWarningDialog with a simple WarningDialog.
* Replaced UsbUsageDialog with a simple WarningDialog.
* Replaced WlbDeleteReportSubscriptionDialog with a simple WarningDialog. Added null checks to event invocation.
* Replaced DisableWlbDialog with a simple Warning dialog.
* Replaced ConnectionRefusedDialog with a simple Error dialog.
* Replaced UserDeviceDialog with a simple Warning dialog.
* Replaced RevertDialog with a simple Warning dialog.
* Removed unused dialogs.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-30 11:29:01 +01:00
Konstantina Chremmou
8fb44a55cb Added flag VM.VirtualisationStatus.NOT_INSTALLED to replace value 0 for clarity.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-30 10:42:20 +01:00
Konstantina Chremmou
5f7d3e1518 Homogeneous icon usage across the application.
- Replaced remaining instances of SystemIcons. SystemIcons.Information of size
  32x32 were excepted as we don't have the right size icon yet.
- The question mark icon is used for help, not for asking questions.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-18 07:49:27 +01:00
Konstantina Chremmou
8a6a579402 CP-20425: Use static images everywhere an image is assigned programmatically.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-18 07:49:27 +01:00
Konstantina Chremmou
ea4175e75c CP-20425: Use the SpinnerIcon instead of a new spinner implementation which does not use the static images.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-18 07:49:27 +01:00
Konstantina Chremmou
e27a0a7333 Minor refactoring on UpsellPage:
- Modernised properties.
- Removed unnecessary public method; it was rather obfuscating setting properties.
- Made Image property non-browsable.
- Missing null check.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-18 07:49:27 +01:00
Konstantina Chremmou
9d7cf72c78 CP-33781: Added admin exit procedure warnings.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-17 16:04:10 +01:00
Konstantina Chremmou
ebe0257af1 CA-339648: Refresh user row when the other_config changes so as to show up to date account details.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-06-05 16:58:19 +01:00
Darren Matthews
1d74094e5a L10N : Translation and Resx Resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2020-05-18 15:15:07 +01:00
Konstantina Chremmou
d1c9e7ddd1 CA-337323: Attempt finding the right owning form for the RoleElevation dialog. Also:
- Simplified SudoElevationResult.
- Renamed SudoDialogDelegate to ElevatedSessionDelegate so that it makes more sense
  for projects not referencing WinForms.
- Call directly the RoleElevationDialog within XenAdmin without using the ElevatedSessionDelegate.
- Minor modernisation in AsyncAction.
- Launch GraphDetailsDialog in a using block.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-04 14:30:24 +01:00
Konstantina Chremmou
bf5c66598c Merge remote-tracking branch 'upstream/master' into feature/REQ-716
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/MainWindow.cs
2020-04-29 16:47:48 +01:00
Konstantina Chremmou
17b6c28978 Merged master into feature/REQ-453 and resolved conflicts.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdminTests/UnitTests/TimeUtilTests.cs
#	XenCenterLib/TimeUtil.cs
2020-04-26 04:11:14 +01:00
Konstantina Chremmou
563b2cc359 CA-338276: Corrected virtualisation state link text for post stockholm linux guests.
Also, merged the methods calculating the virtualisation status and its friendly
string so as to simplify the logic.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-26 00:03:45 +01:00
Konstantina Chremmou
9bf7e80fe9 Merged branch master into feature/REQ-716 and resolved conflicts.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Dialogs/BallooningDialog.cs
#	XenAdmin/Dialogs/WarningDialogs/InstallToolsWarningDialog.cs
2020-04-24 15:37:01 +01:00
Konstantina Chremmou
60da6080f9
Refactored three button dialog (#2627)
* ThreeButtonDialog simplification step1: Help name.
* ThreeButtonDialog simplification step2: Window title.
* ThreeButtonDialog simplification step3: Removed class Details.
* ThreeButtonDialog simplification step4: Removed unnecessary (and wrong) class.
* ThreeButtonDialog simplification step5: Compacted TDButton constructors.
* ThreeButtonDialog simplification step6: Removed purposeless methods.
* ThreeButtonDialog simplification step7: Refactored constructor logic.
* ThreeButtonDialog simplification step8: Icon normalisation.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-22 14:47:03 +01:00
Konstantina Chremmou
dfb49c97a1 CP-32687, CP-32689: Remove "Install PV Tools" options from stockholm onwards.
Replace with help links where necessary or convenient. Also:
- Registered unused event.
- Minor refactoring to: make the InstallToolsCommand.CanExecute clearer; use
  local methods.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-17 16:23:06 +01:00
Konstantina Chremmou
fc944784b4 CP-32697: Show certificate metadata on the host's General TabPage.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-01 16:27:13 +01:00
Konstantina Chremmou
3ecd6a4d8b Fixed missing ExpandedChanged event registrations. Tidied up methods toggling the section expanded state.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-01 16:27:13 +01:00
Konstantina Chremmou
862971621b CA-333059: Fixed issue where the updates list was not refreshed for pool slaves after applying an update.
Also, fixed some performance issues; minor refactoring.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-03-11 22:22:17 +00:00
Konstantina Chremmou
44dd03e85f Fixed issue where it was possible to have both View ToolStripMenuItems in unchecked state.
Also, UX enhancement: added tooltips showing the update alert page URL.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-03-11 22:22:17 +00:00
Konstantina Chremmou
1b35a6898f Spelling corrections, mostly for consistency with the docs.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-02-14 14:43:22 +00:00
Konstantina Chremmou
3869d9654d New bindings (includes CP-29452, CA-75634, CA-280976).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-02-14 14:43:22 +00:00
Konstantina Chremmou
1bcec343f1 Merge remote-tracking branch 'upstream/feature/REQ-803' 2020-02-13 11:43:17 +00:00
Konstantina Chremmou
f7391e991b
CA-156873, CP-31105 (partial): Apply common branding and versioning to assemblies; branding refactoring
Added brand management files and refactored the following brand variables:
* BRANDING_XENSERVER_UPDATE_URL
* BRANDING_PERF_ALERT_MAIL_LANGUAGE_DEFAULT
* BRANDING_SEARCH
* BRANDING_UPDATE
* BRANDING_BACKUP
* BRANDING_LEGACY_PRODUCT_BRAND
* ISO
* BRANDING_VERSION_5_6
* BRANDING_VERSION_6_2
* BRANDING_VERSION_6_0
* BRANDING_VERSION_6_5
* BRANDING_VERSION_7_0
* BRANDING_VERSION_7_1_2
* BRANDING_VERSION_8_0
* BRANDING_VERSION_8_1
* BRANDIND_COPYRIGHT
* BRANDING_COPYRIGHT_2

Also: Try passing the timestamp server as parameter
2020-01-22 14:47:39 +00:00
Konstantina Chremmou
f459ef5956 CA-331420: Do not refresh the license status on the general tab if the selected object is not a pool/host.
- Removed AsyncServerTime class as it adds complexity and the risk of
  getting an outdated time.
- Simplified event signatures and compacted nested method calls.
- Fixed typo and removed unused code.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-12-09 14:39:09 +00:00
Konstantina Chremmou
667e9e8caf Log the stack trace when an exception is encountered and don't use the *Format() counterpart of the logging method for it.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:44 +00:00
Konstantina Chremmou
fb2edf99b8 Do not initialise a logger if a class does not use it.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:44 +00:00
Konstantina Chremmou
0eb2f09fa2 Ensure we update the controls on the UI thread.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:19 +00:00
Mihaela Stoica
32981d24f1 CP-32254: Add DMC deprecation banner
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-10-18 10:04:51 +01:00
Mihaela Stoica
8b41a214b2
Merge pull request #2521 from xenserver/feature/REQ-756
Merge feature/REQ-756 into master
2019-09-27 13:18:21 +01:00
Darren Matthews
4a3fd35b51 L10N: Translation and Resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-09-25 15:17:19 +01:00
Konstantina Chremmou
5244c91658 Help refactoring.
- Removed DebugHelp. The user settings are normally not meant for debugging code.
- Moved HelpId logic from the main window to the tab pages.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-25 15:02:05 +01:00
Mihaela Stoica
4832c7f5e6 CP-32139: Add text regarding the supportability for versions that have reached EOL
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-09-16 10:46:06 +01:00
Konstantina Chremmou
ca72f25ebe Merge remote-tracking branch 'upstream/master' into feature/REQ-756
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/MainWindow.Designer.cs
#	XenAdmin/MainWindow.resx
#	XenAdmin/Properties/Resources.resx
2019-09-13 13:17:32 +01:00
Konstantina Chremmou
61f6f89c25
Merge pull request #2510 from xenserver/feature/REQ-775
Merge REQ-775 into master
2019-09-06 12:08:23 +01:00
Mihaela Stoica
b7c64bddb2 CA-326341: Refresh the hotfix eligibility alerts after a check for updates is completed
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-09-04 14:40:03 +01:00
Mihaela Stoica
3f5125b293 CA-325846: Do not display invalid data in the hotfix eligibility warnings and alerts
- if a hotfix eligibility date field is invalid, then the hotfix eligibility warning does not include any reference to this date.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-09-03 08:52:40 +01:00