Commit Graph

2828 Commits

Author SHA1 Message Date
Konstantina Chremmou
7a1b1a6dcc Since it is easy to forget calling the base class method at the end of the PageLeave
override in derived classes, enforce it by wrapping the page specific code in
a new virtual method, which the derived classes can override and PageLeave can
call before its own logic.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-09 11:22:26 +00:00
Konstantina Chremmou
2b8bf70ee5 CA-272769: Call the base class method in the end of the PageLeave override, so the
WizardContentUpdater is invoked and information flows from the SelectInstallMethod
page to the following pages.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-09 11:22:26 +00:00
Konstantina Chremmou
a8b831fab9 Simplified check as per code review.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-09 11:22:26 +00:00
Mihaela Stoica
0184470ea3
Merge pull request #1968 from kc284/master
CA-284125: Automated updates should prioritise a pending host restart to a mandatory xapi restart
2018-03-08 15:54:39 +00:00
Michael
a4aaeb1165 CA-272150: Optimize destination page of cross-pool-migrate wizard. (#1941)
* CA-272150: Optimize destination page of cross-pool-migrate wizard.

Signed-off-by: Michael Zhao <michael.zhao@citrix.com>
2018-03-08 13:22:38 +00:00
Konstantina Chremmou
9e3a9abfa0 Resolve host before querying its properties.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-08 11:34:00 +00:00
Konstantina Chremmou
b3828ef452 Added parameter enableOnly defaulting to false to the RestartHostPlanAction
so as to be able to evacuate-reboot the host without bringing the VMs back.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-07 17:50:51 +00:00
Mihaela Stoica
929ae78942 CA-284876: Process the VM parameter of the VM_FAILED_SHUTDOWN_ACKNOWLEDGMENT error on host evacuation
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-03-07 11:28:57 +00:00
Konstantina Chremmou
4b6e826ed3 CA-284125: Prioritise a pending host restart over a mandatory toolstack restart.
For this purpose, the evacuate-reboot-bringbabiesback triplet was replaced by a
new RestartHostPlanAction, which allows fallback to toolstack restart if live
patching has succeeded. Also, created new abstract class HostPlanAction to
reduce code duplication.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-06 15:12:04 +00:00
Konstantina Chremmou
de9b0c4d30 Revisited commit 3f2eed35a0 reverting Dictionary to
List in order to enforce the order of checks (the Dictionary is not guaranteed to
keep the order the items are added). Also, extra null check.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-06 14:17:16 +00:00
Konstantina Chremmou
a22a9a41e3 A couple of small inefficiencies.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-06 14:17:16 +00:00
Konstantina Chremmou
7505bda9e3 Removed unused properties of UpdateProgressBackgroundWorker; store the number of
actions on creation instead of calculating it every time on access.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-06 14:17:16 +00:00
Konstantina Chremmou
c5b0af533e Removed methods GetHostBootTime and GetHostAgentTime because they duplicated logic
in the Host extensions. Moved method TryResolveWithTimeout to the Connection class
where it is more relevant. Removed wrapper methods WaitForReboot and WaitForAgent
as they were not particularly useful.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-06 14:17:16 +00:00
Konstantina Chremmou
ed4b131643 Removed unused code and old style custom delegates, and updated property notation.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-06 14:17:16 +00:00
Konstantina Chremmou
71e554cc39 Removed duplicate logic calculating VM groups from the WizardPages and moved it the Host class as extension methods.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-06 14:17:15 +00:00
Konstantina Chremmou
3171005d23 Removed redundant code in file.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-06 14:17:15 +00:00
serencorbett1
393f9d64b9 CA-284095: Fix sort-by creation date (#1966)
* CA-284095: Fix sort-by creation date

Signed-off-by: serenc <seren.corbett@citrix.com>
2018-03-06 13:07:22 +00:00
Kun Ma
f28322e5db CA-270999: Add registration to RestartManager
Signed-off-by: Kun Ma <kun.ma@citrix.com>
2018-03-06 09:36:05 +00:00
Konstantina Chremmou
058601f761 CA-279578: Update the Recheck/Resolve button state and error message visibility
alongside the wizard progress buttons. For this purpose, the separate UpdateControls
method was removed and the logic was moved in the EnableNext method. The OnPageUpdated
method that fires this is now called every time the checks start.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-02 13:32:49 +00:00
Konstantina Chremmou
3f2eed35a0 Refactoring: use a dictionary to hold the list of generated checks; simplified calculation of progress percentage.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-02 13:32:49 +00:00
serenc
c7ac86224a CA-282014: Patching wizard now deletes downloaded patch when wizard cancelled
Signed-off-by: serenc <seren.corbett@citrix.com>
2018-02-27 11:16:26 +00:00
Konstantina Chremmou
b4956da8f1 Performance and workflow improvement:
- no need to register the XenObjects events with the ArchiveMaintainer since
what the handler does is not specific to this class; this can be done on the
Performance page where the events are also registered.
- set directly the ArchiveMaintainer's XenObject to the new value without
setting it intermediately to null as this causes a full data download event
if the object has not changed.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-02-22 10:18:18 +00:00
Konstantina Chremmou
267035c2c6 Use Action instead of EventHandler since the event is fired without arguments.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-02-22 10:18:18 +00:00
Konstantina Chremmou
1728eb64b6 Simplified the code building the plan actions list as the previous code was
calculating the AfterApplyGuidanceActionsForPatch twice when the patch had
mandatory guidance.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-02-21 14:14:03 +00:00
Konstantina Chremmou
63c6b817d5 CA-40854: The Session's uuid is in reality its opaque_ref. Use the opaque_ref so
it's obvious what it is. The Session's uuid will be deprecated from the API bindings.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-02-21 14:08:01 +00:00
kunm
f0f37d9690 CA-280329: Fix CrossPoolMigrateDestinationPage with Current Server showing (#1931)
* CA-280329: Fix CrossPoolMigrateDestinationPage with Current Server showing

Signed-off-by: Kun Ma <kun.ma@citrix.com>

* CA-280329: Refine usage of CreateTargetServerFilterList

Signed-off-by: Kun Ma <kun.ma@citrix.com>
2018-02-05 15:31:22 +00:00
Mihaela Stoica
95471eaac5 CA-281646: Do not download the update again when using an update from disk (#1933)
* CA-281646: Do not download the update again when using an update from disk

When applying a "new version" update, XenCenter starts an automated updates sequence that by default downloads all the updates. However, when using an update from disk, we shouldn't download it again.

With these changes, when an update from disk is used we save the [update, path] mapping, which we then use in the automated updates sequence, so we don't download that update again.

Also fixed a bug where a zipped update file from disk is not identified as a new version.

* CA-281646: Remove unused directive

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-02-05 12:36:49 +00:00
Michael
6a6931dbd5 CA-280322: Space requirement calculation error in migration wizard. (#1934)
* CA-280322: Space requirement calculation error in migration wizard.

* Fix comments.

Signed-off-by: Michael Zhao <michael.zhao@citrix.com>
2018-02-05 10:07:24 +00:00
Mihaela Stoica
0f31a6f857
Merge pull request #1932 from xenserver/REQ-420
Merge request from REQ-420 into master
2018-02-01 12:24:27 +00:00
Konstantina Chremmou
19de8c54b5 CA-280679: Fixed issue where the TabPage plugin could not handle Ipv6 addresses.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-01-29 10:17:27 +00:00
Konstantina Chremmou
123db499f5 Merge branch 'master' into REQ-420 2018-01-25 13:38:58 +00:00
Konstantina Chremmou
99f9a70189 Connection code simplification/update: removed CachePopulatedEventArgs class and use the newer Action delegate instead.
Also, changed the access modifiers of several members to private, because they don't need to be exposed outside the parent class.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-01-24 15:58:16 +00:00
Mihaela Stoica
deb953a6ff CA-280287: Fix the null reference exception on the Import wizard (#1918)
* CA-280287: Fix the null reference exception on the Import wizard

- Added a check so that we don't attempting to show the license warning if the wizard is open without a preselected host/pool.
- The license warning is now updated whenever the host selection changes; plus, we are not attempting to show it if the wizard is open without a preselected host/pool.

- Also a minor refactoring in the GlobalSelectHost page to fix this issue: when the wizard is open with a pre-selected host, we pass this to the page by assigning SelectedHost property, which in turn sets the m_selectedHost. The getter for SelectedHost  resets m_selectedHost to the selected item in the host list. If the getter is used before the host list selection is updated, then the desired pre-selection is lost, because m_selectedHost is reset to null.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* CA-280287: Corrections following code review

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-01-19 14:05:20 +00:00
Mihaela Stoica
babf201d2a CA-276678: Add "Buy licenses" link in the patching wizard when the precheck fails with license restriction
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-01-19 13:11:00 +00:00
Mihaela Stoica
6cefd4d202 CA-276976: Add a new precheck in the Update Wizard
- The new "server selection" precheck is added for Inverness or greater pools and checks if all the servers in the pool are selected (if update not already applied) when applying an update that has the "enforce-homogeneity" flag set to true

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-01-12 14:34:50 +00:00
Mihaela Stoica
018dfb8e79 Rename resource string which causes Messages.resx to become unsorted
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-01-11 12:45:37 +00:00
Mihaela Stoica
13a8b26fc4 Merge release/jura/master into REQ-637
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

# Conflicts:
#	XenModel/Utils/Helpers.cs
2017-12-19 13:12:39 +00:00
Mihaela Stoica
ffa42c086b CP-26290: Add new edition
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-12-18 13:22:17 +00:00
Michael
035f4c234e CA-272797: Limit user to select 8 SRs at most in DR Configure dialog. (#1896)
* CA-272797: Limit user to select 8 SRs at most in DR Configure dialog.

Signed-off-by: Michael Zhao <michael.zhao@citrix.com>
2017-12-18 09:55:45 +00:00
Gabor Apati-Nagy
3a076e21c6 CP-26048: Improve the fix for CA-271775 (console tab)
Fixed typo

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-12-13 10:48:23 +00:00
Gabor Apati-Nagy
a01a4b9855 CP-26048: Improve the fix for CA-271775 (console tab)
Improved message (when using an outdated RDP client)

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-12-13 10:48:23 +00:00
Gabor Apati-Nagy
9b6806de1b CP-26048: Improve the fix for CA-271775 (console tab)
Reserved space for the warning message that is displayed if the XC machine is running an older version of the RDP control

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-12-13 10:48:23 +00:00
Mihaela Stoica
1e08eb2371
Merge pull request #1890 from jishengx/private/jishengx/CA-272130
CA-272130: modify truncated linklabel and text on the memory settings wizard
2017-12-07 13:53:03 +00:00
Gabor Apati-Nagy
a2a5f4eaeb
Merge pull request #1888 from michael2012z/private/fengyangz/CA-271863
CA-271863: Can not automatically resolve autostart-enabled VM in RPU.
2017-12-07 11:12:31 +00:00
Jisheng Xing
449dfe7f56 CA-272130: modify truncated linklabel and text on the memory settings wizard 2017-12-07 17:28:03 +08:00
Michael Zhao
10afdbc541 CA-271863: Update max waiting time to 5 seconds to handle extreme cases. 2017-12-07 13:03:06 +08:00
Michael
1d0a2b76a0 CA-272769: Enable user to cancel URL testing in rolling upgrade wizard. (#1882)
* CA-272769: Enable user to cancel URL testing in rolling upgrade wizard.

* CA-272769: Sort messages resource file.
2017-12-06 12:06:36 +00:00
Michael Zhao
1cf6b55368 CA-271863: Can not automatically resolve autostart-enabled VM in RPU. 2017-12-06 15:57:07 +08:00
Konstantina Chremmou
fb8434819d Namespace tidy 3/several: replaced XenAdmin.Core (instances in XenCenterLib) with XenCenterLib.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-11-30 13:56:32 +00:00
Konstantina Chremmou
7f1ee0b30e Namespace tidy 2/several: replaced XenAdmin with XenCenterLib.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-11-30 13:56:32 +00:00