Konstantina Chremmou
6513abc09e
The check for hosts that are unlicensed for automated updates should be on all pool hosts as there maybe individual restrictions (for example via a feature flag).
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-19 17:20:08 +01:00
Mihaela Stoica
da9e5a5cab
CP-28284: Implement IEquatable in PlanAction
...
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-06-19 13:34:37 +01:00
Mihaela Stoica
59b9b695db
CP-28284: Changes following code review
...
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-06-19 13:34:37 +01:00
Mihaela Stoica
631d7656a2
CP-28284: Corrections
...
- ensure that an action is only added once to the DoneActions and InProgressActions
- reset the wizard buttons (Cancel, Finish) when a retry is started
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-06-19 13:34:37 +01:00
Mihaela Stoica
920da093e0
CP-28284: Only show the error icon and text when all the workers have finished
...
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-06-19 13:34:37 +01:00
Mihaela Stoica
eca6081f48
CP-28284: Show the plan actions indented under the pool name
...
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-06-19 13:34:37 +01:00
Mihaela Stoica
7fa9d0b94f
CP-28284: Updates wizard: Add a "pause and resume" mechanism to handle failures
...
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-06-19 13:34:37 +01:00
Konstantina Chremmou
d9ee664d53
CA-289629: launch confirmation dialog within a using block.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-18 21:59:38 +01:00
Mihaela Stoica
da2c96ad1c
CP-28426: RPU wizard: add user option for automatically applying updates - changes following code review
...
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-06-18 16:28:28 +01:00
Mihaela Stoica
dd19f3a0b7
CP-28426: RPU wizard: add user option for automatically applying updates
...
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-06-18 16:28:28 +01:00
jishengx
cf20ac13c4
CA-289629: prompt host may need to be rebooted to enable SR-IOV ( #2092 )
...
CA-289629: prompt host may need to be rebooted to enable SR-IOV
Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
2018-06-18 12:36:12 +01:00
Joey
abe97def1e
CP-28286: Support resume from a partially upgraded pool via Update wi… ( #2095 )
...
* CP-28286: Support resume from a partially upgraded pool via Update wizard
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
* CP-28286: Fix comments of the previous commit
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-06-18 10:46:41 +01:00
Joey
cf9e05059c
Merge pull request #2096 from MihaelaStoica/CP-28282
...
CP-28282: Update the disk space precheck to calculate the required space according to the new workflow
2018-06-15 16:24:53 +01:00
Mihaela Stoica
93a154e04f
CP-28282: Unit tests fix + improved message
...
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-06-15 16:05:37 +01:00
Mihaela Stoica
121bce92af
CP-28282: Correction to the required disk space calculation
...
- also renamed a variable and updated the problem description to include the server name
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-06-15 14:24:29 +01:00
Mihaela Stoica
e8ab24820d
CP-28282: Fix the bug where the action fails with InvalidOperationException if there is no available SR for upload
...
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-06-14 16:39:43 +01:00
Mihaela Stoica
c702399d95
CP-28282: Update the disk space precheck to calculate the required space according to the new workflow (apply all hotfixes to a host before moving to the next one)
...
- this commit covers the post-Ely case, where updates are uploaded to storage repositories
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-06-13 17:24:33 +01:00
Mihaela Stoica
2efc1b8685
CP-28282: Update the disk space precheck to calculate the required space according to the new workflow (apply all hotfixes to a host before moving to the next one)
...
- this commit covers the pre-Ely case, where patches are uploaded to the server
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-06-13 17:23:17 +01:00
Mihaela Stoica
318f20f65f
CP-28282: Preliminary work: move the disk space calculation inside the precheck
...
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-06-13 17:22:52 +01:00
Mihaela Stoica
8fff0b2b10
Merge pull request #2093 from kc284/REQ-672
...
Separate displayed update information per pool. Minor layout corrections and removal of unused LinkLabel.
2018-06-08 16:54:11 +01:00
Konstantina Chremmou
49823f9dd9
Do not show the successful completion message before the update is actually completed.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-08 16:41:06 +01:00
Konstantina Chremmou
73e7b66fa4
Do not change the page top blurb depending on the process outcome. Improved error messages.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-08 16:15:55 +01:00
Konstantina Chremmou
2e2ae7c196
Separate displayed update information per pool. Minor layout corrections and removal of unused LinkLabel.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-08 13:42:06 +01:00
Mihaela Stoica
15edb13997
Merge pull request #2089 from kc284/REQ-672
...
First batch of changes for CP-28281
2018-06-08 11:32:26 +01:00
Ji Jiang
88224df214
CA-290316: Skip hotfix homogeneity precheck in mixed pool
...
Because we couldn't control user's selected combination from
a mixed pool, and the version compatibility precheck exists already,
here just simply skip the precheck and issue a warning.
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-06-08 11:17:41 +01:00
Konstantina Chremmou
11a9785dba
Log the patch clean-up actions on the screen in case of a failure. Order the shown actions per pool.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-07 16:34:13 +01:00
Konstantina Chremmou
1b4a862fd0
Further corrections to the load/leave page workflow and object selection ensuring correct enablement of the Next button.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-07 12:27:57 +01:00
Konstantina Chremmou
20d74a64c9
Unregister handlers when leaving or cancelling the page and invoke on the current
...
control instead of the main window (may cure CA-289721).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-07 12:27:57 +01:00
Konstantina Chremmou
b36993228c
Moved index retrieval in Invoke and corrected index sanity check. Update the combobox
...
and unregister item event in a try-finally block (may cure CA-289721); suspend-resume
layout when updating the datagridview.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-07 12:27:57 +01:00
Konstantina Chremmou
3f8feb4bdd
Removed invocations where we are already on the UI thread.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-07 12:27:57 +01:00
Konstantina Chremmou
2e07781e6b
Simplify the logic toggling the enabled state of the Next button depending on the selection.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-07 12:27:57 +01:00
Konstantina Chremmou
621fce4d70
Fixed regression whereby the vm-host mapping was lost when proceeding to the next page and returning to the destination selection page.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-07 12:27:57 +01:00
Konstantina Chremmou
355621f183
Simplified event signature.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-07 12:27:57 +01:00
Konstantina Chremmou
1d905fc18c
Simplified logic when fetching the failure reason; capitalised constant names so they're more visible.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-07 12:27:57 +01:00
Konstantina Chremmou
2c3c4bf5ca
Renamed methods so it's more obvious what they do.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-07 12:27:57 +01:00
Konstantina Chremmou
887428872a
Logic corrections. Show the name of the patch being removed each time.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-07 12:12:17 +01:00
Konstantina Chremmou
57ab2ced2b
CA-289335: If there is no other network available, pick the management network for the migration of VDIs.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-06 16:06:41 +01:00
Konstantina Chremmou
14aa3f3f5d
CA-289335: Do not check the NetworkComboBoxItem can be selected unless it has been added to the ComboBox.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-06 16:06:41 +01:00
Konstantina Chremmou
c643351e6c
CP-28281: Change the order in which the updates are applied to a pool, namely apply all updates on a host before continuing with the next host.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-05 22:26:16 +01:00
Konstantina Chremmou
723510b853
Removed class Updates.UpgradeSequence.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-05 11:50:34 +01:00
Alexander Schulz
a294c61bd0
Remove shortcut definition from MainWindow resx files, Shortcut is already defined in Commands\NewVMCommand.cs
...
https://github.com/xenserver/xenadmin/pull/2078
2018-06-05 11:15:18 +01:00
Alexander Schulz
c26de212da
Use "Control+N" instead of "Ctrl+N" to be buildable on non-english operation systems
2018-06-05 11:15:18 +01:00
Jisheng Xing
7034973ae1
CA-287651: Precheck shows SR broken on both hosts but it is only broken on one
...
Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
2018-06-05 05:45:57 +01:00
Konstantina Chremmou
d4b7642ef7
Compacted null checks.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-04 15:18:29 +01:00
Konstantina Chremmou
d58131910b
Corrected logic checking the host is up to date. Renamed method because the old name was not descriptive of the output.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-04 12:40:30 +01:00
Jisheng Xing
b85c6d9f60
CA-289618: Clear the created network after enabling SR-IOV failed
...
Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
2018-06-04 12:06:40 +01:00
Konstantina Chremmou
b0cdc74188
The code in the BackgroundWorker's ProgressChanged and RunWorkerCompleted event handlers does not need invoking as it's already on the UI thread.
...
Also, some logic simplification.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-05-29 13:50:46 +01:00
Konstantina Chremmou
89621c2bb5
Unnecessary field.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-05-29 10:47:54 +01:00
Konstantina Chremmou
18f2ff0785
Typo.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-05-29 10:46:14 +01:00
Mihaela Stoica
c2b42fa107
CA-289335: Refactoring to avoid setting the SelectedItem twice
...
- also avoids iterating through the combobox items again to determine which item to select
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-05-24 16:23:04 +01:00