Kiu/xenadmin
1
0
Fork 0
mirror of https://github.com/xcp-ng/xenadmin.git synced 2025-01-20 23:39:51 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
6,197 Commits 12 Branches 48 Tags 186 MiB
7ca120eb76
Commit Graph

3919 Commits

Author SHA1 Message Date
Konstantina Chremmou
a104175cb6 Corrected the branding of the session's user agent. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-04-14 15:50:50 +01:00
Konstantina Chremmou
3f4737c57a Upgraded log4net to 2.0.12. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-04-09 09:16:01 +01:00
Konstantina Chremmou
6d8ad062f8 CA-353070: Corrected wizard title. Fixed navigation with the Tab key. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-04-08 17:28:48 +01:00
Konstantina Chremmou
abf4ae3f35 CP-36392 pt.1: Removed unused using directives. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-04-07 10:04:47 +01:00
Konstantina Chremmou
e5bee7be6a Added Events in progress to the outlook-style status labels of the main window. 
- Reordered the labels to reduce flickering for short actions.
- No need to fire action events in a try-catch block.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-04-07 10:04:30 +01:00
Konstantina Chremmou
75cda928ec CA-352896: Corrected latency units. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-04-01 11:30:54 +01:00
Konstantina Chremmou
35e1d68afa CA-352901: Fixed window title and translations for window title and menu item. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-04-01 11:30:54 +01:00
Konstantina Chremmou
a0e2967792 CP-31105: Replaced the hardcoded name patterns in the resource files with format placeholders. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-03-31 11:50:32 +01:00
Konstantina Chremmou
c4b076bd97 Removed unused code alongside strings in need of branding. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-03-31 11:50:32 +01:00
Ji Jiang
c1ec145cf7 Fix some messages 
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
 2021-03-22 23:32:09 +00:00
Mihaela Stoica
a5d7bdc0ec CA-352678: Diagnostic token is not needed for uploads to CIS from the SSR wizard 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2021-03-17 15:30:59 +00:00
Ji Jiang
73396d1759 CP-35345: Adjust DeprecationBanner width 
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
 2021-03-17 10:32:17 +00:00
Ji Jiang
96c3d5e1c0 CP-35345: Add pre-cloud connection warning 
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
 2021-03-17 10:32:17 +00:00
Mihaela Stoica
96956dbc81 CA-352663: Fix button action on Custom Field deletion confirmation dialog 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2021-03-16 00:13:06 +00:00
Mihaela Stoica
c6710b7ffd CP-35471: Refactor HostNotSafeToUpgrade classes to avoid code repetition. 
Also:
- added count check when generating the prechecks
- message correction

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2021-03-11 09:30:52 +00:00
Mihaela Stoica
9f6ce35a04 CP-35471: Change the SafeToUpgrade check to show a problem when upgrading to the next version 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2021-03-11 09:30:52 +00:00
Mihaela Stoica
4f989338f2 CP-35471: Add the new version of RPU005 
(required when upgrading from Stockholm)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2021-03-11 09:30:52 +00:00
Konstantina Chremmou
0c572a1d6d Normalised usage of the UpsellDialog. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-03-03 13:50:29 +00:00
Konstantina Chremmou
79d8b00de8 Replaced AllowUpdatesDialog with a ThreeButtonDialog. 
For reasons of code reduction and also because the look and feel of this dialog
was slightly different from the usual application pop-ups.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-03-03 13:50:29 +00:00
Konstantina Chremmou
51dedff3c4 Rebrand Branding.resx instead of the BrandManager.cs. Sorted variables alphabetically and removed unused variable. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-03-03 13:50:29 +00:00
Ji Jiang
7b63b58622 Disallow CHC connection with Havana 
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
 2021-03-03 13:49:45 +00:00
Konstantina Chremmou
6e5cb325f3 CP-35899, CP-36202: Show the driver domain console tab on the corresponding SR. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-03-02 11:57:50 +00:00
Konstantina Chremmou
a109f5f22d Pascal-cased method name. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-03-02 11:57:50 +00:00
Joey
5a29a8fd9b
CP-35838: Add health check precheck into RPU wizard (#2778) 
* CP-35838: Add health check precheck into RPU wizard
* CP-35838: Add disable Health Check in RPU precheck warning

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
 2021-03-02 09:53:21 +00:00
Darren Matthews
a8988276be L10n : Resx resync and translation update 
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
 2021-03-02 09:44:29 +00:00
Konstantina Chremmou
11ce488062 Merge branch 'master' into feature/hyperman 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	Jenkinsfile
#	scripts/xenadmin-build.sh
 2021-02-17 14:51:13 +00:00
Konstantina Chremmou
abd6b41926 Fixed Next button state when re-landing on the page. Usability enhancements. 
Property modernisation.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-02-17 11:56:12 +00:00
Konstantina Chremmou
f852167ad1 Created re-usable project target to add manifest to an assembly. Be specific about the mt executable to use. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-02-16 10:07:46 +00:00
Ji Jiang
7b362e5cd6 CP-35479: Allow connection to certain product versions 
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
 2021-02-11 13:35:43 +00:00
Konstantina Chremmou
145483b193 Minor corrections on Task extensions: 
- Stop rethrowing exceptions.
- Added some checks.
- Renamed method XenCenterUUID to GetXenCenterUUID to match the methods
  SetXenCenterUUID and RemoveXenCenterUUID.
- Replaced check via static string list with a string switch block.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-02-10 23:45:23 +00:00
Konstantina Chremmou
307b97e1d6 Refactored the Command Enabled|Disabled Tooltip to avoid multiple calculation of whether the command can be executed. 
Also, use CommandButtons instead of normal buttons on the SrStorage TabPage.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-02-10 23:44:21 +00:00
Konstantina Chremmou
4cf37879ec Made ShowConfirmationDialog private as in the one case it was accessed by the inheriting class it was not making the code simpler. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-02-10 23:44:21 +00:00
Konstantina Chremmou
0d10e1e53f Replaced own method ConvertToSelection<T>() with Linq queries. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-02-10 23:44:21 +00:00
Konstantina Chremmou
db89699bac Removed method SetParent. Use a setter for the property Parent instead. Property modernisation. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-02-10 23:44:21 +00:00
Konstantina Chremmou
ab59bf22d0 Code design: removed unnecessary base class for Patching and RPU wizards. 
Not sure why I had added that since the containing protected method is probably
more relevant as a static method in the Problem class.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-02-08 17:20:05 +00:00
Ji Jiang
973132ed4e CP-35563: Hide health check service on Hyperman 
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
 2021-01-26 15:44:43 +00:00
Ji Jiang
dc466f245c CP-35478: Rebranding effort 
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
 2021-01-26 15:44:43 +00:00
Konstantina Chremmou
0598e6342d Merge remote-tracking branch 'upstream/master' into feature/REQ-797 2021-01-19 11:01:02 +00:00
Vetrivel Chinnasamy
78033c8186 CA-350227: L10N- Translation Updates 2021-01-15 11:54:48 +00:00
Konstantina Chremmou
be010e1c39 CA-350406: Exclude the Tools SR when plugging PBDs after a host reboot during an update process. 
Also, try plugging PBDs only for the host in question (other hosts are not necessary,
as the PBDs are re-checked for any previously evacuated VMs before repatriation).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-01-12 12:15:12 +00:00
Konstantina Chremmou
90e6cb0dc9 Memory leak when disposing of the RdpControl. 
The rdpControl was set to null too soon and by the time the timer ticked it had
no chance to be disposed of at all. Also, the timer itself was not disposed of.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-01-06 11:28:32 +00:00
Konstantina Chremmou
33e668c0c4 Removed obsolete class XSVersionAttribute. Some refactoring of the usage of Program.Version. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-12-24 01:23:47 +00:00
Konstantina Chremmou
1c4178c7fe CA-347480: Improved ability to cancel an import/export while compressing/uncompressing the files, or packaging into/extracting from an OVA file. 
Also, remove another couple of unused methods from the OVF class.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-12-18 01:34:25 +00:00
Konstantina Chremmou
8d004401fb CA-343280: Removed metadata entry. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-12-07 15:57:26 +00:00
Konstantina Chremmou
f73ea42cb2 CA-343280: Reworked saving user settings. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-12-07 15:57:26 +00:00
Konstantina Chremmou
28c0f1d62a Tweaked the column autosize mode on the SelectNetwork page. 2020-12-07 15:57:00 +00:00
Konstantina Chremmou
e7e6fb3234 CP-35350 preliminary work: Removed images that are not displayed anywhere on the UI. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-12-02 12:34:09 +00:00
Konstantina Chremmou
60fb141e57 CA-339384: Take account of thin provisioning when placing a disk on a target SR. 
Also, set the required disk size to zero when the disk spinner value is invalid.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-11-18 09:24:45 +00:00
Konstantina Chremmou
80119e9411 CP-15790: Implementation improvement aimed to make manual testing easier. 
- Ensure we read the updates.xml location anew from the registry, otherwise the
application has to be relaunched to pick a registry change. Look in both hives
HKCU and HKLM. To avoid performance impact on the UI, move the operation into
the action's Run() body.
- Some refactoring to improve OOP design and fix XmlReader leak.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-11-12 11:04:33 +00:00
Konstantina Chremmou
c9a70d282e Do not disable the OK button on validation, but rather point out the problematic entry using validation tooltips. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-11-03 11:34:06 +00:00
Konstantina Chremmou
c1375c51ed CA-347407: Handle exceptions when failing to unprotect saved proxy credentials. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-11-03 11:34:06 +00:00
Konstantina Chremmou
248b99abd7 Fixed layout issue whereby the rightmost textboxes were spilling out of the containing groupbox when the control was resized. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-11-03 11:34:06 +00:00
Konstantina Chremmou
fd6b7b4b48 Added default values to window size and location. 
There was a silent exception thrown when reading the window location the first
time the application was launched.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-11-03 11:34:06 +00:00
Konstantina Chremmou
61d77cada4 CA-343956: Corrected action performed by the Attach Disk context menu item. Show grip on the Attach Disk dialog. 
The dialog is launched non-modally, hence showing the grip automatically has no effect.
Also, made the dialog slightly bigger.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-11-03 11:33:16 +00:00
Konstantina Chremmou
4f564979e1 CA-345349: Verify the exported disk using DiscUtils and fail the whole export if one disk export failure occurs. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-10-13 14:34:15 +01:00
Konstantina Chremmou
38c88b5692 CA-64500: Offer the option to start the vApp or VM automatically after an OVF/OVA import. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-10-13 14:34:15 +01:00
Konstantina Chremmou
88d3e66505 Hide the error at construction to prevent flickering when the page is loaded. Property modernisation. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-10-13 14:34:15 +01:00
Konstantina Chremmou
54e8347a5c CP-34826: Upgraded DiscUtils to version 0.11. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-10-13 14:34:15 +01:00
Darren Matthews
a9016bc14e L10N : Translation Update and RESX resync 
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
 2020-10-13 13:56:55 +01:00
Konstantina Chremmou
1e6197022e
CA-339233: Do not allow selection of networks while they're locked. (#2733) 
* Hid properties from the designer and renamed them because they give the wrong impression.
* Fixed some inefficiencies around the NetworkComboboxItem.
- Move NetworkComboBoxItem into the NetworkComboBox class.
- Moved XenAdmin.Dialogs.NetworkComboBoxItem into the VIFDialog class and made it
  private to avoid ambiguousness with the public XenAdmin.Controls.NetworkComboBox.NetworkComboboxItem.
- Create a NetworkComboBoxItem only if needed and assign its name at construction time.
- Add method to select a NetworkComboBoxItem and property to return the SelectedNetwork.
* CA-339233: Do not allow selection of networks while they're locked.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-10-07 13:34:03 +01:00
Konstantina Chremmou
6f44821e40 Import refactoring 4: Simplifications and corrections, including: 
- Improvements to progress reporting (CA-65894).
- Added some logging.
- Use the connection cache instead of making server calls.
- Moved some methods to the string utilities and added unit tests.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-10-07 13:22:33 +01:00
Konstantina Chremmou
23892df15d Moved the OVF actions to XenModel and removed what was left from XenOvfTransport. 
Previously this was not possible due to XenModel-XenOvfTransport cyclical references.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-10-07 13:22:33 +01:00
Konstantina Chremmou
4e95b25572 Removed XenOvfTransportEvent. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-10-07 13:22:33 +01:00
Konstantina Chremmou
74aa727f15 Import refactoring 3: Made class Import static. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-10-07 13:22:33 +01:00
Konstantina Chremmou
d22af4cd83 Export refactoring 3: Use the connection cache instead of making server calls. Also: 
- Avoid multiple exception catching and rethrowing.
- Corrected VirtualSystemType identification.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-10-07 13:22:33 +01:00
Konstantina Chremmou
31c4b86395 Export refactoring 2: Made XenOvfTransport.Export static. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-10-07 13:22:33 +01:00
Konstantina Chremmou
18c407d992 Removed controls for Transfer VM configuration. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-10-07 13:22:33 +01:00
Konstantina Chremmou
6e2c45bcd5 CP-34221: Basic implementation of export/import using the API's http actions. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-10-07 13:22:33 +01:00
Konstantina Chremmou
e3d6db3a80 Removed support for long retired XVA v1 packages. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-10-07 13:22:33 +01:00
Konstantina Chremmou
25b61ea129
CA-343763: Corrected the handling of VMSS alert priority/severity according to CA-342874. (#2730) 
* CA-343763: Corrected the handling of VMSS alert priority/severity according to CA-342874.

- Distinguish between warnings and errors.
- Made PolicyAlert derive from MessageAlert to conform with other alert types.
- Replaced EventType column by a simple image column because it adds to clatter
  without really offering useful information.

* Correction as per code review.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-10-06 14:51:14 +01:00
Konstantina Chremmou
7352ae1d38 Fixed broken help button on the ThreeButtonDialog. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-10-06 11:27:32 +01:00
Konstantina Chremmou
d93e40065a Various fixes on the EvacuateHostDialog (includes CA-292642, CA-284126, CP-34862). 
- CP-34862: Do not allow nomination of new master if a pool secret rotation or
  other pool operations are in progress.
- CA-292642: Fixed button enablement after resolving VM problem.
- CA-284126: Added button to rescan running VMs on the server.
- Removed annoying, focus stealing, modal action progress dialog. When scanning
  for VMs show a spinner on the control instead.
- Fixed crash when the host combobox was updated due to cache changes.
- Logging in an elevated session was happening on the UI thread.
- Show the role elevation dialog before launching the host evacuation dialog or
  we end up with showing the user an unpopulated control.
- Stop deriving from animated progress dialog because it makes it difficult to
  get the resizing right when adding more controls.
- Stop using the progress bar for the VM solution actions; rely simply on the
  action's description and the VM's icon in the gridView.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-10-06 11:27:32 +01:00
Konstantina Chremmou
b34a5d54cf CP-34862: Do not allow enabling HA when a pool secret rotation is pending. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-10-06 11:27:32 +01:00
Konstantina Chremmou
f3da384a6a Configuring HA on the TabPage should offer the same UX as when using the Menu Items. 
- Use CommandButtons on the HA TabPage for configuring/disabling HA.
- Added menu item to disable HA.
- There is no point in hiding the buttons on the HA TabPage when the corresponding
  menu items are available. They should rather offer the same user experience.
- Added RBAC page to the HaWizard to avoid unnecessary SR scanning only to be told
  that one cannot proceed.
- Show RBAC error dialog if the user does not have permission to launch the
  EditVmPriorities dialog.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-10-06 11:27:32 +01:00
Konstantina Chremmou
db7582a397 CP-34862: Do not allow enabling clustering when a pool secret rotation is pending. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-10-06 11:27:32 +01:00
Konstantina Chremmou
aec6b395ff CA-343956: Fixed issues on the VM storage TabPage: 
- Disabled button tooltips did not disappear when the DataGridView selection was cleared.
- The disabled Activate/Deactivate button had no tooltip for template disks.
- Minor improvement to the tooltip of the Delete button.
- The Add button was using the enablement logic of the AttachVirtualDiskCommand.
- Use CommandButtons to avoid logic duplication.
- Hide the CommandButton.Command from the designer as it's mostly assigned programmatically.
- Increased the minimum width of the non-autosizable columns so they remain visible.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-10-02 11:59:55 +01:00
Konstantina Chremmou
a01824b836 Fixed alignment of icons on the View dropdown on the Snapshots TabPage. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-10-02 11:59:55 +01:00
Konstantina Chremmou
c4754c0251 Removed exception that was never thrown (referring to obsolete licensing restriction). 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-09-08 10:34:08 +01:00
Konstantina Chremmou
2bb1cd5c5c CA-343781: Fixed error visibility when the check for updates fails. Corrected error image size. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-09-08 10:34:08 +01:00
Konstantina Chremmou
cdd650d40e Fixed 3rd party library references in the solution project files. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-09-08 10:34:08 +01:00
Darren Matthews
c75ab40ef8 L10N : Translation Updates and Resx Resync 
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
 2020-09-01 14:26:40 +01:00
Konstantina Chremmou
822394597f Corrected button text. Fixed duplicate hotkey in the host right click menu. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-08-24 16:49:23 +01:00
Konstantina Chremmou
e3896239df CA-339305: XenCenter was hanging when update alerts were removed very fast, and other issues: 
- Use a plain list to store update alerts and, where possible, fire a collection
  change event only after a bulk change and not every time a single object is added
  or removed.
- Fixed issue where dismissed updates were stored in the config of all connected
  pools, even of those where the update did not apply.
- Corrected RBAC checks for update dismissal.
- Fixed enabled state of dismiss buttons.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-08-21 16:08:20 +01:00
Konstantina Chremmou
f05b512ca4 Tidy up event registration and deregistration on the MainWindow. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-08-21 16:08:20 +01:00
Konstantina Chremmou
f0c20ae86b CA-343459: Update automatically the upgrade method depending on the specified url prefix. 
Also, remove the upgrade methods from the resource files since they are not meant
to be translated.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-08-21 09:11:10 +01:00
Konstantina Chremmou
2e66ec9133 Merge remote-tracking branch 'upstream/master' into feature/REQ-819 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Dialogs/OptionsPages/SecurityOptionsPage.cs
 2020-08-11 13:35:39 +01:00
Konstantina Chremmou
c244d8d4db CA-339584: Include CD VDI in the storage mapping for intra-pool migration 
Also: removed unused method; some property modernisation; removed class
LiveMigrateOptionsVmMapping which was rather complicating things.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-08-11 08:46:42 +01:00
Konstantina Chremmou
e0864cd99c CA-342526: Ensure the update list has been populated and the specified update has been selected before stepping into the next page. 
Also, reduced visibility of the methods moving between wizard pages to avoid
creating complex situations.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-07-31 10:54:49 +01:00
Konstantina Chremmou
a076cc59a2
Dialog deletion (#2701) 
* Replaced LicenseWarningDialog with a simple WarningDialog.
* Replaced VcpuWarningDialog with a simple WarningDialog.
* Replaced RemoveCrashdumpsWarningDialog with a simple WarningDialog.
* Replaced UsbUsageDialog with a simple WarningDialog.
* Replaced WlbDeleteReportSubscriptionDialog with a simple WarningDialog. Added null checks to event invocation.
* Replaced DisableWlbDialog with a simple Warning dialog.
* Replaced ConnectionRefusedDialog with a simple Error dialog.
* Replaced UserDeviceDialog with a simple Warning dialog.
* Replaced RevertDialog with a simple Warning dialog.
* Removed unused dialogs.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-07-30 11:29:01 +01:00
Konstantina Chremmou
a66a82878e The ConnectionOptionsPage should not access private controls of its parent but rather communicate its valid state via an event. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-07-30 11:27:29 +01:00
Konstantina Chremmou
ca3e9c0219 Removed unused SaveSessionCommand and consequently refactored SaveAndRestoreDialog constructor. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-07-30 11:27:29 +01:00
Konstantina Chremmou
65ea154b9d Moved the code that logs settings to the Settings static class. 
Although it may look tidy to log the settings in the OptionsDialogPages that
expose them to the user, in reality it makes for unnecessarily complicated code
design as it places business logic in UI code and mixes the class dependencies.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-07-30 11:27:29 +01:00
Konstantina Chremmou
8fb44a55cb Added flag VM.VirtualisationStatus.NOT_INSTALLED to replace value 0 for clarity. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-07-30 10:42:20 +01:00
Konstantina Chremmou
e30ea433c7 Refactoring to simplify the code and make calculations more efficient: 
Removed unnecessary abstractions. Replaced named delegates with anonymous ones.
Use pattern matching and avoid multiple casts. Be consistent in the properties
we check.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-07-30 10:42:20 +01:00
Konstantina Chremmou
5526a3f7d1 CP-34045: Removed max resolution and max displays columns. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-07-28 10:01:09 +01:00
Konstantina Chremmou
5f7d3e1518 Homogeneous icon usage across the application. 
- Replaced remaining instances of SystemIcons. SystemIcons.Information of size
  32x32 were excepted as we don't have the right size icon yet.
- The question mark icon is used for help, not for asking questions.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-07-18 07:49:27 +01:00
Konstantina Chremmou
8a6a579402 CP-20425: Use static images everywhere an image is assigned programmatically. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-07-18 07:49:27 +01:00
Konstantina Chremmou
d08f02cce2 CP-20425: Added test to ensure all Resource images have a static counterpart. 
Also, stop boxing Bitmap into Image so as to avoid casting wherever it is called.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-07-18 07:49:27 +01:00
Konstantina Chremmou
ea4175e75c CP-20425: Use the SpinnerIcon instead of a new spinner implementation which does not use the static images. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-07-18 07:49:27 +01:00
Konstantina Chremmou
e27a0a7333 Minor refactoring on UpsellPage: 
- Modernised properties.
- Removed unnecessary public method; it was rather obfuscating setting properties.
- Made Image property non-browsable.
- Missing null check.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-07-18 07:49:27 +01:00
Konstantina Chremmou
9d7cf72c78 CP-33781: Added admin exit procedure warnings. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-07-17 16:04:10 +01:00
Konstantina Chremmou
5c1a982659 CP-33771: Added an item to the pool menu for triggering a secret rotation. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-07-17 16:04:10 +01:00
Konstantina Chremmou
a2596ec201
Merge pull request #2711 from xenserver/dotnet48 
Merge branch dotnet48 into master
 2020-07-07 12:10:46 +01:00
Konstantina Chremmou
e42bc54be4 CA-187276: Re-enable "Open SSH Console" button after VM restart 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-07-07 09:25:54 +01:00
Konstantina Chremmou
f3c5e74dae CP-33892: Audited the use of First() and replaced with FirstOrDefault() where appropriate. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-06-25 11:17:11 +01:00
Konstantina Chremmou
d2ded59b7a CA-341576: Corrected title and button text. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-06-22 11:46:02 +01:00
Talons Lee
b09d3cb8e7 CP-33715: add gooroom os icon 
Signed-off-by: Talons Lee <xin.li@citrix.com>
 2020-06-15 22:37:50 +01:00
Konstantina Chremmou
d045d180a0
Merge pull request #2696 from xenserver/master 
Bring branch dotnet48 up to date with master
 2020-06-15 15:43:52 +01:00
Darren Matthews
cef05ab005 L10N : Resx Resync and translation update. Fixed Confirmation Options page with the Resync 
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
 2020-06-11 13:57:12 +01:00
Darren Matthews
00b6fdc8e3 L10N: Translation and Resx Resync 
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
 2020-06-11 13:57:12 +01:00
Konstantina Chremmou
ebe0257af1 CA-339648: Refresh user row when the other_config changes so as to show up to date account details. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-06-05 16:58:19 +01:00
Konstantina Chremmou
c9449b9914 CP-33153: Added friendly title and description for GFS2_CAPACITY alert. Corrected scan action description. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-06-05 11:50:49 +01:00
Konstantina Chremmou
89487fcf60 CA-337270: Perform authentication on a background thread. 
- Added controls to display the error in case authentication fails.
- Use the same control(LinkLabel) to show the rubric either when new
  authentication is needed or an existing one can be used.
- Moved privacy policy statement next to the checkbox because it looked crammed.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-06-05 11:48:54 +01:00
Konstantina Chremmou
ec7fc14c18 Typo. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-06-05 11:48:54 +01:00
Konstantina Chremmou
9ec3dc3127 CA-339374: Changed order of control disposal. Also, fixed wrong title of the undocked console. 
Disposing the vncTabView disconnects the RdpClient and should not be called after
base.Dispose() is called on VNCView, because the latter has released the COM objects
and causes an InvalidComObjectException to be thrown.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-06-01 11:10:54 +01:00
Konstantina Chremmou
9087755277 Test corrections. 
- Exclude VNC key map from l10n tests.
- Added parameterless constructors to the archive classes for use by the tests.
- Scalability tests were removed.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-05-26 23:31:06 +01:00
Konstantina Chremmou
6dde286cc5 Stop suppressing code analysis messages. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-05-22 00:19:40 +01:00
Konstantina Chremmou
41afa2a753 CP-32921: Target .NET Framework 4.8 and build using VS2019 tools. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-05-19 23:10:41 +01:00
Konstantina Chremmou
bea9bd2302 Removed unnecessary class. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-05-19 23:10:41 +01:00
Konstantina Chremmou
88fa402e21 Merged the projects XenAdmin and XenCenterVNC. 
Since the standalone VNC control was removed, the VNC code has been used only by
the UI project. According to Microsoft's performance guidelines large single
assemblies are preferable to multiple smaller ones.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-05-19 23:10:41 +01:00
Konstantina Chremmou
ec1aff6c82 Control alignment corrections on the Role Elevation dialog. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-05-19 23:03:45 +01:00
Konstantina Chremmou
8a478011d9 CA-339370: Assign the new VM's name at a late stage to reduce duplicate names. Some simplifications. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-05-19 07:49:23 +01:00
Konstantina Chremmou
7b7e388bb8 Hide errors when the Finish button is clicked again. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-05-19 07:49:23 +01:00
Konstantina Chremmou
7390011634 CA-339371: Use the correct source SR for custom templates. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-05-19 07:42:27 +01:00
Konstantina Chremmou
94eeb1ddf3 CA-338829: Check the clicked item is indeed a ToolstripMenuItem. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-05-18 23:26:55 +01:00
Darren Matthews
1d74094e5a L10N : Translation and Resx Resync 
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
 2020-05-18 15:15:07 +01:00
Konstantina Chremmou
f05b502399 CA-339331: Skip uses deferred execution and needs enumeration. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-05-15 11:38:23 +01:00
Konstantina Chremmou
c0c3929c7a CA-293814: Do not launch the HostEvacuateDialog for a host without running VMs in a single-host pool. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-05-14 23:28:08 +01:00
Konstantina Chremmou
1113b454f4 CA-339326: Do not close per XenObject dialogs for objects other than VMs (they are closed via other paths). 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-05-14 23:28:08 +01:00
Konstantina Chremmou
bd04229d89 CA-339312: Explain why a host cannot be removed from the pool. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-05-12 15:27:12 +01:00
Konstantina Chremmou
a84053cf8d CA-337323 : SR.scan on the SrPicker was happening silently without any indication on the UI (enhanced fix for CA-280299). 
The result was that numbers were changing suddenly; in cases of slow connections,
a user could make a selection before the scan was over.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-05-04 14:30:24 +01:00
Konstantina Chremmou
4949109bf8 CA-337323: SR.scan should be added to the method list of the Import wizard's RBAC page 
Otherwise it is evaluated independently and launches the RoleElevation dialog.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-05-04 14:30:24 +01:00
Konstantina Chremmou
d1c9e7ddd1 CA-337323: Attempt finding the right owning form for the RoleElevation dialog. Also: 
- Simplified SudoElevationResult.
- Renamed SudoDialogDelegate to ElevatedSessionDelegate so that it makes more sense
  for projects not referencing WinForms.
- Call directly the RoleElevationDialog within XenAdmin without using the ElevatedSessionDelegate.
- Minor modernisation in AsyncAction.
- Launch GraphDetailsDialog in a using block.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-05-04 14:30:24 +01:00
Konstantina Chremmou
8d6686b63f CA-337280: Creation of GFS2 SRs with CHAP authentication is not supported. 
This is also a better fix for CA-335356.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-05-01 15:27:18 +01:00
Konstantina Chremmou
5927d52349 CA-336024, CA-322705: Rewrote the LVMoISCI frontend of the NewSR wizard 
This fixes various workflow bugs and disallows re-attaching GFS2 SR if clustering
is disabled.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-05-01 15:27:18 +01:00
Konstantina Chremmou
5b6bd343dd CA-322705: Disallow re-attaching GFS2 SR if clustering is not enabled. Minor refactoring. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-05-01 15:27:18 +01:00
Konstantina Chremmou
fd497a1370 Added outlook style status labels showing the number of various types of notifications. 
The labels are additionally clickable and navigate to the corresponding panel.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-30 08:30:30 +01:00
Konstantina Chremmou
0fa374313f Corrected dialog title. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-30 08:30:30 +01:00
Konstantina Chremmou
bf5c66598c Merge remote-tracking branch 'upstream/master' into feature/REQ-716 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/MainWindow.cs
 2020-04-29 16:47:48 +01:00
Konstantina Chremmou
436ffe4a37 CA-338003: The action's Sessions is set once the action has started to run. Added missing help references. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-27 10:36:51 +01:00
Konstantina Chremmou
17b6c28978 Merged master into feature/REQ-453 and resolved conflicts. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdminTests/UnitTests/TimeUtilTests.cs
#	XenCenterLib/TimeUtil.cs
 2020-04-26 04:11:14 +01:00
Konstantina Chremmou
563b2cc359 CA-338276: Corrected virtualisation state link text for post stockholm linux guests. 
Also, merged the methods calculating the virtualisation status and its friendly
string so as to simplify the logic.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-26 00:03:45 +01:00
Konstantina Chremmou
9bf7e80fe9 Merged branch master into feature/REQ-716 and resolved conflicts. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Dialogs/BallooningDialog.cs
#	XenAdmin/Dialogs/WarningDialogs/InstallToolsWarningDialog.cs
 2020-04-24 15:37:01 +01:00
Konstantina Chremmou
40e395f2bd CA-338273: Accept more ISO 8086 formats. 
Also, move time utility methods to one place (the Util class which contains unit conversions).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-24 14:30:32 +01:00
Konstantina Chremmou
d80bbfb151
Merge pull request #2656 from xenserver/feature/read-caching 
Merge feature/read-caching branch to master
 2020-04-24 11:47:26 +01:00
Konstantina Chremmou
ec86bb39dc Fixed broken build. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-22 22:44:17 +01:00
Konstantina Chremmou
60da6080f9
Refactored three button dialog (#2627) 
* ThreeButtonDialog simplification step1: Help name.
* ThreeButtonDialog simplification step2: Window title.
* ThreeButtonDialog simplification step3: Removed class Details.
* ThreeButtonDialog simplification step4: Removed unnecessary (and wrong) class.
* ThreeButtonDialog simplification step5: Compacted TDButton constructors.
* ThreeButtonDialog simplification step6: Removed purposeless methods.
* ThreeButtonDialog simplification step7: Refactored constructor logic.
* ThreeButtonDialog simplification step8: Icon normalisation.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-22 14:47:03 +01:00
Konstantina Chremmou
dcc87f4710 CP-32713: Show an error message if the user attempts an update using the base installation ISO. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-22 10:33:22 +01:00
Konstantina Chremmou
0ffccc6d03 CA-338184: Check for null before accessing host properties. 
Also, property modernisation.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-21 10:38:15 +01:00
Konstantina Chremmou
fda52da475 Adjusted margins; made label bold because the current server state was not very obvious. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-20 19:07:31 +01:00
Konstantina Chremmou
cf0da96b87 CA-187943: Revised warning messages to take account the selected affinity. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-20 19:07:31 +01:00
Konstantina Chremmou
3c68e7e097 Improved parsing of SMAPIv3 errors. Deprecated Failure method that should not be used directly by the implementation. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-20 18:56:13 +01:00
Mihaela Stoica
7f6877c330
Merge pull request #2652 from xenserver/feature/REQ-811 
Merge feature/REQ-811 into master
 2020-04-20 18:39:37 +01:00
Konstantina Chremmou
f31a8f2085 Some refactoring to memory editing controls. 
Override the polymorphic methods of XenTabPage on the ballooning wizard;
No need to exposed the memory values outside the VMMemoryControlsEdit class.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-17 16:23:06 +01:00
Konstantina Chremmou
d198b693d1 Replaced InstallToolsWarningDialog with a ThreeButtonDialog. Removed methods duplicating command execution logic. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-17 16:23:06 +01:00
Konstantina Chremmou
dfb49c97a1 CP-32687, CP-32689: Remove "Install PV Tools" options from stockholm onwards. 
Replace with help links where necessary or convenient. Also:
- Registered unused event.
- Minor refactoring to: make the InstallToolsCommand.CanExecute clearer; use
  local methods.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-17 16:23:06 +01:00
Konstantina Chremmou
456978e572 CP-32688: Remove guest tools from DVD ISO dropdown for Stockholm onwards 
Also, removed properties that were never set to true.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-17 16:23:06 +01:00
Mihaela Stoica
66d192b1d8 CP-32985: Changes following code review 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2020-04-16 10:26:17 +01:00
Mihaela Stoica
71a09385c3 CP-32985: XenCenter control to turn read caching on / off per SR 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2020-04-16 10:26:17 +01:00
Konstantina Chremmou
c6c725c37d CA-338012: Corrected error messages for RBAC restrictions and intermediate certificate errors. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-15 14:30:00 +01:00
Darren Matthews
bb560db1dc L10N : Resx resync and translation update 
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
 2020-04-08 15:56:46 +01:00
Konstantina Chremmou
0188fdc69b Corrections as per code review. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-08 13:55:35 +01:00
Konstantina Chremmou
e9acde0b64 Try handling a connection interruption. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-08 13:55:35 +01:00
Konstantina Chremmou
79bebdb816 Parse the certificate alert body as xml. Accept more ISO 8086 formats. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-08 13:55:35 +01:00
Konstantina Chremmou
8fc258420d CP-32699: New dialog for certificate installation on a server. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-08 13:55:35 +01:00
Konstantina Chremmou
f0f8f90875 Dispose of X509Certificate2 objects. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-08 13:55:35 +01:00
Konstantina Chremmou
52369c9d0d Removed references to SSL certificates. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-08 13:55:35 +01:00
Konstantina Chremmou
73a7903ddf Move deprecated feature checks closer to the top of the list. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-02 23:39:42 +01:00
Konstantina Chremmou
a8fc37b22b Merge remote-tracking branch 'upstream/master' into feature/REQ-811 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Diagnostics/Checks/Check.cs
#	XenAdmin/Diagnostics/Problems/PoolProblem/PoolHasPVGuestWarningUrl.cs
#	XenAdmin/Diagnostics/Problems/Problem.cs
#	XenAdmin/Diagnostics/Problems/WarningWithMoreInfo.cs
#	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
#	XenAdmin/Wizards/RollingUpgradeWizard/RollingUpgradeWizardPrecheckPage.cs
#	XenAdmin/XenAdmin.csproj
#	XenModel/Messages.Designer.cs
#	XenModel/Messages.resx
 2020-04-02 23:29:54 +01:00
Konstantina Chremmou
03dbf38f6f Merge branch 'master' into feature/REQ-814 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenModel/Messages.Designer.cs
 2020-04-02 10:58:58 +01:00
Konstantina Chremmou
d5035a010d Run LegacySsl , PowerOn mode, and PV Guest checks only if strictly necessary. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-02 10:55:37 +01:00
Konstantina Chremmou
21071ce463 CA-330308: Do not mark the page as changed or save settings before the page is loaded for the first time. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-02 10:55:37 +01:00
Konstantina Chremmou
6c5edddda8 CP-32701: Show certificate expiry alerts. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-01 16:27:13 +01:00
Konstantina Chremmou
fc944784b4 CP-32697: Show certificate metadata on the host's General TabPage. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-01 16:27:13 +01:00
Konstantina Chremmou
3ecd6a4d8b Fixed missing ExpandedChanged event registrations. Tidied up methods toggling the section expanded state. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-01 16:27:13 +01:00
Konstantina Chremmou
8c4af40cf2 Added command and menu item for launching the certificate installation dialog. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-01 16:27:13 +01:00
Konstantina Chremmou
2b3884fa72 Spinner Icon enhancements 
Added failure result; added default values for success and failure images;
renamed method and property; removed duplicate code.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-01 16:27:13 +01:00
Konstantina Chremmou
00e015f2d0 Run vSwitch Controller and PV Guest checks only if strictly necessary. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-01 15:31:36 +01:00
Konstantina Chremmou
8f79c7cf13 CA-336986: Handle server side update precheck for vSwitchController. 
Also, renamed a couple of parameters because the old name was specific to one error.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-01 15:31:36 +01:00
Konstantina Chremmou
974ece8878 CA-337287: Skip legacy protocol and power-on iLO checks with a warning if the RPU hotfix is missing. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-30 10:48:32 +01:00
Konstantina Chremmou
3a35a96530 CP-33294: Remove iLO power on option from XenCenter 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-30 10:48:32 +01:00
Konstantina Chremmou
5406b933fd CA-330308: Rewrote Power-On edit page to fix workflow issues: 
- It was not possible to apply different settings to multiple hosts
at the same time.
- Server calls were made on the UI thread.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-30 10:48:32 +01:00
Konstantina Chremmou
d7ae7a8571 Corrected instruction to match the documentation. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-27 16:49:51 +00:00
Konstantina Chremmou
888a0555ab CA-337287: Skip vSwitch controller and PV guest checks with a warning if the RPU hotfix is missing. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-27 16:47:25 +00:00
Konstantina Chremmou
608f56fe7d CA-336931: Informational problems should not be resolvable. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-18 13:24:22 +00:00
Konstantina Chremmou
862971621b CA-333059: Fixed issue where the updates list was not refreshed for pool slaves after applying an update. 
Also, fixed some performance issues; minor refactoring.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-11 22:22:17 +00:00
Konstantina Chremmou
6c06b08024 Some refactoring and code modernisation. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-11 22:22:17 +00:00
Konstantina Chremmou
44dd03e85f Fixed issue where it was possible to have both View ToolStripMenuItems in unchecked state. 
Also, UX enhancement: added tooltips showing the update alert page URL.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-11 22:22:17 +00:00
Konstantina Chremmou
452edbc496 Fixed broken build. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-10 14:22:59 +00:00
Konstantina Chremmou
fb7f5ef2d0 CA-335356: If the GFS2 probe cannot find devices, do not prevent the user from creating LVMoHBA SRs. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-10 14:00:31 +00:00
Konstantina Chremmou
237da850b8 Moved vSwitch controlller check closer to the top of the check list. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-06 13:15:09 +00:00
Konstantina Chremmou
9e458373b0 Missing copyright; typos found from spell check; added terms to ignore list. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-04 12:40:20 +00:00
Konstantina Chremmou
a07c68a345 CA-334756: Allow detaching and reattaching all types of SRs. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-03 09:30:00 +00:00
Konstantina Chremmou
00cc547aaf Warning and error corrections. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-02 17:46:29 +00:00
Konstantina Chremmou
d3c5769a70 CP-32844: Check and warn if DVSC is configured when updating or upgrading a pool. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-02 17:46:29 +00:00
Konstantina Chremmou
ebcbf9cabc CP-32947: Hide CHIN network type and do not restrict QoS options. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-02 17:46:29 +00:00
Konstantina Chremmou
4ff42f51f3 Modifications on the NewNetwork wizard (includes CA-192746). 
- NetworkDetails page: reworked it to fix NumericUpdown validation and messages (CA-192746).
- SelectNetworkType page: moved warnings closer to the corresponding network types,
  fixed wrong label enabled state and made enablement logic more explicit.
- All pages: property modernisation and control layout tweaks (mostly margins).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-02 17:46:29 +00:00
Konstantina Chremmou
501970dec5 Name explicitly the control to be focused on page load. No need to search through all the controls of the page. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-02 17:46:29 +00:00
Konstantina Chremmou
76ba20205e CA-335633: Prevent crash due to iterating through modified dictionary. Ensure that per-XenObject dialogs closed by the user are removed from the tracking table. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-02-28 13:33:57 +00:00
Konstantina Chremmou
cf633c3d9d Removed duplicate method. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-02-28 13:33:57 +00:00