Commit Graph

43 Commits

Author SHA1 Message Date
Mihaela Stoica
7f466efc85 CA-297086: Changes following code review 2018-10-31 12:06:18 +00:00
Mihaela Stoica
ce79f72622 CA-297086: Improve the function that uploads a server status report, to avoit timeout exceptions
The changes included are:
- use a HttpClient object instead of HttpWebRequest
- use the same FileStream for all the chunk uploads
- retry the chunk upload if it fails (max three tries)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-10-31 12:06:18 +00:00
Konstantina Chremmou
c0af621167 A couple of random corrrections on error handling (#2265)
* Correct out of range percentage and throw an assertion instead of silently
logging it so we can fix the causes of it. Compacted method logic.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* Exception handling: prevent InvalidOperationException if the health check service
is not found on the computer (installation is optional).
Do not throw exception and handle if the task handle is invalid, but rather
throw it only for other cases of task.status being failure.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-12 13:36:44 +01:00
liulinC
7be8bd0530 CA-204242: save the server status report blocks xencenter (#2158)
* CA-204242: save the server status report blocks xencenter

Signed-off-by: Lin Liu <lin.liu@citrix.com>
2018-08-03 09:08:47 +01:00
Konstantina Chremmou
fb8434819d Namespace tidy 3/several: replaced XenAdmin.Core (instances in XenCenterLib) with XenCenterLib.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-11-30 13:56:32 +00:00
Konstantina Chremmou
ae22560ce8 Converted all extension get properties of the API classes to methods in order to
prevent them from being serialised alongside the API properties. This will also
be useful for moving the API bindings out of XenModel.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-03 03:35:30 +01:00
Mihaela Stoica
713f84cf54 CP-22472: Add new XenCenter metadata file to the server status report: changes following code review
- Added more items to the metadata; the content is now slightly different between the SSR produced in XenCenter and the one from the HealthCheck;
- Encode the metadata string before sending it to the Health Check;
- Always suppress history for the action that sends the proxy settings;
- Renamed some of the new classes;
- Also refactored the actions that send data to the HealthCheck service.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-07-03 17:25:04 +01:00
Mihaela Stoica
54ab9307d2 CP-22472: Add new XenCenter metadata file to the server status report
- XenCenter sends its telemetry info to the HealthCheck service
- The HealthCheck service saves this metadata in its settings file and includes it in the health check upload

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-07-03 17:25:04 +01:00
Gabor Apati-Nagy
f1a20c279e Merge pull request #1603 from MihaelaStoica/CA-253936
CA-253936: Fix proxy authentication in the XenServerHealthCheck service
2017-05-31 14:37:02 +01:00
Mihaela Stoica
f9b7f71b18 Fix the HealthCheck tests - cont.
- restore the "empty credential" test and update HealthCheck to ignore null or empty username and password
- also update XenCenter so it doesn't send null or empty username and password

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-26 16:54:38 +01:00
Mihaela Stoica
ad6631f698 CA-253936: Fix proxy authentication in the XenServerHealthCheck service
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-23 16:57:38 +01:00
Konstantina Chremmou
489d8684e4 Merge remote-tracking branch 'upstream/master' into CAR-2214
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	Branding/branding.sh
#	mk/archive-unsigned.sh
#	mk/build.sh
#	mk/bumpBuildNumber.sh
#	mk/copy-build-output.sh
#	mk/declarations.sh
#	mk/tests-checks-cover.sh
#	mk/tests-checks.sh
2017-01-24 14:46:57 +00:00
Konstantina Chremmou
88b4104dac Moved the ProxyAuthenticationMethod enum to the HTTP class so the VNCControl can compile.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-01-20 14:47:04 +00:00
Gabor Apati-Nagy
7c0bc50b4a CA-176169: Changed copyright statements to include the comma in Citrix Systems,
Inc.

Signed-off-by: Gabor Apati-Nagy<gabor.apati-nagy@citrix.com>
2017-01-16 19:59:50 +00:00
Frezzle
3522e2980d [CP-19111] Added ability to choose Basic or Digest authentication for proxy server
2 new radio buttons in Connection Options page, for Basic and Digest; Digest is the default as it's the most secure.
New proxy authentication method setting, which is used to configure XenAPI's HTTP class and the .NET AuthenticationManager (which handles which authentication schemes can be used by the .NET web classes).
The new setting is also transferred and used by the Health Check service.

The bug noted in CA-214653 also occurs here, but the work-around on PR#1201 for that bug will also work for this.

Signed-off-by: Frezzle <frederico.mazzone@citrix.com>
2016-10-12 19:09:35 +01:00
Frezzle
be94dc2f45 [CA-213410] XenCenter ignores proxy settings in some places
Assigned Proxy property in all WebClient, WebRequest and HttpWebRequest instances.
Removed "proxy not supported" message from Download Appliance dialog, since the download does work with a proxy.

Signed-off-by: Frezzle <frederico.mazzone@citrix.com>
2016-06-27 17:59:02 +01:00
Frederico Mazzone
9fa8740cb9 [CP-17401] Use Proxy authentication in Health Check Service
Removed last bits of code relating to "Bypass proxy server for local addresses" option.
New proxy settings are sent from XenCenter to health check service and used to configure the proxy using GetProxyFromSettings().
Health check service now correctly saves its proxy settings and updates the static Proxy property for the Session class; done in new ReconfigureConnectionSettings().

Signed-off-by: Frederico Mazzone <fredericom@citrite.net>
2016-06-22 13:05:21 +01:00
Mihaela Stoica
fe56eb3444 CA-206761: Health Check shows "No issues found" when the report analysis is not yet available
- updated the url

Signed-off-by: Mihaela Stoica <Mihaela.Stoica@citrix.com>
2016-04-22 12:19:20 +01:00
Mihaela Stoica
8f63854b96 CA-206761: Health Check shows "No issues found" when the report analysis is not yet available
Changes following code review

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-04-11 15:57:32 +01:00
Mihaela Stoica
7e832494c1 CA-206761: Health Check shows "No issues found" when the report analysis is not yet available
- Try to get the analysis progress from cis (as an integer value representing percentage 0 - 100). If this function returns a valid progress less than 100, then we don't try to get the report analysis and continue to display "Analysis not yet available"
- If the progress is 100 then we get the analysis result and display it
- If the progress cannot be obtained, then we try to get the analysis result; If an empty result is obtained within 10 minutes from the upload completion, then we assume that the analysis is still in progress and continue to display "Analysis not yet available"

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-04-08 14:26:52 +01:00
Mihaela Stoica
9c9312c113 CA-204172: Switch Health Check URLs to the production site
Also use 0 (never expire) for the diagnostic token.

Signed-off-by: Mihaela Stoica <Mihaela.Stoica@citrix.com>
2016-03-16 10:00:23 +00:00
Rob Hoes
1de9f35566 CA-192640: Don't log exceptions when HealthCheck service is not installed (part 2)
Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
2016-01-20 14:47:39 +00:00
Rob Hoes
f5a12452ca CA-192640: Don't log exceptions when HealthCheck service is not installed
Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
2016-01-14 13:52:20 +00:00
Gabor Apati-Nagy
d79351a8f4 CA-187909: Special characters should be UrlEncoded on HTTP calls
A bit of refactoring

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2015-11-23 14:47:28 +00:00
Gabor Apati-Nagy
104d5554fb CA-187909: Special characters should be URLencoded on HTTP calls
UrlEncoded all the strings that are used to create URLs. (Such as untrusted user input: string fileName)

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2015-11-16 17:50:43 +00:00
Mihaela Stoica
0963f8ccd2 CA-186234: Group the issues found in a pool when retrieving CIS analysis results for a pool
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-11-06 15:01:31 +00:00
Mihaela Stoica
af7852c7a0 CA-180576: Provide a option to give case number when uploading a report from the Server Status Report wizard
- added Case Number edit box on the Destination page of the wizard
- valid case number needs to be 9 or less digits

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-11-03 15:48:14 +00:00
Hui Zhang
50c2f588d7 CA-185063: Health Check Service: Filename is missed in CIS report.
Add status report filename in the CIS Upload URL.

Signed-off-by: Hui Zhang <hui.zhang@citrix.com>
2015-10-09 15:55:59 +08:00
Mihaela Stoica
2766a18987 Use the ToString() function directly for enum-to-string conversions
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-09-15 13:55:18 +01:00
Mihaela Stoica
23db625d15 Change the validity period of the diagnostic token to one year.
- This is temporary, until the API accepts max_age=0 (never expire)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-09-10 15:29:35 +01:00
Carmen Agimof
cd4281ffab Merge pull request #651 from MihaelaStoica/CP-13077
CP-13077: Changes to the Health Check feature to work properly with RBAC
2015-09-09 13:16:15 +01:00
Mihaela Stoica
62bc632f02 CP-13074: Update the URLs used for retrieving the analysis results 2015-09-07 17:58:53 +01:00
Mihaela Stoica
53b01c425c CP-13077: Changes to the Health Check feature to work properly with RBAC
Changed all the health check actions to perform the necessary role checks
- HealthCheckAuthenticationAction: changed so it does not save the tokens, so no role checks required in this action (all the checks are performed in SaveHealthCheckSettingsAction)
- GetHealthCheckAnalysisActions: added role checks

On the Health Check Overview dialog, a pool is displayed as read-only if connected as a user with roles that don't permit changing the health check settings:
- the following actions are not available: enroll, edit settings, disable health check, request upload, get analysis result
2015-09-03 11:49:53 +01:00
Mihaela Stoica
e38c707ffb CP-12156: Removed unused variable
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-08-27 01:04:56 +01:00
Mihaela Stoica
2eba1c705f Merge remote-tracking branch 'upstream/master' into CP-12156_2
Conflicts:
	XenModel/XenAPI-Extensions/Pool.cs
	XenModel/XenModel.csproj
2015-08-27 01:03:58 +01:00
Mihaela Stoica
44e18df03d CP-12156: Obtain and display the result of the CIS analysis of the last uploaded report
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-08-27 00:30:02 +01:00
Hui Zhang
0761aa5be2 CP-13848: XenCenter transfers proxy settings to HealthCheckService.
Signed-off-by: Hui Zhang <hui.zhang@citrix.com>
2015-08-25 20:32:58 +08:00
Mihaela Stoica
ff64416407 Move HealthCheckSettings class to a separate file
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-08-21 15:19:24 +01:00
Mihaela Stoica
cb35725dd7 CP-13074: Finalize the CIS domain names and product key used for retrieving the authentication tokens and upload
- change the URLs to the production site
- for development and testing these settings should be changed to the staging site via registry keys

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-08-20 16:59:58 +01:00
Hui Zhang
aef05ab064 CP-13072: HealthCheckService: Use proxy for bundle upload.
Signed-off-by: Hui Zhang <hui.zhang@citrix.com>
2015-08-17 15:54:19 +08:00
Cheng Zhang
3f2e8a51da CA-179369: Change CIS default setting
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2015-08-11 16:09:45 +08:00
Mihaela Stoica
f6c477eb67 Merge remote-tracking branch 'hui/CA-178338' into CP-13073 2015-07-30 10:31:38 +01:00
Mihaela Stoica
61b5821e4f CP-13073: Rename files (Call Home to Health Check)
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-07-29 09:12:46 +01:00