Commit Graph

38 Commits

Author SHA1 Message Date
Konstantina Chremmou
6dde286cc5 Stop suppressing code analysis messages.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-22 00:19:40 +01:00
Konstantina Chremmou
576d2d5a83 CA-271455 regression: clean temporary OVF packages extracted from OVAs, but not original OVF packages.
Also, remove obsolete lines that delete touch files (they are not created any more).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-01-29 10:07:36 +00:00
Konstantina Chremmou
bfc8141391 CA-318468, CA-271455: Reworked OVF validation and OVA package extraction during import.
- Handle validation for OVF files with a name different from the containing
  OVA package. Other corrections to wrong validation logic.
- Show validation warnings on a dialog that can be turned off.
- Clean up extracted files after an OVA package has been imported.
- Plus code refactoring and simplification.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-01-16 16:26:30 +00:00
Konstantina Chremmou
9cfb714322 CA-330814: Code clean-up in the XenOvfTransport project.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-19 09:20:14 +00:00
Konstantina Chremmou
072397ac2a Refactoring and deletion of dead code.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:44 +00:00
Konstantina Chremmou
ed30f1e3c3 Do not use audit or trace log.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:44 +00:00
Konstantina Chremmou
667e9e8caf Log the stack trace when an exception is encountered and don't use the *Format() counterpart of the logging method for it.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:44 +00:00
Konstantina Chremmou
fad80c778b Avoid duplicate logging; compact multiple logging calls.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:44 +00:00
Konstantina Chremmou
f4265732ca Do not localise log entries or ellipsise names. Log exception stack traces where applicable.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:44 +00:00
Konstantina Chremmou
667848fef3 CA-329686: Do not fail the import if calling a hard shutdown on the fixed up VM fails; the VM may already be halted.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-11 11:46:21 +00:00
Lin Liu
eb309a1af2 CA-329435: Multiple vGPU settings are not preserved when importing OVA/OVF format file
Signed-off-by: Lin Liu <lin.liu@citrix.com>
2019-11-07 09:49:54 +00:00
Aaron Robson
fbb8864a51
Merge pull request #2276 from xenserver/master
Merge master into feature branch
2018-10-18 15:08:54 +01:00
Konstantina Chremmou
3f2c1ea204 If a disk image import failed, XenCenter did not release its handle on the directory containing the image.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 12:33:04 +01:00
Tim Liu
0b9c2f4f96 CP-28678: XC: Import UEFI OVFs correctly
Add comment for the unusual function usage

Signed-off-by: Tim Liu <tim.liu@citrix.com>
2018-08-29 10:54:37 +01:00
Tim Liu
25c0787238 CP-28677: XC: Exported OVFs contain UEFI metadata
1. Add count check
2. Refine the code by linq (both export & import)
3. Create new desc rather than using the generic one
4. Add backward compatibility when importing

Signed-off-by: Tim Liu <tim.liu@citrix.com>
2018-08-28 10:42:48 +01:00
Tim Liu
92d786d051 CP-28677: XC: Exported OVFs contain UEFI metadata
Extended xenBootOrder to xenBootParams

Signed-off-by: Tim Liu <tim.liu@citrix.com>
2018-08-28 10:42:48 +01:00
Konstantina Chremmou
9e43369ac1 Language level upgrade: removed params array creation.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-02-22 13:31:02 +00:00
Konstantina Chremmou
fb2defccbe CA-283697 part5: Create a new VBD and VM record, assign the necessary fields,
and only update the necessary fields from the OVF values; this is preferrable
to using the constructor from the Hashtable because the latter requires
unnecessary conversions to and from strings, and also fields missing from the
Hashtable are reset to null. Hardcoded strings are also error prone: the VBD
class does not have any field such as 'attachable' or 'vm_name_label' and the
fields 'storage-lock' and 'status-code' are in reality called 'storage_lock'
and 'status_code'.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-02-22 13:31:02 +00:00
Konstantina Chremmou
5494436040 CA-283697 part3: Create a new VBD record and assign the necessary fields
instead of using the constructor from the Hashtable because this requires
unnecessary conversions to and from strings, and also fields missing from the
Hashtable are reset to null. Hardcoded strings are also error prone: the VBD
class does not have fields such as 'attachable' or 'vm_name_label'.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-02-22 13:31:02 +00:00
Konstantina Chremmou
cdf9aec33b CA-283697 part2: Create a new VDI record and assign the necessary fields
instead of using the constructor from the Hashtable because this requires
unnecessary conversions to and from strings, and also fields missing from the
Hashtable are reset to null. Hardcoded strings are also error prone: the VDI
class has the field 'sharable', not 'shareable'.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-02-22 13:31:02 +00:00
Konstantina Chremmou
edf968b27c CA-283697 part1: Create a new VIF record and assign the necessary fields,
instead of using the constructor from the Hashtable because this requires
unnecessary conversions to and from strings and also fields missing from the
Hashtable are reset to null.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-02-22 13:31:02 +00:00
Konstantina Chremmou
63c6b817d5 CA-40854: The Session's uuid is in reality its opaque_ref. Use the opaque_ref so
it's obvious what it is. The Session's uuid will be deprecated from the API bindings.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-02-21 14:08:01 +00:00
Gabor Apati-Nagy
08ad3b107f CA-240234: PVS proxy setup is not preserved accross OVF export/import
Implemented export/import of PVS cache/site setting of a vm for OVF

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-03-03 18:27:59 +00:00
Konstantina Chremmou
489d8684e4 Merge remote-tracking branch 'upstream/master' into CAR-2214
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	Branding/branding.sh
#	mk/archive-unsigned.sh
#	mk/build.sh
#	mk/bumpBuildNumber.sh
#	mk/copy-build-output.sh
#	mk/declarations.sh
#	mk/tests-checks-cover.sh
#	mk/tests-checks.sh
2017-01-24 14:46:57 +00:00
Gabor Apati-Nagy
7c0bc50b4a CA-176169: Changed copyright statements to include the comma in Citrix Systems,
Inc.

Signed-off-by: Gabor Apati-Nagy<gabor.apati-nagy@citrix.com>
2017-01-16 19:59:50 +00:00
Frederico Mazzone
f964fa88c6 Merge branch 'master' into CAR-2214
Conflicts:
	XenAdmin/Core/Registry.cs
	XenModel/Actions/Updates/DownloadUpdatesXmlAction.cs
2016-12-23 14:10:43 +00:00
Konstantina Chremmou
3a2444ea49 CA-226817: Do not allow OVF/OVA import on a host incompatible with the VM's hardware
platform version. Also, preserve between export and import the VM's has_vendor_device settings.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-27 16:03:16 +01:00
Frezzle
be94dc2f45 [CA-213410] XenCenter ignores proxy settings in some places
Assigned Proxy property in all WebClient, WebRequest and HttpWebRequest instances.
Removed "proxy not supported" message from Download Appliance dialog, since the download does work with a proxy.

Signed-off-by: Frezzle <frederico.mazzone@citrix.com>
2016-06-27 17:59:02 +01:00
Stephen Turner
b587ab832e CP-14647: Intermediate check-in #1 2015-11-08 11:27:56 +00:00
Konstantina Chremmou
b191cf5522 Made XenOvfApi project use log4net for logging (before it was using own logging,
leftover from the time when the OVF wizards were a XenCenter plugin; the latter
has now been removed).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2014-01-06 12:31:19 +00:00
Konstantina Chremmou
74d7e0df20 CA-122175: Exclude GPU_groups without any supported vgpu types when assiging a group
to an imported VM.
# HG changeset patch
# User Konstantina Chremmou <Konstantina.Chremmou@citrix.com>
# Date 1385721396 0
#      Fri Nov 29 10:36:36 2013 +0000
# Node ID 2647a9bff529b2c4e6126f7da2f8e5214d5cedd7
# Parent  a4d8eab0dfd7b86ba4d740ee033463a669f80e27

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-12-11 10:31:47 +00:00
Konstantina Chremmou
b95dcf2237 CA-122644: Fixes issue where a vmware package was not detected as such and hence
the import crashed. Some missing null checks.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-12-02 12:37:35 +00:00
Konstantina Chremmou
c843f5b867 CP-6511: Ovf import/export for vGPU enabled VMs.
# HG changeset patch
# User Konstantina Chremmou <Konstantina.Chremmou@citrix.com>
# Date 1384181202 0
#      Mon Nov 11 14:46:42 2013 +0000
# Node ID 6810ba763a896bcf7dd4295f30c6d5f42b02e9de
# Parent  37666849a54470e0da04b8d14c17940f8b580636

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-11-14 12:29:30 +00:00
Konstantina Chremmou
ed88db2df0 Fixed two potential null reference exceptions in the XenOvfTransport project and
removed uninitialised streams which we were taking care to close. Solution-wide
style: use string.IsNullOrEmpty method instead of checking separately for null
and zero length.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-09-26 08:30:34 +01:00
Konstantina Chremmou
809256c375 Made XenOvfTransport project use log4net for logging (before it was using own logging,
leftover from the time when the OVF wizards were a XenCenter plugin; the latter
was not printing output into the XenCenter.log file, thus causing us to miss info).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-09-26 08:30:32 +01:00
Konstantina Chremmou
50e95a0416 Removed unused constructors. Made XenSession a protected readonly field. Removed
field _OwnSession as it was never set to true.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-09-26 08:30:30 +01:00
Konstantina Chremmou
19a7fcdcfb Code readability: removed empty placeholders for XML documentation from the XenOvfTransport project.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-09-26 08:30:28 +01:00
Mihaela Stoica
bd36a85bff CP-4816: Initial commit to git repo
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2013-06-24 12:41:48 +01:00