Commit Graph

2239 Commits

Author SHA1 Message Date
Konstantina Chremmou
8fb44a55cb Added flag VM.VirtualisationStatus.NOT_INSTALLED to replace value 0 for clarity.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-30 10:42:20 +01:00
Konstantina Chremmou
2755f71dcf CA-341423: Added a new filter value for VMs with only the management agent installed so they can be easier to find.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-30 10:42:20 +01:00
Konstantina Chremmou
e30ea433c7 Refactoring to simplify the code and make calculations more efficient:
Removed unnecessary abstractions. Replaced named delegates with anonymous ones.
Use pattern matching and avoid multiple casts. Be consistent in the properties
we check.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-30 10:42:20 +01:00
Konstantina Chremmou
5526a3f7d1 CP-34045: Removed max resolution and max displays columns.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-28 10:01:09 +01:00
Aaron Robson
05c8809539 CP-34000: decimal network and disk access rate unit calculations
Though this was shown in units like kB/s and MB/s (decimal units) it was calculated in
binary terms i.e. 1MB/s was treated as 1024kB/s instead of the expected 1000kB/s.

Updated translations for the units to be of the form 'MB/s' instead of 'MBps'.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2020-07-18 07:55:34 +01:00
Konstantina Chremmou
d08f02cce2 CP-20425: Added test to ensure all Resource images have a static counterpart.
Also, stop boxing Bitmap into Image so as to avoid casting wherever it is called.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-18 07:49:27 +01:00
Konstantina Chremmou
a2596ec201
Merge pull request #2711 from xenserver/dotnet48
Merge branch dotnet48 into master
2020-07-07 12:10:46 +01:00
Konstantina Chremmou
6b168f0e6e CA-341778: Missing entries from distros treated as Linux.
Also, moved the list to the VM class so it can be kept up to date when new guests are added.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-07 09:24:55 +01:00
Konstantina Chremmou
6bf1f7c23c Fixed broken tests and corrected assertion handling in the Jenkinsfile.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-02 09:27:26 +01:00
Konstantina Chremmou
0199e1e73e Latest SDK.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-06-29 12:41:24 +01:00
Konstantina Chremmou
f3c5e74dae CP-33892: Audited the use of First() and replaced with FirstOrDefault() where appropriate.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-06-25 11:17:11 +01:00
Konstantina Chremmou
c14184919d Extended disk latency regex and added unit tests.
Also made a small addition to a past test as per code review.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-06-23 08:51:41 +01:00
Konstantina Chremmou
db041099ef CA-339271: Improved action description. Also:
Added cancelling ability to MoveVM action; made some simplifications.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-06-19 14:04:59 +01:00
Talons Lee
b09d3cb8e7 CP-33715: add gooroom os icon
Signed-off-by: Talons Lee <xin.li@citrix.com>
2020-06-15 22:37:50 +01:00
Konstantina Chremmou
d045d180a0
Merge pull request #2696 from xenserver/master
Bring branch dotnet48 up to date with master
2020-06-15 15:43:52 +01:00
Darren Matthews
00b6fdc8e3 L10N: Translation and Resx Resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2020-06-11 13:57:12 +01:00
Konstantina Chremmou
acd3094b48 CA-314005: Proceed to setting the memory if the issued shutdown has been interrupted by a different shutdown task.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-06-10 23:48:54 +01:00
Konstantina Chremmou
c9449b9914 CP-33153: Added friendly title and description for GFS2_CAPACITY alert. Corrected scan action description.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-06-05 11:50:49 +01:00
Konstantina Chremmou
ec7fc14c18 Typo.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-06-05 11:48:54 +01:00
Konstantina Chremmou
797605d2e7 CA-339526: Updated API bindings.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-29 14:53:54 +01:00
Konstantina Chremmou
cae3796887 CA-339526: Ignore classes that are present in the database but not exposed in the SDK.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-29 14:53:54 +01:00
Konstantina Chremmou
ffcc069aa1 CA-339526: New API bindings.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-28 18:02:42 +01:00
Konstantina Chremmou
4f4217a2b1 CA-339685: Corrected calculation of completion percentage and added checks for division by zero.
Also, some simplifications and removal of unused variables and fields.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-22 00:25:56 +01:00
Konstantina Chremmou
64aa4e730b CA-339237: Show more information in XenCenter's logs on why a patch or update may have failed to apply.
Also, ensure the Failure.ErrorDescription property is always initialised.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-22 00:19:40 +01:00
Konstantina Chremmou
41afa2a753 CP-32921: Target .NET Framework 4.8 and build using VS2019 tools.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-19 23:10:41 +01:00
Konstantina Chremmou
166fe0ecc5 CA-333443: Use the master's address instead of the connection name when joining a pool.
Also, moved code handling RBAC failure from the Failure class into the
PoolJoinAction because it is pretty specific to the latter action.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-19 23:03:45 +01:00
Konstantina Chremmou
d8cbf38cd8 CA-339306: Warn the user that removing a server from a pool removes also domain information.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-19 13:25:53 +01:00
Konstantina Chremmou
fc9d617f27 CA-338830: Pool join checks should not allow slave with enabled clustering to join.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-19 13:25:53 +01:00
Konstantina Chremmou
8a478011d9 CA-339370: Assign the new VM's name at a late stage to reduce duplicate names. Some simplifications.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-19 07:49:23 +01:00
Darren Matthews
1d74094e5a L10N : Translation and Resx Resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2020-05-18 15:15:07 +01:00
Konstantina Chremmou
f05b502399 CA-339331: Skip uses deferred execution and needs enumeration.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-15 11:38:23 +01:00
Konstantina Chremmou
bd04229d89 CA-339312: Explain why a host cannot be removed from the pool.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-12 15:27:12 +01:00
Konstantina Chremmou
a84053cf8d CA-337323 : SR.scan on the SrPicker was happening silently without any indication on the UI (enhanced fix for CA-280299).
The result was that numbers were changing suddenly; in cases of slow connections,
a user could make a selection before the scan was over.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-04 14:30:24 +01:00
Konstantina Chremmou
d1c9e7ddd1 CA-337323: Attempt finding the right owning form for the RoleElevation dialog. Also:
- Simplified SudoElevationResult.
- Renamed SudoDialogDelegate to ElevatedSessionDelegate so that it makes more sense
  for projects not referencing WinForms.
- Call directly the RoleElevationDialog within XenAdmin without using the ElevatedSessionDelegate.
- Minor modernisation in AsyncAction.
- Launch GraphDetailsDialog in a using block.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-04 14:30:24 +01:00
Konstantina Chremmou
8d6686b63f CA-337280: Creation of GFS2 SRs with CHAP authentication is not supported.
This is also a better fix for CA-335356.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-01 15:27:18 +01:00
Konstantina Chremmou
5927d52349 CA-336024, CA-322705: Rewrote the LVMoISCI frontend of the NewSR wizard
This fixes various workflow bugs and disallows re-attaching GFS2 SR if clustering
is disabled.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-01 15:27:18 +01:00
Konstantina Chremmou
fd497a1370 Added outlook style status labels showing the number of various types of notifications.
The labels are additionally clickable and navigate to the corresponding panel.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-30 08:30:30 +01:00
Konstantina Chremmou
0fa374313f Corrected dialog title.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-30 08:30:30 +01:00
Konstantina Chremmou
bf5c66598c Merge remote-tracking branch 'upstream/master' into feature/REQ-716
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/MainWindow.cs
2020-04-29 16:47:48 +01:00
Konstantina Chremmou
436ffe4a37 CA-338003: The action's Sessions is set once the action has started to run. Added missing help references.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-27 10:36:51 +01:00
Konstantina Chremmou
17b6c28978 Merged master into feature/REQ-453 and resolved conflicts.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdminTests/UnitTests/TimeUtilTests.cs
#	XenCenterLib/TimeUtil.cs
2020-04-26 04:11:14 +01:00
Konstantina Chremmou
563b2cc359 CA-338276: Corrected virtualisation state link text for post stockholm linux guests.
Also, merged the methods calculating the virtualisation status and its friendly
string so as to simplify the logic.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-26 00:03:45 +01:00
Konstantina Chremmou
9bf7e80fe9 Merged branch master into feature/REQ-716 and resolved conflicts.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Dialogs/BallooningDialog.cs
#	XenAdmin/Dialogs/WarningDialogs/InstallToolsWarningDialog.cs
2020-04-24 15:37:01 +01:00
Konstantina Chremmou
40e395f2bd CA-338273: Accept more ISO 8086 formats.
Also, move time utility methods to one place (the Util class which contains unit conversions).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-24 14:30:32 +01:00
Konstantina Chremmou
d80bbfb151
Merge pull request #2656 from xenserver/feature/read-caching
Merge feature/read-caching branch to master
2020-04-24 11:47:26 +01:00
Konstantina Chremmou
dcc87f4710 CP-32713: Show an error message if the user attempts an update using the base installation ISO.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-22 10:33:22 +01:00
Konstantina Chremmou
cf0da96b87 CA-187943: Revised warning messages to take account the selected affinity.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-20 19:07:31 +01:00
Konstantina Chremmou
3c68e7e097 Improved parsing of SMAPIv3 errors. Deprecated Failure method that should not be used directly by the implementation.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-20 18:56:13 +01:00
Mihaela Stoica
7f6877c330
Merge pull request #2652 from xenserver/feature/REQ-811
Merge feature/REQ-811 into master
2020-04-20 18:39:37 +01:00
Konstantina Chremmou
d198b693d1 Replaced InstallToolsWarningDialog with a ThreeButtonDialog. Removed methods duplicating command execution logic.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-17 16:23:06 +01:00