Commit Graph

761 Commits

Author SHA1 Message Date
Konstantina Chremmou
8375754a5b CP-40407: Removed fakeAPI and usage of XmlRpcProxy classes in the application.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-03-31 14:17:55 +01:00
Konstantina Chremmou
dfeb347485 Removed integrated storage link code. The feature was removed long ago.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-03-30 16:38:56 +01:00
Danilo Del Busso
65da63755f
[master] CA-375556: Pass non-compressed file stream to HTTP.CopyStream (#3115)
* CA-375556: Pass non-compressed file stream to `HTTP.CopyStream`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CA-375556: Use `sourcefile` instead of `filePath`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

---------

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-03-24 10:24:10 +00:00
Konstantina Chremmou
488f27e2ae Revised Rbac checks for addition/removal of custom fields.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-28 21:25:02 +00:00
Konstantina Chremmou
423ee7bd81 Added RBAC checks to the actions adding/removing custom fields. Also:
- Converted them to proper AsyncActions to facilitate further refactoring.
- Moved SaveCustomFieldsAction to the same folder as the above.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-28 21:03:15 +00:00
Konstantina Chremmou
87ff42086f Missing RBAC permission checks for CreateDiskAction.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-28 15:36:13 +00:00
Konstantina Chremmou
8c42b0428e Refactored the actions creating disks.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-28 15:36:13 +00:00
Danilo Del Busso
ea9669ce1b
CP-42186: Update XML tag name in DownloadUpdatesXmlAction
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-22 10:30:05 +00:00
Konstantina Chremmou
c70116691a Corrections as per code review:
- Bumped branding to v4.11.
- Reverted VS version in the solution file.
- Removed brand override registry entry.
- Converted HealthCheck warning pop-up to info pop-up.
- Moved status report actions to a separate folder.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-21 16:05:10 +00:00
Konstantina Chremmou
7063b3e130 CP-42155: Removed HealthCheck service and related dialogs.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-21 16:05:09 +00:00
Danilo Del Busso
39b84bbcc5 CA-375282: Insert sanitised TARs into Temp folder
Avoids permission related exceptions

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-17 11:50:33 +00:00
Danilo Del Busso
653d66cb10 CP-40842: Report host action as failed when connection isn't possible
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-14 11:26:17 +00:00
Konstantina Chremmou
f885be7e4d
Merge pull request #3094 from xenserver/feature/vtpm
Merge feature/vtpm into master
2023-02-13 15:33:50 +00:00
Danilo Del Busso
6f6bddd755
CP-40842: Remove CIS upload from Server Status Report wizard (#3087)
* Remove credentials controls from `BugToolPageDestination`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* Explicitly call dispose in `BugToolPageDestination.cs`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* Tidy up code in `BugToolPageDestination.cs`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* Move `StatusReportRow` to its own file

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* Move `ClientSideDataRow` and `HostStatusRow` to own files

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CP-40842: Update order of pages in `BugToolWizard`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CP-40842: Update action and create row for packaging status report in BugTool wizard

Instead of creating a new action, this males ZipStatusReportAction inherit StatusReportAction

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CP-40842: Allow for pending `StatusReportAction` to be cancelled

This avoids the need for a running action to update the status. i.e. an action that has been registered but hasn't started running can be cancelled, too.

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CP-40842: Update content of `ACTION_SYSTEM_STATUS_SUCCESSFUL` message

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CP-40842: Add link to `labelBlurb` in `BugToolPageRetrieveData.cs`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CP-40842: Add report packaging logic to `BugToolPageRetrieveData.cs`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CP-40842: Open CIS URL when clicking on `linkLabelBlurb`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CP-40842: Report packaged data amount in `ZipStatusReportAction`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* Remove unused `using`s

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* Minor layout tweaks.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Renamed folder and namespace to match the ones for the other wizards.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Renamed wizard's private fields. Some code efficiency corrections.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Keep the row classes as private within the BugToolPageRetrieveData class.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Removed leftover unused action.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Tidy up status report messages. Use more relevant icon.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Made blurb localisable.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Renamed private fields.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Simplified the stages of the compilation of the status report.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Renamed row classes again to match the action names.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Simplify reporting the progress of the zipping action.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Recursive call is not necessary. Tweaked message.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* Sort strings

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* Update copyright notices

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

---------

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Co-authored-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
Co-authored-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2023-02-13 13:47:21 +00:00
Konstantina Chremmou
a4ddce63c6 Merge remote-tracking branch 'upstream/feature/rebrand'
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenModel/Actions/Pool/SyncDatabaseAction.cs
#	XenModel/Actions/PureAsyncAction.cs
#	XenModel/Actions/VM/VMSuspendAction.cs
#	XenModel/XenServerProxy/RbacCollectorProxy.cs
2023-02-08 16:41:07 +00:00
Konstantina Chremmou
f30afbe1d2 XSI-1362/CA-373773: Reworked the logic for selecting boot mode when creating a VM.
The new logic takes also account of platform:secure-boot=auto.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-31 16:20:13 +00:00
Konstantina Chremmou
439d29d9c3 Don't make server requests in the body of a property. Some minor code smells.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-31 16:20:13 +00:00
Konstantina Chremmou
86c39a559a
Merge pull request #3077 from kc284/pureAsyncAction
Stop using PureAsyncAction and RbacCollectorProxy for RBAC checks on actions.
2023-01-31 12:20:47 +00:00
Konstantina Chremmou
d7b519a53c Updated copyright notice on files.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-30 16:24:16 +00:00
Konstantina Chremmou
34ca86fed7 Corrections as per code review.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-26 00:15:57 +00:00
Konstantina Chremmou
fbe8c60336 Merge remote-tracking branch 'upstream/feature/vtpm'
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

# Conflicts:
#	XenAdmin/MainWindow.cs
#	XenAdmin/Properties/Resources.resx
#	XenModel/Utils/Helpers.Versions.cs
#	XenModel/XenAPI/Pool.cs
2023-01-10 15:17:23 +00:00
Konstantina Chremmou
d46722c6eb Renamed method adding an RbacMethod with key because it was very easy to use it for adding a list of RbacMethods instead.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-04 22:10:18 +00:00
Konstantina Chremmou
7ec581eb95 Stop using PureAsyncAction and RbacCollectorProxy for RBAC checks on actions.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-04 21:27:42 +00:00
Konstantina Chremmou
6dd175eab0 Fixed exception thrown by actions without an API task (typically actions running synchronous calls).
Also, catch and log all exceptions and Failures.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2022-12-14 01:00:54 +00:00
Konstantina Chremmou
92e66a2eed
Merge pull request #3068 from kc284/ionic
Removed dependency on IonicZip.
2022-12-14 01:00:23 +00:00
Konstantina Chremmou
e29b8b39d5 Removed dependency on IonicZip. Use the corresponding classes of .NET Framework.
Also renamed the archive classes because they were named after the 3rd
party library used and were confusing.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-11-18 16:53:30 +00:00
Konstantina Chremmou
8804038dc4 Removed code for bz2 because it has never been used/exposed in the UI.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-11-18 12:20:59 +00:00
Konstantina Chremmou
a98d516bbe Removed delegate definitions and some unused code.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-11-17 14:49:35 +00:00
Konstantina Chremmou
9e00a633f3 Create vTPMs as non-unique by default. Added title and description to create/destroy vTPM actions.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-09-09 11:58:15 +01:00
Konstantina Chremmou
bbc4ccdd52 Allow vTPM assignment when creating a VM.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-09-09 11:58:15 +01:00
Konstantina Chremmou
d94c55533c Renamed VM method is_a_real_vm to IsRealVm.
The new name complies with C# conventions and allows distinguishing it from xapi field names.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-09-09 11:58:15 +01:00
Konstantina Chremmou
1a786b38bf CP-39688: Added vTPM manager for creating and removing vTPMs.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-08-19 17:11:50 +01:00
Konstantina Chremmou
c1e5825e24 CA-368811: FIxed issue whereby a minimum memory of 512MB was enforced silently on disk image imports.
Also, increased the maximum allowed memory for imported disk images.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-07-14 16:00:58 +01:00
Konstantina Chremmou
eb73a9f106 Show the DownloadUpdatesXmlAction only when it is run by the user or it has failed.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-06-20 15:27:22 +01:00
Konstantina Chremmou
9c61f64ec5 Show the status of the DownloadUpdatesXmlAction on the Events tab (previously it was shown on the Updates tab).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-06-16 11:47:54 +01:00
CitrixChris
ffa7f28c12
Merge pull request #3019 from xenserver/feature/REQ-622
REQ-622: Citrix Hypervisor Center quick-update mechanism
2022-06-13 14:57:15 +01:00
Konstantina Chremmou
2f30ef1e19 CP-38687: Improved the speed of deleting multiple alerts.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-05-25 11:29:25 +01:00
Konstantina Chremmou
20cf55c19f Revert "CA-366140: Run data source operations on VMs only if they are allowed."
This reverts commit dd56f744e8.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Actions/GUIActions/SaveDataSourceStateAction.cs
2022-05-19 11:18:52 +01:00
CitrixChris
1d003da4c7
CP-39720: Enable auth tokens (#3002)
* CP-39720 adds a auth token to updates.xml download and chc.msi download if it exists in the registry keys

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CP-39720 adds definition of GetInternalStageAuthToken() to XenServerHealthCheckConfigProvider.cs

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CP-39720 updates token name to be more consistent

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CP-39720 updates token name in missed request

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CP-39720 reads token name from registry

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
2022-05-10 12:22:28 +01:00
Konstantina Chremmou
dd56f744e8 CA-366140: Run data source operations on VMs only if they are allowed.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-05-09 13:36:49 +01:00
Konstantina Chremmou
188cfdda22 CP-39571: Removed spaces from the name of the log files.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-22 14:32:14 +01:00
Konstantina Chremmou
59486541a5
Merge pull request #2985 from kc284/sonarqube
CP-36392: Improvement of sonarqube score
2022-04-20 10:25:23 +01:00
Konstantina Chremmou
889ef5adce Renamed fields.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-14 11:45:21 +01:00
Danilo Del Busso
d90abfd1b6
[CHC] CA-366069 & XSI-1222: Fix incorrect capitalisation of value in Japanese version + add some case insensitive checks (#2986)
* CA-366069: Fix incorrect capitalization of value in Japanese invisible messages `resx`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-366069: Add case insensitive checks on code around usage of `ISO_UPDATE`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-366069: Remove changes in string capitalisation

Move capitalisation invariance to checks only

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-366069: Remove `ISO_UPDATE` from `InvisibleMessages.resx`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-366069: Add remaining `ToLowerInvariant()` calls

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-04-14 11:36:55 +01:00
Konstantina Chremmou
3858320cc4
CA-366115 & CA-366116: Quick Update Feature - FQP Bug fixes (#2988)
* CA-366115: Release the installer when cancelling the installation because of pending tasks.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* CA-366116: Use always the same filename for the temporary downloaded installer.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* Allow to cancel while retrying to download the installer.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-12 12:09:44 +01:00
Konstantina Chremmou
558897740d Reworked instantiation of dummy actions that complete immediately.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-11 21:59:29 +01:00
Konstantina Chremmou
038de3ca62 Use consistent variable names.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-11 19:43:09 +01:00
CitrixChris
5b0b27eca1
CP-39382: Lock msi file while verifying and launching install process (#2973)
* CP-39382 adds lock around msi file while being verified and launched. Improves naming of variables in line with conventions.

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>

* CP-39382 removes unnessessary usings, fixes background tasks running check. Tidies up structure.

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>

* Further modifications.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* CP-39382 adds back in messages lost in merge conflict resolution

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

Co-authored-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-11 10:11:33 +01:00
Konstantina Chremmou
04ac8249a6 CP-36392: Refactored to avoid having unused object instantiations of the ActionBase class.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-06 13:11:35 +01:00
Konstantina Chremmou
dce02a2562 Renamed AsyncAction.RunExternal to AsyncAction.RunSync so it is more descriptive.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-06 13:11:34 +01:00