Commit Graph

2883 Commits

Author SHA1 Message Date
Jisheng Xing
7dd99857cd CP-26391: Display the SR-IOV network status on Networking Tab Page
Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
2018-03-23 14:41:55 +08:00
Jisheng Xing
35acc262ee CP-27188: Filter out the SR-IOV network when configuring IP address
Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
2018-03-23 14:41:54 +08:00
jishengx
6f4fa43c03 CP-26362: Enable create SR-IOV network (#1952)
* update the XenAPI according to the Jason-RPC

* CP-26362: Enable create SR-IOV network

* fix review comments

* fix the judgement on SR-IOV details page

* disable the finish button

Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
2018-03-23 14:27:04 +08:00
Jisheng Xing
530462ad41 CP-26491: modify IsPhysical function and Properties dialog according to SR-IOV 2018-03-23 14:26:03 +08:00
jishengx
c966e25cc1 CP-26000: Add SR-IOV column in Networking and NIC TabPage (#1903) 2018-03-23 14:24:51 +08:00
jishengx
b2c74ff261 CP-25982: add wizard to enable SR-IOV network (#1887) 2018-03-23 14:24:10 +08:00
Konstantina Chremmou
29cdf221bc Cleared some level 4 warnings.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-22 15:07:32 +00:00
Mihaela Stoica
a61dd0c5c0 Fix NullReferenceException in the Patching wizard, on pressing the Finish button)
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-03-22 10:32:41 +00:00
Michael
cb0ee70012
Merge pull request #1986 from MihaelaStoica/CA-285268
CA-285268: Patching Wizard improvement: Read metadata from the update…
2018-03-21 17:30:59 +08:00
Michael Zhao
7c8b2f6d40 CA-271850: Increase the timeout of session for querying MaximumTolerableHostFailures. 2018-03-20 07:09:34 +00:00
Michael
ebb918296b CA-284226: Optimize performance of menu Start-on-Server and Migrate-to-Server (#1985)
* CA-284226: Reduce unnecessary CanExecute() calls.

* CA-284226: Optimize the performance of menu Migrate to Server and Start on Server.

* Fix an error in updating Migrate menu with WLB, which lead to crash.

* Clear the worker queue when menu is closed.

Signed-off-by: Michael Zhao <michael.zhao@citrix.com>

* Fix comments.
2018-03-20 07:07:19 +00:00
Mihaela Stoica
45ad13133d Use the new methods PageLeaveCore and PageLoadedCore in ChooseSrProvisioningPage
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-03-19 14:08:32 +00:00
Mihaela Stoica
f7b27ec222
Merge pull request #1994 from xenserver/REQ-477
Merge REQ-477 into master
2018-03-19 13:23:19 +00:00
Mihaela Stoica
713877b49e CA-285268: Code simplification
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-03-16 14:00:07 +00:00
jishengx
0c13d8786d CA-274082: Check status of SR uploaded updates during update installa… (#1937)
* CA-274082: Check status of SR uploaded updates during update installation
* fix review comments

Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
2018-03-14 12:19:14 +00:00
Mihaela Stoica
f64fd58970 CA-285268: Patching Wizard improvement: Read metadata from the update file, instead of relying on the file name to match the update name in cfu
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-03-14 12:12:18 +00:00
Konstantina Chremmou
d69f2ddda3 Enforce treating warnings as errors in Debug mode too as it is going to save
us a lot of broken builds. Fixed bug where the HostPlanAction.CurrentHost was
always null (as the private field was never set).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-09 11:22:26 +00:00
Konstantina Chremmou
ee648135f6 Since it is easy to forget calling the base class method at the beginning of the
PageLoaded override in derived classes, enforce it by wrapping the page specific
code in a new virtual method, which the derived classes can override and PageLoaded
can call after its own logic.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-09 11:22:26 +00:00
Konstantina Chremmou
7a1b1a6dcc Since it is easy to forget calling the base class method at the end of the PageLeave
override in derived classes, enforce it by wrapping the page specific code in
a new virtual method, which the derived classes can override and PageLeave can
call before its own logic.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-09 11:22:26 +00:00
Konstantina Chremmou
2b8bf70ee5 CA-272769: Call the base class method in the end of the PageLeave override, so the
WizardContentUpdater is invoked and information flows from the SelectInstallMethod
page to the following pages.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-09 11:22:26 +00:00
Konstantina Chremmou
a8b831fab9 Simplified check as per code review.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-09 11:22:26 +00:00
Mihaela Stoica
0184470ea3
Merge pull request #1968 from kc284/master
CA-284125: Automated updates should prioritise a pending host restart to a mandatory xapi restart
2018-03-08 15:54:39 +00:00
Michael
a4aaeb1165 CA-272150: Optimize destination page of cross-pool-migrate wizard. (#1941)
* CA-272150: Optimize destination page of cross-pool-migrate wizard.

Signed-off-by: Michael Zhao <michael.zhao@citrix.com>
2018-03-08 13:22:38 +00:00
Konstantina Chremmou
9e3a9abfa0 Resolve host before querying its properties.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-08 11:34:00 +00:00
Konstantina Chremmou
b3828ef452 Added parameter enableOnly defaulting to false to the RestartHostPlanAction
so as to be able to evacuate-reboot the host without bringing the VMs back.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-07 17:50:51 +00:00
Mihaela Stoica
929ae78942 CA-284876: Process the VM parameter of the VM_FAILED_SHUTDOWN_ACKNOWLEDGMENT error on host evacuation
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-03-07 11:28:57 +00:00
Konstantina Chremmou
4b6e826ed3 CA-284125: Prioritise a pending host restart over a mandatory toolstack restart.
For this purpose, the evacuate-reboot-bringbabiesback triplet was replaced by a
new RestartHostPlanAction, which allows fallback to toolstack restart if live
patching has succeeded. Also, created new abstract class HostPlanAction to
reduce code duplication.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-06 15:12:04 +00:00
Konstantina Chremmou
de9b0c4d30 Revisited commit 3f2eed35a0 reverting Dictionary to
List in order to enforce the order of checks (the Dictionary is not guaranteed to
keep the order the items are added). Also, extra null check.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-06 14:17:16 +00:00
Konstantina Chremmou
a22a9a41e3 A couple of small inefficiencies.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-06 14:17:16 +00:00
Konstantina Chremmou
7505bda9e3 Removed unused properties of UpdateProgressBackgroundWorker; store the number of
actions on creation instead of calculating it every time on access.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-06 14:17:16 +00:00
Konstantina Chremmou
c5b0af533e Removed methods GetHostBootTime and GetHostAgentTime because they duplicated logic
in the Host extensions. Moved method TryResolveWithTimeout to the Connection class
where it is more relevant. Removed wrapper methods WaitForReboot and WaitForAgent
as they were not particularly useful.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-06 14:17:16 +00:00
Konstantina Chremmou
ed4b131643 Removed unused code and old style custom delegates, and updated property notation.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-06 14:17:16 +00:00
Konstantina Chremmou
71e554cc39 Removed duplicate logic calculating VM groups from the WizardPages and moved it the Host class as extension methods.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-06 14:17:15 +00:00
Konstantina Chremmou
3171005d23 Removed redundant code in file.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-06 14:17:15 +00:00
serencorbett1
393f9d64b9 CA-284095: Fix sort-by creation date (#1966)
* CA-284095: Fix sort-by creation date

Signed-off-by: serenc <seren.corbett@citrix.com>
2018-03-06 13:07:22 +00:00
Kun Ma
f28322e5db CA-270999: Add registration to RestartManager
Signed-off-by: Kun Ma <kun.ma@citrix.com>
2018-03-06 09:36:05 +00:00
Konstantina Chremmou
058601f761 CA-279578: Update the Recheck/Resolve button state and error message visibility
alongside the wizard progress buttons. For this purpose, the separate UpdateControls
method was removed and the logic was moved in the EnableNext method. The OnPageUpdated
method that fires this is now called every time the checks start.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-02 13:32:49 +00:00
Konstantina Chremmou
3f2eed35a0 Refactoring: use a dictionary to hold the list of generated checks; simplified calculation of progress percentage.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-02 13:32:49 +00:00
Mihaela Stoica
ff05fb698c Merge remote-tracking branch 'upstream/master' into REQ-477
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

# Conflicts:
#	XenModel/XenAPI/Auth.cs
#	XenModel/XenAPI/Blob.cs
#	XenModel/XenAPI/Bond.cs
#	XenModel/XenAPI/Console.cs
#	XenModel/XenAPI/Converters.cs
#	XenModel/XenAPI/Crashdump.cs
#	XenModel/XenAPI/DR_task.cs
#	XenModel/XenAPI/Event.cs
#	XenModel/XenAPI/Feature.cs
#	XenModel/XenAPI/GPU_group.cs
#	XenModel/XenAPI/Host.cs
#	XenModel/XenAPI/Host_cpu.cs
#	XenModel/XenAPI/Host_crashdump.cs
#	XenModel/XenAPI/Host_metrics.cs
#	XenModel/XenAPI/Host_patch.cs
#	XenModel/XenAPI/JsonRpcClient.cs
#	XenModel/XenAPI/LVHD.cs
#	XenModel/XenAPI/Maps.cs
#	XenModel/XenAPI/Message.cs
#	XenModel/XenAPI/Network.cs
#	XenModel/XenAPI/PBD.cs
#	XenModel/XenAPI/PCI.cs
#	XenModel/XenAPI/PGPU.cs
#	XenModel/XenAPI/PIF.cs
#	XenModel/XenAPI/PIF_metrics.cs
#	XenModel/XenAPI/PUSB.cs
#	XenModel/XenAPI/PVS_cache_storage.cs
#	XenModel/XenAPI/PVS_proxy.cs
#	XenModel/XenAPI/PVS_server.cs
#	XenModel/XenAPI/PVS_site.cs
#	XenModel/XenAPI/Pool.cs
#	XenModel/XenAPI/Pool_patch.cs
#	XenModel/XenAPI/Pool_update.cs
#	XenModel/XenAPI/Role.cs
#	XenModel/XenAPI/SDN_controller.cs
#	XenModel/XenAPI/SM.cs
#	XenModel/XenAPI/SR.cs
#	XenModel/XenAPI/Secret.cs
#	XenModel/XenAPI/Session.cs
#	XenModel/XenAPI/Subject.cs
#	XenModel/XenAPI/Task.cs
#	XenModel/XenAPI/Tunnel.cs
#	XenModel/XenAPI/USB_group.cs
#	XenModel/XenAPI/User.cs
#	XenModel/XenAPI/VBD.cs
#	XenModel/XenAPI/VBD_metrics.cs
#	XenModel/XenAPI/VDI.cs
#	XenModel/XenAPI/VGPU.cs
#	XenModel/XenAPI/VGPU_type.cs
#	XenModel/XenAPI/VIF.cs
#	XenModel/XenAPI/VIF_metrics.cs
#	XenModel/XenAPI/VLAN.cs
#	XenModel/XenAPI/VM.cs
#	XenModel/XenAPI/VMPP.cs
#	XenModel/XenAPI/VMSS.cs
#	XenModel/XenAPI/VM_appliance.cs
#	XenModel/XenAPI/VM_guest_metrics.cs
#	XenModel/XenAPI/VM_metrics.cs
#	XenModel/XenAPI/VTPM.cs
#	XenModel/XenAPI/VUSB.cs
#	XenModel/XenModel.csproj
2018-02-27 17:42:18 +00:00
serenc
c7ac86224a CA-282014: Patching wizard now deletes downloaded patch when wizard cancelled
Signed-off-by: serenc <seren.corbett@citrix.com>
2018-02-27 11:16:26 +00:00
Konstantina Chremmou
b4956da8f1 Performance and workflow improvement:
- no need to register the XenObjects events with the ArchiveMaintainer since
what the handler does is not specific to this class; this can be done on the
Performance page where the events are also registered.
- set directly the ArchiveMaintainer's XenObject to the new value without
setting it intermediately to null as this causes a full data download event
if the object has not changed.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-02-22 10:18:18 +00:00
Konstantina Chremmou
267035c2c6 Use Action instead of EventHandler since the event is fired without arguments.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-02-22 10:18:18 +00:00
Konstantina Chremmou
1728eb64b6 Simplified the code building the plan actions list as the previous code was
calculating the AfterApplyGuidanceActionsForPatch twice when the patch had
mandatory guidance.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-02-21 14:14:03 +00:00
Konstantina Chremmou
63c6b817d5 CA-40854: The Session's uuid is in reality its opaque_ref. Use the opaque_ref so
it's obvious what it is. The Session's uuid will be deprecated from the API bindings.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-02-21 14:08:01 +00:00
kunm
f0f37d9690 CA-280329: Fix CrossPoolMigrateDestinationPage with Current Server showing (#1931)
* CA-280329: Fix CrossPoolMigrateDestinationPage with Current Server showing

Signed-off-by: Kun Ma <kun.ma@citrix.com>

* CA-280329: Refine usage of CreateTargetServerFilterList

Signed-off-by: Kun Ma <kun.ma@citrix.com>
2018-02-05 15:31:22 +00:00
Mihaela Stoica
95471eaac5 CA-281646: Do not download the update again when using an update from disk (#1933)
* CA-281646: Do not download the update again when using an update from disk

When applying a "new version" update, XenCenter starts an automated updates sequence that by default downloads all the updates. However, when using an update from disk, we shouldn't download it again.

With these changes, when an update from disk is used we save the [update, path] mapping, which we then use in the automated updates sequence, so we don't download that update again.

Also fixed a bug where a zipped update file from disk is not identified as a new version.

* CA-281646: Remove unused directive

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-02-05 12:36:49 +00:00
serenc
c99c4a0f2e CA-280299: Rescan SRs when choosing SR for copying VM 2018-02-05 10:53:46 +00:00
Michael
6a6931dbd5 CA-280322: Space requirement calculation error in migration wizard. (#1934)
* CA-280322: Space requirement calculation error in migration wizard.

* Fix comments.

Signed-off-by: Michael Zhao <michael.zhao@citrix.com>
2018-02-05 10:07:24 +00:00
Mihaela Stoica
0f31a6f857
Merge pull request #1932 from xenserver/REQ-420
Merge request from REQ-420 into master
2018-02-01 12:24:27 +00:00
Konstantina Chremmou
19de8c54b5 CA-280679: Fixed issue where the TabPage plugin could not handle Ipv6 addresses.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-01-29 10:17:27 +00:00