Commit Graph

99 Commits

Author SHA1 Message Date
Gabor Apati-Nagy
f55cf77c00 CP-18014: Alter batch hotfixing to use host.patches_requiring_reboot
XenCenter will check host.patches_requiring_reboot when a host restart is due while a batch update is in progress. If the restart is not required, XenCenter will skip relevant PlanActions.
The intention here is to check this whenever a restart is due according to the original schedule - this way a completely livepatchable update can prevent the restart while the key batch hotfixing logic is not changed.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-26 15:37:57 +01:00
Gabor Apati-Nagy
0174974c93 Merge branch 'master' of https://github.com/xenserver/xenadmin into CP-18014
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

Conflicts:
	XenAdmin/Wizards/PatchingWizard/PatchingWizard.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
	XenModel/Messages.Designer.cs
	XenModel/Messages.ja.resx
	XenModel/Messages.resx
	XenModel/Messages.zh-CN.resx
2016-08-26 15:22:03 +01:00
Gabor Apati-Nagy
7ee2e605ee CP-18012: Use extended precheck information in Update Wizard
This commit implements the check for LiveUpdate capability of a patch. If
the patch is completely live-updatable, XenCenter will not restart the
host (but will do further checks once it has finished installing the
update - separate ticket)

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-23 18:31:23 +01:00
Gabor Apati-Nagy
16afbd3bed CA-217382: Batch updates: Install batch updates is not showing low disk space error in pre-checks when host dom0 is full
Fixes following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-08 18:05:42 +01:00
Gabor Apati-Nagy
f93a977ddf CA-217382: Batch updates: Install batch updates is not showing low disk space error in pre-checks when host dom0 is full
Implemented pre-check to check whether there is enough free disk space
before starting updating a pool.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-05 18:05:09 +01:00
Konstantina Chremmou
db79326ab1 Merge pull request #1025 from MihaelaStoica/CA-212147
CA-212147: RPU failing with insufficient license error when host lice…
2016-06-27 11:37:46 +01:00
Mihaela Stoica
62870544c6 CP-17161: Add 'using' statement around dialogs to ensure garbage collection
- fix UpsellDialog usages

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-20 13:26:52 +01:00
Mihaela Stoica
3f25c5868f CP-17161: Add 'using' statement around dialogs to ensure garbage collection
- fix all ThreeButtonDialog usages (and some other dialogs that I've came across)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-20 10:49:12 +01:00
Mihaela Stoica
72cffa03e3 CA-212147: RPU failing with insufficient license error when host license removed
If the license does not allow VM migration, then cause the VMs to be shut down / suspended on the pre-checks page

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-14 13:38:12 +01:00
Mihaela Stoica
fcee4d8876 CA-77990: Report required actions for all VMs at once in the hotfix wizard / RPUW (#951)
* CA-77990: Report required actions for all VMs at once in the hotfix wizard / RPUW

* CA-77990: Resolve precheck problems in parallel in the Patching wizard

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* CA-77990: Resolve precheck problems in parallel in the Patching wizard

Changes following code review: Made the ParallelAction work across connections and removed CrossConnectionParallelAction

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* CA-77990: Modified ParallelAction to create queue on RunSubActions only, with the correct queue size

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-07 17:40:59 +01:00
Mihaela Stoica
531496a46e CA-205118: RPU Wizard Fails Due to Host CPU Incompatibility Error
Added a Precheck to the RPU wizard, to check if the hosts in the pool have different CPU feature sets (using the old feature check for pre-Dundee pools) and display an error, offering to shut down all VMs.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-03-30 11:37:09 +01:00
Mihaela Stoica
7a46698141 CP-16068: Pick up new RPU hotfixes
- XenCenter build system picks up the RPU hotfixes from Artifactory
- RPU001 and RPU002 replace XS62E006 and XS65ESP1006
- Removed hotfixes from the solution, moved  XS60E001 to Branding folder
- also cleaned up code in the HotfixFactory class, removing MNR and Cowley hotfixes (not supported anymore)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-02-11 22:18:06 +00:00
Gabor Apati-Nagy
b8e447afa3 CA-196315: XS65ESP1018 not showing up in XenCenter Updates (on staging)
Fixed code to treat uuids of patches case-insensitive when consuming, but not changing them (eg. to lowercase) to keep compatibility with older XAPIs.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-02-08 10:14:05 +00:00
Mihaela Stoica
fc5ebd2d40 CP-15401: Move HiddenFeatures to a new class
Signed-off-by: Mihaela Stoica <Mihaela.Stoica@citrix.com>
2016-01-28 21:43:15 +00:00
Cheng Zhang
5c399ab4ba CP-15401: Avoid have null in URL constructor
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2016-01-26 11:16:39 +08:00
Cheng Zhang
04d3b81d92 CP-15401: Changed WarningWithInformationUrl and ProblemWithInformationUrl to cope with empty URL string
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2016-01-25 11:15:30 +08:00
Cheng Zhang
88d881b126 CP-15401: Show/Hide rdpPolling, upsell and optimize for XenApp depending on XenCenter registry keys
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2016-01-22 13:31:22 +08:00
Gabor Apati-Nagy
ae05d9de17 CA-159790: [XSO-208] MeddlingActions don't show location information
Updated the GetLocation extension method for ActionBase objects to return action.Connection.FriendlyName should it have no Host or Pool set up. This way we see location for MeddlingActions.
Also changed some messages (Task Names) to include "VM" in them too, because xe command line initiated VM lifecycle actions looked really misleading after the above fix in XenCenter (Eg. restarting a VM would show up as "Restarting", "server" which would suggest that not just the VM, but the host is being restarted.)

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-01-12 19:16:29 +00:00
Stephen Turner
ce609e31ff CP-14647: Intermediate check-in #4 2015-11-08 11:28:01 +00:00
Stephen Turner
b587ab832e CP-14647: Intermediate check-in #1 2015-11-08 11:27:56 +00:00
Mihaela Stoica
cddc03fb6e CP-12476: Include dom0 disk space hotfix in XenCenter RPU pre-requisites
- Added hotfix XS65ESP1006 required for RPU from Creedence (and Cream)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-06-24 17:22:08 +01:00
Gabor Apati-Nagy
970ab331b1 CP-11985: Implement RPU pre-check phase for safe repartitioning
Added check for the "not_enough_space" case

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2015-06-09 17:21:50 +01:00
Gabor Apati-Nagy
fa10c0cf54 CP-11985: Implement RPU pre-check phase for safe repartitioning
testSafe2Upgrade pugin function in prepare_host_upgrade.py is called as part of the RPU pre-checks

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2015-06-04 15:36:39 +01:00
Mihaela Stoica
112ee8c0e4 CA-164176: Make sure that the Install Update does not get stuck on precheck stage after cleanup on slave
- implement GetHashCode on HostOutOfSpaceProblem

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-03-12 14:38:55 +00:00
Mihaela Stoica
a71143c720 CA-164176: Make sure that the Install Update does not get stuck on precheck stage after cleanup on slave
- override the Equals function on HostOutOfSpaceProblem to check the disk space requirements, not the Description.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-03-12 12:34:51 +00:00
Mihaela Stoica
da604fc957 CP-11135: Changes following code review
- add checks for CreamOrGreater

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-02-18 12:26:47 +00:00
Mihaela Stoica
1a484b99ff CP-11135: Expand patch precheck to account for OUT_OF_SPACE exception
- Pool_patch.precheck can fail with the xapi error OUT_OF_SPACE when is trying to copy the patch from master to the slaves. This happens before the patch-precheck checks if enough space is available for installation. Therefore is different from the error we are currently processing, PATCH_PRECHECK_FAILED_OUT_OF_SPACE
- If the precheck fails with OUT_OF_SPACE then we try and retrieve the disk space requirements and report a HostOutOfSpaceProblem.
- Changed the PatchPrecheckCheck to try and find problem from a xapi failure, as well as from the result of the precheck  call.
- Also removed ampersand from the the link labels (More Info and Clean up)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-02-16 11:11:30 +00:00
Mihaela Stoica
a1a402fd30 CP-10798: Remove unreachable code
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-02-12 15:41:23 +00:00
Gabor Apati-Nagy
878229e9a8 CP-10798: XenCenter work for CAR-1711: Pre-Checks for hotfix installation space
-Fixed code following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2015-02-12 14:00:51 +00:00
Gabor Apati-Nagy
91789256e8 CP-10798: XenCenter work for CAR-1711: Pre-Checks for hotfix installation space
-Added HostOutOfSpaceProblem to let the user to clean up disk space when getting PATCH_PRECHECK_FAILED_OUT_OF_SPACE error at precheck stage in the patch install wizard.
-A bit of refactoring of DiskSpaceRequirements class in order to be reused here

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2015-02-12 13:13:45 +00:00
Gabor Apati-Nagy
dbce47a548 CA-136211: Show link to the relevant Knowledge Base article that describes StorageLink pre-check error
-Changes following the code review.
2014-10-02 16:30:50 +01:00
Gabor Apati-Nagy
e28edcc41b CA-136211: Show link to the relevant Knowledge Base article that describes StorageLink pre-check error
-Showing link to CTX page if StorageLink problem was found at pre-check  (in RPU Wizard)
-Enable the Resolve All button on the pre-check page only when there is at least one problem found and all the problems have solution/fix - minor refactoring

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2014-09-26 15:48:14 +01:00
Mihaela Stoica
da87dd2fe2 CA-108379: Hotfix prechecks encourage VMs to be suspended unnecessarily if HA is enabled - Fixed
- Added the "host not live" check and warning to the StorageLink status check

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-07-15 15:04:18 +01:00
Mihaela Stoica
80348d854e CA-108379: Hotfix prechecks encourage VMs to be suspended unnecessarily if HA is enabled - Fixed
- Added three Warning classes (HAEnabledWarning, WLBEnabledWarning, HostNotLiveWarning), used in the Pre-checks page of the Install wizard (also in the Rolling Pool Upgrade wizard) to indicate that a check was skipped and the reason why.
- If HA or WLB is on, we show this as an error in the "HA and WLB status" check and the "VM migration status" checks will be skipped (with a warning displayed) for all the hosts in the pool.
- Similarly, if a host if unreachable, we show this as an error in the "Host liveness status" check and the following checks for that host will be skipped (and warning displayed).

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-07-14 16:00:43 +01:00
Gabor Apati-Nagy
0e5c2932e4 Merge pull request #89 from MihaelaStoica/CP-8667
CP-8667: Update RPU hotfixes in XenCenter
2014-06-10 17:43:54 +01:00
Mihaela Stoica
4e99f6a830 CP-8667: Update RPU hotfixes in XenCenter
- XS60E009 has been replaced by XS62E006 and that the latter applies to all 6.x releases;
- 5.x hotfixes have changed, even though the version numbers are unchanged.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-06-10 10:36:50 +01:00
Mihaela Stoica
b0d2958ac0 CP-8120 Set cores per socket through XenCenter: Added text explaining the invalid vCPU configuration on the New VM Wizard and VM Properties dialog
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-06-06 15:33:22 +01:00
Mihaela Stoica
b8531be374 CP-8120 Rolling Pool Upgrade wizard: add precheck for vCPU configuration.
- Renamed “Checking can evacuate host status” precheck group to “Checking VM migration status”
- Prechecks page – check that all VMs have valid vCPU settings (i.e. number of vCPUs is a multiple of number of cores per socket).
- This check is included in the ‘Checking VM migration status” group
- If a VM has invalid vCPU settings, the precheck will display the problem with a solution to “Fix vCPU configuration” which opens the VM Properties dialog on the CPU page.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-06-06 13:50:13 +01:00
Gabor Apati-Nagy
9169a4dba9 CP-8474: Remove iSL radio button from XenCenter for >= Creedence servers.
Made the radio button invisible for Creedence or higher XS hosts.
Removed previous StorageLink-related upgrade pre-checks and added (strict) check to prevent upgrade when StorageLink is used.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2014-05-21 13:47:51 +01:00
Gabor Apati-Nagy
2c730986d5 CP-7527: fixing tests: removing orphan files from the repo
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2014-04-30 14:00:32 +01:00
zheng chai
e10125fbce CP-7527: Restore WLB for Creedence XenCenter changes.
Signed-off-by: zheng chai <zheng.chai@citrix.com>
2014-04-22 19:14:53 +08:00
Konstantina Chremmou
f5bee7102c Refactored MainWindow to derive from IMainWindow rather than implement a field deriving
from this interface.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2014-01-22 12:39:32 +00:00
Konstantina Chremmou
d9a93db79b CA-122435: Add specific message for the reason why VMs can’t be migrated when it has vGPU assigned
# HG changeset patch
# User Mihaela Stoica <Mihaela.Stoica@citrix.com>
# Date 1385742993 0
#      Fri Nov 29 16:36:33 2013 +0000
# Node ID 59229250db34dd4cc1f34fbdab055467a1570f87
# Parent  f32c185b9214fdd08ca0c573355b07b78fa7eb0a

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-12-11 10:41:54 +00:00
Konstantina Chremmou
077cb17deb CP-5750: Changed the declaration for the ActionBase events Completed, Changed and
NewAction to use the Action<ActionBase> delegate instead of EventHandler. Thus
there is no need to fire them with Empty or null EventArgs and on several occasions
we avoid casting objects in the event handlers.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-09 17:20:33 +01:00
Adrian Jachacy
edce7529f6 CA-109273: [DELL-194] Throws exception if Download & Install used on host in maintenance mode.
1. Added additional check to DownloadAndInstall method in ManageUpdatesDialog.cs: will proceed to the prechecks page in the Install Update Wizard only when there are selected servers on the previous page.
2. Modified code to allow hotfix installation when the host is in maintenance mode; however the host cannot be upgraded when in maintenance mode.
3. Modified test to reflect changes described above.

Signed-off-by: Adrian Jachacy <Adrian.Jachacy@citrix.com>
2013-07-25 09:44:52 +01:00
Adrian Jachacy
355d5e90dc CP-5352: PR-1634: Request and consume list of SRs required to recover a VM / vApp, and add Resolve All button.
1. Added AugustaOrGreater method to Helpers class (which is preferred method over MethodExists to check if a xapi call is available on a server). Also removed MethodExists method.
2. Utilized AugustaOrGreater method in GetDRMissingSRs method in both VM and VM_appliance classes.
2013-07-05 15:43:06 +01:00
Adrian Jachacy
c944acd8a3 CP-5352: PR-1634: Request and consume list of SRs required to recover a VM / vApp, and add Resolve All button.
Consume VM/VM_Appliance get_SRs_rrequired_for_recovery in VM/VM_appliance GetDRMissingSRs method.

Signed-off-by: Adrian Jachacy <Adrian.Jachacy@citrix.com>
2013-07-03 11:52:24 +01:00
Adrian Jachacy
2a29743ecb CP-4946: PR-1634: Bulk import of FibreChannel LUNs in DR Wizard.
1. Modified RunCheck method in AssertCanBeRecoveredCheck.cs to always take
into account SR passed in ErrorDescription.
2. Format Description in MissingMultipleFCSRsProblem.cs.

Signed-off-by: Adrian Jachacy <Adrian.Jachacy@citrix.com>
2013-06-28 10:24:12 +01:00
Mihaela Stoica
bd36a85bff CP-4816: Initial commit to git repo
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2013-06-24 12:41:48 +01:00