Commit Graph

61 Commits

Author SHA1 Message Date
Gabor Apati-Nagy
48134dfd14 Merge pull request #1723 from xenserver/REQ-473
Merge from REQ-473
2017-08-09 10:47:01 +01:00
Ji Jiang
5654b4eb89 CA-258321: Incorrect CFU user agent
Fixed user agent string for CFU.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-07-03 17:54:57 +01:00
Mihaela Stoica
713f84cf54 CP-22472: Add new XenCenter metadata file to the server status report: changes following code review
- Added more items to the metadata; the content is now slightly different between the SSR produced in XenCenter and the one from the HealthCheck;
- Encode the metadata string before sending it to the Health Check;
- Always suppress history for the action that sends the proxy settings;
- Renamed some of the new classes;
- Also refactored the actions that send data to the HealthCheck service.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-07-03 17:25:04 +01:00
Gabor Apati-Nagy
141b670964 CA-249056: Add a unique ID to XenCenter Check For Update (#1537)
* CA-249056: Add a unique ID to XenCenter Check For Update

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

* CA-249056: Add a unique ID to XenCenter Check For Update

Fixed the format of the User-Agent to comply with [1].

[1] https://tools.ietf.org/html/rfc7231#section-5.5.3

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

* CA-249056: Add a unique ID to XenCenter Check For Update

Changes following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

* CA-249056: Add a unique ID to XenCenter Check For Update

Changes following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

* CA-249056: Add a unique ID to XenCenter Check For Update

Changes following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-04-26 12:45:49 +01:00
Letsibogo Ramadi
ba29f1588b CA-244655 - XenCenter shows the wrong message on the Updates page when no updates are found 2017-02-24 12:12:08 +00:00
Mihaela Stoica
02c228ca85 Merge pull request #1390 from GaborApatiNagy/master_CA-238993
CA-238993: Fixed: forever growing updates list while new or updated metadata was not shown
2017-01-24 09:54:25 +00:00
Gabor Apati-Nagy
974aa0293c CA-238993: Fixed the issue of forever growing updates list while new or updated metadata was not shown
These lists were continuously growing on each refresh, because the Where
clauses returned all items as the predicate was always evaluated to
true. The reason is: A. Even IEquatable<XenServerPatch> is
implemented on XenServerPatch, it only compares uuids. B. XenServerVersion
(also XenCenterversion) does not implement Equals (always different as the
Action returns new objects).

The two bugs these caused are: A] forever growing list of versions causing
obsolete data to be kept while everything is added to the end of the list
additionally. B] Any previously added Patch will not be updated unless the uuid has been changed (this never changes).

Fix in this commit: On each refresh, taking the new lists as they are
(from the Action) and not trying to keep or modify existing items. GC will do the rest with the old list (and objects)

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-01-19 18:33:30 +00:00
Gabor Apati-Nagy
7c0bc50b4a CA-176169: Changed copyright statements to include the comma in Citrix Systems,
Inc.

Signed-off-by: Gabor Apati-Nagy<gabor.apati-nagy@citrix.com>
2017-01-16 19:59:50 +00:00
Gabor Apati-Nagy
838303b3b3 CA-230461: NullReferenceException during batch update when no check-for-updates has been performed
Removed unneeded overload and it's usage

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-16 13:53:29 +00:00
Gabor Apati-Nagy
34169dd256 CA-230461: NullReferenceException during batch update when no check-for-updates has been performed
Much better way to update/download the CFU

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-16 12:26:26 +00:00
Gabor Apati-Nagy
33adf91a68 CP-19266: [CAR 2245] Make sure XenCenter does not use Pool_patch at all (from Ely)
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-12 16:49:43 +01:00
Gabor Apati-Nagy
37735febd1 CP-18421: Use host.updates instead of host.patches
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-05 12:55:34 +01:00
Gabor Apati-Nagy
50e9504da7 CA-217862: Batch Updates: Fixed order of checks when setting the tooltip for disabled hosts
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-11 11:14:32 +01:00
Gabor Apati-Nagy
9f7a635da1 Merge remote-tracking branch 'github_xenadmin/REQ-156' into REQ-156
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

Conflicts:
	XenAdmin/Core/Updates.cs
2016-08-10 12:50:45 +01:00
Gabor Apati-Nagy
f9d8b4dea9 CA-217862: Batch updates: Install dundee released hotfixes in Batch fails when pool slave is not reachable and pool partially upgraded
Partially upgraded pools are not supported. If the versions of servers mismatch in a pool, Automatic updating will be disabled with the appropriate info message.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-10 10:48:22 +01:00
Konstantina Chremmou
5f75c0dd74 CA-217847: Fixed issue where servers were marked as unable to be updated automatically
even when automatic mode was supported for them. The problem was that the xenserver
versions were not retrieved from the DownloadUpdatesXmlAction once the latter had run.
Also, minor refactoring.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-09 16:53:02 +01:00
Konstantina Chremmou
208d4aa1f9 Merge pull request #1099 from GaborApatiNagy/CA-217844
CA-217844: Handling Automatic update not supported
2016-08-09 14:05:12 +01:00
Gabor Apati-Nagy
e28ca1ded1 CA-217844: Handling Automatic update not supported
If there is no <minimalpatches /> tag, the version is not supported. This check has priority over licensed state when displaying the reason why a server is not supported.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-08 18:30:54 +01:00
Konstantina Chremmou
e9ca8b529a CA-217843 best effort: Run RestoreDismissedUpdates action asynchronously to prevent UI hiccups.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-08 14:37:47 +01:00
Gabor Apati-Nagy
90653493c5 CA-217232: Batch updates: Install Dundee released hotfixes in Batch fails with wrong message in hotfix wizard
Despite the update sequences are correct by host, when they are flattened, the original order (order in minimal patches) was not considered properly, so a missing patch was scheduled for later in the sequence than it should have been, thus the upgrade failed with a precheck-error.

This bug occurs when we are given
* a pool of more than one host,
* with (at least) patchA not installed on 2 or more hosts
* patchA requires patchR that is not installed on at least one of the above hosts (but not not on all)
* the host that is missing patchR is ahead of other hosts in pool.Hosts.Cache

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-02 16:58:24 +01:00
Gabor Apati-Nagy
a007eec882 CA-216162: Batch updates: Wrong hover message on install update wizard when installing batch updates
Better messages on Select Server Page

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-19 09:12:30 +01:00
Gabor Apati-Nagy
9337663adb CP-17282: Unit tests to validate the Update Sequence logic
Unit tests to test GetUpdateSequence

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-29 12:49:53 +01:00
Gabor Apati-Nagy
3e092f6d50 CP-17444: Show minimal hotfixes on General tab
Showing recommended* hotfixes for servers when the data is available (Check For Updates xml has been downloaded and has minimalPatches node in it for the given server version). *:Not applied ones from the minimal set.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-08 13:34:59 +01:00
Gabor Apati-Nagy
9ec512921b CP-15790: Prepare XenCenter for unit testing of Automatic Updates
Added support for defining custom update.xml location in Registry. This
can be either a local file or an URL. This will be beneficial when testing XenCenter.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-07 16:02:57 +01:00
Gabor Apati-Nagy
fdb930bb19 CP-15717: UI: Implement basic upload/precheck/patch/cleanup logic
cleaned up code

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-05-04 11:21:23 +01:00
Gabor Apati-Nagy
466f01b926 CP-15717: UI: Implement basic upload/precheck/patch/cleanup logic
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-05-04 11:06:39 +01:00
Gabor Apati-Nagy
d3914a2318 CP-15717: UI: Implement basic upload/precheck/patch/cleanup logic
intermediate commit

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-05-04 11:02:16 +01:00
Gabor Apati-Nagy
0574a63de5 CP-15710: Code to Construct an Update Sequence
Using OrdinalIgnoreCase for uuid comparisons

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-03-16 13:46:58 +00:00
Gabor Apati-Nagy
25e83b72bf CP-15712: Add Automatic mode (internal parameter)
Removed Contained

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-03-16 13:41:10 +00:00
Gabor Apati-Nagy
312cd931ca CP-15712: Add Automatic mode (internal parameter)
Disableded non-required pages in the wizard
Added placeholder for new pages
Changed sequence of pages
Removed unnecessary code

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-03-16 11:38:16 +00:00
Gabor Apati-Nagy
7acbce0ca1 Merge remote-tracking branch 'github_xenadmin/master' into master_batchupdate_2 2016-03-10 14:57:29 +00:00
Gabor Apati-Nagy
39ae204363 Merge remote-tracking branch 'github_xenadmin/master' 2016-02-08 10:14:25 +00:00
Gabor Apati-Nagy
b8e447afa3 CA-196315: XS65ESP1018 not showing up in XenCenter Updates (on staging)
Fixed code to treat uuids of patches case-insensitive when consuming, but not changing them (eg. to lowercase) to keep compatibility with older XAPIs.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-02-08 10:14:05 +00:00
Mihaela Stoica
20970ff122 CP-15399: Move check for updates url to Branding.cs
- InvisibleMessages.resx contains the default url for check for updates, which can be overwritten in Branding.cs
- Added an extra parameter to DownloadUpdatesXmlAction for the updates url. If this is not specified (or null), then the default one (from InvisibleMessages) is used

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-02-04 10:39:14 +00:00
Gabor Apati-Nagy
618283e051 CP-15710: Code to Construct an Update Sequence
Comments

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-02-03 12:00:41 +00:00
Gabor Apati-Nagy
459565423a CP-15710: Code to Construct an Update Sequence
Removed unnecessary reversing of lists and fixed code to start with SP. (None of these have not been causing problems, but they are not needed)

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-02-03 11:53:34 +00:00
Gabor Apati-Nagy
a8e7a199cf CP-15710: Code to Construct an Update Sequence
Extracted step6 to a new method.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-02-02 19:27:08 +00:00
Gabor Apati-Nagy
71a44aff12 CP-15710: Code to Construct an Update Sequence
This code constructs an update sequence/schedule for each host in a pool.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-02-02 19:14:59 +00:00
Mihaela Stoica
817d42fb18 CA-187698: When restoring dismissed updates, only do it on the connections with sufficient privileges
- This fixes the uncaught exception raised when an unauthorized user tries to restore dismissed updates.
- Also added the roles check when dismissing updates.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-11-05 15:49:38 +00:00
Gabor Apati-Nagy
f6b632d0b6 Merge pull request #593 from agimofcarmen/CA-178243
CA-178243: When only Automatic check for XenServer updates was checke…
2015-08-04 17:30:22 +01:00
Carmen Agimof
c8e5138031 CA-178243: Refactors code, simplifying it. Now we only keep one list in DownloadUpdatesXmlAction for XenServerVersions and added a property that returns the list with the versions if Automatic check for XS version is checked and a new list which is empty when is not checked. 2015-08-04 17:28:29 +01:00
Carmen Agimof
f3e4c140a0 CA-178244: Adds condition to RemoveUpdate that checks if the list contains the given update. 2015-08-04 16:27:12 +01:00
Carmen Agimof
04b204a0d9 CA-178244: Solves the issue about duplicates in the list of updates in the Updates Tab. 2015-08-03 15:12:42 +01:00
Carmen Agimof
9de57d38c2 CA-178243: When only Automatic check for XenServer updates was checked in Updates Options, when opening XC, the grid appeared empty in the Updates Tab. This was because to get the list of XS updates, we need the list of XS versions. Created a list of XenServer versions that is used only to get the XenServer updates. 2015-08-03 15:06:01 +01:00
Carmen Agimof
b7a010b5f0 CA-178243: The Refresh button was not working correctly because of the restore button. Automatic check for updates works now when certain boxes are checked, showing the updates when the user opens XenCenter, but, the list has duplicates.
Improves the centering of the warning messages in the Updates Tab, making the picture align with the text.
Corrects bug related to the visibility of the warning about automatic checks for updates.
2015-07-30 14:58:23 +01:00
Carmen Agimof
32461b38b9 CP-13028: Corrects the Dismiss function and provides Dismiss All/ Dismiss Selected button on the Updates Tab. 2015-07-29 13:43:47 +01:00
Carmen Agimof
182307963f CP-13030: Provide button on the Updates tab to restore dismissed updates. 2015-07-23 13:50:32 +01:00
Carmen Agimof
f79199752a CP-13026: Provide Dismiss option on the Updates Tab. 2015-07-23 11:48:14 +01:00
Mihaela Stoica
2ca98a7638 CP-7686: Make check-for-updates work in the presence of service packs by using the new fields from updates.xml, requiredpatches and conflictingpatches.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-02-17 09:31:57 +00:00
Konstantina Chremmou
f8117cd4f5 CA-114482: Changed workflow of retrieving updates: the list of published updates
is downloaded and stored every time an update is performed (if manual all updates
are downloaded, if automatic only as per the user's choices). If there are available
updates, update alerts are generated if there are connected hosts and disappear
when the hosts are disconnected.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2014-01-08 13:17:02 +00:00