Commit Graph

6930 Commits

Author SHA1 Message Date
Konstantina Chremmou
f8ab0a1414
Merge pull request #3127 from kc284/proxy_removal
CP-40407: Removal of IXmlRpcProxy related classes and simulation infrastructure
2023-04-12 09:54:17 +01:00
Danilo Del Busso
61ff54ba44
Remove unused calls
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-04-12 08:43:50 +01:00
Danilo Del Busso
7b18b3b105
Update DownloadAndUpdateClientAction to not prepend param name when downloading
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-04-12 08:43:42 +01:00
Danilo Del Busso
1b3b4b218d
Move AddAuthTokenToQueryString to Helpers
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-04-12 08:31:05 +01:00
Konstantina Chremmou
2c28824594 CA-294901: Reworded (again) so that we don't give the impression that the VMs' affinity will be set.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-04-11 22:15:02 +01:00
Konstantina Chremmou
efce18eff9 CA-376330: If the boot mode radios are invisible do not check them or show the warning if they are disabled.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-04-11 13:26:19 +01:00
Konstantina Chremmou
601d615f52
Merge pull request #3126 from kc284/obsolete
Stop using reflection for the creation of context menu builders; and some smaller corrections.
2023-04-11 13:26:00 +01:00
Konstantina Chremmou
7859d12e34 Use our own info icon instead of the system's because it does not scale.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-04-03 13:55:02 +01:00
Konstantina Chremmou
9d6d1a185d Simplified SrAction by splitting it to four different actions. Fixed RBAC permissions when detaching SR and destroying PBDs.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-04-03 13:55:02 +01:00
Konstantina Chremmou
a4df1eed61 New logic for connection to a xapi database and some connection tidy up:
- Removed event that had no subscribers.
- The xml docs are more useful on the properties and not their supporting private fields.
- Stop silencing cache errors as they may reveal other issues.
- Adding server to history was called twice.
- Connection null checks and refactoring of ConnectionExists exceptions.
- Added some logging.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-03-31 14:17:56 +01:00
Konstantina Chremmou
8375754a5b CP-40407: Removed fakeAPI and usage of XmlRpcProxy classes in the application.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-03-31 14:17:55 +01:00
Konstantina Chremmou
b543fbeedb Corrections in the context menu builder:
- Stop using reflection for the creation of context menu builders. It's error prone.
- MultipleDockerContainers was not constructed because it was abstract.
- Do not reconstruct the selectionList for each builder.
- Unused variables.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-03-31 11:07:17 +01:00
Konstantina Chremmou
6838b76132 Unused code.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-03-31 11:07:12 +01:00
Konstantina Chremmou
a01264233d Updated the SDK to 23.3.0.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-03-30 16:40:34 +01:00
Konstantina Chremmou
dfeb347485 Removed integrated storage link code. The feature was removed long ago.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-03-30 16:38:56 +01:00
Danilo Del Busso
16ce163e7f
Remove whitespace only keys from query string
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-03-30 13:31:58 +01:00
Danilo Del Busso
a888ed9274
Only add InternalStageAuthToken if URI isn't pointing to a file
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-03-30 13:31:06 +01:00
Konstantina Chremmou
6cd1393161 Bumped branding to v4.15. Removed leftover references of branded components.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-03-30 10:22:12 +01:00
Konstantina Chremmou
392efff62d
Merge pull request #3120 from kc284/addserver
Dead/obsolete code removal and some issues on the AddServerDialog
2023-03-29 22:52:31 +01:00
Danilo Del Busso
dd571056ae CP-42286: Add friendly name for pool_session_creation_rate
Also adds new unit to `DataSet.cs`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-03-29 22:52:01 +01:00
Danilo Del Busso
732d1f4a30
Do not pre-pend key to InternalStageAuthToken query parameters
Use of `InternalStageAuthToken=foo` is not needed anymore. Furthermore, we can now provide any token format.

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-03-27 09:28:21 +01:00
Danilo Del Busso
65da63755f
[master] CA-375556: Pass non-compressed file stream to HTTP.CopyStream (#3115)
* CA-375556: Pass non-compressed file stream to `HTTP.CopyStream`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CA-375556: Use `sourcefile` instead of `filePath`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

---------

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-03-24 10:24:10 +00:00
Konstantina Chremmou
1a2e934e6f Corrected alignment of error message.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-03-24 00:45:12 +00:00
Konstantina Chremmou
b2a9dd9f1d Fixed some code inefficiencies:
- Multiple server entries should not be parsed differently from single entries;
  (the Uri case was parsed incorrectly; multiple servers with ports could not be added).
- Simplified code parsing the hostname and port.
- Removed obsolete property IXenConnection.Version.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-03-22 15:48:43 +00:00
Konstantina Chremmou
66bd90662d Removed unnecessary AddServerTask class. Add the new connection once notified by the dialog's CachePopulated event.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-03-22 14:25:45 +00:00
Konstantina Chremmou
3ee2e7e571 Removed obsolete code/hidden functionality and related outdated sample xapi databases.
- Removed sample databases. They are outdated, hence unloadable, and loading

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-03-21 15:51:59 +00:00
Konstantina Chremmou
e582ae1e24 Use the server combobox's item list for autocompletion suggestions.
This fixes occasional crash when typing in the combobox.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-03-21 15:51:59 +00:00
Konstantina Chremmou
e4cecfb1bd Removed unused button and made minor layout tweaks.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-03-21 15:51:59 +00:00
Konstantina Chremmou
8ede70ff99 CA-375942: Corrected RBAC check for create/destroy vTPM (rely on the actions' RBAC check instead of replicating it on the dialog).
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-03-20 08:55:30 +00:00
Konstantina Chremmou
ef4ceaac3c
Merge pull request #3113 from danilo-delbusso/localised-install-CA-375703
CA-375703: Remove leftover language mentions in `XenCenter.wxs`
2023-03-08 09:57:28 +00:00
Danilo Del Busso
d4f232cd87
Remove unused lines from xenadmin-build.sh
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-03-08 09:53:25 +00:00
Konstantina Chremmou
1b8fd8eb48 CA-375668: Report bytes uncompressed instead of percentage when uncompressing a gzip.
GZipStream does not support Position.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-03-08 09:51:06 +00:00
Danilo Del Busso
2585da8bb3
CA-375703: Remove leftover language mentions in XenCenter.wxs
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-03-08 09:35:27 +00:00
Ross Lagerwall
91b224d0c4 CP-41775: Fix using Hanja/Hangeul keys over VNC
Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
2023-03-06 15:59:48 +00:00
Konstantina Chremmou
8cf8e6289a
Merge pull request #3086 from danilo-delbusso/FCoE-CP-41737
CP-41737: Add FCoE deprecation warnings
2023-03-06 15:25:25 +00:00
Konstantina Chremmou
4034a48ee3 Reordered templates on the NewVM wizard:
- Moved Windows Server templates to a different category.
- Show templates in reverse alphabetical (typically release) order.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-03-06 15:24:41 +00:00
Danilo Del Busso
e5664bab7e Update CODEOWNERS and MAINTAINERS
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-03-06 14:44:17 +00:00
Danilo Del Busso
8f6ebb63fd CP-42354: Bump branding version
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-03-02 15:41:21 +00:00
Konstantina Chremmou
5bf8559b60 Show more analytical warning.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-03-02 09:04:43 +00:00
Konstantina Chremmou
fddca73f08
Merge pull request #3090 from kc284/custom_fields
Fixed some issues around custom fields
2023-03-01 14:31:18 +00:00
Konstantina Chremmou
488f27e2ae Revised Rbac checks for addition/removal of custom fields.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-28 21:25:02 +00:00
Konstantina Chremmou
5c70cbfd3d CA-84612: Rewrote the CustomFields Property page to fix some issues:
- The CustomFieldsDialog was an unnecessary intermediate step deteriorating the user experience.
- Fixed layout issues when we have a long list of custom fields.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-28 21:03:16 +00:00
Konstantina Chremmou
0d1e4993ec Added blurb to the NewCustomFieldDialog; improved error message and control state checks.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-28 21:03:16 +00:00
Konstantina Chremmou
bc40d47ba6 Corrections to removal of custom fields:
- Custom fields were not removed from all types of objects the UI allows
  setting them for, which meant they were left behind in the other_config.
- Only remove a custom field if it is set on an object, otherwise we hammer
  the server with unnecessary requests.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-28 21:03:16 +00:00
Konstantina Chremmou
423ee7bd81 Added RBAC checks to the actions adding/removing custom fields. Also:
- Converted them to proper AsyncActions to facilitate further refactoring.
- Moved SaveCustomFieldsAction to the same folder as the above.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-28 21:03:15 +00:00
Konstantina Chremmou
87ff42086f Missing RBAC permission checks for CreateDiskAction.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-28 15:36:13 +00:00
Konstantina Chremmou
d3a2805af8 Renamed private fields to match conventions.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-28 15:36:13 +00:00
Konstantina Chremmou
8c42b0428e Refactored the actions creating disks.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-28 15:36:13 +00:00
Konstantina Chremmou
5828c03e8d CA-375173: Create the VDI and VBD records before closing the new disk dialog. Also:
Fixed issue where the SR was not preselected when editing an existing disk and no scans were taking place.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-28 15:36:13 +00:00
Danilo Del Busso
43e2cecf32
CP-41737: Update copyright notices
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-28 08:07:30 +00:00