Commit Graph

3974 Commits

Author SHA1 Message Date
Mihaela Stoica
be66919627 CP-19086: Improvements to the PVS cache UI
- If the PVS site cannot be removed (it has running proxies) then popup a dialog stating the reason, instead of starting the action and failing there. We still have the same check in the action, just in case the situation changed in the meantime.
- Removed unused controls

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-03 10:51:56 +01:00
Konstantina Chremmou
b78f823b17 CA-220218: For halted VMs moving intra-pool, XenCenter does not need to assert migration
is possible, because what it actually does is move. When asserting migration use
an SR other than the VDI's current SR for the check to ensure that both source and
target SRs are checked to see whether they support migration. Also, use the VM's
Home() instead of resident_on to ensure the current server cannot be selected as
target server. Some refactoring.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-03 10:30:40 +01:00
Konstantina Chremmou
e6b2f9b293 Refactoring: removed three out of the classes deriving from the DelayLoadingOptionComboBoxItem
because the differentiation was in the filters, which can be passed in as parameters
to the base class, and other than this they were only adding complexity.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-02 22:04:58 +01:00
Mihaela Stoica
aebffe9b13 CP-19086: Improvements to the PVS cache UI
PVS Tab:
- Move the "View PVS sites" button inside the "Configure PVS Cache" dialog (next to Remove button) and make it per-site (showing only the PVS servers from that site)
- Remove "Currently attached" column from the VMs section
- Rename "Status" column to "Read caching status"

Configure PVS Cache" dialog:
- Make sure there is a scrollbar to accommodate all hosts in a pool
- Add a confirmation dialog when a site is removed. The action is executed when the Remove button is pressed.
- When Memory SR is selected, set the maximum value to the dom0-extra-memory..
- Allow empty configuration (but see next point): The OK button should only be disabled if the PVS site name is empty
- Add an extra option in the "Cache storage" combobox, with text "Not configured", selected by default on a new site. When this is selected, we will remove the existing entry in pvs_cache_storage and will not create a new one.
- When a PVS site is deleted (forgotten), we first delete all the associated PVS_servers, otherwise the site cannot be deleted.
2016-10-01 00:23:28 +01:00
Stephen Turner
e9b9e43c48 Merge pull request #1190 from MihaelaStoica/CAR-2184
CP-17932: Add friendly names for PVS Cache RRDs + merge master
2016-09-30 16:42:34 +01:00
Stephen Turner
3e8f052117 Merge pull request #1187 from MihaelaStoica/CP-19060
CP-19060: Port vCPU hotplug code to master and add license key
2016-09-30 16:33:56 +01:00
Mihaela Stoica
b84b82a2be Merge pull request #1189 from stephen-turner/Credits_201609
Update credits
2016-09-30 14:54:03 +01:00
Mihaela Stoica
cdfec90fa8 Merge branch 'master' into CAR-2184 2016-09-30 14:46:26 +01:00
Mihaela Stoica
93664f602c CP-17932: Add friendly names for PVS Cache RRDs
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-30 14:33:15 +01:00
Stephen Turner
9d2024c132 Update credits 2016-09-30 13:49:47 +01:00
Konstantina Chremmou
61a2c12c45 CA-205799: Fixed issue where the user was allowed to select the VM's home server
as move (halted) or migrate (suspended) destination; this was caused by using the
VM's resident_on instead of Home() host. Also, changed the disabled reason to be
a bit more generic and cover cases other than migration.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-30 13:45:59 +01:00
Konstantina Chremmou
1acc717417 CA-205791: Added detail to the action migrating a VM that's not resident on a host.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-30 13:45:52 +01:00
Konstantina Chremmou
f1a43abbf0 Refactoring: it's not a good idea to set virtual members in constructors; thus
the MenuText can stay a getter.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-30 13:45:44 +01:00
Konstantina Chremmou
4bf04e6279 In Move mode the text on the destination page should read "move the VMs" and not migrate.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-30 13:45:37 +01:00
Konstantina Chremmou
55f1a03224 Fixed wrong images in the following cases:
- the image for resume suspended VM on non-home server should be connected-server,
not vm-being-migrated.
- the image for a server where a running VM cannot be migrated to should be connected-server,
not disconnected-server (it is disabled anyway). Also, simplified the logic to obtain
the cannot-execute-reasons.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-30 13:45:30 +01:00
Konstantina Chremmou
6833722992 Renamed command so it's more obvious what it does and made some corrections to its checks.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-30 13:45:23 +01:00
Konstantina Chremmou
97278e88ad Refactoring: normally we create the actions in the wizard class obtaining the parameters
from the page properties; removed unnecessary field.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-30 13:45:04 +01:00
Mihaela Stoica
f53255e906 CP-19060: Add license key for vCPU hotplug
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-29 12:20:25 +01:00
Mihaela Stoica
2a6a237a7f CP-18889: Fix the layout in the CN version of the CPU page (#1166)
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-29 12:17:00 +01:00
kunm
8ff4723242 CP-18890: Translate new strings for vCPU hotplug (#1163)
Signed-off-by: kunm <kun.ma@citrix.com>
2016-09-29 12:16:01 +01:00
Mihaela Stoica
18fb723f6a CP-18889: Implement UI changes for vCPU hotplug (#1159)
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-29 12:11:37 +01:00
Gabor Apati-Nagy
51beba73e4 Merge pull request #1186 from MihaelaStoica/CA-223407
CA-223407: Hosts don't get rebooted after a supplemental pack install…
2016-09-29 11:26:45 +01:00
Callum McIntyre
fb261afcf1 [DotNet Upgrade] Update the build scripts to use .net 4.6
Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-09-29 11:02:46 +01:00
Callum McIntyre
1b1c7ae581 [Dotnet Upgrade] Convert all projects to use .net 4.6. All changes autogenerated by VS.
Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-09-29 10:50:24 +01:00
Mihaela Stoica
4aaaea43d9 CA-223407: Hosts don't get rebooted after a supplemental pack installation and the wizard is stuck in "rebooting" phase
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-29 10:07:00 +01:00
Konstantina Chremmou
13bc93a5ad UI workaround for CA-220216: swapped the order of checks and put VDI migration
before move; thus, if the SR does not support migration, the user can at least
detach the disk and try a move.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-28 23:50:46 +01:00
Konstantina Chremmou
775ee87bab CA-220511: Fixed issue where it was not possible to migrate the VDI of a VM without
home host from a shared to a local storage (while it was possible from the CLI).
Minor refactoring.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-28 23:14:25 +01:00
Stephen Turner
babfa0ee83 Merge pull request #1185 from MihaelaStoica/CAR-2184
CP-17920: New icons for Add and Remove PVS site
2016-09-28 18:02:28 +01:00
Mihaela Stoica
b0f748ceb5 CP-17920: New icons for Add and Remove PVS site
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-28 17:56:39 +01:00
Konstantina Chremmou
eb3fbe2ac8 Corrections and refactoring on VDI move/migrate:
- Allow move of multiple VDIs
- CA-187659: show better messages when batching move/migration of multiple VDIs.
- Show different tooltips for single vs. multiple VDI move/migration/deletion.
- Refactored the MoveDiskDdialog. Removed the inherited class VDIMigrateDialog and
the batching manager as it was not very different from its parent, it was registering
the events twice, and was batching migration of even single VDIs.
- Tidied up the Move- and MigrateVirtualDisk commands so they're easier to compare.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-28 09:50:43 +01:00
Konstantina Chremmou
2ff6f74488 Fixed the following issues:
- Was only able to move and not migrate vdi if selected from the objects view.
- The text on the ToolStripMenuItems on the SrStoragePage was different from the
corresponding buttons.
- Added item move/migrate to the multiple VDI context menu. The Properties item
should not be shown in this case.
2016-09-28 09:50:23 +01:00
Gabor Apati-Nagy
633579952e Merge pull request #1184 from MihaelaStoica/CAR-2184
CP-17920: Add dialog for PVS cache configuration
2016-09-27 18:47:02 +01:00
Mihaela Stoica
277914a202 CP-17920: Add dialog for PVS cache configuration
-rename local variable

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-27 18:39:49 +01:00
Mihaela Stoica
82dea74899 CP-17920: Add dialog for PVS cache configuration
- new image for PVS_site
- added cache size restrictions based on the SR selected
- added button to remove the PVS site on the page
- fixed the error where the subtext for a new PVS sites showed as "Not configured" even after it has been configured

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-27 16:34:26 +01:00
Mihaela Stoica
695934d907 CP-16922: Update the menu items and fix the tests
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-26 17:45:28 +01:00
Mihaela Stoica
fe6144ba70 CP-17920: Add dialog for PVS cache configuration
- this commit contains a temporary image for PVS_site

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-26 17:44:17 +01:00
Mihaela Stoica
0b2f63461a Merge pull request #1181 from xenserver/GaborApatiNagy-CA-223082
CA-223082: Replace PATCH_PRECHECK_LIVEPATCH_MISSING
2016-09-26 13:33:47 +01:00
Mihaela Stoica
25a3770af0 Merge pull request #1183 from MihaelaStoica/CAR-2184-merge
Merge master into CAR-2184
2016-09-26 13:31:40 +01:00
Mihaela Stoica
f2b1443064 Merge branch 'master' into CAR-2184
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

Conflicts:
	XenModel/Messages.Designer.cs
	XenModel/Messages.resx
2016-09-26 13:26:31 +01:00
Konstantina Chremmou
3d0705bbbc Merge pull request #1182 from MihaelaStoica/CAR-2184
CP-17920: Show the PVS tab only when the supplemental pack is installed & Hide Memory SR
2016-09-26 11:49:07 +01:00
Mihaela Stoica
fe9302a40e CP-17920: Hide memory SR in XenCenter
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-25 21:16:45 +01:00
Mihaela Stoica
151e6f42fb CP-17920: Show the PVS tab only when the supplemental pack is installed
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-23 14:51:19 +01:00
Gabor Apati-Nagy
ccaeed67cb CA-223082: Replace PATCH_PRECHECK_LIVEPATCH_MISSING
Replace PATCH_PRECHECK_LIVEPATCH_MISSING to PATCH_PRECHECK_LIVEPATCH_NOT_APPLICABLE due to changes in XAPI
Note: if XAPI change gets active before this change we will see UNKNOWN instead of PATCH_PRECHECK_LIVEPATCH_NOT_APPLICABLE in XenCenter what will make no difference
2016-09-23 13:35:02 +01:00
Mihaela Stoica
c6eab65fdf Merge pull request #1154 from kc284/master
Some corrections on VMStorage page and disk move/migrate/detach
2016-09-22 15:21:48 +01:00
mcintyre94
dd42394a25 CP-16922: Implement GUI for enabling PVS read caching (#1179)
* CP-16922: UI changes to PvsPage to replace the single configure button with a separate enable and disable one, per the design doc

* CP-16922: Intermediate checkin - command + dialog implemented, but PVS page has some layout problems.

* CP-16922:  Implement GUI for enabling PVS read caching and marking/unmarking VMs for prepopulation

Fix the broken layout by reverting MainWindow.resx (which shouldn't have changed) back to the previous commit. Also removed duplicate properties button code.

*  CP-16922: PVS Page changes, to properly display all VMs (not just ones with proxy), only populating proxy columns if there is a proxy set.

* CP-16922: Use a CommandButton for the enable button, connected to the same command as the VM main menu button, and using the table selection as its selection manager.

* CP-16922: Delete the old enable button click behaviour (because it now has a proper command), was causing the dialog to show up twice

* CP-16922: Properly list VMs by hiding those that should be hidden (in addition to non-VMs, also hide the __gui__ prefix and others covered by Show function). Also fixes a bug in NewVMGroupVMsPage discovered when fixing this - it would show VMs that should be hidden if you used the search bar.


* CP-16922: Use ButtonText on the Command to set the text on the PVS enable button

* CP-16922: Add the disable PVS read-caching command, and its associated proxy destroy action. Both based off enable equivalents (main difference is no dialog for now). Not used yet but will be in main window menu + disable button

* CP-16922: Add disable PVS read-caching to the main window menu (under enable), with the disable command attached to it


* CP-16922: Add support for disabling PVS read-caching for selected hosts via the PVS tab page by converting the disable button into a CommandButton in the same way as the enable button, using its own command + selection manager (because Selection Managers only bind to one control)

* CP-16922: Design - adding the "read caching enabled" column from the design, so that we display both whether caching is enabled and whether the VM is currently cached. If it's disabled all other values are missing.


* CP-16922: Add the PVS site column per the design to show the site a VM's PVS Proxy is on if it has a proxy


* CP-16922: Add an event handler for VMs changing so that newly provisioned VMs immediately show up in the PVS tab page


* CP-16922: Support for properly remembering the selection when the VM list is refreshed. A new method returns the list of VMs for the selected rows, and we can then check if the VM for the row being added is in this list. If there was no previous selection then we still select the first row by default.


* CP-16922: Remove prepopulate, which is being removed from the design. The next XAPI version will remove it, so just pass False as prepopulate for now, and remove the option from the dialog and PVS tab page.


* CP-16922: Improve UI appearance for a missing Storage Repository. Per the design, if there is no SR show the message None (memory only) instead of an empty cell

* CP-16922: Improved sorting behaviour. All columns (except VM name, which always uses it) use the VM tag as a sorting fallback (since they all have duplicates). New default sort which sorts by caching enabled first (yes before no), and then VM tag as a tiebreaker. Support for remembering the current sort on refresh, ie when a value changes.

* CP-16922: Refactoring to use a VM extension method to get the PVSProxy (or null if none exists) for a VM. This was used in the PVS Page + commands which are now much simpler.


* CP-16922: Move where the SelectionChanged event handler is set when refreshing the PVS table, so that the command buttons are updated correctly.

* CP-16922: Improvements to PVS read-caching dialog. Set accept/cancel buttons properly + adjust tab values, so focus acts as expected


* CP-16922: Remove the images from the menu for Enable/Disable PVS read-caching, most commands in the menu don't have one

* CP-16922: Sorting out the strings for the actions + ParallelAction calls, and moving them into the resx. Also reverting wrong MainWindow.resx changes.

* CAR-2184: XAPI changes. I've made the minimal possible changes to PvsPage to ensure it compiles, but it's had a lot of feature work (CP-16922) that supersedes this, these small changes should keep that merge painless.


* CAR-2184 XAPI: Reverse the unrelated changes, only keep the PVS ones.

* CP-16922: Merge latest XAPI changes, notably changes to Pvs_site.create

* CP-16922: Change tab show/hide logic for PVS tab, show it even if there are no PVS sites.

* CP-16922: Implement GUI for enabling PVS read caching

Design changes - remove the storage repo column and replace it with status, which is populated with a friendly version of the pvs_proxy_status enum. Also populate site list using site.name_label

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>

*  CP-16922: Implement GUI for enabling PVS read caching

Adjusting the CanExecute of Enable PVS read-caching command to require at least one PVS site to be created. Since the PVS tab can show up without any sites, we need this because we can't create a proxy without a site.

* CP-16922: Code review changes.

Tidied up messages, and ensured actions run async properly, and without exiting before their task.

* CP-16922: Code review changes.

Update dialog resx, wider combobox on dialog, update action descriptions before setting RelatedTask, add friendly message body for PVS error notifications.
2016-09-22 15:08:15 +01:00
Mihaela Stoica
8ea8c71f74 Merge pull request #1164 from kc284/master2
Did some work on the SrStoragePage:
2016-09-22 14:12:59 +01:00
Mihaela Stoica
502f436b03 Merge pull request #1180 from mcintyre94/CA-218260
CA-218260: Reverting to Snapshots causes VM to go back to parent host
2016-09-22 14:12:05 +01:00
Callum McIntyre
336e4d8149 CA-218260: Reverting to Snapshots causes VM to go back to parent host
Move the test for whether we can boot the VM on the previous host into the VmSnapshotRevertAction, and run it using the Session of the action.
2016-09-22 13:36:43 +01:00
Callum McIntyre
d30ff533fd CA-218260: Correcting nesting
The else if (vm.power_state == vm_power_state.Suspended) block had been incorrectly moved out an indent level to the outer if.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-09-21 17:45:42 +01:00
Callum McIntyre
502e386e53 CA-218260: Reverting to Snapshots causes VM to go back to parent host
Where we have a host the VM is running on (ie vm.resident_on is not null) at the time it is reverted, attempt to start/resume on that host if possible, instead of the home server of the VM.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-09-21 17:39:03 +01:00