Commit Graph

1811 Commits

Author SHA1 Message Date
Konstantina Chremmou
8991a257d2 Removed some unnecessary methods; changed visibility for controls that don't need to be public. 2016-07-04 23:05:51 +01:00
Konstantina Chremmou
8de55cb90c Merge pull request #1051 from kallisti5/master
Case sensitivity fixes
2016-07-04 13:30:30 +01:00
Konstantina Chremmou
04ffdbadc5 CP-17756: Do not use the field VM.is_control_domain to find the console for the
host as it applies to other control domains too. Use the new Host.control_domain
field instead. Minor refactoring.
2016-07-04 13:22:08 +01:00
Konstantina Chremmou
56265bbfd6 CP-17756: The dom0 VM is found now using the new field Host.control_domain as
there can be more than one control domains. For older hosts return the control
domain with domid 0. Renamed property.
2016-07-04 13:21:52 +01:00
Konstantina Chremmou
94df31b878 Removed call of virtual member in the constructors. 2016-07-04 08:22:35 +01:00
Cheng Zhang
a682811ed5 CA-213045: Rework on comments to change string format
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2016-07-04 09:11:10 +08:00
Konstantina Chremmou
f320dd7881 Renamed control because Resharper was complaining about ambiguous references in
the resx files between this and homonymous control in two derived classes. Removed
reference of non-existent file from XenAdmin.csproj.
2016-07-03 19:45:40 +01:00
Konstantina Chremmou
f1b7aadc88 Fixed issue where the error message was not displayed if connection to the host console was not possible.
Refactored to hide/show error controls instead of adding/removing them. Removed duplicate null check.
Do not use a second list to track active VM consoles.
2016-07-03 17:45:49 +01:00
Konstantina Chremmou
8a8bdc21e6 Tidied up the ConsolePanel; moved designer code to the corresponding file and removed setting of virtual field from the constructor. 2016-07-01 17:47:41 +01:00
Konstantina Chremmou
7d618d9e79 Merge pull request #1049 from MihaelaStoica/CA-116547
CA-116547: During Installation of Hotfix requiring restart of PV gues…
2016-07-01 09:16:29 +01:00
Konstantina Chremmou
051afb48c2 Merge pull request #1012 from MihaelaStoica/CA-209502
CA-209502: Exception while deleting multiple folders
2016-07-01 09:04:48 +01:00
Liang Dai
42f69a7ea1 CA-144951: [WLB Settings] Multiple pop-ups when navigating to Automation tab.
Signed-off-by: Liang Dai <liang.dai1@citrix.com>
2016-07-01 13:37:38 +08:00
Alexander von Gluck IV
47c65d4bcc XenAdmin/Resources: More image path case fixes 2016-06-30 23:01:52 -05:00
Alexander von Gluck IV
4d0097ce9c XenAdmin/TabPages: Case fix on WlbPage files 2016-06-30 22:51:27 -05:00
Alexander von Gluck IV
4cf4c4c33f XenAdmin/Resources: Fix case of images paths 2016-06-30 22:42:58 -05:00
Mihaela Stoica
bcc120f0b2 CA-209502: FolderAction refactoring
- created subclasses for each folder action type (create, rename, delete, move)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-30 15:41:46 +01:00
Mihaela Stoica
60c298d9e3 CA-116547: During Installation of Hotfix requiring restart of PV guests displays Dom0 in the list of VMs to be rebooted in XenCenter.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-30 12:32:41 +01:00
Konstantina Chremmou
975fe4f303 While researching the places where we use is_control_domain, I refactored some issues I noticed and were quick to fix:
- removed unnecessary casts
- no need to catch exception only to rethrow it; do not interrupt the call stack by using "throw ex"
- redundant check and value setting
2016-06-30 12:23:49 +01:00
Cheng Zhang
76f7946ec4 CA-213045: Make server backup file name rebrandable
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2016-06-30 10:31:10 +08:00
Konstantina Chremmou
d35c162e76 CP-17689: Restrict maximum host failures to tolerate to the number specified by the other-config:hci-limit-fault-tolerance field. 2016-06-29 12:57:29 +01:00
Mihaela Stoica
97feb30fbf Merge pull request #1041 from kc284/CAR-2217-other
CP-17866: Grey out the "Move" button on the VM storage tab if the storage does not allow mirroring.
2016-06-28 13:22:30 +01:00
Mihaela Stoica
20cb3b4df1 Merge pull request #1042 from kc284/master
Latest API bindings, including definition of dundee-plus release...
2016-06-28 13:09:36 +01:00
Konstantina Chremmou
db79326ab1 Merge pull request #1025 from MihaelaStoica/CA-212147
CA-212147: RPU failing with insufficient license error when host lice…
2016-06-27 11:37:46 +01:00
Konstantina Chremmou
3d8ae9daf8 CP-17470: Added missing hotkey. Performance improvement by using Exists instead of FindAll in check. 2016-06-27 10:43:29 +01:00
Konstantina Chremmou
fd3393049c Code simplification: use Action delegate instead of EventHandler since the event is not sending any objects when triggered. 2016-06-27 10:20:23 +01:00
Konstantina Chremmou
5dd2873b72 CP-17866: Grey out the "Move" button on the VM storage tab if the storage does not allow mirroring. 2016-06-24 18:10:22 +01:00
Mihaela Stoica
05059c6f52 CA-213414: Check feature-flag for ssl-legacy control switch
- For Dundee and newer hosts: the feature is restricted only if the "restrict_ssl_legacy_switch" flag exists and it is set to true
- For pre-Dundee hosts: the feature is restricted if the "restrict_ssl_legacy_switch" is absent or it is present and set to true

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-24 13:16:40 +01:00
Konstantina Chremmou
7e926f64a3 Rebooted myself. 2016-06-23 21:27:41 +01:00
Frezzle
7faf4fad1d Merge pull request #1032 from MihaelaStoica/CP-17161
CP-17161: Add 'using' statement around dialogs to ensure garbage collection
2016-06-23 15:52:32 +01:00
Mihaela Stoica
e87505e13d CP-17161: Add 'using' statement around dialogs to ensure garbage collection
- fix a dialog return check changed by accident

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-23 15:47:15 +01:00
Konstantina Chremmou
8e2c381f85 CP-17470: Warn users if they attempt rebooting or shutting down a host running a
VM with the hci-warn-before-shutdown flag. Minor changes to make the warnings for
rebooting and shutting down more consistent (preselect the No button for rebooting;
extended the Yes button text; modified warning text)
2016-06-23 15:26:32 +01:00
Konstantina Chremmou
3fc701ecb8 CP-17502: Hide SR types from the NewSrWizard if the corresponding sm plugin is not available.
Further, disable the Reattach SR if there is no sm plugin for its type.
2016-06-22 18:34:21 +01:00
Konstantina Chremmou
bdbd9e1f55 CP-17502: No directly related to this ticket, but I found myself in the ISO SR neighbourhood and did some minor refactoring. 2016-06-21 10:29:37 +01:00
Konstantina Chremmou
0f908a674e CP-17750: Block the patching wizard for clusters with the hci-forbid-update flag (disable the relevant pools/hosts on the select servers page; do not launch the patching wizard at all if there are no clusters that can be patched). 2016-06-20 14:10:00 +01:00
Mihaela Stoica
62870544c6 CP-17161: Add 'using' statement around dialogs to ensure garbage collection
- fix UpsellDialog usages

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-20 13:26:52 +01:00
Mihaela Stoica
da9e99b1cb CP-17161: Add 'using' statement around dialogs to ensure garbage collection
- fix ActionProgressDialog usages

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-20 13:17:42 +01:00
Konstantina Chremmou
b575fd3d44 CP-17690: Block RPU for clusters with the hci-forbid-rpu flag (disable the relevant pools/hosts on the select pool page; do not launch the RPU wizard at all if there are no upgradable clusters). 2016-06-20 13:11:21 +01:00
Mihaela Stoica
3f25c5868f CP-17161: Add 'using' statement around dialogs to ensure garbage collection
- fix all ThreeButtonDialog usages (and some other dialogs that I've came across)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-20 10:49:12 +01:00
Mihaela Stoica
72cffa03e3 CA-212147: RPU failing with insufficient license error when host license removed
If the license does not allow VM migration, then cause the VMs to be shut down / suspended on the pre-checks page

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-14 13:38:12 +01:00
Frederico Mazzone
acf39533fe [CA-207306] Select box is not in line with pGPU bar on GPU tab of host
The last pGPU's row was stretching to the bottom, causing the lowest select box to fill its space and go down too much.
Changed the select boxs' dock style and margin.

Signed-off-by: Frederico Mazzone <fredericom@citrite.net>
2016-06-13 15:16:31 +01:00
Gabor Apati-Nagy
d04cccea85 Merge pull request #1017 from MihaelaStoica/CA-212905
CA-212905: Fix dialog size
2016-06-13 11:14:26 +01:00
Mihaela Stoica
996f84c97f CA-212905: Fix dialog size
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-10 11:25:38 +01:00
Mihaela Stoica
a89ba4a91e Merge pull request #1013 from kc284/master
CA-212078: Do not check for CPU compatibility feature when the VM's r…
2016-06-08 12:59:26 +01:00
Mihaela Stoica
fcee4d8876 CA-77990: Report required actions for all VMs at once in the hotfix wizard / RPUW (#951)
* CA-77990: Report required actions for all VMs at once in the hotfix wizard / RPUW

* CA-77990: Resolve precheck problems in parallel in the Patching wizard

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* CA-77990: Resolve precheck problems in parallel in the Patching wizard

Changes following code review: Made the ParallelAction work across connections and removed CrossConnectionParallelAction

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* CA-77990: Modified ParallelAction to create queue on RunSubActions only, with the correct queue size

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-07 17:40:59 +01:00
Konstantina Chremmou
42f76bfa23 CA-212078: Correction as per code review to guard against the case when the VM is not resident on any host. 2016-06-07 12:27:54 +01:00
Konstantina Chremmou
5b19081d61 CA-212078: Do not check for CPU compatibility feature when the VM's resident host is not dundee or greater. 2016-06-07 09:30:37 +01:00
Mihaela Stoica
41f749e941 Merge pull request #1011 from fillzero/master
CA-150197: Improvement: No confirmation message before delete wlb scheduler
2016-06-06 13:38:29 +01:00
Liang Dai
2a874bbf40 CA-150197:EN: Improvement: No confirmation message to ask if certain to delete Scheduler
Signed-off-by: Liang Dai <liang.dai1@citrix.com>
2016-06-06 15:55:40 +08:00
Mihaela Stoica
5d58222248 CA-209502: Exception while deleting multiple folders
- Changed the FolderAction class so that it can be used to delete or move multiple folders across connections, instead of having multiple actions (one for each holder) which can not run in parallel.
- The api calls that update the EMPTY_FOLDERS entry in pool's other_config are preformed last for all connections, avoiding cross-thread exceptions when two threads try to add/remove the same key.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-03 15:38:52 +01:00
Liang Dai
fd5c7773f5 CA-150197:EN: Improvement: No confirmation message to ask if certain to delete Scheduler
Signed-off-by: Liang Dai <liang.dai1@citrix.com>
2016-06-03 14:19:59 +08:00
Gabor Apati-Nagy
725beacd4b CA-209290: "Virtualization state" label displayed twice on General Tab of newly created VM
Fixed duplicated headers.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-02 12:03:26 +01:00
Gabor Apati-Nagy
81ec2af86b Merge pull request #1003 from MihaelaStoica/CA-208829
CA-208829: Unexpected error if connection lost while health check dia…
2016-06-01 14:01:47 +01:00
Mihaela Stoica
82a274571b Merge pull request #1002 from GaborApatiNagy/master_CA-208707
CA-208707: [SCTX-2316] XenCenter Incorrect pop-up error message displayed if SSL secure channel cannot be created
2016-06-01 14:00:50 +01:00
Mihaela Stoica
2b993a4a9c Merge pull request #1007 from Frezzle/vdi-attach-exception
CA-211418: Exception in XenCenter while attaching vdi to a VM on a p…
2016-06-01 13:46:58 +01:00
Frederico Mazzone
b21d87e6e6 [CA-211418] Exception in XenCenter while attaching vdi to a VM on a pool with an SR with 20,000 VDIs
Added back the event handler removal in BuildList function, as it can run more than once.

Signed-off-by: Frederico Mazzone <fredericom@citrite.net>
2016-05-31 11:23:31 +01:00
Frederico Mazzone
b401a11e76 [CA-211418] Exception in XenCenter while attaching vdi to a VM on a pool with an SR with 20,000 VDIs
All event handlers are now unsubscribed when AttachDiskDialog is closed, allowing its memory to be garbage collected.
Image for each VDI now references an existing image instead of creating a new object.

Signed-off-by: Frederico Mazzone <fredericom@citrite.net>
2016-05-25 16:37:31 +01:00
Mihaela Stoica
67e4e2113f CA-208829: Unexpected error if connection lost while health check dialog open
- Invoke on the main thread

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-05-23 14:11:03 +01:00
Gabor Apati-Nagy
9d2a204bb7 CA-208707: [SCTX-2316] XenCenter Incorrect pop-up error message displayed if SSL secure channel cannot be created
My commit fixes the error message so the dialog will show "Could not create SSL/TLS secure channel." instead of "An unknown error occurred". This text is localised.
Unfortunately we see only a WebException with Status=SecureChannelFailure with no other details - couldn't provide an improved error message

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-05-23 12:48:01 +01:00
Mihaela Stoica
0527164425 CA-211417: Remove WLB.chm
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-05-23 11:42:33 +01:00
Frederico Mazzone
8954c2e038 [CP-17415] XC: Add awareness of new AD feature flag
Added AD-related strings to japanese and chinese resource files; still need translation.
Changed F1/Help mapping of the AD upsell tab to go to the 'Managing Users' help page.

Signed-off-by: Frederico Mazzone <fredericom@citrite.net>
2016-05-20 14:30:39 +01:00
Frederico Mazzone
9a729e2547 [CP-17415] XC: Add awareness of new AD feature flag
Added awareness; basic license now shows upsell tab and premium license shows full feature tab.

Signed-off-by: Frederico Mazzone <fredericom@citrite.net>
2016-05-20 13:01:51 +01:00
Gabor Apati-Nagy
5ba776d0bf Merge pull request #996 from Frezzle/lost-scrollbar
[CA-208810]: I18n:JA/SC:  Lost Scrollbar for the long strings...
2016-05-18 13:32:51 +01:00
Frederico Mazzone
781fcba141 [CA-208810]: I18n:JA/SC: Lost Scrollbar for the long strings...
Made textbox bigger in health check policy dialog.
Made textbox bigger in the 'Authentication with Citrix Insight Services'
section of the health check enrollment dialog.
Adjusted some control properties to correct the position of OK/Cancel
buttons.
Changed 'User name:' labels to 'Username:' in health check enrollment
dialog.
Changed Chinese and Japanese resource files to match English changes.

Signed-off-by: Frederico Mazzone <fredericom@citrite.net>
2016-05-16 14:29:21 +01:00
CITRITE\sriharshak
0da47aa988 L10N: Xencenter:Help Update 2016-05-16 09:04:45 +05:30
Mihaela Stoica
3f7f33fc40 CA-210732: XenCenter VM properties GPU always shows "None" (#983)
* CA-210732: XenCenter VM properties GPU always shows "None"

The error occurs when there is a gpu group with only one vgpu type: When setting the selected item in the vGPU combobox, XenCenter tries to select the group header instead of the vGPU type; because the group header is not selectable, we then default to "None".
With this fix, we ensure that two items are not equal if one is a group header and the other is a subitem.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* CA-210732: XenCenter VM properties GPU always shows "None"

Changes following code review: Added the reverse case in the Equals function

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* CA-210732: XenCenter VM properties GPU always shows "None"

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-05-12 13:44:16 +01:00
Frederico Mazzone
bfd0a6365e Added fred/myself to the credits.
Signed-off-by: Frederico Mazzone <frederico.mazzone@citrix.com>
2016-05-06 17:02:12 +01:00
CITRITE\sriharshak
8b8ea87f5c Dundee:L10N help check-ins 2016-05-05 15:21:33 +05:30
CITRITE\sriharshak
6c202460d9 Merge branch 'master' of https://github.com/sriharshak/xenadmin 2016-05-05 15:16:34 +05:30
Gabor Apati-Nagy
834c012fb8 Merge pull request #953 from MihaelaStoica/CA-206464
CA-206464: Add certificate validation to the VM export
2016-05-04 13:58:04 +01:00
Frederico Mazzone
049e0f100d CA-209496: EN: Duplicate hotkey appeared on the “Updates” page of “Notifications” windows.
Changed hotkey for 'Check for Updates Now' button from Alt+U to Alt+C.

Signed-off-by: Frederico Mazzone <frederico.mazzone@citrix.com>
2016-05-03 18:09:59 +01:00
CITRITE\sriharshak
c4e5528920 L10N:CA-209394 partial fix 2016-04-28 11:29:23 +05:30
Mihaela Stoica
aeb64f04e0 Merge pull request #948 from stephen-turner/CA-137301
CA-137301: Double-click should choose item in Move VM/VDI dialogs
2016-04-27 14:47:23 +01:00
Stephen Turner
f71bea09b3 Merge pull request #966 from MihaelaStoica/CA-208808
CA-208808: The items of “Day of the week” drop-down list are not localized
2016-04-27 14:26:21 +01:00
Mihaela Stoica
afb60dcb0f CA-208808: The items of “Day of the week” drop-down list are not localized
- added HelpersGUI.DayOfWeekToString function

Signed-off-by: Mihaela Stoica <Mihaela.Stoica@citrix.com>
2016-04-27 14:22:50 +01:00
CITRITE\sriharshak
809bf9161e L10N:Dundee translation changes 2016-04-26 16:39:21 +05:30
Mihaela Stoica
394320679f CA-208808: The items of “Day of the week” drop-down list are not localized
Signed-off-by: Mihaela Stoica <Mihaela.Stoica@citrix.com>
2016-04-26 11:17:09 +01:00
Mihaela Stoica
f9c52cd637 Merge pull request #962 from sriharshak/master
L10N:CA-205536 fix
2016-04-22 11:18:32 +01:00
CITRITE\sriharshak
56b5ccbda5 L10N: CA-205187 fix(partial) 2016-04-21 23:45:24 +05:30
CITRITE\sriharshak
f600cb53a5 L10N:CA-205536 fix 2016-04-21 23:14:03 +05:30
Gabor Apati-Nagy
e7d7661d51 CA-208720: Fix for: Can type text into the label in Bugtool wizard, Destination page
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-04-21 17:55:56 +01:00
Mihaela Stoica
972055fbb7 Merge pull request #959 from sriharshak/master
L10N: CA-208682 fix
2016-04-21 15:21:09 +01:00
Mihaela Stoica
858b582319 Merge pull request #960 from ushamandya/master
CA-208609: Updated version of XC Help
2016-04-21 15:20:49 +01:00
Usha Mandya
101c1d7b12 CA-208609: Updated version of XC Help 2016-04-21 15:04:42 +01:00
CITRITE\sriharshak
f043573688 L10N:CA-207887 fix 2016-04-21 18:28:36 +05:30
CITRITE\sriharshak
240546795c L10N: CA-208682 fix 2016-04-21 18:23:22 +05:30
CITRITE\sriharshak
baf05cc194 L10N:CA-205650 fix 2016-04-21 17:54:35 +05:30
CITRITE\sriharshak
7d5f20cf4e L10N:CA-206595 fix 2016-04-21 17:17:22 +05:30
Mihaela Stoica
421b1bd827 Merge pull request #955 from sriharshak/master
L10N:CA-151447 fix
2016-04-21 10:58:55 +01:00
Stephen Turner
0ff7604dc1 Merge pull request #954 from MihaelaStoica/CA-208609
CA-208609: Change wording on TLS settings page
2016-04-21 10:28:22 +01:00
Mihaela Stoica
3a5e6a8798 CA-208609: Change wording on TLS settings page
Signed-off-by: Mihaela Stoica <Mihaela.Stoica@citrix.com>
2016-04-21 09:37:13 +01:00
CITRITE\sriharshak
68790cc1fc L10N:CA-205182 fix 2016-04-21 13:55:37 +05:30
CITRITE\sriharshak
9b6ecde8ab L10N:CA-169593 fix 2016-04-21 12:34:33 +05:30
Stephen Turner
30dfce6a7b CA-137301: Add null checks, following code review 2016-04-20 17:18:46 +01:00
Mihaela Stoica
ed7548e02a CA-206464: Add certificate validation to the VM export
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-04-20 15:17:48 +01:00
CITRITE\sriharshak
8c0623b8f2 L10N:Dundee:Translation check-ins 2016-04-20 19:16:33 +05:30
Mihaela Stoica
549e26ad94 CA-208495: XenCenter does not specify the NFS version when reattaching an existing SR
- Re-position the version radio-buttons, so that is clear that the selected version applies to both Create and Reattach
- Pass the selected version to the attach command in the device_config parameter

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-04-20 09:44:58 +01:00
Stephen Turner
953ea412df CA-137301: Double-click should choose item in Move VM/VDI dialogs 2016-04-18 16:17:01 +01:00
Mihaela Stoica
64d9bece24 CA-207915: XenCenter does not display the correct supported NFS versions in the New SR wizard
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-04-15 15:01:09 +01:00
Stephen Turner
eaa85a3b2e Merge pull request #945 from ushamandya/master
Fixed a minor bug
2016-04-15 11:19:49 +01:00
Usha Mandya
f9a3f323dc Fixed a minor bug 2016-04-15 11:10:51 +01:00