- Add options for multiple users/subjects
- Let user know they'll also be disconnecting other users
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-359809 improved illegal character message
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
* CA-359809 cleared whitespace, improve code readability
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
* CA-359809 implemented reviewer comments.
Moved Path validator to XenModel Project where other language files have already been set up.
Improved error messages.
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
* CA-359809 improved string localisation, Code tidy
Cannot became can not, messages file alphabetised, improved readability with using xenmodel as opposed to direct call
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
* CA-359809 changed can not to cannot
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
- CA-359068¨Match the whole datasource name (previously the wrong one was picked
for disk read/write latency).
- New/edit Graph dialog: differentiate between enabled/disabled datasources and
visible/hidden (known/unknown units; the latter may mean no data).
- Some refactoring.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Also, no need to use a different message for single and multiple VMs or templates.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* CA-34231: Replace negative language with `block list` in code and references
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `stop` in code and references
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `freezing` in code
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `run/ran` in code comments
Some paramater mentions have been renamed, as they will be renamed in future commits.
Excluded mentions in XenAPI/Host.cs and XenAPI/VM.cs since code is autogenerated.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# CFUValidator/CommandLineOptions/CFUCommandLineOptionManager.cs
# XenAdmin/Controls/Wlb/WlbOptModeScheduler.cs
# XenAdmin/Dialogs/Wlb/WorkloadReports.cs
* CA-34231: Replace negative language with `run` in Command.cs Run method
Used Resharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/TabPages/GeneralTabPage.cs
* CA-34231: Replace negative language with `run` in Command.cs CanRun method
Used Resharper rename utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `run` in Command.cs CanRunCore method
Used ReSharper rename utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Commands/DRConfigureCommand.cs
# XenAdmin/Commands/DRDryrunCommand.cs
# XenAdmin/Commands/DRFailbackCommand.cs
# XenAdmin/Commands/DRFailoverCommand.cs
# XenAdmin/Commands/DisasterRecoveryCommand.cs
# XenAdmin/Commands/VMGroupCommand.cs
* CA-34231: Replace negative language with `run` in Command.cs RunCore method
Used ReSharper rename utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `run` in Command.cs GetCantExecuteReasonCore method
Used ReSharper rename utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `run` in Command.cs GetCantRunReasons method
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace remaining negative language with `run` in Command.cs
Also applied to related symbols. Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `run` in methods named CanRun
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `run` in methods in CrossPoolMigrateCommand.cs
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Commands/CrossPoolMigrateCommand.cs
* CA-34231: Replace negative language with `run` in remaining Run methods
Also updated negative language in `DeleteVMCommand`
Also updated in comment in `CrossPoolMigrateCommand`
Also renamed missed instances of `CanRun`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `run` in `CanRunCore` and `RunCore`
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace remaining negative language with `run` in Commands folder
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace remaining negative language with `run` in XenAdmin/Controls folder
Used ReSharper renaming utility. Had to rename `WlbReportView.xs:RunReport()` to `WlbReportView.xs:StartRunReport()` to resolve conflict with change from `WlbReportView:ExecuteReport()` to `WlbReportView:RunReport()`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Controls/Wlb/WlbOptModeScheduler.cs
# XenAdmin/Dialogs/Wlb/WorkloadReports.cs
# XenAdminTests/UnitTests/WlbTests/WlbScheduledTaskTests.cs
* CA-34231: Replace all remaining negative language with `run` in code
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Commands/Controls/WlbRecommendations.cs
# XenAdminTests/UnitTests/WlbTests/WlbScheduledTaskTests.cs
# XenModel/WLB/WlbScheduledTask.cs
* CA-34231: Replace negative language with `supporter` or `bond member` in code strings
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `supporter` or `bond member` in Messages string
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/MainWindow.cs
# XenAdmin/Wizards/PatchingWizard/PatchingWizard_SelectServers.cs
# XenModel/Messages.Designer.cs
# XenModel/Messages.resx
* CA-34231: Replace remaining negative language with `supporter` in .resx files
Used ReSharper renaming utility. FriendlyErrorNames.resx has been excluded.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `supporter` or `bond member` in XenAdmin code
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Dialogs/NewPoolDialog.cs
* CA-34231: Replace negative language with `supporter` or `bond member` in XenModel code
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `coordinator` in CFUValidator code
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# CFUValidator/CFUValidator.cs
* CA-34231: Replace negative language with `coordinator` in solution's comments and hardcoded strings
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `coordinator` in `Helpers:GetCoordinator` method
Used ReSharper renaming utility.
also renamed similarly named method in `ObjectChange.cs`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Alerts/Types/HotfixEligibilityAlert.cs
# XenAdmin/Controls/CustomDataGraph/ArchiveMaintainer.cs
* CA-34231: Replace negative language with `coordinator` in `EvacuateHostDialog.resx`
Used ReSharper renaming utility. Excluded jp and zh resources
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Dialogs/EvacuateHostDialog.resx
* CA-34231: Replace negative language with `coordinator` in `EvacuateHostDialog.resx`
Used ReSharper renaming utility. Excluded jp and zh resource files.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Dialogs/NewPoolDialog.resx
* CA-34231: Rename missing language references for change to `coordinator`
Misc files were not saved before last commits.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `coordinator` in `Messages.resx`'s code
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Commands/HACommand.cs
# XenAdmin/TabPages/AdPage.cs
# XenModel/Actions/Network/CreateBondAction.cs
# XenModel/Actions/Network/NetworkAction.cs
# XenModel/Messages.Designer.cs
# XenModel/Messages.resx
* CA-34231: Replace negative language with `coordinator` in `ExternalPluginAction.cs`
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `coordinator` in `XenAdmin/Commands`
Used ReSharper renaming utility. Also replace negative language in missed comment in `ExternalPluginAction.cs`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Commands/AddHostToPoolCommand.cs
# XenAdmin/Commands/HACommand.cs
* CA-34231: Replace negative language with `coordinator` in `Helpers.cs`
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `coordinator` in `NetworkingHelper.cs`
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `coordinator` in `PoolJoinRules.cs`
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Dialogs/NewPoolDialog.cs
* CA-34231: Replace negative language with `coordinator` in `XenAdmin/Commands`, `Controls`, and `Core`
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Commands/AddHostToPoolCommand.cs
* CA-34231: Replace negative language with `coordinator` in `XenAdmin/Diagnostics`
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `coordinator` in `XenAdmin/Dialogs`
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Dialogs/NewPoolDialog.cs
* CA-34231: Replace remaining negative language with `coordinator` in `XenAdmin`
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/MainWindow.cs
# XenAdmin/TabPages/GeneralTabPage.cs
# XenAdmin/Wizards/PatchingWizard/PatchingWizard_SelectServers.cs
# XenAdmin/Wizards/RollingUpgradeWizard/RollingUpgradeExtrasPage.cs
# XenAdmin/Wizards/RollingUpgradeWizard/RollingUpgradeWizard.cs
# XenAdmin/Wizards/RollingUpgradeWizard/RollingUpgradeWizardPrecheckPage.cs
# XenAdmin/XenSearch/Columns.cs
* CA-34231: Replace remaining negative language with `coordinator` in `XenModel\Actions`
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenModel/Actions/Network/CreateBondAction.cs
* CA-34231: Replace remaining negative language with `coordinator` in `XenModel`
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace remaining negative strings with `main` in `Messages.resx`
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenModel/Messages.Designer.cs
# XenModel/Messages.resx
* CA-34231: Replace remaining negative string names with `main` in `Messages.resx`
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Dialogs/OptionsPages/SaveAndRestoreOptionsPage.cs
# XenModel/Messages.resx
* CA-34231: Rename dialogs to replace negative connotations with `main`
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `main` in `SaveAndResoreOptionsPage.cs`
Also updated its resx file. Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Dialogs/OptionsPages/SaveAndRestoreOptionsPage.cs
* CA-34231: Fix invalid reference in `SaveAndRestoreOptionsPage.Designer.cs` after renaming
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `main` in `EnterMainPasswordDialog.cs`
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `main` in `ChangeMainPasswordDialog.cs`
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Fix invalid reference not changed after renaming `EnterMainPasswordDialog.cs`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace remaining negative language with `main` in `XenAdmin/Dialogs`
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Update class names in HelpManager.resx
Following renaming of main password dialog. Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `main` in `Metadata.cs`
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Remove remaning negative language with `coordinator` from `Messages.resx`
Used ReSharper renaming
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Remove remaning negative language with `other pool member` from `Messages.resx`
Used ReSharper
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace remaining negative language in solution
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Remove commented out code in VNCGraphicsClient.cs
Code has only been improved partially as it's not strictly relevant to the PR
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Amend negative word replacement in XSVNCScreen.cs
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Simplify debug call formatting in NewPoolDialog.cs
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Add code mistakenly removed in MainWindow.cs
Removed as part of `f155f9c8`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Revert renaming of constant related to Windows' API
Considered external to CH Center
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Amend hotkey for Coordinator field in `NewPoolDialog`
Previous ALT+<key> hotkey was conflicting with CreatePool
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Remove unecessary whitespace in EvacuateHostDialog.cs
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Update if block to exclude unecessary else in DRFailoverWizard.cs
Not relevant to the PR, but the change is small enought to no need extra testing
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Amend typo in PoolJoinRules.cs
supporer -> supporter
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Replace missing negative language with `coordinator` in `XenAPI-Extensions/Pool.cs`
Variables and methods XenAPI-Extensions were mistakenly skipped
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Replace negative language in `XenApi-Extensions` with `coordinator/interface`
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Replace negative language in `XenApi-Extensions` with `supporter/member`
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Replace remaining negative language in `XenServerHealthCheckBugTool.cs`
This is only used to format the string
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Change line-endings to CRLF in `Page_CloudConfigParamters.cs`
Done in order to fix merge conflict into master
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Amend misc negative language renaming typos
`XenServerHealthCheckBugTool` and `XenServerHealthCheckService`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-310974: Hide GPU page if the host has no GPU capability
* Hid GPU page in PropertiesDialog
* Hid GPU page in NewVMWizard
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-310974: Move GPU availability check to Helpers class
* Switch from field to method based check
* Update affected logic
* Remove rubric toggle in PopulatePage when GpuEditPage is shown
* Hide AddVGPUDialog when GpusAvailable returns false
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-310974: Remove missing GPUs strings in Messages.resx
* GPU_RUBRIC_NO_GPUS_POOL
* GPU_RUBRIC_NO_GPUS_SERVER
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-310974: Disable combobox in AddVGPUDialog when there are no GPUs
Avoids exception being thrown if user tries to select empty first item
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-310974: Amend position of GPU availability check
Moved since gpuCapability is used in the Finish method of the wizard
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-310974: Remove unecessary null checks in Helpers method
The Cache and its properties (e.g. GPU_groups) are readonly and initialised as empty.
The API object properties that are ref lists (g.PGPUs, g.supported_VGPU_types) are also initialised as empty and are demarshalled by the SDK as empty if they have no values.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
This allows removal of DelegatedAsyncAction.ResultObject, which might lead to complicated implementations.
Also: some refactoring of the other WLB retrieve recommendations actions.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Fixed exception handling in RetrieveWlbConfiguration action (exceptions of type
other than Failure were silenced).
- CA-339666: Fixed control flickering when showing the WorkloadReports dialog.
- Retrieve the WlbConfiguration before attempting populating the controls.
- If the dialog was launched requesting a certian report to be run, the report
was not selected on the list.
- Some refactoring to simplify the code.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Also, NoTargetServerPoolItem class should be private to the SelectMultipleVMDestinationPage
because it is not used anywhere else.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Reordered the labels to reduce flickering for short actions.
- No need to fire action events in a try-catch block.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
For reasons of code reduction and also because the look and feel of this dialog
was slightly different from the usual application pop-ups.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* CP-35838: Add health check precheck into RPU wizard
* CP-35838: Add disable Health Check in RPU precheck warning
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
- Removed wrapper delegates; call the http_actions directly.
- In case of failure or cancellation of the http_action, poll the related task
ignoring any exceptions thrown, so that any clean up code within the http_action's exception handling can run.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Moved the code to the ExportApplianceAction so it's easier to modify the
action's description.
- Fixed issue where the user's option for adding signature/manifest to a plain
OVF package was ignored.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* Hid properties from the designer and renamed them because they give the wrong impression.
* Fixed some inefficiencies around the NetworkComboboxItem.
- Move NetworkComboBoxItem into the NetworkComboBox class.
- Moved XenAdmin.Dialogs.NetworkComboBoxItem into the VIFDialog class and made it
private to avoid ambiguousness with the public XenAdmin.Controls.NetworkComboBox.NetworkComboboxItem.
- Create a NetworkComboBoxItem only if needed and assign its name at construction time.
- Add method to select a NetworkComboBoxItem and property to return the SelectedNetwork.
* CA-339233: Do not allow selection of networks while they're locked.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Improvements to progress reporting (CA-65894).
- Added some logging.
- Use the connection cache instead of making server calls.
- Moved some methods to the string utilities and added unit tests.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Previously this was not possible due to XenModel-XenOvfTransport cyclical references.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* CA-343763: Corrected the handling of VMSS alert priority/severity according to CA-342874.
- Distinguish between warnings and errors.
- Made PolicyAlert derive from MessageAlert to conform with other alert types.
- Replaced EventType column by a simple image column because it adds to clatter
without really offering useful information.
* Correction as per code review.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- CP-34862: Do not allow nomination of new master if a pool secret rotation or
other pool operations are in progress.
- CA-292642: Fixed button enablement after resolving VM problem.
- CA-284126: Added button to rescan running VMs on the server.
- Removed annoying, focus stealing, modal action progress dialog. When scanning
for VMs show a spinner on the control instead.
- Fixed crash when the host combobox was updated due to cache changes.
- Logging in an elevated session was happening on the UI thread.
- Show the role elevation dialog before launching the host evacuation dialog or
we end up with showing the user an unpopulated control.
- Stop deriving from animated progress dialog because it makes it difficult to
get the resizing right when adding more controls.
- Stop using the progress bar for the VM solution actions; rely simply on the
action's description and the VM's icon in the gridView.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Use CommandButtons on the HA TabPage for configuring/disabling HA.
- Added menu item to disable HA.
- There is no point in hiding the buttons on the HA TabPage when the corresponding
menu items are available. They should rather offer the same user experience.
- Added RBAC page to the HaWizard to avoid unnecessary SR scanning only to be told
that one cannot proceed.
- Show RBAC error dialog if the user does not have permission to launch the
EditVmPriorities dialog.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Disabled button tooltips did not disappear when the DataGridView selection was cleared.
- The disabled Activate/Deactivate button had no tooltip for template disks.
- Minor improvement to the tooltip of the Delete button.
- The Add button was using the enablement logic of the AttachVirtualDiskCommand.
- Use CommandButtons to avoid logic duplication.
- Hide the CommandButton.Command from the designer as it's mostly assigned programmatically.
- Increased the minimum width of the non-autosizable columns so they remain visible.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Use a plain list to store update alerts and, where possible, fire a collection
change event only after a bulk change and not every time a single object is added
or removed.
- Fixed issue where dismissed updates were stored in the config of all connected
pools, even of those where the update did not apply.
- Corrected RBAC checks for update dismissal.
- Fixed enabled state of dismiss buttons.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* Replaced LicenseWarningDialog with a simple WarningDialog.
* Replaced VcpuWarningDialog with a simple WarningDialog.
* Replaced RemoveCrashdumpsWarningDialog with a simple WarningDialog.
* Replaced UsbUsageDialog with a simple WarningDialog.
* Replaced WlbDeleteReportSubscriptionDialog with a simple WarningDialog. Added null checks to event invocation.
* Replaced DisableWlbDialog with a simple Warning dialog.
* Replaced ConnectionRefusedDialog with a simple Error dialog.
* Replaced UserDeviceDialog with a simple Warning dialog.
* Replaced RevertDialog with a simple Warning dialog.
* Removed unused dialogs.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Though this was shown in units like kB/s and MB/s (decimal units) it was calculated in
binary terms i.e. 1MB/s was treated as 1024kB/s instead of the expected 1000kB/s.
Updated translations for the units to be of the form 'MB/s' instead of 'MBps'.
Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
The result was that numbers were changing suddenly; in cases of slow connections,
a user could make a selection before the scan was over.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
This fixes various workflow bugs and disallows re-attaching GFS2 SR if clustering
is disabled.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
