Commit Graph

2596 Commits

Author SHA1 Message Date
Kun Ma
c007194e06 CP-21658: Expose UI of feature REQ-378 to user when the XenServer support the feature
Signed-off-by: Kun Ma <kun.ma@citrix.com>
2017-04-17 15:27:50 +08:00
Kun Ma
8c837bb2c2 CP-19639: Refine data structure for mail language
Signed-off-by: Kun Ma <kun.ma@citrix.com>
2017-04-13 13:34:30 +08:00
Gabor Apati-Nagy
49fd823650 CA-249084: deleted more unneeded code
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-04-11 17:50:47 +01:00
Gabor Apati-Nagy
3805bcef40 CA-249084: Fixes for code review
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-04-11 17:31:17 +01:00
Gabor Apati-Nagy
2823e0337b CA-249084: Fix code for new build number format
removing unneeded code (after 55f17d4)

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-04-11 16:37:19 +01:00
Gabor Apati-Nagy
72ceeb2de3 CA-249084: Removed obsolete functionality
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-04-11 16:01:20 +01:00
Gabor Apati-Nagy
55f17d416b CA-249084: Fix code for new build number format
fixed by removing checks that are no longer needed

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-04-11 11:06:03 +01:00
Gabor Apati-Nagy
1abf9bf525 CA-249084: Build number is gone, hiding it
Hide build number from now on
2017-04-11 11:04:49 +01:00
Mihaela Stoica
8650f5880b CA-249824: Unable to create vlan, bond using XenCenter
- set managed=true, otherwise the network creation fails with the error "The network is not managed by xapi"

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-04-10 07:49:51 -04:00
Mihaela Stoica
b65c4cd578 Merge pull request #1531 from letsboogey/nre_on_rdp
CA-249627 - NPE while accessing XenCenter console on a RDP establishe…
2017-04-07 12:05:20 +01:00
Letsibogo Ramadi
0381de85a4 CA-249627 - NPE while accessing XenCenter console on a RDP established & then disconnected guest VM 2017-04-07 11:41:59 +01:00
Gabor Apati-Nagy
b332082d43 Merge pull request #1521 from MihaelaStoica/CA-248471
CA-248471: XenCenter offers passthrough on unlicensed hosts even when…
2017-04-05 10:50:30 +01:00
Mihaela Stoica
75ed339d04 Merge pull request #1522 from letsboogey/master
CA-150305 - EN: Truncation issue occurs under the “Hide Details” of S…
2017-04-04 17:34:51 +01:00
Letsibogo Ramadi
ea6a082136 CA-150305 - EN: Truncation issue occurs under the “Hide Details” of Snapshots tab
Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-04-04 17:15:15 +01:00
Kun Ma
6dc10c1490 CP-19453: XenCenter: Add mail-language to other-config parameters when configure e-mail options
Signed-off-by: Kun Ma <kun.ma@citrix.com>
2017-04-01 11:21:21 +08:00
Kun Ma
22446010b4 CP-19639: Provide XenCenter UI configuration option for email alert charset
Signed-off-by: Kun Ma <kun.ma@citrix.com>
2017-04-01 09:58:17 +08:00
Mihaela Stoica
6c260c04d0 CA-248471: XenCenter offers passthrough on unlicensed hosts even when it's not available
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-03-30 15:06:54 +01:00
Gabor Apati-Nagy
70a4e9880e Merge pull request #1506 from MihaelaStoica/CA-237939
CA-237939: Cannot create VM from Checkpoint other than the resident h…
2017-03-28 14:43:10 +01:00
Gabor Apati-Nagy
6d6a9ed147 Merge pull request #1490 from MihaelaStoica/CA-152101
CA-152101: Incorrect error when trying to license pool with old licen…
2017-03-28 14:31:58 +01:00
Gabor Apati-Nagy
3a83bba457 Merge pull request #1503 from letsboogey/gpu
CP-21558 - On the vGPU types dialog, hide the column headers where al…
2017-03-28 10:54:54 +01:00
Letsibogo Ramadi
808063c125 CP-21558 - On the vGPU types dialog, hide the column headers where all the values are 0 2017-03-27 14:22:16 +01:00
Mihaela Stoica
06e624c3dc Merge pull request #1502 from stephen-turner/CA-248254
CA-248254: XenCenter doesn't list partially applied patches if there are fully applied patches
2017-03-24 10:50:23 +00:00
Mihaela Stoica
dc56379dc3 CA-232996: Storage menu doesn't refresh in XenCenter for destroy and forget
Update the toolbar when an SR action is completed

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-03-24 10:40:55 +00:00
Mihaela Stoica
83dbaf6b5e CA-237939: Cannot create VM from Checkpoint other than the resident host in pool
Use VM.clone (and not VM.copy) when creating a VM from a snapshot.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-03-23 12:49:24 +00:00
Konstantina Chremmou
8f1a539cca Merge pull request #1501 from stephen-turner/CA-248252b
CA-248252: Show version numbers for updates
2017-03-23 12:39:39 +00:00
Stephen Turner
be746126a1 Fix typo 2017-03-23 12:28:32 +00:00
Konstantina Chremmou
07c0ad25cf CA-248087: Updated API bindings.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-03-23 12:20:07 +00:00
Mihaela Stoica
170dcfc70b Merge pull request #1504 from geosharath/CA-246288
CA-246288: Removing mention of the word "paused" from the text in NewpolicySnapshotTypePage
2017-03-23 09:34:08 +00:00
Sharath Babu
553e559bee CA-246288: Removing mention of the word "paused" from the text in NewpolicySnapshotTypePage
Signed-Off-By: Sharath Babu <sharath.babu@citrix.com>
2017-03-23 04:02:13 +05:30
Stephen Turner
5f878e9661 CA-248254: Remove unused function 2017-03-22 17:56:01 +00:00
Stephen Turner
21f6bc22c4 CA-248254: XenCenter doesn't list partially applied patches if there are fully applied patches 2017-03-22 17:47:06 +00:00
Stephen Turner
7bd5dd98ca CA-248252: Show version numbers for updates 2017-03-22 17:29:11 +00:00
Gabor Apati-Nagy
40074d5969 Merge pull request #1491 from MihaelaStoica/CA-242918
CA-242918: Improve the exception shown in XenCenter if the hotfix upl…
2017-03-22 11:05:51 +00:00
Gabor Apati-Nagy
7a875cae94 Merge pull request #1492 from MihaelaStoica/CA-137249
CA-137249: Strange 'Completed' text shows while enabling or disabling HA
2017-03-22 11:04:05 +00:00
Mihaela Stoica
4ceafb5cd6 Merge pull request #1497 from geosharath/CA-245801
CA-245801: [VMSS] Usability issues with Snapshot schedules window
2017-03-22 09:54:36 +00:00
Sharath Babu
035fd959c3 CA-246288: [VMSS] Incorrect message in schedule properties->snapshot type window
Signed-Off-By: Sharath Babu <sharath.babu@citrix.com>
2017-03-22 09:58:04 +05:30
Sharath Babu
b1373b8d76 CA-245801: [VMSS] Usability issues with Snapshot schedules window
Signed-Off-By: Sharath Babu <sharath.babu@citrix.com>
2017-03-22 08:34:36 +05:30
Letsibogo Ramadi
143456fffc CA-239224 - [IN-306] Error on viewing Network properties
Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-03-16 16:57:23 +00:00
Mihaela Stoica
19f1460865 CA-137249: Strange 'Completed' text shows while enabling or disabling HA
Suppress updates to the status when the PureAsyncAction runs the action to populate the ApiMethodsToRoleCheck

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-03-16 13:31:51 +00:00
Mihaela Stoica
6b26093303 CA-242918: Improve the exception shown in XenCenter if the hotfix upload fails
When a TargetInvocationException is raised, its InnerException property holds the underlying exception, which is what we should display.
Also ellipsise the action description (which could be an error thrown by the upload action) that is displayed on the Upload page.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-03-16 11:41:14 +00:00
Mihaela Stoica
37a287edd1 CA-152101: Incorrect error when trying to license pool with old license server
Try to match the alerts by message type, not by title, because for pooled hosts the title contains the host name followed by the friendly name, while for standalone hosts the host name is not included

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-03-16 10:40:41 +00:00
Mihaela Stoica
28546579c5 Merge pull request #1485 from stephen-turner/CA-95798
CA-95798: Limit size of LongStringComboBox
2017-03-14 13:45:33 +00:00
Stephen Turner
6d8c7b76df CA-95798: Limit size of LongStringComboBox 2017-03-10 17:29:58 +00:00
Gabor Apati-Nagy
178db9d02e CA-246338: Changing Network Bond Mode on a single host in a pool changes bond mode on all hosts
Added "Changes will apply to all hosts in a pool." to clarify the scope of these settings

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-03-10 16:32:17 +00:00
Letsibogo Ramadi
e6b912173d CA-147612 - EN: background should expand to the right border.
Also fixed appearance to be consistent with other Vertically Tabbed Dialogs

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-03-09 17:40:21 +00:00
Letsibogo Ramadi
d85af7f8a5 CA-245626 - Properties dialog content clipped when content panel is made smaller
In addition to adding scrollbars when content panel size is reduced using splitter,
I also fixed the teal top panel issue from the base class so that it is applied to all
VerticallyTabbedDialog implementations.

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-03-09 17:35:26 +00:00
Mihaela Stoica
0da7a5c55d Merge pull request #1472 from letsboogey/vncfocusborder
CA-245475 - Focus border not visible on some sides in VNC console
2017-03-08 11:49:24 +00:00
Gabor Apati-Nagy
5f3d49e9da Merge pull request #1473 from letsboogey/gpu
CP-21120 - XenCenter shows MxGPU as 'passthrough' rather than model
2017-03-07 18:53:20 +00:00
Letsibogo Ramadi
34780b1e0a CP-21120 - XenCenter shows MxGPU as 'passthrough' rather than model 2017-03-07 16:13:53 +00:00
Mihaela Stoica
eb9ed4cda0 Merge pull request #1469 from letsboogey/rdpconsole8
CA-245546 - Only the active RDP console is resized when the main XenC…
2017-03-07 14:56:19 +00:00
Letsibogo Ramadi
b604f79fa6 CA-245475 - Focus border not visible on some sides in VNC console 2017-03-06 15:45:56 +00:00
Letsibogo Ramadi
29a683afc3 CA-245546 - Only the active RDP console is resized when the main XenCenter window is resized 2017-03-03 17:29:19 +00:00
Mihaela Stoica
ef39cd2e11 Merge pull request #1465 from letsboogey/bug_thursday
CA-245614 - Teal banner in VM properties dialog does not span with of…
2017-03-03 10:29:18 +00:00
Konstantina Chremmou
fe67df9f09 Merge pull request #1467 from MihaelaStoica/master
CA-169169: Wrong help context showing after clicking help icon on RDP…
2017-03-02 20:56:26 +00:00
Mihaela Stoica
dc758977f2 CA-169169: Wrong help context showing after clicking help icon on RDP confirmation dialog 2017-03-02 17:24:52 +00:00
Letsibogo Ramadi
8c9d65f761 CA-245614 - Teal banner in VM properties dialog does not span with of dialog box
This was a regression introduced by commit b3fe4aa2. Fixed by reversing commit
2017-03-02 13:44:43 +00:00
Mihaela Stoica
ed3668d68d Merge pull request #1457 from letsboogey/rdpconsole8
CP-20881 - Implement RDP console resize when toggling the full screen…
2017-03-02 10:36:31 +00:00
Letsibogo Ramadi
27918a1c02 CP-20881 - Implement RDP console resize when toggling the full screen mode
In addition to ticket requirements, the console size is updated when the console is:
- resized in undocked mode
- resized manually by dragging window edges
- resized by dragging the panel splitter

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-03-01 17:48:42 +00:00
Mihaela Stoica
418d2edb7b Merge pull request #1461 from GaborApatiNagy/CA-244687_2
CA-244687: Install Updates Wizard: Automated mode: bugfix for omitted after-apply-guidances
2017-03-01 13:35:42 +00:00
Gabor Apati-Nagy
e9eeb3d595 CA-244687: Install Updates Wizard: Automated mode: bugfix for omitted after-apply-guidances
Fixes following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-03-01 13:10:45 +00:00
Gabor Apati-Nagy
15827512e1 CA-244687: XSINT71E003 asks user to restart toolstack after installing hotfixes using Batch hotfixing
This commit fixes a bug in the Update Wizard that causes XenCenter to not restart Toolstack when it should in the following case: in Automated Mode, when the update sequence for a host has an update that contains live-patch with restartHost guidance (and guidance-mandatory=false) followed by an update with Toolstack restart guidance.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-03-01 12:05:44 +00:00
Mihaela Stoica
4ef110cebe Merge pull request #1459 from letsboogey/optionsdialog
CA-164371 - Usability issue with Popup windows from XenCenter Tools Menu
2017-02-28 16:44:29 +00:00
Letsibogo Ramadi
3d46e1e835 CA-164371 - Usability issue with Popup windows from XenCenter Tools Menu
Added scrollbars for case when panel is resized using splitter.

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-02-28 16:37:38 +00:00
Mihaela Stoica
d0b87b6ec2 Merge pull request #1460 from kc284/master
CA-244618: Corrected the xml-rpc licence.
2017-02-28 16:06:00 +00:00
Mihaela Stoica
a0b19b958a Merge pull request #1448 from letsboogey/bug_thursday
CA-244655 - XenCenter shows the wrong message on the Updates page
2017-02-28 15:30:15 +00:00
Konstantina Chremmou
b70908a300 CA-244618: Corrected the xml-rpc licence.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-02-28 15:29:36 +00:00
Gabor Apati-Nagy
48ce1f5229 Merge pull request #1458 from MihaelaStoica/CAR-2214-to-master
Merge CAR-2214 to master
2017-02-28 15:28:22 +00:00
Gabor Apati-Nagy
118dea1fa7 Merge pull request #1455 from MihaelaStoica/CA-245345
CA-245345: XenCenter doesn't mark a host as unapplicable when an upda…
2017-02-28 15:19:16 +00:00
Gabor Apati-Nagy
2515c3ca4f Merge pull request #1456 from MihaelaStoica/CA-236104
CA-236104: Do not allow pre and post Ely servers to be selected at th…
2017-02-28 15:18:47 +00:00
Mihaela Stoica
dab5e3da05 CA-236104: Do not allow pre and post Ely servers to be selected at the same time when the user browsed for an iso update or supplemental pack.
Changes following code review

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-02-28 14:29:59 +00:00
Mihaela Stoica
7a04e5186e Merge remote-tracking branch 'upstream/CAR-2214' into master
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

Conflicts:
	Jenkinsfile
	XenModel/Actions/Updates/DownloadAndUnzipXenServerPatchAction.cs
	XenModel/Actions/Updates/DownloadUpdatesXmlAction.cs
2017-02-28 10:30:02 +00:00
Mihaela Stoica
1a6639bdc7 Merge pull request #1432 from letsboogey/master
CP-20727 - Use new version of the rdpclient
2017-02-27 17:25:09 +00:00
Letsibogo Ramadi
8d2cbfc87c CP-20727 - Use new version of the rdpclient 2017-02-27 17:24:25 +00:00
Mihaela Stoica
33979bb1f2 CA-236104: Do not allow pre and post Ely servers to be selected at the same time when the user browsed for an iso update or supplemental pack.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-02-27 16:45:34 +00:00
Mihaela Stoica
f1470d1c53 CA-245345: XenCenter doesn't mark a host as unapplicable when an update is installed via "Select update from disk" option
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-02-27 16:43:02 +00:00
Stephen Turner
bcc282093d Update credits 2017-02-24 16:49:16 +00:00
Mihaela Stoica
0585590afa CA-243640: XenCenter HealthCheck Analysis Status Refresh is failing
XenCenter uses the wrong token (upload token instead of the diagnostic token) when the "Request an additional update" option is used

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-02-24 16:03:09 +00:00
Letsibogo Ramadi
ba29f1588b CA-244655 - XenCenter shows the wrong message on the Updates page when no updates are found 2017-02-24 12:12:08 +00:00
Mihaela Stoica
46315e4c83 CA-244656: The popup dialog for Check for Updates (on first XC start) should enable all CFU options
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-02-23 12:48:04 +00:00
Mihaela Stoica
daa4d981b5 Merge pull request #1446 from geosharath/CAR-1841
CP-17253: [XC] Ability to select VLAN PIF as a management interface of a host/Pool
2017-02-23 09:22:56 +00:00
Sharath Babu
0dc313941c CP-17253: [XC] Ability to select VLAN PIF as a management interface of a host
This is allowed for both host and pool (on a host by host basis).

Signed-Off-By: Sharath Babu <sharath.babu@xitrix.com>
2017-02-22 18:47:12 +05:30
Frederico Mazzone
39c1169933 CA-244661: Improve dialog message for 407 proxy authentication error
Signed-off-by: Frederico Mazzone <frederico.mazzone@citrix.com>
2017-02-21 16:33:00 +00:00
Gabor Apati-Nagy
da4140d75e Merge pull request #1443 from stephen-turner/CA-243964
CA-243964: Don't allow upload of .xsupdate files to >= 7.1 servers
2017-02-20 11:36:28 +00:00
Stephen Turner
20df8ce2fe CA-244097: XenCenter sometimes refuses .xsupdate files 2017-02-17 17:11:03 +00:00
Stephen Turner
74c567ef1d CA-243964: Don't allow upload of .xsupdate files to >= 7.1 servers 2017-02-17 16:56:44 +00:00
Letsibogo Ramadi
f414407f40 CA-164371 - Usability issue with Popup windows from XenCenter Tools Menu 2017-02-17 12:12:45 +00:00
Gabor Apati-Nagy
2de8f55e30 Merge pull request #1439 from letsboogey/funnylabelfix
CA-236150 - Funny label on status report wizard
2017-02-15 14:05:14 +00:00
Letsibogo Ramadi
10bb65d2f2 CA-236150 - Funny label on status report wizard
Changed label to a LinkLabel instead of RichTextBox. Also fixed similar bug on the healthcheck enrollment dialog.
2017-02-15 13:51:19 +00:00
Gabor Apati-Nagy
dbebd7de74 Merge pull request #1435 from kc284/master
Collect all 3rd party components in one place.
2017-02-14 12:34:44 +00:00
Stephen Turner
f3a64fc54b Merge pull request #1433 from geosharath/feature_merge
Scheduled Snapshots feature merge
2017-02-14 10:09:17 +00:00
vetrivelc
6d9273f304 L10N: Translation Changes & VMSS updates CP-20708 2017-02-14 03:27:38 +00:00
Frezzle
d3e64ad2d2 CP-20918: Remove proxy authentication registry key (#1440)
The ProxyAuthenticationEnabled registry key is no longer needed since
CAR-2214 is now in its own branch.

Signed-off-by: Frederico Mazzone <frederico.mazzone@citrix.com>
2017-02-13 20:28:35 +00:00
Gabor Apati-Nagy
b8b8e846f5 CA-227631: License Manager doesn't respond immediately to disconnected host
Fixed the bug that caused a disconnected host to appear as if it was still connected in the License Manager. After this commit, if a host get disconnected in the background its row will be disabled and will be unselectable.

(Note that when the connection resumes, the user will still have to click on a different row to have the disabled state (and the buttons) fixed, but that is a Won't fix bug (CA-115261) that I couldn't fix right now.)

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-02-10 15:55:09 +00:00
Konstantina Chremmou
a04b039870 Collected all third party libraries in one place so it's easier for developers to setup their system.
Added a help script to that purpose.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-02-09 20:27:03 +00:00
Gabor Apati-Nagy
6693570b11 Merge pull request #1428 from MihaelaStoica/CA-238265
CA-238265: Add the action title to the error message displayed on the…
2017-02-08 11:47:38 +00:00
Mihaela Stoica
ef331986c7 CA-238265: Add the action title to the error message displayed on the Install Update page of the patching wizard.
Also changed  ApplyPatchAction and ApplyUpdateAction to install a single update to a single host, so that the appropriate action title can be displayed if an action fails. And replaced 2 hardcoded strings with resource strings.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-02-06 13:04:07 +00:00
Mihaela Stoica
0d1862feff Merge pull request #1427 from geosharath/CA-241810
CA-241810: [VMSS] VM scheduled snapshot options visible on XC on host with Dundee XS
2017-02-06 12:11:23 +00:00
Mihaela Stoica
41adff4ea4 Merge pull request #1426 from geosharath/VMSS-B2B
B2B merge from master to VMSS
2017-02-06 09:26:32 +00:00
Sharath Babu
32836a4b49 CA-241810: [VMSS] VM scheduled snapshot options visible on XC on host with Dundee XS
Updating DundeeOrGreater check with FalconOrGreater

Signed-Off-By: Sharath Babu <sharath.babu@citrix.com>
2017-02-06 11:38:26 +05:30
Sharath Babu
0800e361c6 Merge branch 'master' of https://github.com/xenserver/xenadmin into VMSS 2017-02-04 13:59:58 +05:30
Gabor Apati-Nagy
01cebc9166 Merge pull request #1404 from MihaelaStoica/CP-19607
CP-19607: Make sure that event handlers are unregistered when controls are not visible
2017-02-01 13:53:14 +00:00
Mihaela Stoica
ce8cdce0a4 CA-236844: XenCenter throws "Assertion failed" error when toggling be… (#1419)
* CA-236844: XenCenter throws "Assertion failed" error when toggling between the RDP and VNC consoles

Couldn't reproduce it, but it looks like the assertion is hit because the console view still holds a subscription to an event from an old vnc stream (maybe not garbage collected yet).
Added code to deregister event handlers when the vcnStream is disconnected and also replaced the the assertion with an if statement, ignoring the case that might have caused the assertion failure.

* CA-236844: XenCenter throws "Assertion failed" error when toggling between the RDP and VNC consoles

Added a Debug assert and a null check.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-02-01 12:55:00 +00:00
Sharath Babu
b5c96618ff CA-241844: [VMSS] Deleting a snapshot schedule raises XenCenter error
After deleting the schedule vmss will be null for that message, hence
we need to handle this case.

Signed-Of-By: Sharath Babu <sharath.babu@citrix.com>
2017-02-01 14:15:49 +05:30
Mihaela Stoica
430b9e87ed CP-19607: More event handlers that needed to be deregistered 2017-01-31 14:35:59 +00:00
Sharath Babu
9da9aabce7 CA-241767: [VMSS] Scheduled snapshots not getting listed in XC
Signed-Off-by: Sharath Babu <Sharath.Babu@citrix.com>
2017-01-31 10:01:33 +05:30
Mihaela Stoica
73293c7e4b Merge pull request #1401 from letsboogey/master
CA-239951 - Patching wizard allows selection of unreachable hosts
2017-01-30 11:02:38 +00:00
Usha Mandya
2bcf798678 Fixed a tag issue 2017-01-27 12:34:54 +00:00
Letsibogo Ramadi
3a4e3e8235 CA-237968 - Unfriendly error 'method name that you used is host.call_extension' while applying Ely hotfix on partially upgraded pool 2017-01-26 17:03:23 +00:00
Letsibogo Ramadi
2aae7ab0f2 CA-239890 - EN: The update for PVS-Accelerator is displayed as “pvsaccelerator” on the “General” page.
Changes all update names to friendly names which are usually identical to the Name Description.
2017-01-26 10:39:06 +00:00
Mihaela Stoica
c35eae23be CP-19607: Unregister event handlers when the tab pages are hidden
Implemented a generic mechanism to allow tab pages to unregister their event handlers when they are hidden (when a tab page gets deselected)
Also changed VMStoragePage to derive from BaseTabPage, so it could use the same mechanism.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-01-25 12:38:33 +00:00
Mihaela Stoica
80e60abf7c CP-19607: Make sure that event handlers are unregistered when the SrPicker control is disposed
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-01-25 12:15:59 +00:00
Letsibogo Ramadi
045c405f92 CA-239951 - Patching wizard allows selection of unreachable hosts
Disabled the ability to select unreachable hosts and in addition
added a try/catch block to hide error message resulting from trying
to clean up an unreachable host.

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-01-25 10:28:11 +00:00
Sharath Babu
4833565ec6 Fixing copyright check failures at build time
Signed-Off-by: Sharath Babu <sharath.babu@citrix.com>
2017-01-25 14:11:24 +05:30
Sharath Babu
ee4b2818f6 Merge remote-tracking branch 'xenserver/CAR-2205' into xenserver/VMSS
Signed-Off-by: Sharath Babu <Sharath.Babu@citrix.com>
2017-01-25 13:01:54 +05:30
Konstantina Chremmou
489d8684e4 Merge remote-tracking branch 'upstream/master' into CAR-2214
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	Branding/branding.sh
#	mk/archive-unsigned.sh
#	mk/build.sh
#	mk/bumpBuildNumber.sh
#	mk/copy-build-output.sh
#	mk/declarations.sh
#	mk/tests-checks-cover.sh
#	mk/tests-checks.sh
2017-01-24 14:46:57 +00:00
Mihaela Stoica
02c228ca85 Merge pull request #1390 from GaborApatiNagy/master_CA-238993
CA-238993: Fixed: forever growing updates list while new or updated metadata was not shown
2017-01-24 09:54:25 +00:00
Mihaela Stoica
a6e95e3cb7 Merge pull request #1387 from geosharath/CA-213512
CA-213512: [VMSS] XC mentions VMPR instead of VMSS on failure of snapshot
2017-01-24 09:31:34 +00:00
Mihaela Stoica
b14cc05968 Merge pull request #1397 from letsboogey/master
CA-236114 - Wrong update is installed when two different updates are …
2017-01-23 12:51:03 +00:00
Letsibogo Ramadi
cdfdacd88f CA-236114 - Wrong update is installed when two different updates are uploaded in the same instance of the wizard
Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-01-23 12:36:47 +00:00
Usha Mandya
7859badc54 CP-20468: XC Help for Revised Management Agent updates 2017-01-23 12:02:14 +00:00
Sharath Babu
af182d9e7e CA-213512: [VMSS] XC mentions VMPR instead of VMSS on failure of snapshot
Signed-Off-by: Sharath Babu <sharath.babu@citrix.com>
2017-01-23 16:25:16 +05:30
Gabor Apati-Nagy
d85cc824b5 Merge pull request #1392 from letsboogey/master
Ca-238273 - Install Update Wizard: Update still shows up in the grid …
2017-01-20 17:01:26 +00:00
Konstantina Chremmou
88b4104dac Moved the ProxyAuthenticationMethod enum to the HTTP class so the VNCControl can compile.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-01-20 14:47:04 +00:00
Mihaela Stoica
cfed0d1eec Merge pull request #1388 from geosharath/CA-213505
CA-213505: Right click on a VM allows assignment to a policy of unsupported snapshot type
2017-01-20 12:26:43 +00:00
Letsibogo Ramadi
8f48c99b2d Ca-238273 - Install Update Wizard: Update still shows up in the grid after it's been installed
Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-01-20 11:35:25 +00:00
Sharath Babu
fe373447b6 CA-213505: Right click on a VM allows assignment to a policy of unsupported snapshot type
[VMSS] XC -> right click 'VM' -> Assign VM to snapshot schedule shows all policies,
even though they are not supported by VM

Signed-Off-By: Sharath Babu <sharath.babu@citrix.com>
2017-01-20 11:35:10 +05:30
Gabor Apati-Nagy
974aa0293c CA-238993: Fixed the issue of forever growing updates list while new or updated metadata was not shown
These lists were continuously growing on each refresh, because the Where
clauses returned all items as the predicate was always evaluated to
true. The reason is: A. Even IEquatable<XenServerPatch> is
implemented on XenServerPatch, it only compares uuids. B. XenServerVersion
(also XenCenterversion) does not implement Equals (always different as the
Action returns new objects).

The two bugs these caused are: A] forever growing list of versions causing
obsolete data to be kept while everything is added to the end of the list
additionally. B] Any previously added Patch will not be updated unless the uuid has been changed (this never changes).

Fix in this commit: On each refresh, taking the new lists as they are
(from the Action) and not trying to keep or modify existing items. GC will do the rest with the old list (and objects)

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-01-19 18:33:30 +00:00
Konstantina Chremmou
a59e4f4ad3 Merge pull request #1382 from GaborApatiNagy/master_CA-176169
CA-176169: Copyright statement checking
2017-01-19 15:14:25 +00:00
Frederico Mazzone
72b2429084 Enable roaming for proxy authentication settings
Signed-off-by: Frederico Mazzone <frederico.mazzone@citrix.com>
2017-01-19 14:39:01 +00:00
Frederico Mazzone
76fd266913 Merge branch 'master' into CAR-2214
Conflicts:
	XenAdmin/Properties/Settings.Designer.cs
	XenAdmin/Properties/Settings.settings
	XenAdmin/app.config
	XenModel/Actions/Updates/DownloadAndUnzipXenServerPatchAction.cs

Signed-off-by: Frederico Mazzone <frederico.mazzone@citrix.com>
2017-01-19 14:16:51 +00:00
Mihaela Stoica
2ae2bdfdd8 CA-182453: XenCenter does not show an active XenMotion in another session
Added "VM.pool_migrate" to the list of tasks suitable for meddling actions.
Removed the usage of MeddlingActionTitle other_config key, because it wasn't working as intended for two reasons:
- If XenCenter starts an action that does multiple async api calls, so multiple tasks, the action's title is assigned to all tasks as MeddlingActionTitles, so the second XenCenter instance would create multiple meddling actions with the same title.
- When a second XenCenter instance tries to see if a task is suitable for a meddling action, the MeddlingActionTitle is not yet present in the task's other_config, so the task is ignored in most of the cases.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-01-18 14:25:55 +00:00
Gabor Apati-Nagy
356a7ebdc4 Merge pull request #1372 from MihaelaStoica/CA-226900
CA-226900: Do not allow selection of individual pool members when ins…
2017-01-18 14:07:31 +00:00
Mihaela Stoica
3abce40f74 CA-226900: Do not allow selection of individual pool members when installing a hotfix
Changed the rubric on the Select Servers page.
2017-01-18 10:59:35 +00:00
Mihaela Stoica
66eab6d8cb Merge pull request #1384 from letsboogey/master
CA-169475 - G11n: SC&JA: Didn't provide AM/PM on date info under “Cre…
2017-01-17 12:47:47 +00:00
Letsibogo Ramadi
d83bc64cef CA-169475 - G11n: SC&JA: Didn't provide AM/PM on date info under “Created On” list
Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-01-17 10:37:55 +00:00
Sharath Babu
866968c063 CA-227792: unable to change policy type and modify VMs list at the same time
Signed-Off-by: Sharath Babu <sharath.babu@citrix.com>
2017-01-17 12:02:54 +05:30
Gabor Apati-Nagy
978f85233c CA-176169: Added copyright statement to files which it was missing from
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-01-16 20:14:56 +00:00
Gabor Apati-Nagy
7c0bc50b4a CA-176169: Changed copyright statements to include the comma in Citrix Systems,
Inc.

Signed-off-by: Gabor Apati-Nagy<gabor.apati-nagy@citrix.com>
2017-01-16 19:59:50 +00:00
Mihaela Stoica
27a2a1d88c Merge pull request #1380 from letsboogey/master
CA-148598 - EN: Missing and duplicate hotkeys on "Alerts" pane under …
2017-01-16 16:28:05 +00:00
Letsibogo Ramadi
75db446168 CA-151449 - EN: Missing hotkeys on Pool Properties ->GPU wizard.
Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-01-16 15:08:58 +00:00
Letsibogo Ramadi
c7f5dd90d1 CA-148598 - EN: Missing and duplicate hotkeys on "Alerts" pane under Server Properties dialog.
Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-01-16 13:41:40 +00:00
Konstantina Chremmou
9b9d0bb353 Merge pull request #1354 from GaborApatiNagy/master
CA-214628: .NET Image limit causes exception
2017-01-16 11:47:13 +00:00
Usha Mandya
e82d26fd7e Merge branch 'master' of https://github.com/xenserver/xenadmin 2017-01-12 15:02:34 +00:00
Usha Mandya
5906581df3 Minor update to the RBAC topic 2017-01-12 14:51:32 +00:00
sri harsha tagore k
cb0a0e2267 L10N:Translations check-ins 2017-01-12 13:22:48 +00:00
Gabor Apati-Nagy
a1a411b9df CA-214628: .NET Image limit causes exception
Further changes

* implemented similar logic for the Commands too as those are keep on getting updates so affected
* moved these static fields to a class (at Images)
* used the same casing as in Resources once they have been moved

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-01-11 13:56:45 +00:00
Mihaela Stoica
84df0d5f80 CA-239210: Fixed the tab order on the Select Servers page
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-01-11 11:48:58 +00:00
Mihaela Stoica
b418a8a170 CA-226900: Do not allow selection of individual pool members when installing a hotfix
This change does not apply to supplemental packs, as we should be able to install supp packs to individual hosts in a pool.
Also, if the wizard is installing an update from disk and we cannot match it in updates.xml, then we will continue to allow host selection, because we can't tell whether it is a supp pack or a hotfix.

Plus fixing the bug where the "Select All" button is enabled even when all the selectable servers/pools are selected

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-01-11 11:32:57 +00:00
Usha Mandya
387492fff1 CP-20269: Updated XC Help to accommodate PVS feature name change 2017-01-09 15:23:40 +00:00
sri harsha tagore k
08edd54ac1 L10N:Translations check-ins 2017-01-06 12:46:19 +00:00
Mihaela Stoica
3f89610f75 CP-20245: Wording changes for change of feature name to PVS-Accelerator
- changes following the renaming of the RRDs

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-01-04 14:41:56 +00:00
Mihaela Stoica
e45accbe55 CP-20245: Wording changes for change of feature name to PVS-Accelerator
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-01-04 14:41:56 +00:00
Frederico Mazzone
f964fa88c6 Merge branch 'master' into CAR-2214
Conflicts:
	XenAdmin/Core/Registry.cs
	XenModel/Actions/Updates/DownloadUpdatesXmlAction.cs
2016-12-23 14:10:43 +00:00
Konstantina Chremmou
cbdf7d3742 Merge pull request #1334 from MihaelaStoica/CA-216752
CA-216752: Not all wizards progress through to the next page by press…
2016-12-22 09:14:29 +00:00
sri harsha tagore k
41335a1ca1 L10N:TRanslations checkins 2016-12-21 16:21:09 +00:00
sri harsha tagore k
fcda47d3a0 L10N:Translations check-ins
Cherry-picked: ff6a3984d5a97313903a4d230bca15e54674976e [ff6a398]
Author: sri harsha tagore k <sriharshatagore.karpurapu@citrix.com>
2016-12-21 16:20:30 +00:00
Gabor Apati-Nagy
5a117334af CA-214628: .NET Image limit causes exception
Changed code at a a few places where it made sense to limit how many times XenCenter asks the Resource Manager for a new instance(*1) of the same(*2) image.
*1: RM returns a new object each time
*2: they are the same as we don't change the locale of a thread and also we don't localise these images - by design

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-21 13:57:50 +00:00
Mihaela Stoica
0115461f66 CA-216752: Not all wizards progress through to the next page by pressing the Enter key
- Added SelectDefaultControl() to more wizard pages

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-12-21 13:33:04 +00:00
Mihaela Stoica
ed4981b5a8 Merge pull request #1348 from GaborApatiNagy/CA-236547
CA-236547: Unexpected error while applying hotfix on multiple Xenservers of different version
2016-12-21 11:32:28 +00:00
Gabor Apati-Nagy
7ce6d50ed0 CA-236547: Unexpected error while applying hotfix on multiple Xenservers of different version
Reset both before any upload as the upload is going to set the correct one anyway

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-21 10:37:06 +00:00
Mihaela Stoica
eecec89a08 Merge pull request #1352 from GaborApatiNagy/CA-234494
CA-234494: System template cross-pool copy fails with Internal error:assert_can_migrate: inter_pool_metadata_transfer returned nonempty list
2016-12-20 16:19:02 +00:00
Gabor Apati-Nagy
06812f4da1 CA-234494: System template cross-pool copy fails with Internal error: assert_can_migrate: inter_pool_metadata_transfer returned nonempty list
Added a check for default_template as a workaround an issue where the allowed_operations of a default template _initially_ indicated that cross pool migration was allowed.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-20 14:30:27 +00:00
Konstantina Chremmou
e176194a06 Merge pull request #1339 from GaborApatiNagy/master_CA-211363
CA-211363: Replace 'User name' labels with 'Username'
2016-12-20 09:44:25 +00:00
Gabor Apati-Nagy
9bd776c83d CA-236547: Unexpected error while applying hotfix on multiple Xenservers of different version
Fixing the error, so the hotfix installation will fail as and where it is expected

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-19 18:00:42 +00:00
Gabor Apati-Nagy
bff70c5c6a CA-211363: Replace 'User name' labels with 'Username'
Second round of renaming

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-16 18:36:35 +00:00
Gabor Apati-Nagy
751ba4956d Merge pull request #1303 from kc284/CA-104329
CA-104329: Removed calculation which might cause lag from the page lo…
2016-12-16 11:13:05 +00:00
sri harsha tagore k
7e13917939 L10N:TRanslations check-ins
CA-235084/CA-235085/CA-235080/CA-235081 fixes
2016-12-16 11:01:53 +00:00
sri harsha tagore k
5bb479ec4e L10N:TRanslations check-in
CA-235023 fix
2016-12-16 10:59:45 +00:00
sri harsha tagore k
c2ef32e1eb L10N:TRanslation check-in
CA-236062 fix
2016-12-16 10:58:07 +00:00
sri harsha tagore k
27b2646071 L10N:Translations check-in
CA-236354 and CA-236060 fix
2016-12-16 10:57:27 +00:00
Gabor Apati-Nagy
c5c2906cb1 Merge pull request #1333 from MihaelaStoica/CA-235381
CA-235381: XenCenter should not allow users to edit the PVS cache sto…
2016-12-13 11:34:54 +00:00
Mihaela Stoica
ce554a7cd3 Merge pull request #1335 from GaborApatiNagy/CP-20065
CP-20065: Change "Automatic Update" to "Automated Updates"
2016-12-13 11:16:04 +00:00
Mihaela Stoica
30c30e85bb CA-235381: XenCenter should not allow users to edit the PVS cache storage if it is in use
- Replaced the information tooltip with a warning icon and label at the bottom of the page.
- Added some null checks

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-12-13 11:09:23 +00:00
Mihaela Stoica
3b0d7f7c32 Merge pull request #1328 from GaborApatiNagy/CA-207011
CA-207011: Don't allow XC to create more than one SMB ISO SR on the same share
2016-12-13 10:49:05 +00:00
Konstantina Chremmou
f165cef307 CA-104329: Do not re-iterate through the datagridview rows to retrieve the VMs'
restart settings when leaving the page. Get the already calculated value from the
tolerance indicator instead.
2016-12-13 09:10:26 +00:00
Konstantina Chremmou
bad9ef8cca Enforce a minimum size for the groupbox so its title does not appear ellipsized.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-12-13 09:10:26 +00:00
Konstantina Chremmou
38bc4848bb CA-104329: Removed calculation which might cause lag from the page loading step;
have the wizard do it before we get there. Also, replaced the labels in such way
that, if there should be lag, the user will not see the draft message used only
on the designer.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-12-13 09:10:26 +00:00
Gabor Apati-Nagy
9d5e71326c CP-20065: Change "Automatic Update" to "Automated Updates"
changed more messages following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-12 18:12:01 +00:00
Usha Mandya
b937945d7a Adding the updated CHM 2016-12-12 11:00:35 +00:00
Gabor Apati-Nagy
5ed6a7c8ff CP-20065: Change "Automatic Update" to "Automated Updates"
more renaming

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-10 15:01:25 +00:00
Gabor Apati-Nagy
b0ca08ae6d CP-20065: Change "Automatic Update" to "Automated Updates"
made naming more consistent

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-10 14:44:15 +00:00
Gabor Apati-Nagy
5b6bedea48 CP-20065: Change "Automatic Update" to "Automated Updates"
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-10 14:19:37 +00:00
Gabor Apati-Nagy
122e6ae012 CA-207011: Don't allow XC to create more than one SMB ISO SR on the same share
fixed the name of a method

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-09 15:27:22 +00:00
Mihaela Stoica
508f638b3a CA-216752: Not all wizards progress through to the next page by pressing the Enter key
- Added a new method in XenTabPage which the derived classes can implement to select a default control after the page is loaded.
- Added a new wizard test that runs through the wizard by pressing the Enter key and checks if it has landed on the right page.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-12-08 14:52:21 +00:00
Mihaela Stoica
1156d57787 CA-235381: XenCenter should not allow users to edit the PVS cache storage if it is in use
- On the PVS Cache Configuration dialog, disable the cache storage fields with an information tooltip stating that this PVS cache storage cannot be changed because it is in use.
- Also set the minimum width for the splitter panels, to avoid display issues when the splitter is moved and either of the panels becomes unusable.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-12-07 17:45:50 +00:00
Gabor Apati-Nagy
5f24a4e084 CA-211363: Replace 'User name' labels with 'Username'
According to the Microsoft style guide XC to use 'username' for UI fields and use 'user name' when it's being referred to.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-07 11:12:58 +00:00
Gabor Apati-Nagy
517b4cc45b CA-207011: Don't allow XC to create more than one SMB ISO SR on the same share
This commit uses the same logic that is used for NFS ISOs.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-06 11:27:53 +00:00
Gabor Apati-Nagy
5826a87551 Merge pull request #1325 from MihaelaStoica/CA-234827
CA-234827: Destination dropdown menu content is blurred with overlapp…
2016-12-02 16:19:45 +00:00
Mihaela Stoica
1d92986aa7 CA-234827: Added check for ErroDescription.Count
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-12-02 15:47:42 +00:00
sri harsha tagore k
821f42e1f2 L10N:Translations check-ins 2016-12-02 20:13:49 +05:30
Mihaela Stoica
765dee4fe7 CA-234827: Destination dropdown menu content is blurred with overlapping 'Action: vm.assert_can_migrate' text in Migrate VM wizard
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-12-02 13:52:32 +00:00
Gabor Apati-Nagy
b56cd8d08a Merge pull request #1321 from MihaelaStoica/CA-234628
CA-234628: Errors with no title in XenCenter
2016-12-02 09:20:40 +00:00
Mihaela Stoica
a1d878725d CA-231500: XenCenter allows you to open multiple windows from change role button
Show the "Change role" dialog as modal. This way we avoid other issues, like removing the user while the "Change role" dialog is open.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-12-01 17:08:51 +00:00
Mihaela Stoica
f64923cea0 CA-234628: Errors with no title in XenCenter
Set the suppressHistory flag to true for the parallel action that we run periodically to check the Health Check analysis result

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-12-01 16:23:44 +00:00
Konstantina Chremmou
3e94c6c5c9 CA-145890: switched roaming on for the new settings.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-12-01 11:14:01 +00:00
Mihaela Stoica
1aaa310c50 Merge pull request #1287 from kc284/master
CA-145890: added new Page to the options dialog where the user can co…
2016-12-01 09:39:22 +00:00
Mihaela Stoica
a4480df442 Merge pull request #1315 from GaborApatiNagy/CA-229365
CA-229365: Install Update Wizard: Fixed commas in the blurb
2016-11-30 12:53:54 +00:00
mcintyre94
7f2ecb6eab [CA-233454] PVS tab doesn't show a new VM when it's created (#1314)
* [CA-233454] PVS tab doesn't show a new VM when it's created

Refined the rules for not adding a VM to the table, if it is a template (thus not_a_real_vm), and it has the __gui__ prefix (thus hidden), we still add it, but hide it.
When its name is changed (to remove the __gui__ prefix), we update its name and re-calculate whether it should be visible (in the case of a new VM this will be true once the __gui__ prefix is gone). Also resort the table if a node changes from hidden to visible, because it appears as an addition to the table.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>

* [CA-233454] Update criteria for VM visibility to include is_a_real_vm

is_a_template is changed before the name_label removes the __gui__ prefix, so this works with no other changes to the vm property changed event.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>

* [CA-233454] Update when the VMs are shown in the PVS list

New observable property IsBeingCreated for VMs, set to true when they're made a hidden object, and false when they're removed from hidden objects (both in CreateVMAction). In the PVS Page when this is set to false, we re-evaluate whether a VM can be shown. This means that new VMs show here at the same time they're added to the tree (only different is tree refresh time), instead of far earlier (and before their networks were added).

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>

* [CA-233454] Set IsbeingCreated in the CreateVMFastAction

* [CA-233454] Properly support the VM Fast Create action

Further changes to CreateVMFastAction, to ensure it works with PVS tab - use the __gui__ prefix when the VM is created and then change it back just before showing.

* [CA-233454] Small logic adjustments/tidying up
2016-11-30 12:24:02 +00:00
Gabor Apati-Nagy
9c4628f216 CA-229365: Install Update Wizard: Fixed commas in the blurb
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-25 17:40:15 +00:00
Mihaela Stoica
0cdce9dfaf Merge pull request #1311 from GaborApatiNagy/master_CA-232294
CA-232294: Can't connect if an Add Server dialog has been cancelled before
2016-11-25 15:27:24 +00:00