Kiu/xenadmin
1
0
Fork 0
mirror of https://github.com/xcp-ng/xenadmin.git synced 2024-12-30 07:40:13 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
5,272 Commits 12 Branches 48 Tags 186 MiB
9304bbff5a
Commit Graph

3248 Commits

Author SHA1 Message Date
Mihaela Stoica
e59b5dcb2b CA-293119: Add the pending master reboot precheck to all wizard modes 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-07-02 15:24:09 +01:00
Ji Jiang
2edacbf43f CA-293092: Add HostCheck class to fix check.Host null exception 
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
 2018-06-29 14:27:10 +01:00
Mihaela Stoica
ad1dabd257 CA-293026: Fix the updates shown on a partially upgraded pool 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-28 15:37:02 +01:00
Konstantina Chremmou
f16cc7f770 Made UploadPatchAction and UploadSupplementalPackAction report progress of uploaded bytes. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-28 12:25:56 +01:00
Konstantina Chremmou
3e71da4e0a Do not trigger the Action.Change event when the PercentComplete or the Description 
are set unless the new value is actually different. Small efficiency improvements
to the DownloadPatch action and plan action.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-28 12:25:56 +01:00
Konstantina Chremmou
86ea06696e CA-293009: Show the message for reconnecting storage after the host is rebooted. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-28 12:25:56 +01:00
Konstantina Chremmou
8d6b615841 Check and plug PBDs for VMs only if and when there are VMs to migrate; do not log 
a message in this case as the SRs are reconnected after reboot and this may lead
to duplicate messages. Also, simplified check-and-plug methods for PBDs to avoid
repetition of iterations.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-27 07:58:55 +01:00
Konstantina Chremmou
8a6c661f30 Fixed broken test. Small logging and window title improvements. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-26 22:15:11 +01:00
Konstantina Chremmou
2c07869599 CA-292363: Do not show the DownloadAndUnzipXenServerPatchAction in action history. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-26 22:15:11 +01:00
Konstantina Chremmou
d3f761b070 Reworked the logging for the plan actions. (#2109) 
* Deprecate set but unused Status property in favour of ProgressDescription.
* Deprecate set but unused TitlePlan property.
* Deprecated property Title in favour of ProgressDescription.
* Removed unused plan RebootHostPlanAction.
* Updated event declaration.
* Removed property Visible. The plan is to have the actions log their history as soon as some is available.
* Reworked the logging for the plan actions. The main change is the replacement of
the ProgressDescription with a stack where all the steps of an action are stored,
i.e. the action is responsible for its history, not the worker running it.
* Lock the progress history before accessing it.
* Better handling of error logging and user cancellation.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-26 14:04:51 +01:00
Ji Jiang
41e358a8fa CP-28583: Remove host-level selection in Update wizard 
1) Always pool level selection of hosts, except uploading sup pack file
from disk.
2) Revert homogeneity precheck change recently. It won't happen in new version
update any more.
3) User can never update slaves to a higher version than master, so delete
master_version_not_compatible_problem.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
 2018-06-26 12:45:59 +01:00
Mihaela Stoica
1bd439a2af CP-28279: Corrections to the plan actions 
- In the RPU case, re-enable the host after the upgrade is done, as the host will be put back into maintenance mode when needed during the update process.
- The VMs should not be repatriated during the RPU
- When a host is rebooted, it needs to be disabled first (even if an evacuation is not needed), otherwise the reboot won't happen

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-25 17:12:39 +01:00
Mihaela Stoica
2023f93199 CP-28279:When installing the updates in the RPU wizard, we need to get the minimal patches for the first upgraded host (usualy the master), not for the whole pool, because the pool is of mixed versions at this stage. 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-25 11:31:18 +01:00
Konstantina Chremmou
03b5e9a0c4 Moved logic for calculating the progress increment into the UpdateProgressBackgroundWorker. 
Renamed HostPlanActions class to HostPlan to avoid confusion with the HostPlanAction class.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-25 11:31:18 +01:00
Konstantina Chremmou
37d9bc4b3b Moved all the code for the manual upgrade into the UpgradeManualHostPlanAction and removed the IsManual property. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-25 11:31:18 +01:00
Konstantina Chremmou
09de5fbcd6 Code repetition. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-25 11:31:18 +01:00
Konstantina Chremmou
73fd7df880 Use existing extension method to retrieve the host's running VMs. Removed field 
Dialogs needed only by test code; use existing wrappers of Windows APIs instead.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-25 11:31:18 +01:00
Konstantina Chremmou
50b78ddd83 Moved NonModalThreeButtonDialog out of the RpuUpgradePage because it is pretty generic and can be reused. 
Removed unnecessary null check.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-25 11:31:18 +01:00
Mihaela Stoica
0d3c475439 CP-28279: Fix the AutoScaleMode 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-25 11:31:18 +01:00
Mihaela Stoica
e8d2b9e493 CP-28279: Use different messages for RPU (for reporting success or failure) 
- Also corrected the function that creates the update plan action in RPU: when running a retry, these actions shouldn't be regenerated.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-25 11:31:18 +01:00
Mihaela Stoica
7ed8a2ba44 CP-28279: Add updates installations to the RPU wizard 
- Some methods have been moved/added to the base class to facilitate the calculation of the plan actions in the RPU case.
- Also fixed the calculation of the progress bar value.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-25 11:31:18 +01:00
Mihaela Stoica
a99ae50f57 CP-28279: Change the upgrade page of the RPU wizard to inherit from the class AutomatedUpdatesBasePage 
- Methods have been added to the base class to deal with the manual upgrade mode

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-25 11:31:18 +01:00
Mihaela Stoica
3201ed3329 CP-28279: Fix the layout of the AutomatedUpdatesBasePage 
(by putting everything on a TableLayoutPanel)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-25 11:31:18 +01:00
Konstantina Chremmou
97a60c91da Since the reason why a VM already involved in an operation in progress cannot be migrated is known, display it, otherwise the user may wonder unnecessarily what the problem is. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-22 17:40:53 +01:00
Konstantina Chremmou
e7683fcf0b CP-28492: Evacuate the VMs before the first reboot and repatriate them after the last one. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-22 17:40:53 +01:00
Konstantina Chremmou
cfb1c0f4d7 CA-291402: Do not display a plan action before it is actually running; this prevents skipped actions from being displayed. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-22 17:40:53 +01:00
Konstantina Chremmou
907e991745 Renamed file to match class name. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-22 17:40:53 +01:00
Ji Jiang
6d070d3cfc CP-28425: Add automated updates license precheck in RPU wizard 
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
 2018-06-22 17:20:11 +01:00
Ji Jiang
ccf6f97732 CP-28280: Add CFU availability precheck to RPU wizard comments fix 
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
 2018-06-22 12:02:19 +01:00
Ji Jiang
9ae8340913 CP-28280: Add CFU availability precheck to RPU wizard 
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
 2018-06-22 12:02:19 +01:00
Jisheng Xing
b6e1ad6b83 fix typos and rename a function 2018-06-21 14:54:47 +01:00
Jisheng Xing
538e6f90a1 fix some comments 2018-06-21 14:54:47 +01:00
Jisheng Xing
cb1da504fd CA-289627: SR-IOV on NIC tab is confusing 
Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
 2018-06-21 14:54:47 +01:00
Mihaela Stoica
3c300accce CP-28279: Make the base AutomatedUpdatesBasePage class abstract 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-20 11:15:35 +01:00
Mihaela Stoica
73f6ebdf5c CP-28279: Add a base class for Automated Updates (this will be later used for the RPU as well) 
The base class contains all the code for creating and starting the background workers, displaying the progress of the actions, handling failures and retries.
The derived classes override the property for label at the top of the page and the method that generates the plan actions.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-20 11:15:35 +01:00
Konstantina Chremmou
6513abc09e The check for hosts that are unlicensed for automated updates should be on all pool hosts as there maybe individual restrictions (for example via a feature flag). 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-19 17:20:08 +01:00
Mihaela Stoica
da9e5a5cab CP-28284: Implement IEquatable in PlanAction 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-19 13:34:37 +01:00
Mihaela Stoica
59b9b695db CP-28284: Changes following code review 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-19 13:34:37 +01:00
Mihaela Stoica
631d7656a2 CP-28284: Corrections 
- ensure that an action is only added once to the DoneActions and InProgressActions
- reset the wizard buttons (Cancel, Finish) when a retry is started

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-19 13:34:37 +01:00
Mihaela Stoica
920da093e0 CP-28284: Only show the error icon and text when all the workers have finished 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-19 13:34:37 +01:00
Mihaela Stoica
eca6081f48 CP-28284: Show the plan actions indented under the pool name 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-19 13:34:37 +01:00
Mihaela Stoica
7fa9d0b94f CP-28284: Updates wizard: Add a "pause and resume" mechanism to handle failures 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-19 13:34:37 +01:00
Konstantina Chremmou
d9ee664d53 CA-289629: launch confirmation dialog within a using block. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-18 21:59:38 +01:00
Mihaela Stoica
da2c96ad1c CP-28426: RPU wizard: add user option for automatically applying updates - changes following code review 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-18 16:28:28 +01:00
Mihaela Stoica
dd19f3a0b7 CP-28426: RPU wizard: add user option for automatically applying updates 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-18 16:28:28 +01:00
jishengx
cf20ac13c4 CA-289629: prompt host may need to be rebooted to enable SR-IOV (#2092) 
CA-289629: prompt host may need to be rebooted to enable SR-IOV

Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
 2018-06-18 12:36:12 +01:00
Joey
abe97def1e CP-28286: Support resume from a partially upgraded pool via Update wi… (#2095) 
* CP-28286: Support resume from a partially upgraded pool via Update wizard

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>

* CP-28286: Fix comments of the previous commit

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
 2018-06-18 10:46:41 +01:00
Mihaela Stoica
121bce92af CP-28282: Correction to the required disk space calculation 
- also renamed a variable and updated the problem description to include the server name

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-15 14:24:29 +01:00
Mihaela Stoica
c702399d95 CP-28282: Update the disk space precheck to calculate the required space according to the new workflow (apply all hotfixes to a host before moving to the next one) 
- this commit covers the post-Ely case, where updates are uploaded to storage repositories

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-13 17:24:33 +01:00
Mihaela Stoica
2efc1b8685 CP-28282: Update the disk space precheck to calculate the required space according to the new workflow (apply all hotfixes to a host before moving to the next one) 
- this commit covers the pre-Ely case, where patches are uploaded to the server

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-13 17:23:17 +01:00
Mihaela Stoica
318f20f65f CP-28282: Preliminary work: move the disk space calculation inside the precheck 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-13 17:22:52 +01:00
Mihaela Stoica
8fff0b2b10
Merge pull request #2093 from kc284/REQ-672 
Separate displayed update information per pool. Minor layout corrections and removal of unused LinkLabel.
 2018-06-08 16:54:11 +01:00
Konstantina Chremmou
49823f9dd9 Do not show the successful completion message before the update is actually completed. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-08 16:41:06 +01:00
Konstantina Chremmou
73e7b66fa4 Do not change the page top blurb depending on the process outcome. Improved error messages. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-08 16:15:55 +01:00
Konstantina Chremmou
2e2ae7c196 Separate displayed update information per pool. Minor layout corrections and removal of unused LinkLabel. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-08 13:42:06 +01:00
Mihaela Stoica
15edb13997
Merge pull request #2089 from kc284/REQ-672 
First batch of changes for CP-28281
 2018-06-08 11:32:26 +01:00
Ji Jiang
88224df214 CA-290316: Skip hotfix homogeneity precheck in mixed pool 
Because we couldn't control user's selected combination from
a mixed pool, and the version compatibility precheck exists already,
here just simply skip the precheck and issue a warning.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
 2018-06-08 11:17:41 +01:00
Konstantina Chremmou
11a9785dba Log the patch clean-up actions on the screen in case of a failure. Order the shown actions per pool. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-07 16:34:13 +01:00
Konstantina Chremmou
1b4a862fd0 Further corrections to the load/leave page workflow and object selection ensuring correct enablement of the Next button. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-07 12:27:57 +01:00
Konstantina Chremmou
20d74a64c9 Unregister handlers when leaving or cancelling the page and invoke on the current 
control instead of the main window (may cure CA-289721).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-07 12:27:57 +01:00
Konstantina Chremmou
b36993228c Moved index retrieval in Invoke and corrected index sanity check. Update the combobox 
and unregister item event in a try-finally block (may cure CA-289721); suspend-resume
layout when updating the datagridview.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-07 12:27:57 +01:00
Konstantina Chremmou
3f8feb4bdd Removed invocations where we are already on the UI thread. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-07 12:27:57 +01:00
Konstantina Chremmou
2e07781e6b Simplify the logic toggling the enabled state of the Next button depending on the selection. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-07 12:27:57 +01:00
Konstantina Chremmou
621fce4d70 Fixed regression whereby the vm-host mapping was lost when proceeding to the next page and returning to the destination selection page. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-07 12:27:57 +01:00
Konstantina Chremmou
355621f183 Simplified event signature. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-07 12:27:57 +01:00
Konstantina Chremmou
1d905fc18c Simplified logic when fetching the failure reason; capitalised constant names so they're more visible. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-07 12:27:57 +01:00
Konstantina Chremmou
2c3c4bf5ca Renamed methods so it's more obvious what they do. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-07 12:27:57 +01:00
Konstantina Chremmou
887428872a Logic corrections. Show the name of the patch being removed each time. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-07 12:12:17 +01:00
Konstantina Chremmou
57ab2ced2b CA-289335: If there is no other network available, pick the management network for the migration of VDIs. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-06 16:06:41 +01:00
Konstantina Chremmou
14aa3f3f5d CA-289335: Do not check the NetworkComboBoxItem can be selected unless it has been added to the ComboBox. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-06 16:06:41 +01:00
Konstantina Chremmou
c643351e6c CP-28281: Change the order in which the updates are applied to a pool, namely apply all updates on a host before continuing with the next host. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-05 22:26:16 +01:00
Konstantina Chremmou
723510b853 Removed class Updates.UpgradeSequence. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-05 11:50:34 +01:00
Alexander Schulz
a294c61bd0 Remove shortcut definition from MainWindow resx files, Shortcut is already defined in Commands\NewVMCommand.cs 
https://github.com/xenserver/xenadmin/pull/2078
 2018-06-05 11:15:18 +01:00
Alexander Schulz
c26de212da Use "Control+N" instead of "Ctrl+N" to be buildable on non-english operation systems 2018-06-05 11:15:18 +01:00
Jisheng Xing
7034973ae1 CA-287651: Precheck shows SR broken on both hosts but it is only broken on one 
Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
 2018-06-05 05:45:57 +01:00
Konstantina Chremmou
d4b7642ef7 Compacted null checks. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-04 15:18:29 +01:00
Konstantina Chremmou
d58131910b Corrected logic checking the host is up to date. Renamed method because the old name was not descriptive of the output. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-04 12:40:30 +01:00
Konstantina Chremmou
b0cdc74188 The code in the BackgroundWorker's ProgressChanged and RunWorkerCompleted event handlers does not need invoking as it's already on the UI thread. 
Also, some logic simplification.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-05-29 13:50:46 +01:00
Konstantina Chremmou
89621c2bb5 Unnecessary field. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-05-29 10:47:54 +01:00
Konstantina Chremmou
18f2ff0785 Typo. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-05-29 10:46:14 +01:00
Mihaela Stoica
c2b42fa107 CA-289335: Refactoring to avoid setting the SelectedItem twice 
- also avoids iterating through the combobox items again to determine which item to select

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-05-24 16:23:04 +01:00
Mihaela Stoica
54b134a2eb CA-289335: Show empty selection if the cluster network cannot be resolved 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-05-24 16:23:04 +01:00
Mihaela Stoica
5d0b760a96 CA-288751: Fix the RBAC checks for probe_ext 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-05-24 13:00:05 +01:00
Ji Jiang
9ddb253ec0 CP-26866: Add a specific warning when creating a bond on cluster network 
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
 2018-05-23 16:47:59 +01:00
serenc
29d82b1498 CP-28229: Update XenCenter to remove Cluster.network 2018-05-18 16:40:59 +01:00
Konstantina Chremmou
9a7fcde66e CA-289948: Do not show the upsell dialog if migration is not permitted due to licensing restrictions; launch the move VM dialog instead. 
Also, removed unused constructor.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-05-18 16:37:12 +01:00
Konstantina Chremmou
2f2a533b46 Fixed some column sizing issues on the VM, SR and physical storage pages as well as a regression in the selection mode of the last one. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-05-17 15:45:50 +01:00
Mihaela Stoica
01c8a7ed83 CA-289150: Use a local variable to avoid calculating DistinctHosts twice 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-05-17 14:33:31 +01:00
Mihaela Stoica
2dab045441 CA-289150: Use a lock object to ensure that the hosts and connections lists are safely accessed from separate threads 
This change fixes the crash with IndexOutOfRangeException in XenServerUpdateAlert

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-05-17 14:33:31 +01:00
Mihaela Stoica
5ad2aa302e CA-289959: Add null checks when resolving the updates which require reboot 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-05-17 14:24:51 +01:00
Mihaela Stoica
171284ff34 CP-28094: Rationalise device-config keys with SMAPIv1 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-05-16 17:18:12 +01:00
Konstantina Chremmou
c475861941 CA-248353: Refactoring to avoid referencing cells with hardcoded index numbers, 
which makes them undiscoverable and breaks if the columns are rearranged.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-05-15 13:17:04 +01:00
Konstantina Chremmou
81115674e7 Removed DataGridView grid because we normally don't use one. Renamed columns 
to make them more discoverable. Removed unused class.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-05-15 13:17:04 +01:00
Konstantina Chremmou
085b4d4f6e CA-248353: Do not use a hardcoded string or integer to reference DataGridView columns or ToolStripMenuItems. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-05-15 13:17:04 +01:00
Konstantina Chremmou
7cc1402099 CA-248353: Do not use a hardcoded string to find the status image column as 
the code will break if the column on the LicenceManager is renamed. Also, do
not create the new cell before the index checks pass.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-05-15 13:17:04 +01:00
Konstantina Chremmou
6a36bf37ff The designed class should be the first one in the file, otherwise VisualStudio's designer breaks. 
In this case, the CheckableDataGridViewRowEventArgs are very specialised and can be nested in the CheckableDataGridView.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-05-15 13:17:04 +01:00
Konstantina Chremmou
79684617eb CA-248353: Reference the column object directly instead of trying to retrieve it using a hardcoded string as a key. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-05-15 13:17:04 +01:00
Mihaela Stoica
8992e55141 CA-286291: Add the additional menu items immediately after the first item, so we don't have to wait for the WLB recommendations to be 
retrieved.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-05-14 12:30:40 +01:00
Mihaela Stoica
ba8a612c01 CA-286291: Remove the ToolTip from the VMOperationTollStripManuSubItem, as the reason why the item is disabled is already included in the items's MenuText 
This change improves the performance of the drop-down menu considerably, as it avoids the server calls from the Command.ToolTipText

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-05-14 12:30:40 +01:00
Mihaela Stoica
025e92bc7d CA-286291: Some more refactoring in VMOperationToolStripManuItem 
(including the removal of the HostListUpdater class)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-05-14 12:30:40 +01:00
Mihaela Stoica
7ba8546929 CA-286291: Refactoring in VMOperationToolStripManuItem 
- added an action for the API call that retrieves the WLB VM recommendations
- removed the thread used for updating the menu items, so that we always access the menu items on the UI thread and do only the server calls on separate threads (for WLB, getting the recommendations now is done on the new action, for non-WLB we have the `workerQueueWithoutWlb`)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-05-14 12:30:40 +01:00
Jisheng Xing
79f91ce2b4 CA-288188: correct the NICPage status when SR-IOV logical pif unplugged 
Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
 2018-05-14 12:14:22 +01:00
Konstantina Chremmou
0c3298fd8b CA-289153: Do not attempt updating the licence status for disconnected hosts. (#2072) 
Also, no need to trigger an event when the host is null or when get_servertime
fails only to double-log it in the handling class.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-05-11 16:38:46 +01:00
Konstantina Chremmou
8ae3ceeea1 CA-289718: Refine the storage connections precheck to allow the installation of an update that has been uploaded to a local SR (#2071) 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-05-11 14:38:44 +01:00
Mihaela Stoica
5b234d181d
Merge pull request #2065 from kc284/release/kolkata/master2 
Disable creation of SR-IOV network if the feature is disabled.
 2018-05-09 12:54:32 +01:00
Konstantina Chremmou
3fc14c5344 Disable creation of SR-IOV network if the feature is disabled. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-05-09 12:38:26 +01:00
Mihaela Stoica
4096803ee1 CA-288560: Convert CPU average frequency to GHz, when needed 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-05-02 12:57:10 +01:00
Mihaela Stoica
906af62422 CA-288560: Add friendly name and units for CPU average frequency 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-05-02 12:57:10 +01:00
vetrivelc
1f4fa9b46a L10N: CA-288597 & Translation Updates 2018-04-26 10:54:18 +01:00
Vetrivel Chinnasamy
998cea2ec2 L10N: Kolkata Bug Fixes (#2052) 
* L10N: UI Truncation Fixes

* L10N: Bug fix truncation issue JA

* L10N: Removed the help image in SC Wizard page

* L10N: Update to zh-CN XenWizrd Base
 2018-04-25 18:19:03 +01:00
Mihaela Stoica
296739cfa4
CP-27751: Include new RPU003 and RPU004 plugins for CA-287020 (#2049) 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-04-23 15:39:34 +01:00
Mihaela Stoica
d72ec5a94f
CA-286291: Add null and type checks (#2048) 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-04-23 12:54:09 +01:00
Michael
1a8f19ba69 CA-286291: Fix the crash when quickly and repeatedly popping up Migrate-to-Server menu (#2018) 
* CA-286291: Fix the crash when quickly and repeatedly popping up Migrate-to-Server menu.

* Update the thread model.

Signed-off-by: Michael Zhao <michael.zhao@citrix.com>

* Fix an error in using _stopped flag.
 2018-04-23 09:59:18 +01:00
Konstantina Chremmou
21d6080464 Normalisation and internationalisation for exceptions thrown when failing to resolve objects in the cache. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-04-23 09:54:48 +01:00
Mihaela Stoica
8a16c794c1
Merge pull request #2046 from vetrivelc/master 
L10N:CA-281877,CA-283587,CA-286950,CA-287318 Fix Updates
 2018-04-20 11:38:52 +01:00
Vetrivel Chinnasamy
0cf3d404ee L10N:CA-281877,CA-283587,CA-286950,CA-287318 Fix Updates 2018-04-20 18:28:09 +08:00
jishengx
aa276dc8f5 CA-286449: Filter out SR-IOV network when importing OVF (#2037) 
CA-286449: Filter out SR-IOV network when importing OVF

Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
 2018-04-19 15:51:33 +01:00
vetrivelc
4ac8f99bae L10N: Localization File updates 2018-04-19 18:07:23 +05:30
Kat Shann
5d961c22f2 Update the CHM files (#2042) 
* L10n: Inverness

build_chm #24

* Revert "L10n: Inverness"

This reverts commit 8b41bb8c79cd4d73ed6021a5533cf7624a5421c4.

* L10n: Inverness

CHMs from build_chm master-l10n #24

Second attempt at checkin with a merge conflict resolve. (I hope)

* L10n: Localized files with fix

Remove artifacts introduced by XTM

* Update Kolkata Help files

* Update fro broken links fix
 2018-04-17 15:13:43 +01:00
Konstantina Chremmou
2a6451f0cd Some more string corrections. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-04-17 13:32:05 +01:00
Konstantina Chremmou
04a29dd3a0 Message correction. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-04-17 13:32:05 +01:00
Mihaela Stoica
1af6781de8
Merge pull request #2040 from vetrivelc/master 
L10N: CA-281877 JA & SC fix
 2018-04-17 11:03:48 +01:00
vetrivelc
ea1baf33e7 L10N: CA-281877 JA & SC fix 2018-04-17 15:25:29 +05:30
kunm
0afcef56d3 CA-278960: Replace ListViewEx with DataGridViewEx for PhysicalStoragePage (#2015) 
* CA-278960: Replace ListViewEx with DataGridViewEx for PhysicalStoragePage

Signed-off-by: Kun Ma <kun.ma@citrix.com>
 2018-04-17 10:36:04 +01:00
vetrivelc
7c3c95f74b L10N: Fixes CA-283585,CA-283587,CA-287318,CA-286950,CA-287342,CA-281877 UI/Truncation Issues 2018-04-17 12:11:23 +05:30
vetrivelc
b57d7d13bf L10N:CA-287607 Translation Updates 2018-04-17 10:08:42 +05:30
Konstantina Chremmou
e6b62809c1 CA-287714: Fixed regression introduced with b4956da8f1: 
The DataArchive.Sets are supposed to be updated on the UI thread.
Added an extra safeguard when updating the DataKey items, namely copy the archives
to a local variable. Also, some minor refactoring to make looking up sets into
the archives more efficient.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-04-12 15:48:47 +01:00
Konstantina Chremmou
ae8cdcdc23 Fixed annoying xml doc warning. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-04-12 15:48:47 +01:00
Mihaela Stoica
2af3de8e7f CA-287430: Fixed the issue where the "Install Update" page of the patching wizard does not show the information on the host reboot steps. 
- use the plan action's ProgressDescription property to display the steps in RestartHostPlanAction (evacuate host, reboot host, bring babies back);
- the plan action should not be visible if the restart is skipped;

- The change to the DownloadAndUnzipXenServerPatchAction is to ensure that the download progress description is updated on the wizard with the correct description (in automated updates mode, via DownloadPatchPlanAction); DownloadPatchPlanAction is using the ActionChanged event to update its description based on the  action's DownloadProgressDescription property, but the ActionChanged event is called when the PercentComplete is updated, so this needs to happen after DownloadProgressDescription has been updated.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-04-10 11:08:18 +01:00
Konstantina Chremmou
82dc176c44 CA-287498: Removed left over calls to the base class method which were causing an infinite loop. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-04-09 09:58:40 +01:00
Mihaela Stoica
1925fc9ec4 CA-285215: Cancel button should be enabled on the Patching wizard when the update installation is in progress 
- also fixing an error on the patching wizard where a null reference exception is thrown if, when the wizard is cancelled, the host where an update has been uploaded is not connected anymore

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-04-09 08:47:26 +01:00
Mihaela Stoica
e85954fb75 CP-27568: Update the RPU hotfix to version 5 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-04-05 11:01:04 +01:00
Mihaela Stoica
cab6a051b8 Merge branch 'REQ-477' into master 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

# Conflicts:
#	XenModel/XenAPI/PCI.cs
#	XenModel/XenModel.csproj
 2018-04-04 09:59:29 +01:00
Konstantina Chremmou
5d4a9270eb Simplified class hierarchies for the SrDescriptors. Among others, we avoid the presence of irrelevant key-value pairs in the DeviceConfig . 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-04-04 08:03:28 +01:00
Mihaela Stoica
2943b048fa CP-17099: Remove unused function 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-04-04 08:03:28 +01:00
Mihaela Stoica
6a8b65b21e CP-17099: Do the double probe for HBA 
- The LVMOHBAWarningDialog class has been changed to display the type of the existing SR and the requested type (that will be used for formatting)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-04-04 08:03:28 +01:00
Konstantina Chremmou
585f7a848f Cleared some more warnings with regards to xml documentation. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-04-03 13:00:27 +01:00
Konstantina Chremmou
c96fd646d3 Removed unused event (event handler content was commented out). 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-04-03 13:00:27 +01:00
Konstantina Chremmou
583513f9e4 CA-202377: Removed the QueuedBackgroundWorker from the NewDisk dialog (unused) 
and the vApps dialog (not particularly needed because we only query the cache
and do not make any server side calls).
Also, removed unhooked event handlers from the NewDisk dialog.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-04-03 13:00:27 +01:00
Konstantina Chremmou
78511b0a02 Replaced Java-like documentation of class members with C# xml documentation. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-04-03 13:00:27 +01:00
Konstantina Chremmou
7655011158 Compliance with C# conventions: normally interface names start with an I. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-04-03 13:00:27 +01:00
Vetrivel Chinnasamy
587144d3bf L10N: Translation Updates (#2020) 
* L10N: Translation Updates
 2018-04-03 11:57:09 +01:00
Konstantina Chremmou
6adcd2b83f Some more code simplifications. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-04-03 11:24:40 +01:00
Konstantina Chremmou
4b0aa132d2 Simplified the FibreChannelProbeAction and compacted the methods and helper classes for parsing the results for the various SR types. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-04-03 11:24:40 +01:00
Konstantina Chremmou
4452318d1d Moved the classes FibreChannelDevice and FibreChannelProbeParsing to XenModel. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-04-03 11:24:40 +01:00
Konstantina Chremmou
959e43480c CP-17099: Double probe for iSCSI - minor refactoring to reduce code duplication. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-04-03 11:24:40 +01:00
Mihaela Stoica
fc42be5bee CP-17099: Do the probe_ext for HBA 
- Move the scan for HBA devices after the Provisioning page
- Fix the device-config for HBA (removed uri)
- Add probe_ext in FibreChannelProbeAction and the method to process the result

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-04-03 11:24:40 +01:00
Mihaela Stoica
e294e903fd CP-17099: Do the double probe for iSCSI 
When we scan the LUN to see if there are any existing SRs, we need to do an additional probe if the probe for the desired type didn't find any SRs.
E.g. if  GFS2 is selected and no GFS2 SR was found on the LUN, then we need to also check if there is a LVM over iSCSI SR, and if there is one we will offer to reattach it (as LVM over iSCSI) or format it as GFS2

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-04-03 11:24:40 +01:00
Joey
48782eac44 CA-286458: Fix latestcr XC requirement when apply CR update (#2010) 
* CA-286458: Fix latestcr XC requirement when apply CR update

Using minimum_xc_version attribute in xenserver version to
determine which xencenter version is required.

* CA-286458: change MinimumXcVersion type to Version

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
 2018-03-29 11:13:13 +01:00
Mihaela Stoica
fcb6399535 CP-17099: Changes following code review 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-03-28 17:07:15 +01:00
Mihaela Stoica
6ad6b4efc7 CP-17099: Use SR.probe_ext for GFS2 over iSCSI to populate the lists of IQNs and LUNs on the New SR wizard 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-03-28 17:07:15 +01:00
Mihaela Stoica
d3fa68e210 CA-286582: Hide the Provisioning method page if the feature is not present or disabled 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-03-28 17:07:15 +01:00
serenc
b7d3a2b3b5 CP-17099: Add gfs2 SR probe 
Signed-off-by: serenc <seren.corbett@citrix.com>
 2018-03-28 11:34:42 +01:00
vetrivelc
c910f7d41b L10N: Translation Updates 2018-03-27 13:47:39 +01:00
Joey
d80240b891 CA-281652: Add VM_REQUIRES_GPU failure reason (#1997) 
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
 2018-03-26 11:04:12 +01:00
jishengx
ebadba53c3 CA-286339: The prompt information on RPU prechecks should be accurate (#2009) 
* CA-286339: The prompt information on RPU prechecks should be accurate

Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>

* fix some comments
 2018-03-26 10:55:24 +01:00
Jisheng Xing
8e64c917e2 fix review comments 
modify the judgement of SR-IOV network

fix review comments

fix review comments

judge the resolve result and modify the link status of VLAN on SR-IOV
 2018-03-26 16:33:11 +08:00
Jisheng Xing
ba0cfdbf59 CA-286129: add or filter out SR-IOV network when creating VM or importing XVA 
Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
 2018-03-26 16:32:53 +08:00
Jisheng Xing
f41a61ac73 CA-286278: VLAN network on top of SRIOV also belongs to SR-IOV 
Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
 2018-03-26 16:32:38 +08:00
Jisheng Xing
59ba1db95f CA-286136: modify the SR-IOV related display 2018-03-23 14:44:59 +08:00
Jisheng Xing
6cf968a209 CA-286129: allow VIF to be updated to a SRIOV VF 2018-03-23 14:44:58 +08:00
Jisheng Xing
73eefe33b5 CA-286136: modify SR-IOV related info display 
Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
 2018-03-23 14:44:57 +08:00
jishengx
a22cb38835 CP-26363: Display the remaining VF numbers in NIC TabPage (#1982) 
* CP-26363: Display the remaining VF numbers in NIC TabPage

* correct the link status of Networking TabPage

* show the warning when creating SR-IOV network

* fix some comments

* modify the action

Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
 2018-03-23 14:44:56 +08:00
jishengx
e7bfb78c00 CP-26884 + CP-27199: Add network-sriov info in OVF file when exporting vm + Block VF assignment to VM according to recommendations: a (#1980) 
* CP-26884: add network-sriov info in OVF file when exporting vm

Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>

* CP-27199: Block VF assignment to VM according to recommendations

Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>

* fix some comments

* revert the Messages.resx
 2018-03-23 14:44:51 +08:00
jishengx
9cfac68d8d CP-25990: Enable Create VLAN on SR-IOV network (#1975) 
* CP-25990: Enable Create VLAN on SR-IOV network

Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>

* fix review comments
 2018-03-23 14:43:51 +08:00
Jisheng Xing
7dd99857cd CP-26391: Display the SR-IOV network status on Networking Tab Page 
Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
 2018-03-23 14:41:55 +08:00
Jisheng Xing
35acc262ee CP-27188: Filter out the SR-IOV network when configuring IP address 
Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
 2018-03-23 14:41:54 +08:00
jishengx
6f4fa43c03 CP-26362: Enable create SR-IOV network (#1952) 
* update the XenAPI according to the Jason-RPC

* CP-26362: Enable create SR-IOV network

* fix review comments

* fix the judgement on SR-IOV details page

* disable the finish button

Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
 2018-03-23 14:27:04 +08:00
Jisheng Xing
530462ad41 CP-26491: modify IsPhysical function and Properties dialog according to SR-IOV 2018-03-23 14:26:03 +08:00
jishengx
c966e25cc1 CP-26000: Add SR-IOV column in Networking and NIC TabPage (#1903) 2018-03-23 14:24:51 +08:00
jishengx
b2c74ff261 CP-25982: add wizard to enable SR-IOV network (#1887) 2018-03-23 14:24:10 +08:00
Konstantina Chremmou
29cdf221bc Cleared some level 4 warnings. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-03-22 15:07:32 +00:00
Mihaela Stoica
a61dd0c5c0 Fix NullReferenceException in the Patching wizard, on pressing the Finish button) 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-03-22 10:32:41 +00:00
Michael
cb0ee70012
Merge pull request #1986 from MihaelaStoica/CA-285268 
CA-285268: Patching Wizard improvement: Read metadata from the update…
 2018-03-21 17:30:59 +08:00
Michael Zhao
7c8b2f6d40 CA-271850: Increase the timeout of session for querying MaximumTolerableHostFailures. 2018-03-20 07:09:34 +00:00
Michael
ebb918296b CA-284226: Optimize performance of menu Start-on-Server and Migrate-to-Server (#1985) 
* CA-284226: Reduce unnecessary CanExecute() calls.

* CA-284226: Optimize the performance of menu Migrate to Server and Start on Server.

* Fix an error in updating Migrate menu with WLB, which lead to crash.

* Clear the worker queue when menu is closed.

Signed-off-by: Michael Zhao <michael.zhao@citrix.com>

* Fix comments.
 2018-03-20 07:07:19 +00:00
Mihaela Stoica
45ad13133d Use the new methods PageLeaveCore and PageLoadedCore in ChooseSrProvisioningPage 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-03-19 14:08:32 +00:00
Mihaela Stoica
f7b27ec222
Merge pull request #1994 from xenserver/REQ-477 
Merge REQ-477 into master
 2018-03-19 13:23:19 +00:00
Mihaela Stoica
713877b49e CA-285268: Code simplification 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-03-16 14:00:07 +00:00
jishengx
0c13d8786d CA-274082: Check status of SR uploaded updates during update installa… (#1937) 
* CA-274082: Check status of SR uploaded updates during update installation
* fix review comments

Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
 2018-03-14 12:19:14 +00:00
Mihaela Stoica
f64fd58970 CA-285268: Patching Wizard improvement: Read metadata from the update file, instead of relying on the file name to match the update name in cfu 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-03-14 12:12:18 +00:00
Konstantina Chremmou
d69f2ddda3 Enforce treating warnings as errors in Debug mode too as it is going to save 
us a lot of broken builds. Fixed bug where the HostPlanAction.CurrentHost was
always null (as the private field was never set).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-03-09 11:22:26 +00:00
Konstantina Chremmou
ee648135f6 Since it is easy to forget calling the base class method at the beginning of the 
PageLoaded override in derived classes, enforce it by wrapping the page specific
code in a new virtual method, which the derived classes can override and PageLoaded
can call after its own logic.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-03-09 11:22:26 +00:00
Konstantina Chremmou
7a1b1a6dcc Since it is easy to forget calling the base class method at the end of the PageLeave 
override in derived classes, enforce it by wrapping the page specific code in
a new virtual method, which the derived classes can override and PageLeave can
call before its own logic.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-03-09 11:22:26 +00:00
Konstantina Chremmou
2b8bf70ee5 CA-272769: Call the base class method in the end of the PageLeave override, so the 
WizardContentUpdater is invoked and information flows from the SelectInstallMethod
page to the following pages.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-03-09 11:22:26 +00:00
Konstantina Chremmou
a8b831fab9 Simplified check as per code review. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-03-09 11:22:26 +00:00
Mihaela Stoica
0184470ea3
Merge pull request #1968 from kc284/master 
CA-284125: Automated updates should prioritise a pending host restart to a mandatory xapi restart
 2018-03-08 15:54:39 +00:00
Michael
a4aaeb1165 CA-272150: Optimize destination page of cross-pool-migrate wizard. (#1941) 
* CA-272150: Optimize destination page of cross-pool-migrate wizard.

Signed-off-by: Michael Zhao <michael.zhao@citrix.com>
 2018-03-08 13:22:38 +00:00
Konstantina Chremmou
9e3a9abfa0 Resolve host before querying its properties. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-03-08 11:34:00 +00:00
Konstantina Chremmou
b3828ef452 Added parameter enableOnly defaulting to false to the RestartHostPlanAction 
so as to be able to evacuate-reboot the host without bringing the VMs back.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-03-07 17:50:51 +00:00
Mihaela Stoica
929ae78942 CA-284876: Process the VM parameter of the VM_FAILED_SHUTDOWN_ACKNOWLEDGMENT error on host evacuation 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-03-07 11:28:57 +00:00
Konstantina Chremmou
4b6e826ed3 CA-284125: Prioritise a pending host restart over a mandatory toolstack restart. 
For this purpose, the evacuate-reboot-bringbabiesback triplet was replaced by a
new RestartHostPlanAction, which allows fallback to toolstack restart if live
patching has succeeded. Also, created new abstract class HostPlanAction to
reduce code duplication.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-03-06 15:12:04 +00:00
Konstantina Chremmou
de9b0c4d30 Revisited commit 3f2eed35a0 reverting Dictionary to 
List in order to enforce the order of checks (the Dictionary is not guaranteed to
keep the order the items are added). Also, extra null check.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-03-06 14:17:16 +00:00
Konstantina Chremmou
a22a9a41e3 A couple of small inefficiencies. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-03-06 14:17:16 +00:00
Konstantina Chremmou
7505bda9e3 Removed unused properties of UpdateProgressBackgroundWorker; store the number of 
actions on creation instead of calculating it every time on access.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-03-06 14:17:16 +00:00
Konstantina Chremmou
c5b0af533e Removed methods GetHostBootTime and GetHostAgentTime because they duplicated logic 
in the Host extensions. Moved method TryResolveWithTimeout to the Connection class
where it is more relevant. Removed wrapper methods WaitForReboot and WaitForAgent
as they were not particularly useful.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-03-06 14:17:16 +00:00
Konstantina Chremmou
ed4b131643 Removed unused code and old style custom delegates, and updated property notation. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-03-06 14:17:16 +00:00
Konstantina Chremmou
71e554cc39 Removed duplicate logic calculating VM groups from the WizardPages and moved it the Host class as extension methods. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-03-06 14:17:15 +00:00
Konstantina Chremmou
3171005d23 Removed redundant code in file. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-03-06 14:17:15 +00:00
serencorbett1
393f9d64b9 CA-284095: Fix sort-by creation date (#1966) 
* CA-284095: Fix sort-by creation date

Signed-off-by: serenc <seren.corbett@citrix.com>
 2018-03-06 13:07:22 +00:00
Kun Ma
f28322e5db CA-270999: Add registration to RestartManager 
Signed-off-by: Kun Ma <kun.ma@citrix.com>
 2018-03-06 09:36:05 +00:00
Konstantina Chremmou
058601f761 CA-279578: Update the Recheck/Resolve button state and error message visibility 
alongside the wizard progress buttons. For this purpose, the separate UpdateControls
method was removed and the logic was moved in the EnableNext method. The OnPageUpdated
method that fires this is now called every time the checks start.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-03-02 13:32:49 +00:00
Konstantina Chremmou
3f2eed35a0 Refactoring: use a dictionary to hold the list of generated checks; simplified calculation of progress percentage. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-03-02 13:32:49 +00:00
Mihaela Stoica
ff05fb698c Merge remote-tracking branch 'upstream/master' into REQ-477 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

# Conflicts:
#	XenModel/XenAPI/Auth.cs
#	XenModel/XenAPI/Blob.cs
#	XenModel/XenAPI/Bond.cs
#	XenModel/XenAPI/Console.cs
#	XenModel/XenAPI/Converters.cs
#	XenModel/XenAPI/Crashdump.cs
#	XenModel/XenAPI/DR_task.cs
#	XenModel/XenAPI/Event.cs
#	XenModel/XenAPI/Feature.cs
#	XenModel/XenAPI/GPU_group.cs
#	XenModel/XenAPI/Host.cs
#	XenModel/XenAPI/Host_cpu.cs
#	XenModel/XenAPI/Host_crashdump.cs
#	XenModel/XenAPI/Host_metrics.cs
#	XenModel/XenAPI/Host_patch.cs
#	XenModel/XenAPI/JsonRpcClient.cs
#	XenModel/XenAPI/LVHD.cs
#	XenModel/XenAPI/Maps.cs
#	XenModel/XenAPI/Message.cs
#	XenModel/XenAPI/Network.cs
#	XenModel/XenAPI/PBD.cs
#	XenModel/XenAPI/PCI.cs
#	XenModel/XenAPI/PGPU.cs
#	XenModel/XenAPI/PIF.cs
#	XenModel/XenAPI/PIF_metrics.cs
#	XenModel/XenAPI/PUSB.cs
#	XenModel/XenAPI/PVS_cache_storage.cs
#	XenModel/XenAPI/PVS_proxy.cs
#	XenModel/XenAPI/PVS_server.cs
#	XenModel/XenAPI/PVS_site.cs
#	XenModel/XenAPI/Pool.cs
#	XenModel/XenAPI/Pool_patch.cs
#	XenModel/XenAPI/Pool_update.cs
#	XenModel/XenAPI/Role.cs
#	XenModel/XenAPI/SDN_controller.cs
#	XenModel/XenAPI/SM.cs
#	XenModel/XenAPI/SR.cs
#	XenModel/XenAPI/Secret.cs
#	XenModel/XenAPI/Session.cs
#	XenModel/XenAPI/Subject.cs
#	XenModel/XenAPI/Task.cs
#	XenModel/XenAPI/Tunnel.cs
#	XenModel/XenAPI/USB_group.cs
#	XenModel/XenAPI/User.cs
#	XenModel/XenAPI/VBD.cs
#	XenModel/XenAPI/VBD_metrics.cs
#	XenModel/XenAPI/VDI.cs
#	XenModel/XenAPI/VGPU.cs
#	XenModel/XenAPI/VGPU_type.cs
#	XenModel/XenAPI/VIF.cs
#	XenModel/XenAPI/VIF_metrics.cs
#	XenModel/XenAPI/VLAN.cs
#	XenModel/XenAPI/VM.cs
#	XenModel/XenAPI/VMPP.cs
#	XenModel/XenAPI/VMSS.cs
#	XenModel/XenAPI/VM_appliance.cs
#	XenModel/XenAPI/VM_guest_metrics.cs
#	XenModel/XenAPI/VM_metrics.cs
#	XenModel/XenAPI/VTPM.cs
#	XenModel/XenAPI/VUSB.cs
#	XenModel/XenModel.csproj
 2018-02-27 17:42:18 +00:00
serenc
c7ac86224a CA-282014: Patching wizard now deletes downloaded patch when wizard cancelled 
Signed-off-by: serenc <seren.corbett@citrix.com>
 2018-02-27 11:16:26 +00:00
Konstantina Chremmou
b4956da8f1 Performance and workflow improvement: 
- no need to register the XenObjects events with the ArchiveMaintainer since
what the handler does is not specific to this class; this can be done on the
Performance page where the events are also registered.
- set directly the ArchiveMaintainer's XenObject to the new value without
setting it intermediately to null as this causes a full data download event
if the object has not changed.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-02-22 10:18:18 +00:00
Konstantina Chremmou
267035c2c6 Use Action instead of EventHandler since the event is fired without arguments. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-02-22 10:18:18 +00:00
Konstantina Chremmou
1728eb64b6 Simplified the code building the plan actions list as the previous code was 
calculating the AfterApplyGuidanceActionsForPatch twice when the patch had
mandatory guidance.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-02-21 14:14:03 +00:00
Konstantina Chremmou
63c6b817d5 CA-40854: The Session's uuid is in reality its opaque_ref. Use the opaque_ref so 
it's obvious what it is. The Session's uuid will be deprecated from the API bindings.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-02-21 14:08:01 +00:00
kunm
f0f37d9690 CA-280329: Fix CrossPoolMigrateDestinationPage with Current Server showing (#1931) 
* CA-280329: Fix CrossPoolMigrateDestinationPage with Current Server showing

Signed-off-by: Kun Ma <kun.ma@citrix.com>

* CA-280329: Refine usage of CreateTargetServerFilterList

Signed-off-by: Kun Ma <kun.ma@citrix.com>
 2018-02-05 15:31:22 +00:00
Mihaela Stoica
95471eaac5 CA-281646: Do not download the update again when using an update from disk (#1933) 
* CA-281646: Do not download the update again when using an update from disk

When applying a "new version" update, XenCenter starts an automated updates sequence that by default downloads all the updates. However, when using an update from disk, we shouldn't download it again.

With these changes, when an update from disk is used we save the [update, path] mapping, which we then use in the automated updates sequence, so we don't download that update again.

Also fixed a bug where a zipped update file from disk is not identified as a new version.

* CA-281646: Remove unused directive

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-02-05 12:36:49 +00:00
serenc
c99c4a0f2e CA-280299: Rescan SRs when choosing SR for copying VM 2018-02-05 10:53:46 +00:00
Michael
6a6931dbd5 CA-280322: Space requirement calculation error in migration wizard. (#1934) 
* CA-280322: Space requirement calculation error in migration wizard.

* Fix comments.

Signed-off-by: Michael Zhao <michael.zhao@citrix.com>
 2018-02-05 10:07:24 +00:00
Mihaela Stoica
0f31a6f857
Merge pull request #1932 from xenserver/REQ-420 
Merge request from REQ-420 into master
 2018-02-01 12:24:27 +00:00
Konstantina Chremmou
19de8c54b5 CA-280679: Fixed issue where the TabPage plugin could not handle Ipv6 addresses. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-01-29 10:17:27 +00:00
Konstantina Chremmou
123db499f5 Merge branch 'master' into REQ-420 2018-01-25 13:38:58 +00:00
Konstantina Chremmou
99f9a70189 Connection code simplification/update: removed CachePopulatedEventArgs class and use the newer Action delegate instead. 
Also, changed the access modifiers of several members to private, because they don't need to be exposed outside the parent class.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-01-24 15:58:16 +00:00
Mihaela Stoica
deb953a6ff CA-280287: Fix the null reference exception on the Import wizard (#1918) 
* CA-280287: Fix the null reference exception on the Import wizard

- Added a check so that we don't attempting to show the license warning if the wizard is open without a preselected host/pool.
- The license warning is now updated whenever the host selection changes; plus, we are not attempting to show it if the wizard is open without a preselected host/pool.

- Also a minor refactoring in the GlobalSelectHost page to fix this issue: when the wizard is open with a pre-selected host, we pass this to the page by assigning SelectedHost property, which in turn sets the m_selectedHost. The getter for SelectedHost  resets m_selectedHost to the selected item in the host list. If the getter is used before the host list selection is updated, then the desired pre-selection is lost, because m_selectedHost is reset to null.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* CA-280287: Corrections following code review

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-01-19 14:05:20 +00:00
Mihaela Stoica
babf201d2a CA-276678: Add "Buy licenses" link in the patching wizard when the precheck fails with license restriction 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-01-19 13:11:00 +00:00
Mihaela Stoica
b9e85f93d5
Merge pull request #1914 from serencorbett1/REQ-477 
CP-26253: changed "images" to "virtual disks" to avoid confusion
 2018-01-18 15:39:51 +00:00
Mihaela Stoica
5fb9709b8a Merge master into REQ-477 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

# Conflicts:
#	XenModel/FriendlyNames.resx
#	XenModel/Messages.resx
#	XenModel/XenAPI/ApiVersion.cs
 2018-01-15 14:41:40 +00:00
Mihaela Stoica
6cefd4d202 CA-276976: Add a new precheck in the Update Wizard 
- The new "server selection" precheck is added for Inverness or greater pools and checks if all the servers in the pool are selected (if update not already applied) when applying an update that has the "enforce-homogeneity" flag set to true

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-01-12 14:34:50 +00:00
serenc
92a809e433 CP-26253: changed "images" to "virtual disks" to avoid confusion 
Signed-off-by: serenc <seren.corbett@citrix.com>
 2018-01-12 14:05:01 +00:00
Mihaela Stoica
018dfb8e79 Rename resource string which causes Messages.resx to become unsorted 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-01-11 12:45:37 +00:00
serencorbett1
16d0c1cc77 CP-26253: Added changes to UI based on feedback (#1906) 
* CP-26253: Added changes to UI based on feedback

Signed-off-by: serenc <seren.corbett@citrix.com>

* CP-26253: Corrected spelling mistake

Signed-off-by: serenc <seren.corbett@citrix.com>

* CP-26253: Changed "Thin Provisioning (GFS2) SRs"  to "thinly provisioned"

Signed-off-by: serenc <seren.corbett@citrix.com>
 2018-01-10 15:13:55 +00:00
Mihaela Stoica
13a8b26fc4 Merge release/jura/master into REQ-637 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

# Conflicts:
#	XenModel/Utils/Helpers.cs
 2017-12-19 13:12:39 +00:00
Mihaela Stoica
ffa42c086b CP-26290: Add new edition 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2017-12-18 13:22:17 +00:00
Michael
035f4c234e CA-272797: Limit user to select 8 SRs at most in DR Configure dialog. (#1896) 
* CA-272797: Limit user to select 8 SRs at most in DR Configure dialog.

Signed-off-by: Michael Zhao <michael.zhao@citrix.com>
 2017-12-18 09:55:45 +00:00
Gabor Apati-Nagy
00040b5761
Merge pull request #1897 from MihaelaStoica/REQ-477 
CP-26131: IP Address Configuration when clustering is enabled
 2017-12-15 11:11:40 +00:00
serencorbett1
89ae8534fa CP-26193: Disable remove IP address button when clustering enabled on… (#1898) 
* CP-26193: Disable remove IP address button when clustering enabled on network

* CP-25967: Combine two if statements

* CP-25967: Changed ClusteringEnabled boolean method

* CP-25967: Removed var

Signed-off-by: serenc <seren.corbett@citrix.com>
 2017-12-15 11:09:26 +00:00
Mihaela Stoica
080b69befa CP-26131: Use SR.GetSR.GetSRType()instead of type 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2017-12-15 10:47:12 +00:00
Gabor Apati-Nagy
3a076e21c6 CP-26048: Improve the fix for CA-271775 (console tab) 
Fixed typo

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
 2017-12-13 10:48:23 +00:00
Gabor Apati-Nagy
a01a4b9855 CP-26048: Improve the fix for CA-271775 (console tab) 
Improved message (when using an outdated RDP client)

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
 2017-12-13 10:48:23 +00:00
Gabor Apati-Nagy
9b6806de1b CP-26048: Improve the fix for CA-271775 (console tab) 
Reserved space for the warning message that is displayed if the XC machine is running an older version of the RDP control

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
 2017-12-13 10:48:23 +00:00
serencorbett1
f4d501474a CP-25564: Changed clusteringEnabled variable (#1891) 
* CP-25564: Changed clusteringEnabled variable

* CP-26026: Added a link to enable clustering on SR Wizard

* CP-26026: Tweaked according to PR feedback

* CP-25967: Added license restriction for GFS2

Signed-off-by: serenc <seren.corbett@citrix.com>
 2017-12-12 13:36:09 +00:00
Mihaela Stoica
1e08eb2371
Merge pull request #1890 from jishengx/private/jishengx/CA-272130 
CA-272130: modify truncated linklabel and text on the memory settings wizard
 2017-12-07 13:53:03 +00:00
Gabor Apati-Nagy
a2a5f4eaeb
Merge pull request #1888 from michael2012z/private/fengyangz/CA-271863 
CA-271863: Can not automatically resolve autostart-enabled VM in RPU.
 2017-12-07 11:12:31 +00:00
Jisheng Xing
449dfe7f56 CA-272130: modify truncated linklabel and text on the memory settings wizard 2017-12-07 17:28:03 +08:00
Michael Zhao
10afdbc541 CA-271863: Update max waiting time to 5 seconds to handle extreme cases. 2017-12-07 13:03:06 +08:00
serenc
d3be7848f1 CP-25564: pif.host.opaque_ref 
Signed-off-by: serenc <seren.corbett@citrix.com>
 2017-12-06 13:50:55 +00:00
Michael
1d0a2b76a0 CA-272769: Enable user to cancel URL testing in rolling upgrade wizard. (#1882) 
* CA-272769: Enable user to cancel URL testing in rolling upgrade wizard.

* CA-272769: Sort messages resource file.
 2017-12-06 12:06:36 +00:00
serenc
1b4f2c4e32 CP-25564: Deleted tags 
Signed-off-by: serenc <seren.corbett@citrix.com>
 2017-12-06 09:53:52 +00:00
serenc
3532e9b586 CP-25563: Improved code from feedback 
Signed-off-by: serenc <seren.corbett@citrix.com>
 2017-12-06 09:49:56 +00:00
Michael Zhao
1cf6b55368 CA-271863: Can not automatically resolve autostart-enabled VM in RPU. 2017-12-06 15:57:07 +08:00
serenc
7790bed4ca Merge remote-tracking branch 'upstream/REQ-477' into REQ-477 
Signed-off-by: serenc <seren.corbett@citrix.com>

# Conflicts:
#	XenAdmin/Dialogs/NetworkingPropertiesPage.cs
#	XenAdmin/Help/HelpManager.resx
 2017-12-05 11:16:16 +00:00
serenc
ea7c9b76f2 CP-25564: Added condition for maintenance mode and clustering 
Signed-off-by: serenc <seren.corbett@citrix.com>
 2017-12-05 10:50:56 +00:00
serenc
dd2bde777a CP-25564: Disable IP configuration if clustering is enabled 
Signed-off-by: serenc <seren.corbett@citrix.com>
 2017-12-04 16:51:14 +00:00
serenc
f430cf58c8 CP-25563: Corrected column layout of tableLayoutInfo 
Signed-off-by: serenc <seren.corbett@citrix.com>
 2017-12-04 15:57:12 +00:00
serenc
00aa042bd7 CP-25563: Added hotkeys,changed flowLayout and corrected label alignment 
Signed-off-by: serenc <seren.corbett@citrix.com>
 2017-12-04 13:50:52 +00:00
Mihaela Stoica
72071a3334 Merge master into REQ-477 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

Conflicts:
	XenModel/XenAPI/Proxy.cs
 2017-12-04 13:37:12 +00:00