Commit Graph

3222 Commits

Author SHA1 Message Date
Callum McIntyre
df9410ac6a CA-112317: Sorting on SR storage tab is incorrect
Making the requested changes: Name is now sorted by the generic CompareTo method (which uses name with opaque ref as tiebreaker), and Description also uses opaque ref as tiebreaker for consistency.
2016-08-31 16:42:01 +01:00
Callum McIntyre
49a586430e CP-17848: Rename UpdateType enum NewSuppPack to ISO, since for this ticket we will handle all updates as ISOs 2016-08-31 10:42:09 +01:00
Callum McIntyre
c9ed8a1f68 CP-17848: XAPI changes to support new update packaging calls/structrures 2016-08-30 17:11:47 +01:00
Gabor Apati-Nagy
d5bb5d96bc Merge pull request #1139 from mcintyre94/CA-107341
CA-107341:  Truncation issue occurred on rolling pool upgrade window.
2016-08-30 16:01:01 +01:00
Gabor Apati-Nagy
b510dbe8c7 Merge pull request #1140 from mcintyre94/CA-112317
CA-112317: Sorting on SR storage tab is incorrect
2016-08-30 15:57:47 +01:00
Gabor Apati-Nagy
65f02fbba9 CA-174979: Confusing right-click add to pool menu (if you accept the defaults)
Changed "Unnamed Pool" to "Pool" to make the terminology clearer

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-30 15:52:33 +01:00
Gabor Apati-Nagy
e374ac2d12 Merge pull request #1143 from GaborApatiNagy/master
CP-18014: Fixed PatchingWizardModeGuidanceBuilderTests
2016-08-26 18:16:22 +01:00
Gabor Apati-Nagy
7680d3160f CP-18014: Fixed PatchingWizardModeGuidanceBuilderTests
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-26 18:15:14 +01:00
Gabor Apati-Nagy
d99cb8b06e Merge pull request #1142 from xenserver/CAR-2197
Merge CAR-2197 into Master
2016-08-26 16:50:47 +01:00
mcintyre94
9acf3950fd Merge pull request #1141 from GaborApatiNagy/CP-18014
CP-18014 + Merge master
2016-08-26 16:45:08 +01:00
Gabor Apati-Nagy
d7a94c1684 CP-18014: Alter batch hotfixing to use host.patches_requiring_reboot
Fixed flickering

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-26 16:41:12 +01:00
Gabor Apati-Nagy
15f69ef584 CP-18014: Alter batch hotfixing to use host.patches_requiring_reboot
Improving AvoidRestartHost usage/interface

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-26 16:04:28 +01:00
Gabor Apati-Nagy
f55cf77c00 CP-18014: Alter batch hotfixing to use host.patches_requiring_reboot
XenCenter will check host.patches_requiring_reboot when a host restart is due while a batch update is in progress. If the restart is not required, XenCenter will skip relevant PlanActions.
The intention here is to check this whenever a restart is due according to the original schedule - this way a completely livepatchable update can prevent the restart while the key batch hotfixing logic is not changed.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-26 15:37:57 +01:00
Gabor Apati-Nagy
0174974c93 Merge branch 'master' of https://github.com/xenserver/xenadmin into CP-18014
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

Conflicts:
	XenAdmin/Wizards/PatchingWizard/PatchingWizard.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
	XenModel/Messages.Designer.cs
	XenModel/Messages.ja.resx
	XenModel/Messages.resx
	XenModel/Messages.zh-CN.resx
2016-08-26 15:22:03 +01:00
Callum McIntyre
1cc960860b CA-112317: Sorting on SR storage tab is incorrect
Change the sorting on the Name and Description columns to use StringUtility.NaturalCompare, which correctly sorts strings with numbers at the end (eg name, name0, name1, name2, name10 will now sort correctly while alphabetic sorting is incorrect). Also added a tie break on uuid to make sorting behave predictably with duplicates in these columns.
2016-08-26 10:06:30 +01:00
Callum McIntyre
c41602085d CA-107341: Truncation issue occurred on rolling pool upgrade window.
Truncated pool and host names on the Ready to Upgrade page to 64 characters, which resolves the layout problem from extremely long names.
2016-08-25 16:48:39 +01:00
Konstantina Chremmou
9b7f90ccb4 CA-215575 plus refactoring: The connection bar does not need to manipulate anything
other than strings. Moved settings of the FullScreenForm from the VNCTabView to
the former class. The FullScreenFormof the VNCTabView is only initialised as
FullSCreenFrom so no casts are necessary. The FullScreenForm is responsible for
updating the connection bar text with the value obtained from the vncScreen everytime
the name of the connection changes. Also reduced visibility of certain members.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-24 13:51:50 +01:00
Gabor Apati-Nagy
6cf7865290 Merge pull request #1137 from mcintyre94/CAR-2197
CP-18618: If live patching fails, warn the user
2016-08-24 13:37:57 +01:00
Konstantina Chremmou
a9a1cd6b9c Tidied up: the vncScreen should notify the parent vncTab when the rdp warning needs
to be shown. It is complicated to have the one control call a method in the other
which checks the state on the first control.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-24 11:48:42 +01:00
Callum McIntyre
3de9b5d662 Revert "CP-18618: If live patching fails, warn the user"
This reverts commit cc60726084.
2016-08-24 11:38:41 +01:00
Callum McIntyre
cf48f1dc2e Revert "no message"
This reverts commit abf2357a31.
2016-08-24 11:38:23 +01:00
Callum McIntyre
7f5390e9c4 CP-18618: If live patching fails, warn the user
If we are expecting to live patch, but at the end
hosts.patches_requring_reboot contains the patch, then warn the user that
live patching has failed for the host - and it needs to be rebooted.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-24 11:13:58 +01:00
Callum McIntyre
abf2357a31 no message
Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-24 11:07:33 +01:00
Callum McIntyre
cc60726084 CP-18618: If live patching fails, warn the user
Intermediate checkin. Currently has fake functionality, will always claim every involved host requires a reboot. If one host, uses ThreeButtonDialog to offer to reboot it, else uses a new RebootHostsDialog to let the user choose which, if any, to reboot. Uses the progress bar + log already on the page, which is probably the wrong design but works for now.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-24 11:06:13 +01:00
Konstantina Chremmou
38ca217bc3 Tidied up: moved the full screen message from the VNCTabView class to the more relevant
FullScreenHint class.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-24 01:38:51 +01:00
mcintyre94
ab02ad6e91 Merge pull request #1136 from GaborApatiNagy/CP_18012_rebased
CP-18012: Use extended precheck information in Update Wizard
2016-08-23 18:56:24 +01:00
Gabor Apati-Nagy
7ee2e605ee CP-18012: Use extended precheck information in Update Wizard
This commit implements the check for LiveUpdate capability of a patch. If
the patch is completely live-updatable, XenCenter will not restart the
host (but will do further checks once it has finished installing the
update - separate ticket)

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-23 18:31:23 +01:00
Gabor Apati-Nagy
90c4e79c8c Merge pull request #1125 from mcintyre94/CP-18013
CP-18013: [XenCenter] Update host/pool updates pane
2016-08-23 17:45:07 +01:00
Konstantina Chremmou
629c2b48d1 Merge pull request #1134 from mcintyre94/CA-140181
CA-140181: Inconsistent name displaying when it contains symbol '&’
2016-08-23 12:14:01 +01:00
Konstantina Chremmou
ba4ecd5fa4 Merge pull request #1135 from mcintyre94/CA-152163
CA-152163: Duplicate hotkey "S" on "Location Mirrored SRs" wizard.
2016-08-23 12:06:20 +01:00
Callum McIntyre
cf4ed293ba CA-140181: Inconsistent name displaying when it contains symbol '&’ and becomes hotkey.
Now using the EscapeAmpersands string extension method. Also resolved the custom fields display issue in the same way.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-23 11:33:24 +01:00
Callum McIntyre
af9327d30a CA-152163: Duplicate hotkey "S" on "Location Mirrored SRs" wizard.
Redone the commit without any size changes.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-23 10:52:00 +01:00
Callum McIntyre
493b86a5c3 Revert "CA-152163: Duplicate hotkey "S" on "Location Mirrored SRs" wizard."
This reverts commit d928a406bc.
2016-08-23 10:37:29 +01:00
Konstantina Chremmou
bb327ac245 Merge pull request #1132 from stephen-turner/CA-150364
CA-150364: Shrunken item on status bar
2016-08-23 10:01:46 +01:00
Callum McIntyre
d928a406bc CA-152163: Duplicate hotkey "S" on "Location Mirrored SRs" wizard.
Moved the hotkey for "Find Storage Repositories" from S to R.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-22 17:44:56 +01:00
Callum McIntyre
14288ede3a CA-140181: Inconsistent name displaying when it contains symbol '&’
The ticket said the character after the & became a hotkey (like labels etc do with UseMnemonic enabled) but I couldn't reproduce that - & symbols were simply removed from the string. The fix is to replace them with &&, so the string.format prints a single & as it should.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-22 16:07:53 +01:00
Konstantina Chremmou
1994695fa6 Merge pull request #1133 from xenserver/REQ-156
Request to merge feature branch REQ-156 to master
2016-08-22 09:28:28 +01:00
Konstantina Chremmou
e99f86c29c Merge branch 'master' into REQ-156 2016-08-19 17:54:37 +01:00
Konstantina Chremmou
e561f04fb9 Revert "Ignore temporarily this test on branch REQ-156 (broke on trunk and is not relevant for this feature)."
This reverts commit 26009a79f0.
2016-08-19 17:52:16 +01:00
Stephen Turner
e99a97f748 CA-150364: Shrunken item on status bar 2016-08-19 16:50:08 +01:00
Frezzle
5464341e21 Merge pull request #1131 from kc284/master
Set checkbox state in the designer and not in the constructor to avoi…
2016-08-19 16:16:03 +01:00
Konstantina Chremmou
d07a34ad19 Set checkbox state in the designer and not in the constructor to avoid starting
the checks before the page is loaded. Corrected the conditions for enabling the
Previous and Next buttons on this page. This commit fixes broken RPU wizard test.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-19 15:45:16 +01:00
Konstantina Chremmou
26009a79f0 Ignore temporarily this test on branch REQ-156 (broke on trunk and is not relevant for this feature).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-19 12:56:15 +01:00
Frezzle
bbfd32353b Merge pull request #1130 from kc284/REQ-156
CA-217232: Added some null ref checks.
2016-08-19 12:44:04 +01:00
Konstantina Chremmou
73b0c36fb6 CA-217232: Added some null ref checks.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-19 10:55:18 +01:00
Konstantina Chremmou
0cd8391feb Merge pull request #1128 from GaborApatiNagy/REQ-156_github
CA-217232: Fixed regression caused by the fix for CA-216935
2016-08-19 10:42:41 +01:00
Gabor Apati-Nagy
54f67be47c CA-217232: Fixed regression caused by the fix for CA-216935
Changes following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-18 17:55:44 +01:00
Konstantina Chremmou
f17bf6fc68 Merge pull request #1129 from GaborApatiNagy/REQ-156_github_master
Merge master into branch REQ-156
2016-08-18 17:02:47 +01:00
Gabor Apati-Nagy
d054c80f62 CA-217232: Fixed regression caused by the fix for CA-216935
Changes following the code review
2016-08-18 16:02:24 +01:00
Gabor Apati-Nagy
1c5ba794b4 CA-217232: Fixed regression caused by the fix for CA-216935
Changes following the code review
2016-08-18 16:00:50 +01:00