Commit Graph

3189 Commits

Author SHA1 Message Date
Konstantina Chremmou
bb327ac245 Merge pull request #1132 from stephen-turner/CA-150364
CA-150364: Shrunken item on status bar
2016-08-23 10:01:46 +01:00
Callum McIntyre
d928a406bc CA-152163: Duplicate hotkey "S" on "Location Mirrored SRs" wizard.
Moved the hotkey for "Find Storage Repositories" from S to R.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-22 17:44:56 +01:00
Callum McIntyre
14288ede3a CA-140181: Inconsistent name displaying when it contains symbol '&’
The ticket said the character after the & became a hotkey (like labels etc do with UseMnemonic enabled) but I couldn't reproduce that - & symbols were simply removed from the string. The fix is to replace them with &&, so the string.format prints a single & as it should.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-22 16:07:53 +01:00
Konstantina Chremmou
1994695fa6 Merge pull request #1133 from xenserver/REQ-156
Request to merge feature branch REQ-156 to master
2016-08-22 09:28:28 +01:00
Konstantina Chremmou
e99f86c29c Merge branch 'master' into REQ-156 2016-08-19 17:54:37 +01:00
Konstantina Chremmou
e561f04fb9 Revert "Ignore temporarily this test on branch REQ-156 (broke on trunk and is not relevant for this feature)."
This reverts commit 26009a79f0.
2016-08-19 17:52:16 +01:00
Stephen Turner
e99a97f748 CA-150364: Shrunken item on status bar 2016-08-19 16:50:08 +01:00
Frezzle
5464341e21 Merge pull request #1131 from kc284/master
Set checkbox state in the designer and not in the constructor to avoi…
2016-08-19 16:16:03 +01:00
Konstantina Chremmou
d07a34ad19 Set checkbox state in the designer and not in the constructor to avoid starting
the checks before the page is loaded. Corrected the conditions for enabling the
Previous and Next buttons on this page. This commit fixes broken RPU wizard test.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-19 15:45:16 +01:00
Konstantina Chremmou
26009a79f0 Ignore temporarily this test on branch REQ-156 (broke on trunk and is not relevant for this feature).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-19 12:56:15 +01:00
Frezzle
bbfd32353b Merge pull request #1130 from kc284/REQ-156
CA-217232: Added some null ref checks.
2016-08-19 12:44:04 +01:00
Konstantina Chremmou
73b0c36fb6 CA-217232: Added some null ref checks.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-19 10:55:18 +01:00
Konstantina Chremmou
0cd8391feb Merge pull request #1128 from GaborApatiNagy/REQ-156_github
CA-217232: Fixed regression caused by the fix for CA-216935
2016-08-19 10:42:41 +01:00
Gabor Apati-Nagy
54f67be47c CA-217232: Fixed regression caused by the fix for CA-216935
Changes following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-18 17:55:44 +01:00
Konstantina Chremmou
f17bf6fc68 Merge pull request #1129 from GaborApatiNagy/REQ-156_github_master
Merge master into branch REQ-156
2016-08-18 17:02:47 +01:00
Gabor Apati-Nagy
d054c80f62 CA-217232: Fixed regression caused by the fix for CA-216935
Changes following the code review
2016-08-18 16:02:24 +01:00
Gabor Apati-Nagy
1c5ba794b4 CA-217232: Fixed regression caused by the fix for CA-216935
Changes following the code review
2016-08-18 16:00:50 +01:00
Gabor Apati-Nagy
53619c775d Merge remote-tracking branch 'github_xenadmin/master' into REQ-156_github_master
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

Conflicts:
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_SelectServers.cs
	XenModel/Actions/ParallelAction.cs
	XenModel/FriendlyNames.resx
	XenModel/Messages.Designer.cs
	XenModel/Messages.resx
2016-08-18 12:22:40 +01:00
Gabor Apati-Nagy
37c120ee57 CA-217232: Fixed regression caused by the fix for CA-216935
Creation of PoolPatchMapping objects made safer.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-18 11:30:50 +01:00
Gabor Apati-Nagy
feafb7ac62 CA-217232: Fixed regression caused by the fix for CA-216935
Comparing uuids instead of references that likely will be changed after the Cache has been repopulated.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-18 11:25:39 +01:00
Gabor Apati-Nagy
71cdd69f90 Merge pull request #1127 from kc284/master
Improvements made while investigating CA-218953:
2016-08-18 11:11:11 +01:00
Konstantina Chremmou
73a549a4d0 Improvements made while investigating CA-218953:
- when the cd drive or the tools iso cannot be found, the action should fail.
- if the tools SR is broken, do not show the error on a pop-up because the UX is
bad when installation is attempted on multiple VMS.
- added one more entry to the list of possible tools iso names.
- small performance improvement.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-17 22:35:01 +01:00
Callum McIntyre
e664a2e3da Merge branch 'CAR-2197' of https://github.com/xenserver/xenadmin into CP-18013 2016-08-17 10:51:54 +01:00
Callum McIntyre
2d089fa9e9 CP-18013: [XenCenter] Update host/pool updates pane
Generalising to also support pools. New CheckHostPatchesRequiringReboot method with the same behaviour as old method (return list of KeyValue warning messages). Pool updates on Ely use the union of messages from this method instead of the old one. Also localised the "{hotfix} on {server}" string per todo (hence resx changes).

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-17 10:45:11 +01:00
Callum McIntyre
dffd7507cc CP-18013: [XenCenter] Update host updates pane
For servers running Ely or greater we now produce messages for patching requiring reboot using the host.patches_requiring_reboot field. The Pool_patch objects resolved are sufficient to produce the same messages. Note that some patches produce a message in the old API but not the new, this is intentional. Still to do: update pool updates in the same way,

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-17 09:29:39 +01:00
Gabor Apati-Nagy
684b03317d Merge pull request #1120 from MihaelaStoica/CA-180127
CA-180127: Unable to unset VM home server if all shared SRs are full
2016-08-16 16:22:16 +01:00
Gabor Apati-Nagy
a069e177c3 Merge pull request #1118 from MihaelaStoica/CA-147142
CA-147142: ReadOnly user should not be allowed to delete crash dump f…
2016-08-16 16:16:56 +01:00
Gabor Apati-Nagy
3fc9c3edb6 Merge pull request #1111 from MihaelaStoica/CA-210549
CA-210551: Non-modal action progress bar on the Pre-Checks page of th…
2016-08-16 16:08:54 +01:00
Mihaela Stoica
a3ad025bc6 Merge pull request #1117 from mcintyre94/CA-218304
CA-218304: Text cut off in Properties dialog, Alerts tab
2016-08-16 11:03:48 +01:00
Callum McIntyre
e2215c71f5 CA-218304: Modify tab stops in alert properties tab
Now behaves as expected - alert interval (top control) has lowest tab stop, all other groups incremented by 1.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-16 10:44:37 +01:00
Mihaela Stoica
4bc3cca91c Merge pull request #1122 from GaborApatiNagy/master_CA-150198
CA-150198: EN: Missing hotkey for “Properties” after right clicking virtual disk
2016-08-16 10:40:55 +01:00
Mihaela Stoica
7c4a4fa219 Merge pull request #1121 from mcintyre94/CA-218241
CA-218241: Cancel connect right click menu item does not seem to be doing anything
2016-08-16 09:44:51 +01:00
Callum McIntyre
4559e162b7 CA-218304: Text cut off in Properties dialog, Alerts tab
Instead of adding a second table layout panel for the rubric label, I have extended the original table to include two new rows at the top - one for the label rubric, and one for the repeat interval controls (previously not in the table).

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-16 08:49:56 +01:00
Mihaela Stoica
8bdcbc5208 Merge pull request #1119 from mcintyre94/CA-217821
CA-217821: Specified home server in cross pool migration should behave as home server
2016-08-15 19:38:00 +01:00
Gabor Apati-Nagy
7d8d0ad837 CA-174979: Confusing right-click add to pool menu (if you accept the defaults)
Changed "New Pool" to "Unnamed Pool"

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-15 19:10:28 +01:00
Gabor Apati-Nagy
c7482b8c93 CA-150816: fix: G11n:I18n: Hardcode issue "Set VM other_config" on Authentication dialog.
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-15 17:43:20 +01:00
Gabor Apati-Nagy
0cb878d577 CA-150198: EN: Missing hotkey for “Properties” after right clicking virtual disk.
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-15 17:32:53 +01:00
Callum McIntyre
a41c76a0ba CA-217821: Remove unused TARGET_SERVER_MENU_ITEM key from Japanese+Chinese resources
Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-15 16:38:48 +01:00
Callum McIntyre
05efba8b9f CA-217821: Rename command back to CrossPoolMigrateToHomeCommand 2016-08-15 16:13:35 +01:00
Callum McIntyre
8b035b3af5 CA-218241: Cancel connect right click menu item does not seem to be doing anything
The CancelHostConnectionCommand executes by using a DisconnectCommand, so the fix here is to allow that command to execute on connections in progress as well as those that are connected.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-15 15:25:14 +01:00
Mihaela Stoica
67be366858 CA-180127: Unable to unset VM home server if all shared SRs are full
By passing null as the srHost parameter to the affinity picker, the "no home server" radio button remains enabled, even when no shared SRs are available, allowing users to unset the home server of a VM

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-15 15:15:00 +01:00
Mihaela Stoica
b35564cb85 CA-147142: ReadOnly user should not be allowed to delete crash dump files
- Made the action PureAsyncAction, so that it automatically checks if the current user can perform all the necessary api calls

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-15 14:27:43 +01:00
Callum McIntyre
3a5444ceb2 CA-217821: Specified home server in cross pool migration should behave as home server
Mostly just terminology changes from home server to target server in the CPM wizard. Changes in shared component SelectMultipleVMDestinationPage (shared with ImportWizard) to allow CPM wizard to rename the Home Server column (as it can the VM/template one - using the same pattern).

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-15 14:22:18 +01:00
Callum McIntyre
0cb567128b CA-218304: Text cut off in Properties dialog, Alerts tab
This is resolved by moving the label into a TableLayoutPanel, docked to the top and with auto-grow on.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-15 10:45:53 +01:00
Gabor Apati-Nagy
c90582a72e Merge pull request #1116 from GaborApatiNagy/master_livepatch
CP-18012: Fixed the Jenkins build, regenerated resources
2016-08-12 18:31:27 +01:00
Gabor Apati-Nagy
866b2f0e0d Merge pull request #1115 from GaborApatiNagy/master_livepatch
CP-18012: Fixed the Jenkins build
2016-08-12 18:30:55 +01:00
Gabor Apati-Nagy
b835090338 CP-18012: Fixed the Jenkins build, regenerated resources
Fixed test:
1) Test Failure : XenAdminTests.UnitTests.MiscTests.NamesAndMessagesTests.XapiFriendlyNameStaticMethodsReturnStrings
     Null value returned for get_SR_BACKEND_FAILURE_457
  Expected: not null
  But was:  null

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-12 18:26:30 +01:00
Gabor Apati-Nagy
8a10351c5d Merge pull request #1113 from xenserver/revert-1110-CP-18011
Revert "Cp 18011: [XenCenter] Add live patching checkbox"
2016-08-12 17:20:38 +01:00
Gabor Apati-Nagy
9dd3a41857 Revert "Cp 18011: [XenCenter] Add live patching checkbox" 2016-08-12 17:19:34 +01:00
Mihaela Stoica
aeeb1260e7 Merge pull request #1110 from mcintyre94/CP-18011
Cp 18011: [XenCenter] Add live patching checkbox
2016-08-12 17:17:37 +01:00