Commit Graph

5706 Commits

Author SHA1 Message Date
Konstantina Chremmou
374078fbec Fixed a bunch of small issues on the password handling dialogs.
- CA-92787: Added tip on how to reset a forgotten password on the LoadSessionDialog.
- The LoadSessionDialog was launching help twice.
- The error message on the SetPasswordDialog was truncated after the first time
it appeared.
- The checks on the ChangeMasterPasswordDialog were out of order.
- Minor layout corrections and code compacting on all dialogs.
- Moved LoadSessionDialog to the same folder as the other RestoreSession dialogs.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-19 09:30:13 +01:00
Konstantina Chremmou
faa662c9ec New user and group icons.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-19 09:30:13 +01:00
Konstantina Chremmou
bf6f06457e Added travis file so as to run developer checks on PRs.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-15 14:31:06 +01:00
Konstantina Chremmou
e0b9a68b40 Replaced check-roaming.sh tool with an Nunit test and expanded it to include more assemblies.
Corrected the scope of two OvfApi settings as a result of the test run.
Also, sync-ed settings and app.config for XenOvfApi and XenOvfapiTransport.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-15 14:31:06 +01:00
Konstantina Chremmou
32a3ad0c80 Removed check for dead files as it's slowing down the build without being particularly useful.
EC2 files are long gone. The script was only checking one project in the solution,
but on occasion having temporarily dead files may be needed. In any case, dead
files can be found using the IDE.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-15 14:31:06 +01:00
Konstantina Chremmou
95af694fd7 CA-187654: Focus on the password box when authorisation fails to allow easier edit.
Also, improved icon, and renamed event handler to match button name.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-15 12:08:03 +01:00
Konstantina Chremmou
ff0cee88ac CA-293375: "Remove Server" main menu item should not be enabled for the pool master.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-15 11:33:01 +01:00
Konstantina Chremmou
adab54a9c5 CA-293375: Fixed inconsistencies in the items related to removing servers from a pool
- Add item "Remove From Pool" to the main Server menu; it should be enabled
if the selected servers are removable and disabled at all other times.
The item should be present in the server's right click menu only if it is enabled.
- Replaced the above item in the Pool menu with the dropdown "Remove Server"
where the user can select the server to remove from the list of removable
servers.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-15 11:33:01 +01:00
Konstantina Chremmou
8fedb2d6e0 Removed unnecessary constructors. The ones with the 'params' param cover for them.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-15 11:33:01 +01:00
Konstantina Chremmou
57b8d8f5cb Do not expose the Ovf project's settings to the other projects in the solution.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-14 11:07:16 +01:00
Konstantina Chremmou
0024bb9f09 Removed almost 500 lines of empty xml docs. Fixed enum docs and typos.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-14 11:07:16 +01:00
Konstantina Chremmou
536cb18837 CA-322526: Made the ImportOptions page sensitive to PBD changes in the cache. Improved combobox selection functionality.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-14 11:07:16 +01:00
Konstantina Chremmou
5314da7e29 Ensure the ArchiveIterator disposes of the compression stream. Removed unused constructors.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-13 10:18:15 +01:00
Konstantina Chremmou
e6da7045b6 Ensure we always dispose of the ArchiveIterator and ArchiveWriter after use.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-13 10:18:15 +01:00
Konstantina Chremmou
38fcc83874 Fixed labels; removed unnecessary control disablement.
The blurbs should be user-centric rather than developer-centric.
No need to disable the page controls in the absence of signature/manifest
since the whole page becomes disabled in that case.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-13 10:18:15 +01:00
Konstantina Chremmou
fd95530e4f CA-294511: Rewrote the OVA appliance abstraction class to include:
- Verification of appliance files in chunks to avoid StreamTooLong exception.
- Disposal of HashAlgorithms and X509Certificates after use.
- General code simplification.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-13 10:18:15 +01:00
Konstantina Chremmou
4cacc422b8 Small improvement to abstract class design.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-13 10:18:15 +01:00
Darren Matthews
4162b19cfc L10N : Translation and resx updates
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-08-09 12:14:59 +01:00
Konstantina Chremmou
909ac731dd CA-287873: Make undock/redock console work when pressing Shift+Alt+U.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-09 09:11:26 +01:00
Konstantina Chremmou
c0d6b409e2 CA-324782: Select the right memory SR otherwise the PVS cache appears as not configured.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-06 10:43:01 +01:00
Konstantina Chremmou
9cfc7ff8d3 Added friendly name and description for the bug tool capability nvidia-logs.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-06 10:43:01 +01:00
Konstantina Chremmou
366267a975 Fixed checked state display issue on ShowToolbarMenuItem.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-06 10:43:01 +01:00
Konstantina Chremmou
dd94ebaf3f Duplicate key. Use "Delete" instead of "Delete VM" to match menus for other objects.
Made Debug Assertion more detailed to aid us pick unique hotkeys.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-25 13:09:22 +01:00
Konstantina Chremmou
655b8eedf7 Fixed truncation issue introduced by the fix to CA-311165.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-25 13:09:22 +01:00
Mihaela Stoica
76c806c0b3 CA-322790: Fix unhandled exception when the host cannot be reached to execute an API call.
In the CrossPoolMigrateCanMigrateFilter a WebException can be raised if the host cannot be reached to execute the API call that asserts is the VM can be migrated there. With these changes, we catch any exception (not just Failure) and mark the VM as not migratable (because we couldn't assert if it can be migrated to that host).

Also fixed other places where the same error might occur.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-07-24 09:46:00 +01:00
Konstantina Chremmou
30226c590d CA-116060: Stop saving the expanded state of the New Search panel with the other Search metadata.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-23 14:00:38 +01:00
Konstantina Chremmou
e0f42a5205 CA-311165: Modified Display Options
- Removed option to show host only vs pool properties on the Search Tab
when selecting a host within a pool. It is out of place and confusing
because the items under the host don't follow suit. The same result can
be achieved using the filters on the Search Tab.
- Added option to disable remembering the last selected Tab per object
as it can be annoying when trying to compare data on the same Tab for
different objects.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-23 14:00:38 +01:00
Darren Matthews
8c59390de0 L10N : CA-207272 truncation issue fix
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-07-23 11:27:21 +01:00
Darren Matthews
8b698c0bfc L10N : Translation updates
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-07-23 11:27:21 +01:00
Konstantina Chremmou
8f2794b89d Prevent crash and improve behaviour when the user tries to configure/disable HA in a pool that has lost the HA statefile.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-23 10:28:01 +01:00
Konstantina Chremmou
dd81a5d14c CA-280117: Show the user the VDI uuid instead of the VDI opaque_ref when enabling HA throws VDI_NOT_AVAILABLE error.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-23 10:28:01 +01:00
Mihaela Stoica
c137b4a6ea CA-317752: Take live-patching qualification into consideration in the Install Update pre-checks
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-07-22 17:49:18 +01:00
Konstantina Chremmou
0e57e871b9 Removed unnecessary instance class SrPickerItemFactory.
Removed comments that did not provide further info than the class name
they were documenting. Removed unused code. Launch progress dialog within
a using block.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-22 16:19:25 +01:00
Konstantina Chremmou
6e9ac153ca CA-323248: Allow VDI move to a local SR if the latter can be seen from the home hosts of the VMs the VDI is attached to.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-22 16:19:25 +01:00
Konstantina Chremmou
1c22696d70 Message normalisation.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-22 13:15:59 +01:00
Konstantina Chremmou
85654a4f36 CA-314720: Replaced "Still waiting" dialog popping up during RPU with a message displayed in the upgrade output.
Also, fixed issue where uploading a supp-pack resulted in a perpetually
pending action if the file had disappeared from the disk.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-22 13:15:59 +01:00
Mihaela Stoica
3d3a96fbe6 CA-323766: Show the upgrade version in the RPU wizard, if available
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-07-22 12:24:07 +01:00
Darren Matthews
bd846babb6 L10N: CA-169591 truncation issue fixed
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-07-18 14:49:51 +01:00
Darren Matthews
60b4282aba L10N : Resx resync and translation update
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-07-18 14:49:51 +01:00
Konstantina Chremmou
b533585a79 Renamed release. Updated bindings.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-18 09:38:26 +01:00
Konstantina Chremmou
a191635b5c CP-30453: Corrected the check for nunit test failures.
Also, removed echoing the test start and finish time as it is included
in the nunit3-console output.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-12 16:14:23 +01:00
Mihaela Stoica
79c9a7ecbc CA-320203: Fixed the update wizard failure when installing two cumula… (#2466)
CA-320203: Fixed the update wizard failure when installing two cumulative updates

The issue was that when installing 2 new versions in one go (e.g. two cumulative updates), the installation succeeds on master but it cannot continue on slaves, because it cannot find the first CU update anymore.
The fix is to refresh the update record before applying the update, with the record found in the cache. Also, if there is no update in the cache, try to re-introduce the update.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-07-12 14:43:48 +01:00
Konstantina Chremmou
43578c5f4a CP-14806: Removed outdated databases from the rebranding.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-12 12:09:09 +01:00
Konstantina Chremmou
d814d050b8 Enabled a subset of unit tests (exclude the rest temporarily from the project).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-11 16:34:59 +01:00
Konstantina Chremmou
4844bac1e8 CP-30451: Unit test restructuring and modifications for better use of the Nunit3 framework.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-11 16:34:59 +01:00
Konstantina Chremmou
bb369ed627 CP-14806: Removed outdated databases.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-11 16:34:59 +01:00
Konstantina Chremmou
454092350c CP-30453: Upgraded to NUnit3.
The tests will be ported gradually.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-11 16:34:59 +01:00
Konstantina Chremmou
866eae0edc Minor improvements on ImportWizard pages.
- Made storage selector blurb for XVA import a bit more informative.
- A simple checkbox for starting the new VMS on the finish page is adequate.
- Typos. Property modernisation.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-11 11:25:37 +01:00
Konstantina Chremmou
db02d206cb Duplicate hotkey. Layout simplification trying to leverage CA-209149.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-11 11:11:47 +01:00
Konstantina Chremmou
979f88a90c CA-322699: Do not use an intermediate MemoryStream when sanitising the files of a tar archive.
If the tar contains huge files, this causes memory spikes, even OutOfMemoryException.
Instead, copy the file from the input to the output stream in chunks.
For this purpose the sanitisation code was moved to XenCenterLib to avoid
exposing the tar internals to the UI project.
Also, made some minor improvements in error handling, clean up, and logging.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-11 09:19:47 +01:00