Kiu/xenadmin
1
0
Fork 0
mirror of https://github.com/xcp-ng/xenadmin.git synced 2024-12-30 07:40:13 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
5,416 Commits 12 Branches 48 Tags 186 MiB
977d2aa503
Commit Graph

5416 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Konstantina Chremmou
73e7b66fa4 Do not change the page top blurb depending on the process outcome. Improved error messages. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-08 16:15:55 +01:00
Konstantina Chremmou
2e2ae7c196 Separate displayed update information per pool. Minor layout corrections and removal of unused LinkLabel. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-08 13:42:06 +01:00
Mihaela Stoica
15edb13997
Merge pull request #2089 from kc284/REQ-672 
First batch of changes for CP-28281
 2018-06-08 11:32:26 +01:00
Ji Jiang
88224df214 CA-290316: Skip hotfix homogeneity precheck in mixed pool 
Because we couldn't control user's selected combination from
a mixed pool, and the version compatibility precheck exists already,
here just simply skip the precheck and issue a warning.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
 2018-06-08 11:17:41 +01:00
Konstantina Chremmou
11a9785dba Log the patch clean-up actions on the screen in case of a failure. Order the shown actions per pool. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-07 16:34:13 +01:00
Konstantina Chremmou
1b4a862fd0 Further corrections to the load/leave page workflow and object selection ensuring correct enablement of the Next button. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-07 12:27:57 +01:00
Konstantina Chremmou
20d74a64c9 Unregister handlers when leaving or cancelling the page and invoke on the current 
control instead of the main window (may cure CA-289721).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-07 12:27:57 +01:00
Konstantina Chremmou
b36993228c Moved index retrieval in Invoke and corrected index sanity check. Update the combobox 
and unregister item event in a try-finally block (may cure CA-289721); suspend-resume
layout when updating the datagridview.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-07 12:27:57 +01:00
Konstantina Chremmou
3f8feb4bdd Removed invocations where we are already on the UI thread. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-07 12:27:57 +01:00
Konstantina Chremmou
2e07781e6b Simplify the logic toggling the enabled state of the Next button depending on the selection. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-07 12:27:57 +01:00
Konstantina Chremmou
621fce4d70 Fixed regression whereby the vm-host mapping was lost when proceeding to the next page and returning to the destination selection page. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-07 12:27:57 +01:00
Konstantina Chremmou
355621f183 Simplified event signature. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-07 12:27:57 +01:00
Konstantina Chremmou
1d905fc18c Simplified logic when fetching the failure reason; capitalised constant names so they're more visible. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-07 12:27:57 +01:00
Konstantina Chremmou
2c3c4bf5ca Renamed methods so it's more obvious what they do. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-07 12:27:57 +01:00
Konstantina Chremmou
887428872a Logic corrections. Show the name of the patch being removed each time. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-07 12:12:17 +01:00
Konstantina Chremmou
57ab2ced2b CA-289335: If there is no other network available, pick the management network for the migration of VDIs. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-06 16:06:41 +01:00
Konstantina Chremmou
14aa3f3f5d CA-289335: Do not check the NetworkComboBoxItem can be selected unless it has been added to the ComboBox. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-06 16:06:41 +01:00
Konstantina Chremmou
c643351e6c CP-28281: Change the order in which the updates are applied to a pool, namely apply all updates on a host before continuing with the next host. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-05 22:26:16 +01:00
Konstantina Chremmou
723510b853 Removed class Updates.UpgradeSequence. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-05 11:50:34 +01:00
Alexander Schulz
a294c61bd0 Remove shortcut definition from MainWindow resx files, Shortcut is already defined in Commands\NewVMCommand.cs 
https://github.com/xenserver/xenadmin/pull/2078
 2018-06-05 11:15:18 +01:00
Alexander Schulz
c26de212da Use "Control+N" instead of "Ctrl+N" to be buildable on non-english operation systems 2018-06-05 11:15:18 +01:00
Jisheng Xing
7034973ae1 CA-287651: Precheck shows SR broken on both hosts but it is only broken on one 
Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
 2018-06-05 05:45:57 +01:00
Konstantina Chremmou
d4b7642ef7 Compacted null checks. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-04 15:18:29 +01:00
Konstantina Chremmou
d58131910b Corrected logic checking the host is up to date. Renamed method because the old name was not descriptive of the output. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-04 12:40:30 +01:00
Jisheng Xing
b85c6d9f60 CA-289618: Clear the created network after enabling SR-IOV failed 
Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
 2018-06-04 12:06:40 +01:00
Konstantina Chremmou
b0cdc74188 The code in the BackgroundWorker's ProgressChanged and RunWorkerCompleted event handlers does not need invoking as it's already on the UI thread. 
Also, some logic simplification.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-05-29 13:50:46 +01:00
Konstantina Chremmou
89621c2bb5 Unnecessary field. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-05-29 10:47:54 +01:00
Konstantina Chremmou
18f2ff0785 Typo. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-05-29 10:46:14 +01:00
Mihaela Stoica
c2b42fa107 CA-289335: Refactoring to avoid setting the SelectedItem twice 
- also avoids iterating through the combobox items again to determine which item to select

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-05-24 16:23:04 +01:00
Mihaela Stoica
54b134a2eb CA-289335: Show empty selection if the cluster network cannot be resolved 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-05-24 16:23:04 +01:00
Mihaela Stoica
a74ee3a793 CA-290064: Make the FibreChannelProbeAction an AsyncAction, because the PureAsyncAction throws an exception when collecting the API methods for RBAC checks. 
An exception is thrown by the ProcessXml function if the result is an empty string, which is the case when the action is run with the RbacCollectorProxy to collect the API calls

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-05-24 13:00:05 +01:00
Mihaela Stoica
5d0b760a96 CA-288751: Fix the RBAC checks for probe_ext 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-05-24 13:00:05 +01:00
Ji Jiang
9ddb253ec0 CP-26866: Add a specific warning when creating a bond on cluster network 
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
 2018-05-23 16:47:59 +01:00
serenc
29d82b1498 CP-28229: Update XenCenter to remove Cluster.network 2018-05-18 16:40:59 +01:00
Konstantina Chremmou
9a7fcde66e CA-289948: Do not show the upsell dialog if migration is not permitted due to licensing restrictions; launch the move VM dialog instead. 
Also, removed unused constructor.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-05-18 16:37:12 +01:00
Konstantina Chremmou
2f2a533b46 Fixed some column sizing issues on the VM, SR and physical storage pages as well as a regression in the selection mode of the last one. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-05-17 15:45:50 +01:00
Mihaela Stoica
01c8a7ed83 CA-289150: Use a local variable to avoid calculating DistinctHosts twice 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-05-17 14:33:31 +01:00
Mihaela Stoica
2dab045441 CA-289150: Use a lock object to ensure that the hosts and connections lists are safely accessed from separate threads 
This change fixes the crash with IndexOutOfRangeException in XenServerUpdateAlert

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-05-17 14:33:31 +01:00
Mihaela Stoica
5ad2aa302e CA-289959: Add null checks when resolving the updates which require reboot 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-05-17 14:24:51 +01:00
Mihaela Stoica
171284ff34 CP-28094: Rationalise device-config keys with SMAPIv1 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-05-16 17:18:12 +01:00
Konstantina Chremmou
c475861941 CA-248353: Refactoring to avoid referencing cells with hardcoded index numbers, 
which makes them undiscoverable and breaks if the columns are rearranged.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-05-15 13:17:04 +01:00
Konstantina Chremmou
81115674e7 Removed DataGridView grid because we normally don't use one. Renamed columns 
to make them more discoverable. Removed unused class.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-05-15 13:17:04 +01:00
Konstantina Chremmou
085b4d4f6e CA-248353: Do not use a hardcoded string or integer to reference DataGridView columns or ToolStripMenuItems. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-05-15 13:17:04 +01:00
Konstantina Chremmou
7cc1402099 CA-248353: Do not use a hardcoded string to find the status image column as 
the code will break if the column on the LicenceManager is renamed. Also, do
not create the new cell before the index checks pass.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-05-15 13:17:04 +01:00
Konstantina Chremmou
6a36bf37ff The designed class should be the first one in the file, otherwise VisualStudio's designer breaks. 
In this case, the CheckableDataGridViewRowEventArgs are very specialised and can be nested in the CheckableDataGridView.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-05-15 13:17:04 +01:00
Konstantina Chremmou
79684617eb CA-248353: Reference the column object directly instead of trying to retrieve it using a hardcoded string as a key. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-05-15 13:17:04 +01:00
Konstantina Chremmou
0d8f61fbb0 CA-289182: Corrections to sorting (clearer handling of null cases, non-XenObjects, logic path inconsistencies). 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-05-14 14:56:42 +01:00
Konstantina Chremmou
fd2ee1922a CA-286291: Missing copyright. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-05-14 13:37:40 +01:00
Mihaela Stoica
8992e55141 CA-286291: Add the additional menu items immediately after the first item, so we don't have to wait for the WLB recommendations to be 
retrieved.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-05-14 12:30:40 +01:00
Mihaela Stoica
ba8a612c01 CA-286291: Remove the ToolTip from the VMOperationTollStripManuSubItem, as the reason why the item is disabled is already included in the items's MenuText 
This change improves the performance of the drop-down menu considerably, as it avoids the server calls from the Command.ToolTipText

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-05-14 12:30:40 +01:00