Kiu/xenadmin
1
0
Fork 0
mirror of https://github.com/xcp-ng/xenadmin.git synced 2024-11-21 17:11:29 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
7,160 Commits 11 Branches 48 Tags 186 MiB
980788a0ab
Commit Graph

7160 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Danilo Del Busso
066a59a0b4
CP-43000: Add friendly name for trial edition 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-19 15:53:54 +01:00
Danilo Del Busso
3bf6a88f9c
CP-43000: Add Host extension methods to check if upselling messages are needed 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-19 15:53:52 +01:00
Konstantina Chremmou
c439f3de41
Merge pull request #3175 from xenserver/feature/merge 
Merge branch 'feature/merge' -> master
 2023-07-19 15:32:22 +01:00
Konstantina Chremmou
1d21ceef93 Bumped pipeline version to v4.8. 
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
 2023-07-19 15:32:06 +01:00
Danilo Del Busso
d3a811d566 CA-378758: Ensure all hosts in pool hit HOST_NOT_ENOUGH_FREE_MEMORY before preventing migration 
If pool any of the hosts in a pool hit the `HOST_NOT_ENOUGH_FREE_MEMORY` when calling `VM.assert_can_migrate`, XenCenter would prevent migration even if other hosts had enough memory to accommodate the VM.

Likely a result of the fact that other `VM.assert_can_migrate` failures are a consequence of pool-wide configurations. This is an exception.

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-19 13:42:15 +01:00
Konstantina Chremmou
aa6703cc5f Bumped branding to v4.17. 
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
 2023-07-19 12:29:33 +01:00
Konstantina Chremmou
693286425f Corrections following the merge from master. 
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
 2023-07-12 16:35:21 +01:00
Konstantina Chremmou
9950996db2
Merge pull request #3171 from xenserver/master 
Merge master into feature/merge
 2023-07-12 10:19:07 +01:00
Konstantina Chremmou
387d030a4f Updated SDK to v23.15.0. Updated code as this drop deprecates certain Session constructors. 
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
 2023-07-12 09:56:06 +01:00
Konstantina Chremmou
00246d7429 Disallow connection to havana servers. 
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
 2023-07-12 09:55:42 +01:00
Danilo Del Busso
60a5580d20
Dispose of timer when creating new port polling Timer 
This avoids having too many timers running at the same time.

One could for instance update the `EnableRDPPolling` property from the `Options` dialog and start several concurrent `Timer`s

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-12 09:22:00 +01:00
Konstantina Chremmou
00668e8d53
Merge pull request #3166 from kc284/wlb_images 
CP-43770: Removed images from the WLB credentials dialog (plus some refactoring and layout tweaks)
 2023-07-11 11:36:09 +01:00
Danilo Del Busso
84e294b4b7
Tidy up XSVNCScreen: fix whitespace 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:14 +01:00
Danilo Del Busso
559843f549
Tidy up XSVNCScreen: use explicit modifiers 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:13 +01:00
Danilo Del Busso
9618c11ba5
Tidy up XSVNCScreen: fix typos 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:13 +01:00
Danilo Del Busso
baea368447
Tidy up XSVNCScreen: fix missing uses of null propagation 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:12 +01:00
Danilo Del Busso
85414de2c2
Tidy up XSVNCScreen: Fix naming in file 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:11 +01:00
Danilo Del Busso
133cd456c6
Tidy up XSVNCScreen: use null propagation and conditional access 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:10 +01:00
Danilo Del Busso
4cfb129f6d
Tidy up XSVNCScreen: fix typo 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:10 +01:00
Danilo Del Busso
d28ec66a2b
Tidy up XSVNCScreen: remove cast with pattern variable 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:10 +01:00
Danilo Del Busso
56274d7298
Tidy up XSVNCScreen: merge conditional expression 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:09 +01:00
Danilo Del Busso
a55cc8ea7a
Tidy up XSVNCScreen: remove redundant type arguments 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:09 +01:00
Danilo Del Busso
d0e63e7bd7
Tidy up XSVNCScreen: remove redundant explicit delegate creation 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:08 +01:00
Danilo Del Busso
a79eaa0bcc
Tidy up XSVNCScreen: use var when possible 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:08 +01:00
Danilo Del Busso
67dd31fc44
Tidy up XSVNCScreen: remove redundant base() call 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:07 +01:00
Danilo Del Busso
2287672e44
Tidy up XSVNCScreen: use expression-bodied properties 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:07 +01:00
Danilo Del Busso
bcb3fdc00a
Tidy up XSVNCScreen: use built-in type references 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:06 +01:00
Danilo Del Busso
5ba0a42bd5
Tidy up XSVNCScreen: remove redundant initializers 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:06 +01:00
Danilo Del Busso
53fba195a7
Tidy up XSVNCScreen: remove this when unnecessary 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:06 +01:00
Danilo Del Busso
b8eb2b5549
CA-379640: Do not reset remote consoles if they're still attempting connection to a VM 
This prevents `AccessViolationException`s being called, as they're hit when two instances of `AxMSTSCLib.AxMsRdpClient9` call `Connect` on the same IP + Port combination, which results in the same memory being accessed in unmanaged code.

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:05 +01:00
Danilo Del Busso
9ea0a53447
Catch HRESULT E_FAIL exceptions for IRDPClient.Connect calls 
The `Connect` method returns `E_FAIL` if it is called while the control is already connected or in the connecting state. This can be hit when a lot of connections are being opened at the same time, and it's there as a failsafe.

Also adds `IsAttemptingConnection` as a new field

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:47:02 +01:00
Danilo Del Busso
7067629b29
Add IRdpClient to abstract some common functionality of RDP clients 
The reason this wasn't added to the `AxMsRdpClientX` classes is that I thought it best to not touch `AxMSTSCLib` classes as they are likely generated.

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:47:01 +01:00
Konstantina Chremmou
33d0b725ff
Merge pull request #3160 from danilo-delbusso/dev/vcpus-warnings 
Miscellaneous fixes to vCPUs warnings
 2023-07-10 15:11:56 +01:00
Konstantina Chremmou
d3004bfac3
Merge pull request #3136 from danilo-delbusso/dev/start-twice-CA-376480 
CA-376480, CA-374325, & CA-378489: Prevent two instances from starting after running installer; Add desktop shortcut option; Remove existing shortcuts
 2023-07-10 15:07:34 +01:00
Danilo Del Busso
1d8391c9f9
CA-378489: Remove all remnants of previous installation when upgrading with Wix installer 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-10 13:48:09 +01:00
Danilo Del Busso
715f873329
CA-374325: Move shortcut to last page 
Also update spacing of controls within the `CustomizeDlg` to take more advantage of the available space

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-10 13:48:09 +01:00
Danilo Del Busso
a08ed18770
Improve wording for IMPORT_WIZARD_CPUS_COUNT_MISMATCH_POOL warning 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-10 13:44:09 +01:00
Konstantina Chremmou
b7eff2d790
Merge pull request #3167 from danilo-delbusso/bug/CA-379402_eua 
CA-379402: Fix EUA check & add hotfix check to `HostMemoryPostUpgradeCheck`
 2023-07-04 15:47:29 +01:00
Danilo Del Busso
d2424eacf3
Ensure PrepareToUpgradeCheck is run first in the manual upgrade block 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-04 08:58:31 +01:00
Danilo Del Busso
4e59f26cad
Ensure CanRun is called before adding EUA check to precheks list 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-04 08:57:45 +01:00
Danilo Del Busso
eba3305587
Prevent HostMemoryPostUpgradeCheck from running if required hotfixes are missing 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-03 16:03:17 +01:00
Danilo Del Busso
6eb09cbac4
CA-379402: Do not return Problems if the EUA check is run for upgrades to 8.2 CU1 or below 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-03 16:03:16 +01:00
Danilo Del Busso
dc747fec05
Update wording of vCPUs count warnings in ImportWizard 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-03 15:46:02 +01:00
Danilo Del Busso
b43387774e
Remove backing field for AllSelectedTargets 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-03 15:43:49 +01:00
Konstantina Chremmou
d4374285a9 CA-377017: Improved message shown when attempting to export VMs with vTPMs as OVF/OVA packages. 
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
 2023-07-03 11:38:58 +01:00
Konstantina Chremmou
57c2cb9fb5 Refactoring to avoid repetition of calculations. 
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
 2023-06-29 18:10:29 +01:00
Konstantina Chremmou
cfd0216bf4 CP-43770: Removed images from the WLB credentials dialog. Minor text and layout tweaks: 
- The checkbox should be above the credential textboxes.
- Some controls were not aligned correctly.
- Place the controls in tableLayout panels.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
 2023-06-29 18:10:29 +01:00
Danilo Del Busso
1e78d6964b CP-41573: Do not attempt problem reversion if SolutionAction.Connection is null 
Applies to newly added EUA presence problem

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-06-26 16:26:22 +01:00
Danilo Del Busso
594db56b6a CP-41573: Refresh pre-checks once EuaNotAcceptedProblem is fixed 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-06-26 10:11:19 +01:00
Danilo Del Busso
06ab09eabb CP-41573: Apply code review suggestions 
- Ensure `UpgradeRequiresEUA` runs for Yangtze or greater hosts
- Group non-manual checks in same if block
- Remove unused field in `EuaNotFoundProblem`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-06-26 10:11:19 +01:00