Commit Graph

63 Commits

Author SHA1 Message Date
Konstantina Chremmou
1df1083a2d Use more generic names for client version updates, checks, alerts etc.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-06-09 15:52:10 +01:00
Konstantina Chremmou
67d1ddd1d1 Merge remote-tracking branch 'upstream/master' into feature/hyperman
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	Branding/Branding.resx
#	Jenkinsfile
#	XenAdmin/Alerts/Types/GuiOldAlert.cs
#	XenAdmin/Alerts/Types/LicenseAlert.cs
#	XenAdmin/Commands/RestartToolstackCommand.cs
#	XenAdmin/Diagnostics/Problems/HostProblem/HostNotSafeToUpgradeWarning.cs
#	XenAdmin/Dialogs/AllowUpdatesDialog.cs
#	XenAdmin/Dialogs/OptionsPages/ConfirmationOptionsPage.cs
#	XenAdmin/Dialogs/RepairSRDialog.cs
#	XenAdmin/Dialogs/UpsellDialog.cs
#	XenAdmin/Plugins/UI/TabPageCredentialsDialog.cs
#	XenAdmin/Program.cs
#	XenAdmin/Wizards/ConversionWizard/ConversionNetworkPage.cs
#	XenAdmin/Wizards/CrossPoolMigrateWizard/CrossPoolMigrateDestinationPage.cs
#	XenAdmin/Wizards/NewSRWizard_Pages/SrWizardType.cs
#	XenAdmin/Wizards/PatchingWizard/PatchingWizard_FirstPage.cs
#	XenCenterLib/XSVersionAttribute.cs
#	XenModel/BrandManager.cs
#	XenModel/Messages.Designer.cs
#	XenModel/Messages.resx
2021-05-25 15:51:42 +01:00
Joey
a56a383ec0
CP-35687: Detach update mechanism from update wizard (#2812)
* CP-35687: Detach update mechanism from update wizard
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>

* CP-35687 part 2: Removed updates mechanism.
* Corrections as per code review.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-05-21 15:13:45 +01:00
Konstantina Chremmou
a0e2967792 CP-31105: Replaced the hardcoded name patterns in the resource files with format placeholders.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-03-31 11:50:32 +01:00
Mihaela Stoica
c6710b7ffd CP-35471: Refactor HostNotSafeToUpgrade classes to avoid code repetition.
Also:
- added count check when generating the prechecks
- message correction

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2021-03-11 09:30:52 +00:00
Mihaela Stoica
9f6ce35a04 CP-35471: Change the SafeToUpgrade check to show a problem when upgrading to the next version
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2021-03-11 09:30:52 +00:00
Joey
5a29a8fd9b
CP-35838: Add health check precheck into RPU wizard (#2778)
* CP-35838: Add health check precheck into RPU wizard
* CP-35838: Add disable Health Check in RPU precheck warning

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2021-03-02 09:53:21 +00:00
Konstantina Chremmou
73a7903ddf Move deprecated feature checks closer to the top of the list.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-02 23:39:42 +01:00
Konstantina Chremmou
a8fc37b22b Merge remote-tracking branch 'upstream/master' into feature/REQ-811
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Diagnostics/Checks/Check.cs
#	XenAdmin/Diagnostics/Problems/PoolProblem/PoolHasPVGuestWarningUrl.cs
#	XenAdmin/Diagnostics/Problems/Problem.cs
#	XenAdmin/Diagnostics/Problems/WarningWithMoreInfo.cs
#	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
#	XenAdmin/Wizards/RollingUpgradeWizard/RollingUpgradeWizardPrecheckPage.cs
#	XenAdmin/XenAdmin.csproj
#	XenModel/Messages.Designer.cs
#	XenModel/Messages.resx
2020-04-02 23:29:54 +01:00
Konstantina Chremmou
d5035a010d Run LegacySsl , PowerOn mode, and PV Guest checks only if strictly necessary.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-02 10:55:37 +01:00
Konstantina Chremmou
00e015f2d0 Run vSwitch Controller and PV Guest checks only if strictly necessary.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-01 15:31:36 +01:00
Konstantina Chremmou
974ece8878 CA-337287: Skip legacy protocol and power-on iLO checks with a warning if the RPU hotfix is missing.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-03-30 10:48:32 +01:00
Konstantina Chremmou
3a35a96530 CP-33294: Remove iLO power on option from XenCenter
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-03-30 10:48:32 +01:00
Konstantina Chremmou
888a0555ab CA-337287: Skip vSwitch controller and PV guest checks with a warning if the RPU hotfix is missing.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-03-27 16:47:25 +00:00
Konstantina Chremmou
d3c5769a70 CP-32844: Check and warn if DVSC is configured when updating or upgrading a pool.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-03-02 17:46:29 +00:00
Konstantina Chremmou
7aeb17272b CP-32844: Check and warn if legacy SSL mode is enabled when updating or upgrading a pool.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-02-27 09:29:40 +00:00
Konstantina Chremmou
fc1cbf636e Simplified signature of connection events.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-12-06 11:17:46 +00:00
Konstantina Chremmou
fb2edf99b8 Do not initialise a logger if a class does not use it.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:44 +00:00
Xueqing Zhang
4dacede64b CP-32033 Add PV guests precheck in Xencenter
Signed-off-by: Xueqing Zhang <Xueqing.Zhang@citrix.com>
2019-10-18 09:56:21 +01:00
Mihaela Stoica
d2f62111f7 CA-309753: If the user decides not to proceed with cancelling the wizard, then the wizard shouln't do the cleanup actions
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-02-06 15:13:32 +00:00
Konstantina Chremmou
eef3320eca Removed code applicable to servers earlier than dundee since connection to them is now blocked.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-02-06 09:25:38 +00:00
Konstantina Chremmou
7836717a56 CA-308212: The prepare_host_upgrade plugin should be called on each
of the hosts to be upgraded and not only on the first one in the list.
For this purpose, the test has been moved to the prechecks, and the
failures are now shown as a non-fixable problem.
Further, specification of the network location of the installer files
has moved closer to the upgrade mode selection.
Also, moved the hotfix and upgrade related checks immediately after the
host liveness check.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-31 15:04:03 +00:00
Mihaela Stoica
6d44fd0350 CP-30335 - Part 2: Add a new precheck + Part 3: Enhance the error message displayed in case of migration failure during the RPU (#2371)
* CP-30335: Fix RPU wizard tests

* CP-30335: Add abstract class WarningWithMoreInfo and use it for two of the existing Warnings

* CP-30335: Add a new precheck which produces a warning if the Dom0 memory after the upgrade will be increased.

- if the Dom0 memory after the upgrade is known, then a warning is shown if this is higher than the current memory, regardless of the version of the upgrade
- if the Dom0 memory after the upgrade is not known (e.g. because the rpu plugin does not have the function that returns this), then a warning is shown if upgrading from a pre-Naples version

* CP-30335: Add a more detailed error message if the host evacuation fails due to not enough memory in the RPU and Patching wizards

* CP-30335: Add branding variable for version 8.0

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-01-28 14:44:58 +00:00
Mihaela Stoica
e67e5eb644 CP-30335: Rearrange the RPU wizard pages
- Moved Install Location (RollingUpgradeWizard_SelectInstallMethod) page immediatelly after the Upgrade Mode page (and before the Prechecks page)
- Added a new page, called Extras, which contains the updates and supp pack installation options. These options have been moved here from the "Upgrade Mode" and "Ready To Upgrade" pages. This page is also inserted before the Prechecks
- There is no "Ready To Upgrade" page anymore. So the wizard pages are:
   - when automatic mode is selected: Before You Start, Select Pools, Upgrade Mode, Installer Location, Extras, Prechecks, Apply Upgrade.
   - when manual mode is selected: Before You Start, Select Pools, Upgrade Mode, Extras, Prechecks, Apply Upgrade.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-01-21 17:13:54 +00:00
Konstantina Chremmou
749518e94c CA-303195: Provide the user the option to reconsider wizard cancellation
(either when cancelling the wizard itself or exiting the application).
Implemented in the first instance for compiling the server status report.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-15 17:12:09 +00:00
Konstantina Chremmou
e8ff04d671 Removed HostMaintenanceModeCheck; simplified logic by having the HostLivenessCheck
verify, if required, whether the host is enabled.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-22 14:23:29 +01:00
Mihaela Stoica
9accb3c69f Merge branch 'master' into REQ-672
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

# Conflicts:
#	XenAdmin/Wizards/RollingUpgradeWizard/RollingUpgradeWizardPrecheckPage.cs
#	XenAdmin/XenAdmin.csproj
2018-07-13 13:14:36 +01:00
Mihaela Stoica
12dc85f830 CA-293687: Remove redundant check
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-11 12:59:52 +01:00
Mihaela Stoica
f59c6a4815 In the RPU wizard, run the HA and automated updates license checks on SelectedMasters, to ensure that they are run even if the master does not need to be upgraded or updated
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-11 12:59:52 +01:00
serencorbett1
63d09dd117 CP-28431: Block updates/upgrades from Kolkata if clustering enabled (#2124)
* CP-28431: Block updates and upgrades from Kolkata onwards if clustering enabled
* CP-28431: Rename files and change from Pool Check to [Host] Check
* CP-28431: Change description message

Signed-off-by: Seren Corbett <seren.corbett@citrix.com>
2018-07-09 10:59:09 +01:00
Konstantina Chremmou
0aa43018a4 Removed ManualModeSelected property in favour of the existing ManualUpgrade; moved the latter in the class using it.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-08 22:43:21 +01:00
Konstantina Chremmou
8851139a11 Reverted the AutomatedUpdatedLicenseCheck to derive from HostPostLivenessCheck or
the liveness warning is not issued if the pool is disconnected. HAOffCheck tidy up.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-08 22:43:21 +01:00
Mihaela Stoica
a511124b82 CA-293311: RPU wizard: Only check the maintenance mode on hosts that need to be upgraded (and check host liveness on the hosts where we will only apply updates)
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-06 16:03:28 +01:00
Mihaela Stoica
1ac88b7cec CA-293311: RPU wizard: In a partially upgraded pool, apply the hotfixes on the upgraded hosts before upgrading the remaining slaves
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-06 16:03:28 +01:00
Konstantina Chremmou
b08e91a470 Do not create a new background worker every time the checks are refreshed; queue
a new check on the existing one instead. Moved the background worker to the designer
of the class.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-04 12:09:37 +01:00
Konstantina Chremmou
c2ae0a6069 Placed the CFU availability and the automated updates licence checks under the same group as requested per code review.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-04 12:09:37 +01:00
Konstantina Chremmou
63e4ced7fe Run the CFU availability check together with the check for the automated updates licence.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-04 12:09:37 +01:00
Ji Jiang
6d070d3cfc CP-28425: Add automated updates license precheck in RPU wizard
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-06-22 17:20:11 +01:00
Ji Jiang
ccf6f97732 CP-28280: Add CFU availability precheck to RPU wizard comments fix
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-06-22 12:02:19 +01:00
Ji Jiang
9ae8340913 CP-28280: Add CFU availability precheck to RPU wizard
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-06-22 12:02:19 +01:00
Konstantina Chremmou
ee648135f6 Since it is easy to forget calling the base class method at the beginning of the
PageLoaded override in derived classes, enforce it by wrapping the page specific
code in a new virtual method, which the derived classes can override and PageLoaded
can call after its own logic.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-09 11:22:26 +00:00
Konstantina Chremmou
7a1b1a6dcc Since it is easy to forget calling the base class method at the end of the PageLeave
override in derived classes, enforce it by wrapping the page specific code in
a new virtual method, which the derived classes can override and PageLeave can
call before its own logic.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-09 11:22:26 +00:00
Konstantina Chremmou
de9b0c4d30 Revisited commit 3f2eed35a0 reverting Dictionary to
List in order to enforce the order of checks (the Dictionary is not guaranteed to
keep the order the items are added). Also, extra null check.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-06 14:17:16 +00:00
Konstantina Chremmou
3f2eed35a0 Refactoring: use a dictionary to hold the list of generated checks; simplified calculation of progress percentage.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-02 13:32:49 +00:00
Gabor Apati-Nagy
a8db7bfae9 Merge remote-tracking branch 'github_xenadmin/REQ-411' into master_REQ-411_merge
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

Conflicts:
	XenAdmin/Core/Updates.cs
	XenAdmin/TabPages/ManageUpdatesPage.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
	XenModel/Messages.Designer.cs
2017-09-29 11:56:46 +01:00
Konstantina Chremmou
ae22560ce8 Converted all extension get properties of the API classes to methods in order to
prevent them from being serialised alongside the API properties. This will also
be useful for moving the API bindings out of XenModel.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-03 03:35:30 +01:00
Mihaela Stoica
86d2acee7f Merge branch 'master' into REQ-411
Conflicts:
	CFUValidator/CFUValidator.cs
	CFUValidator/OutputDecorators/XenCenterUpdateDecorator.cs
	CFUValidator/OutputDecorators/XenServerUpdateDecorator.cs
	XenAdmin/TabPages/ManageUpdatesPage.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
	XenModel/Actions/Updates/XenCenterVersion.cs
	XenModel/Actions/Updates/XenServerVersion.cs
	XenModel/Messages.Designer.cs
	XenModel/Messages.resx
2017-08-23 16:32:39 +01:00
Mihaela Stoica
a31c31eb07 CA-242134: Remove licensing code targeting pre-Clearwater hosts
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-08 13:40:48 +01:00
Mihaela Stoica
68aa91bcaa CA-242134: Remove code targeting pre-Clearwater hosts and unnecessary ClearwaterOrGreater checks
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-05 15:35:25 +01:00
Mihaela Stoica
b65084fdc3 CP-21184: Add a check for the XenCenter version
- On the Updates tab: for new versions, check that the version of XenCenter is at least the latest. If not, give an additional option to download a newer XenCenter (for both updates and upgrades), and not offer "Download and Install" (for updates).
- In the Patching wizard: if the update is a new version, we force the user to first update their XenCenter to the new version
- In the RPU wizard: if the server version is not the latest and their XenCenter version is not the latest from updates.xml, we assume that they want to upgrade to the latest XenServer version and we force the user to first update their XenCenter to the latest version.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-03-22 10:59:32 +00:00