Commit Graph

747 Commits

Author SHA1 Message Date
Konstantina Chremmou
99572da0fb Corrections to the logging of Win32 exceptions. Minor refactoring.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:44 +00:00
Konstantina Chremmou
fad80c778b Avoid duplicate logging; compact multiple logging calls.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:44 +00:00
Konstantina Chremmou
fb2edf99b8 Do not initialise a logger if a class does not use it.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:44 +00:00
Konstantina Chremmou
4a8507fd86 CA-330394: Fixed issue whereby queued conversions had a start time in future.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-08 09:24:06 +00:00
Darren Matthews
01764e8972 L10N: Translation and Resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-10-21 13:53:59 +01:00
Konstantina Chremmou
ce958e5999 Corrected message and tab indices.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-14 09:24:36 +01:00
Konstantina Chremmou
f39a715816 CP-29522, CA-302477: Added TB option to the NumericUpdown of the NewDiskDialog and fixed validation on the VDISizeLocationPage.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-14 09:24:36 +01:00
Konstantina Chremmou
73eaed6af8 Fixed some issues around the validation of SrPicker selections.
- Fixed button enablement on the IntraPoolCopy page.
- Regression on the NewDiskDialog were selection was considered valid
even if the SR was disabled.The SrSelectionChanged and SelectedIndexChanged
were fired in the wrong order. To fix this the event SrSelectionChanged
is removed (in reality after the refactoring in 5b79b1dc94
it became obsolete).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-14 09:24:36 +01:00
Konstantina Chremmou
ec79720057 Do not pass the delegates showing messages as parameters to the actions, but rather have them handle action events.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-14 09:24:36 +01:00
Konstantina Chremmou
6f0a9cae6a CA-293784: updated plugins to use the XenServerPSModule as the snap-in has been retired.
- Check for the module existence when the process is created, not when
loading the plugin.
- Removed snapin max and min version as the specification documents them
as not implemented (CA-40580).
- Refactored Registry class to avoid code repetition and ensure that all
opened keys are closed.
- Added null checks and compacted the code parsing the plugin xml.
- Modernized properties.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-09 13:32:07 +01:00
Konstantina Chremmou
6bae7380a2 Property modernisation.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-09 13:32:07 +01:00
Konstantina Chremmou
e9d2da082d Prevent XenCenter from crashing if starting it by double-clicking a license file.
Also, fixed hotkeys and info message on the PasswordRequest dialog.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-07 18:00:32 +01:00
Konstantina Chremmou
73d457ec16 CA-328086: Prevent XenCenter from crashing when started from the cli without enough parameters for connecting to a server.
Also, compacted the code parsing command line parameters; removed class
and cli option MessageBoxTest as it adds to code complexity, plus that
the application is not meant to be used as testing infrastructure.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-07 18:00:32 +01:00
Mihaela Stoica
8b41a214b2
Merge pull request #2521 from xenserver/feature/REQ-756
Merge feature/REQ-756 into master
2019-09-27 13:18:21 +01:00
Darren Matthews
4a3fd35b51 L10N: Translation and Resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-09-25 15:17:19 +01:00
Konstantina Chremmou
5244c91658 Help refactoring.
- Removed DebugHelp. The user settings are normally not meant for debugging code.
- Moved HelpId logic from the main window to the tab pages.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-25 15:02:05 +01:00
Konstantina Chremmou
441734be82 CP-32140: Allow the user to select which XCM VPX to use when there are multiple XCM VPXs in the pool.
Also, corrected the RBAC permission check after stopping using the conversion plugin.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-25 13:25:26 +01:00
Konstantina Chremmou
ca72f25ebe Merge remote-tracking branch 'upstream/master' into feature/REQ-756
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/MainWindow.Designer.cs
#	XenAdmin/MainWindow.resx
#	XenAdmin/Properties/Resources.resx
2019-09-13 13:17:32 +01:00
Konstantina Chremmou
d5d32baa88 CA-326611: Improved connecting to the conversion VM.
- Poll for the appliance version because the service may take a while to
  start after an IP address is obtained.
- More flexible IP address look up.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-11 13:27:29 +01:00
Mihaela Stoica
57741506b4 CP-32070: Fix icon visibility + some improvements
- make the info messages icon+text instead of clickable icons. Some rearrangements of the controls on the dialog to accommodate them.
- in the "Assign To Snapshot Schedule" dropdown item, do not add a separator if there are no suitable policies listed.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-09-07 01:35:46 +01:00
Konstantina Chremmou
57689f7498 Some spelling corrections.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-04 13:37:33 +01:00
Mihaela Stoica
fca17a7ef5 Fix menu and dialog title inconsistencies for Snapshot schedules.
Also, use an info (instead of warning) icon on the message for Disk and memory snapshot

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-09-03 09:44:59 +01:00
Mihaela Stoica
224f398307 CP-32070: Hide the quiesce checkbox based on the version of the server
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-09-03 08:18:19 +01:00
Konstantina Chremmou
1a88c3713d Activate the conversion VPX and get the service IP address without employing the conversion plug-in.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-02 10:34:58 +01:00
Konstantina Chremmou
6066de3ae2 Corrections and enhancements. (#2496)
* Corrections and enhancements.

Fixed version compatibility check. Added context menu to the conversion list.

* Exclude templates and snapshots when looking for the conversion VM.

* Further corrections.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-28 14:57:36 +01:00
Konstantina Chremmou
aab9df208a Further improvements.
- Added textual description of the conversion status in the Details panel.
- Merged status detail and error message.
- Added initial sort order.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-27 07:52:38 +01:00
Konstantina Chremmou
fc07e2344e Missing comma. Wrong AutoScaleMode.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-22 11:48:14 +01:00
Konstantina Chremmou
9157735803 CP-30958: Initial implementation of the Conversion Manager in XenCenter. (#2481)
* CP-30958: Initial implementation of the Conversion Manager in XenCenter.
* Corrections following review and improvements.
* Further corrections and improvements.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-22 10:47:43 +01:00
Konstantina Chremmou
374078fbec Fixed a bunch of small issues on the password handling dialogs.
- CA-92787: Added tip on how to reset a forgotten password on the LoadSessionDialog.
- The LoadSessionDialog was launching help twice.
- The error message on the SetPasswordDialog was truncated after the first time
it appeared.
- The checks on the ChangeMasterPasswordDialog were out of order.
- Minor layout corrections and code compacting on all dialogs.
- Moved LoadSessionDialog to the same folder as the other RestoreSession dialogs.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-19 09:30:13 +01:00
Konstantina Chremmou
faa662c9ec New user and group icons.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-19 09:30:13 +01:00
Konstantina Chremmou
95af694fd7 CA-187654: Focus on the password box when authorisation fails to allow easier edit.
Also, improved icon, and renamed event handler to match button name.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-15 12:08:03 +01:00
Darren Matthews
4162b19cfc L10N : Translation and resx updates
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-08-09 12:14:59 +01:00
Konstantina Chremmou
655b8eedf7 Fixed truncation issue introduced by the fix to CA-311165.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-25 13:09:22 +01:00
Konstantina Chremmou
e0f42a5205 CA-311165: Modified Display Options
- Removed option to show host only vs pool properties on the Search Tab
when selecting a host within a pool. It is out of place and confusing
because the items under the host don't follow suit. The same result can
be achieved using the filters on the Search Tab.
- Added option to disable remembering the last selected Tab per object
as it can be annoying when trying to compare data on the same Tab for
different objects.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-23 14:00:38 +01:00
Konstantina Chremmou
8f2794b89d Prevent crash and improve behaviour when the user tries to configure/disable HA in a pool that has lost the HA statefile.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-23 10:28:01 +01:00
Konstantina Chremmou
0e57e871b9 Removed unnecessary instance class SrPickerItemFactory.
Removed comments that did not provide further info than the class name
they were documenting. Removed unused code. Launch progress dialog within
a using block.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-22 16:19:25 +01:00
Darren Matthews
a0aeeccee7 L10N : Translation and Resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-07-03 12:16:09 +01:00
Michael Z
a0e3649ba8 CA-320182: Error in adding vGPU in New VM wizard.
Signed-off-by: Michael Z <michael.zhao@citrix.com>
2019-06-10 14:49:31 +08:00
Michael Z
9a26478a16 CP-31400: Collection of improvements.
1. Update AddVGPUDialog title;
2. Add label above the combobox;
3. In the combobox, add text to the entry saying if multiple vGPU is supported;
4. When the dialog is open, focus on the combobox;
5. Preselect the vGPU type if there is only one option available;
6. Setup the Help ID for dialog;
7. Optimize vGPU adding and deleting in GpuAssignAction.

Signed-off-by: Michael Z <michael.zhao@citrix.com>
2019-06-10 14:49:31 +08:00
Michael Z
7f4ddc87e7 Change AutoScaleMode to Dpi.
Signed-off-by: Michael Z <michael.zhao@citrix.com>
2019-06-10 14:49:31 +08:00
Michael Z
b0e6e6216b Simplify more.
Signed-off-by: Michael Z <michael.zhao@citrix.com>
2019-06-10 14:49:31 +08:00
Michael Z
9c94e4ffd0 CP-30423: Update binding; Remove hardcode for device; Simplify combobox building calculation.
Signed-off-by: Michael Z <michael.zhao@citrix.com>
2019-06-10 14:49:31 +08:00
Michael
99af56ac94 REQ-720: Initial implementation of GPUEditPage and AddVgpuDialog. (#2422)
* CP-31063: Add support for multiple vGPU
(incomplete)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* CP-31063: Add support for multiple vGPU
(part 2)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* AddVGPUDialog

Signed-off-by: Michael Z <michael.zhao@citrix.com>

* Update bindings.

Signed-off-by: Michael Z <michael.zhao@citrix.com>

* REQ-720: Initial implementation of AddVgpuDialog.

Signed-off-by: Michael Z <michael.zhao@citrix.com>

* Improve the handling of buttons and combobox. Fix comments.

Signed-off-by: Michael Z <michael.zhao@citrix.com>

* Fix comments.

Signed-off-by: Michael Z <michael.zhao@citrix.com>
2019-06-10 14:49:31 +08:00
Andrew Kisliakov
d8341d5162 Correct spelling in Resolving Subjects Dialog
Signed-off-by: andrew.kisliakov@citrix.com
2019-04-26 12:13:06 +01:00
Darren Matthews
1100fb5199 L10N : Translation and resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-04-25 16:29:56 +01:00
Konstantina Chremmou
4ce9878b45 Refactored the VIFDialog to fix various problems: (#2398)
* Refactored the VIFDialog to fix various problems:
- Launch the dialog in using blocks.
- Event GotFocus is not meant to be handled directly in the code.
- Populate the dialog in the OnLoad override instead of the constructor
  as this causes problems at design time.
- Popping up an error message for duplicate MAC on combobox item
  selection or textbox text change is not optimal UX. Perform this
  check once when closing the form. Additionally the parent form of the
  pop up should be the dialog, not the main window.
- The validation messages are not obvious to the user because they are
  hidden in the tooltip of a disabled button. Show them inline instead.
- There is no need to create commands for VIF creation/change; use
  the relevant actions instead.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* Corrections as per code review plus some more code tidy and refactoring.

- Added option to suppress Create/DeleteVIFActions
- Use property RebootRequired to indicate hot-plugging is unavailable
  (assigning various objects of different types to the Result of the action
  during its run may cause confusion).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-04-25 08:23:09 +01:00
Konstantina Chremmou
c3f77a7113 Increased slightly the size of the dialog to avoid message truncation.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-04-24 15:03:20 +01:00
Darren Matthews
bc009bda2c L10N : Translation and resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-04-04 09:05:50 +01:00
RoryBG
80333d5aa4 CP-29310 & CP-30765: added support for the new xxHash-based VM imports and exports (#2411)
* added support for the new xxHash-based VM imports and exports
* added xxHash to the legal notices
* added Citrix copyright notice
* removed redundant code and made use of unused variable

Signed-off-by: Rory Bertuzzi-Glover <rory.bertuzzi-glover@citrix.com>
2019-03-26 16:06:25 +00:00
Darren Matthews
3e4108cef8 L10N : translation and resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-03-26 12:08:55 +00:00