Commit Graph

1777 Commits

Author SHA1 Message Date
Gabor Apati-Nagy
a007eec882 CA-216162: Batch updates: Wrong hover message on install update wizard when installing batch updates
Better messages on Select Server Page

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-19 09:12:30 +01:00
Gabor Apati-Nagy
bd26c7ac0e CA-215093: Batch updates: Update progress failed in a pool of mixed state hosts
Utilising default comparer on Host (This will makemaster first.)

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-05 15:37:52 +01:00
Gabor Apati-Nagy
f8a7d97890 CA-215093: Batch updates: Update progress failed in a pool of mixed state hosts
Where (in code removed by this commit) we iterated through the planActionsByHost dictionary, the hosts were iterated through in the order how the dictionary was initialized. Despite the actions were added in the right order, they then were screwed up, because the Cache.Hosts can have the hosts randomly while we want the master to be first.

To fix the bug, I changed the data structure from a dictionary to a list that has the actions exactly in the (good) order, the order they were added, eliminating the risk of the actions being retrieved in the wrong order.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-05 14:35:31 +01:00
Gabor Apati-Nagy
1fe300c16d CA-214063: Batch Updates: Name of the master is shown
Removed unused field

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-05 11:00:40 +01:00
Gabor Apati-Nagy
504f73778f CA-214063: Batch Updates: Name of the master is shown instead of the pool's name on Select Servers Page
Code review changes: Showing server icon for standalone hosts instead the pool icon

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-05 10:42:49 +01:00
Gabor Apati-Nagy
55ff3794cf CA-214063: Batch Updates: Name of the master is shown instead of the pool's name on Select Servers Page
Fixed display issue, now showing pools (and standalone hosts at the same level), not masters.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-01 17:41:49 +01:00
Gabor Apati-Nagy
66be637878 Merging (upstream) master into REQ-156 branch caused a build error:
Fixed build error that was caused by changed visibility of a method.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-29 17:56:51 +01:00
Gabor Apati-Nagy
994f5b4811 Merge remote-tracking branch 'github_xenadmin/master' into master_batch_new2 2016-06-29 16:52:13 +01:00
Gabor Apati-Nagy
9337663adb CP-17282: Unit tests to validate the Update Sequence logic
Unit tests to test GetUpdateSequence

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-29 12:49:53 +01:00
Mihaela Stoica
20cb3b4df1 Merge pull request #1042 from kc284/master
Latest API bindings, including definition of dundee-plus release...
2016-06-28 13:09:36 +01:00
Gabor Apati-Nagy
ee08e06f52 CA-214566: Upload succeeded, but Pool_patch hasn't been found
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-27 19:43:41 +01:00
Konstantina Chremmou
db79326ab1 Merge pull request #1025 from MihaelaStoica/CA-212147
CA-212147: RPU failing with insufficient license error when host lice…
2016-06-27 11:37:46 +01:00
Konstantina Chremmou
fd3393049c Code simplification: use Action delegate instead of EventHandler since the event is not sending any objects when triggered. 2016-06-27 10:20:23 +01:00
Mihaela Stoica
05059c6f52 CA-213414: Check feature-flag for ssl-legacy control switch
- For Dundee and newer hosts: the feature is restricted only if the "restrict_ssl_legacy_switch" flag exists and it is set to true
- For pre-Dundee hosts: the feature is restricted if the "restrict_ssl_legacy_switch" is absent or it is present and set to true

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-24 13:16:40 +01:00
Konstantina Chremmou
7e926f64a3 Rebooted myself. 2016-06-23 21:27:41 +01:00
Frezzle
7faf4fad1d Merge pull request #1032 from MihaelaStoica/CP-17161
CP-17161: Add 'using' statement around dialogs to ensure garbage collection
2016-06-23 15:52:32 +01:00
Mihaela Stoica
e87505e13d CP-17161: Add 'using' statement around dialogs to ensure garbage collection
- fix a dialog return check changed by accident

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-23 15:47:15 +01:00
Gabor Apati-Nagy
a8445d5ed8 Fixed warning as an error in build
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-23 10:27:16 +01:00
Gabor Apati-Nagy
587c2b5f5d CA-214077: Typo in Messages.resx
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-22 14:43:22 +01:00
Gabor Apati-Nagy
39109d30a4 CA-214062: REQ-156 Batch Updates: In progress actions shown as done
Fixed trivial bug where in progress actions had done shown as their statuses

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-22 11:07:12 +01:00
Mihaela Stoica
62870544c6 CP-17161: Add 'using' statement around dialogs to ensure garbage collection
- fix UpsellDialog usages

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-20 13:26:52 +01:00
Mihaela Stoica
da9e99b1cb CP-17161: Add 'using' statement around dialogs to ensure garbage collection
- fix ActionProgressDialog usages

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-20 13:17:42 +01:00
Mihaela Stoica
3f25c5868f CP-17161: Add 'using' statement around dialogs to ensure garbage collection
- fix all ThreeButtonDialog usages (and some other dialogs that I've came across)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-20 10:49:12 +01:00
Gabor Apati-Nagy
7a84b305ef CP-17699: Developer testing and improvements
for Batch Updating

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-17 14:15:59 +01:00
Mihaela Stoica
72cffa03e3 CA-212147: RPU failing with insufficient license error when host license removed
If the license does not allow VM migration, then cause the VMs to be shut down / suspended on the pre-checks page

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-14 13:38:12 +01:00
Frederico Mazzone
acf39533fe [CA-207306] Select box is not in line with pGPU bar on GPU tab of host
The last pGPU's row was stretching to the bottom, causing the lowest select box to fill its space and go down too much.
Changed the select boxs' dock style and margin.

Signed-off-by: Frederico Mazzone <fredericom@citrite.net>
2016-06-13 15:16:31 +01:00
Gabor Apati-Nagy
d04cccea85 Merge pull request #1017 from MihaelaStoica/CA-212905
CA-212905: Fix dialog size
2016-06-13 11:14:26 +01:00
Mihaela Stoica
996f84c97f CA-212905: Fix dialog size
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-10 11:25:38 +01:00
Gabor Apati-Nagy
546dbca6e1 CP-17444: Show minimal hotfixes on General tab
Changed heading from Recommended Updates to Required Updates following further discussions around wording

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-08 16:16:01 +01:00
Gabor Apati-Nagy
3e092f6d50 CP-17444: Show minimal hotfixes on General tab
Showing recommended* hotfixes for servers when the data is available (Check For Updates xml has been downloaded and has minimalPatches node in it for the given server version). *:Not applied ones from the minimal set.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-08 13:34:59 +01:00
Mihaela Stoica
a89ba4a91e Merge pull request #1013 from kc284/master
CA-212078: Do not check for CPU compatibility feature when the VM's r…
2016-06-08 12:59:26 +01:00
Mihaela Stoica
fcee4d8876 CA-77990: Report required actions for all VMs at once in the hotfix wizard / RPUW (#951)
* CA-77990: Report required actions for all VMs at once in the hotfix wizard / RPUW

* CA-77990: Resolve precheck problems in parallel in the Patching wizard

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* CA-77990: Resolve precheck problems in parallel in the Patching wizard

Changes following code review: Made the ParallelAction work across connections and removed CrossConnectionParallelAction

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* CA-77990: Modified ParallelAction to create queue on RunSubActions only, with the correct queue size

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-07 17:40:59 +01:00
Gabor Apati-Nagy
9ec512921b CP-15790: Prepare XenCenter for unit testing of Automatic Updates
Added support for defining custom update.xml location in Registry. This
can be either a local file or an URL. This will be beneficial when testing XenCenter.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-07 16:02:57 +01:00
Konstantina Chremmou
42f76bfa23 CA-212078: Correction as per code review to guard against the case when the VM is not resident on any host. 2016-06-07 12:27:54 +01:00
Konstantina Chremmou
5b19081d61 CA-212078: Do not check for CPU compatibility feature when the VM's resident host is not dundee or greater. 2016-06-07 09:30:37 +01:00
Mihaela Stoica
41f749e941 Merge pull request #1011 from fillzero/master
CA-150197: Improvement: No confirmation message before delete wlb scheduler
2016-06-06 13:38:29 +01:00
Liang Dai
2a874bbf40 CA-150197:EN: Improvement: No confirmation message to ask if certain to delete Scheduler
Signed-off-by: Liang Dai <liang.dai1@citrix.com>
2016-06-06 15:55:40 +08:00
Gabor Apati-Nagy
bd69aab6d2 CP-15719: UI: Implement error handling/reporting on Upload & Install page
Changes following code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-03 15:08:30 +01:00
Gabor Apati-Nagy
d449b153b3 Merge remote-tracking branch 'github_xenadmin/REQ-156' into master_batch_new2 2016-06-03 13:31:00 +01:00
Gabor Apati-Nagy
9ea99ec91a Merge remote-tracking branch 'github_xenadmin/master' into master_batch_new2 2016-06-03 13:28:48 +01:00
Liang Dai
fd5c7773f5 CA-150197:EN: Improvement: No confirmation message to ask if certain to delete Scheduler
Signed-off-by: Liang Dai <liang.dai1@citrix.com>
2016-06-03 14:19:59 +08:00
Gabor Apati-Nagy
725beacd4b CA-209290: "Virtualization state" label displayed twice on General Tab of newly created VM
Fixed duplicated headers.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-02 12:03:26 +01:00
Gabor Apati-Nagy
81ec2af86b Merge pull request #1003 from MihaelaStoica/CA-208829
CA-208829: Unexpected error if connection lost while health check dia…
2016-06-01 14:01:47 +01:00
Mihaela Stoica
82a274571b Merge pull request #1002 from GaborApatiNagy/master_CA-208707
CA-208707: [SCTX-2316] XenCenter Incorrect pop-up error message displayed if SSL secure channel cannot be created
2016-06-01 14:00:50 +01:00
Mihaela Stoica
2b993a4a9c Merge pull request #1007 from Frezzle/vdi-attach-exception
CA-211418: Exception in XenCenter while attaching vdi to a VM on a p…
2016-06-01 13:46:58 +01:00
Gabor Apati-Nagy
3561155d03 CP-15719: UI: Implement error handling/reporting on Upload & Install page
Some more on error handling, better displaying of errors

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-01 13:45:21 +01:00
Gabor Apati-Nagy
81a0bf20f9 CP-15714: UI: Change Select Servers Page
DownloadUpdatesXmlAction is called on PageLeave and not when the user selects Automatic Mode. This way we get the error message at the right time, also showing a progress dialog what makes the UX much better.
New tooltips for servers on the Select Server Page to to cover two more cases

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-05-31 19:00:35 +01:00
Frederico Mazzone
b21d87e6e6 [CA-211418] Exception in XenCenter while attaching vdi to a VM on a pool with an SR with 20,000 VDIs
Added back the event handler removal in BuildList function, as it can run more than once.

Signed-off-by: Frederico Mazzone <fredericom@citrite.net>
2016-05-31 11:23:31 +01:00
Frederico Mazzone
b401a11e76 [CA-211418] Exception in XenCenter while attaching vdi to a VM on a pool with an SR with 20,000 VDIs
All event handlers are now unsubscribed when AttachDiskDialog is closed, allowing its memory to be garbage collected.
Image for each VDI now references an existing image instead of creating a new object.

Signed-off-by: Frederico Mazzone <fredericom@citrite.net>
2016-05-25 16:37:31 +01:00
Mihaela Stoica
67e4e2113f CA-208829: Unexpected error if connection lost while health check dialog open
- Invoke on the main thread

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-05-23 14:11:03 +01:00