Commit Graph

503 Commits

Author SHA1 Message Date
Aaron Robson
cdc8de930f CA-301907: Improvements to the VMSS dialog, the VMSS frequency properties/wizard page and the VMSS finish wizard page (#2358)
- On the dialog show the next run time in both the client's and the server's local time zone.
- On the VMSS frequency page allow the user to pick the schedule in the client's
  local time zone and show then next run time in both the client's and the server's local time zone.
- Refactoring to fix workflow and class design, reduce amount of code and simplify logic.
- Various layout improvements.

Signed-off-by: Aaron Robson aaron.robson@citrix.com
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-03-15 14:10:42 +00:00
Konstantina Chremmou
2c884ea47f CA-311146: Copy the results of a linq query to a list to prevent
enumeration on modified collection (it also improves efficiency).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-02-26 11:18:53 +00:00
Konstantina Chremmou
eef3320eca Removed code applicable to servers earlier than dundee since connection to them is now blocked.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-02-06 09:25:38 +00:00
Konstantina Chremmou
749518e94c CA-303195: Provide the user the option to reconsider wizard cancellation
(either when cancelling the wizard itself or exiting the application).
Implemented in the first instance for compiling the server status report.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-15 17:12:09 +00:00
Konstantina Chremmou
7a0658c908 Reduced accessibility of controls to private. Moved some of the wizard cancelling
logic to the last wizard page.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-08 12:01:46 +00:00
Konstantina Chremmou
1789abb901 Reduced accessibility of controls to private. Minor refactoring. Typo. Removed
unnecessary event handler. Removed event that was fired but never subscribed to.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-08 12:01:46 +00:00
Konstantina Chremmou
033b7579ef Reduced accessibility of controls to private.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-08 12:01:46 +00:00
Konstantina Chremmou
e762dd04c7 Added readonly restrictions to DataGridViewRow cells.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-12-19 11:30:15 +00:00
Konstantina Chremmou
83732625ac The event handler meant to toggle the section's expanded state on mouse double
click was hooked to the wrong event.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-12-18 09:28:47 +00:00
Tim Liu
530257c1bb Fix the wrong layout
Signed-off-by: Tim Liu <tim.liu@citrix.com>
2018-12-11 14:52:20 +00:00
Darren Matthews
e6d2861b9b L10N : Translation updates and resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-12-03 14:48:42 +00:00
Konstantina Chremmou
16c88cc7b7 CA-302791: Rewrote the ChangeFolder dialog to fix usability issues.
- Corrected folder selection; reduced clicks required to select folders;
  improved text; added delete button.
- Moved FolderChangeDialogTreeView to the same folder as the other TreeViews;
- Added missing null checks to the MutliSelectTreeView and hid properties
  HScrollPos and VScrollPos from VS's designer (the former was initialised
  to zero every time the designer was updated, causing the treeview images
  to disappear).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-26 10:29:39 +00:00
Aaron Robson
4af1f68fd6 CA-270440: Copy VM full copy SR list isn't sorted naturally. Resolving not just for SrPickerItem but for the CustomTreeNode as used for other related classes.
Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-11-16 15:11:34 +00:00
Aaron Robson
7122615836 CA-271967: Dismiss button is flat after dismissing first of a list of events.
Handling OnMouseMove which fires more repeatedly than OnMouseEnter and OnMouseLeave with an early return to preserve CPU efficiency.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-11-16 11:14:21 +00:00
Konstantina Chremmou
2a575b01a5 Fixed issue whereby VS kept toggling between SubType Component and User Control
for some custom controls.

In the case of DoubleBufferedPanel I removed the Designer attributes from
the class definition.
In the case of the EnableableComboBoxEditingControl I moved it to a new
file because the other classes it was sharing the old file with did not
derive from Component.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-09 16:23:29 +00:00
Konstantina Chremmou
c1256c7734 Removed redundant code from GradientPanel and made it more object oriented;
also moved it out of the containing folder as it was its only resident.
Corrected the TitleBar fore colour as it was hard to read due to small contrast
with the bar's backround colour; normalised the code setting the other colours
so it's more unambiguous.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-09 16:20:52 +00:00
Darren Matthews
1a74fd440f L10N: Translation and resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-10-29 12:01:08 +00:00
Konstantina Chremmou
e9b598e3ba CA-209495: Layout correction on exit VM full screen tip.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-26 13:39:13 +03:00
Konstantina Chremmou
fdb9cb4743 CA-235084, CA-235085: Layout corrections on the host and VM memory panels.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-26 13:39:13 +03:00
Konstantina Chremmou
5b79b1dc94 Removed the label from the SrPicker because in half of the occasions it was
hidden and in all other cases it was set by the implementing control, i.e.
the label was not reusable, hence no reason to have it in the control and risk
layout issues. This means that the SrPicker does not need to be a control
encapsulating a CustomTreeVIew, but simply derive from the latter.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-24 12:49:31 +01:00
Konstantina Chremmou
f1d5abb7a5 Replaced duplicate events ItemSelectionNull and ItemSelectionNotNull with SrSelectionChanged.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-24 12:49:31 +01:00
Konstantina Chremmou
0fe584cdba Removed unnecessary method and replaced it with the field it returns.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-24 12:49:31 +01:00
Konstantina Chremmou
0eef02fc3b Removed redundant code.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-24 12:49:31 +01:00
Konstantina Chremmou
90589a30c9 Modified treeview and toolbar updates (#2264)
This PR is aimimg to (1) fix a regression introduced by #2223 whereby the toolbar items did not have the correct state on first launch; (2) improve performance by removing some updates which I believe are not needed.

* Removed some duplicate calls to RefershTreeView and UpdateToolbars because
they are called within the action's Complete event handler.
Also, normalise the way the treeview refresh is requested by the various actions the
commands are launching.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* Removed some explicit calls to refresh the treeview since this is done by
the connection result handlers.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* The toolbars and tabs should be updated every time the treeview is refreshed.

This should happen when the refresh event is handled rather than calling
UpdateToolbars explicitly after a treeview refresh is requested; also, it is
the treeview refreshes that should be throttled and not the toolbar and
tab updates (the throttling mechanism may need correction).
Also, removed unnecessary Invoke as we are already on the UI thread.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* Simplified UpdateManager.Update event declaration.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-16 16:24:54 +01:00
Aaron Robson
c1c368070a CA-299063: Prevent the Network Interfaces from disappearing when the VM is Locked due to a Storage Deveice being deleted.
Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-10-08 12:59:55 +01:00
Konstantina Chremmou
edea57ebf3 Simplified the logic updating the TabPages.
- The new logic of adding/removing tabs in the ChangeToNewTabs method also fixes
  tab-title flickering when we move from the Home node to a disconnected host.
- Renamed enum members Tab.Overview to Tab.Search and Tab.Settings to Tab.General
  since the pages mapped to them are TabPageSearch and TabPageGeneral respectively.
- Do not call directly UpdateToolbarsCore but rather UpdateToolbars since the
  latter takes account of the queued requested updates.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 11:10:44 +01:00
Konstantina Chremmou
b267007bdc Unused code removal; designer tidy up.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 11:10:44 +01:00
Konstantina Chremmou
194cd18ea3 Do not construct certain members if we are in Visual Studio's designer mode
because they crash the designer.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 11:10:44 +01:00
Konstantina Chremmou
fb40cb7a5a Hide properties which should not be serialised by the Visual Studio designer.
Minor refactoring.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 11:10:44 +01:00
Konstantina Chremmou
fa1cf41d5b No need to add nodes to the treeview in the constructor (which also means at design time);
PersistExpandNodes should not take for granted that the treeview always has nodes.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 11:10:44 +01:00
Mihaela Stoica
02075486ba
Merge pull request #2237 from xenserver/feature/REQ-488
Merge branch feature/REQ-488 into master
2018-10-05 09:41:21 +01:00
Aaron Robson
ca1113fbcc CA-287643: Replaced list view with data grid view to resolve column sizing issue and for consistency with the rest of the product. (#2226)
CA-287643: Replaced list view with data grid view to resolve column sizing issue and for consistency with the rest of the product.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-10-02 10:18:34 +01:00
Darren Matthews
2ce509efb3 L10N: Translation updates along with Interface resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-09-28 14:00:14 +01:00
Darren Matthews
47be1b0ecf L10N: CA-294292 resync Japanese and Chinese files. Truncation issues fixed.
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-09-27 12:43:04 +01:00
Konstantina Chremmou
2b83de433d CA-294292: Layout modifications to fix error message truncation issues.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-09-27 12:43:04 +01:00
Konstantina Chremmou
95cd300e61 CA-210190 Memory spinner: removed the label so it's easier to align
the spinner with the surrounding controls on a parent control/form.
Also, removed the icon from the spinner because in the
majority of implementations it was invisible and the extra space was just
complicating the alignment of the surrounding controls.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-09-26 11:06:24 +01:00
Konstantina Chremmou
1d7008beab
Merge pull request #2227 from xenserver/feature/REQ-680
REQ-680: Rebranding XenServer to Citrix Hypervisor
2018-09-21 00:28:44 +01:00
Michael Z
40197ae2d0 REQ-680: Fix auto-merge errors.
Signed-off-by: Michael Z <michael.zhao@citrix.com>
2018-09-20 22:41:11 +08:00
Mihaela Stoica
592b110f06 CA-297216: Remove the upsell message from the memory tab and disable the DMC settings for VMs in the "Memory Setting" dialog if the server is not licensed.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-09-18 15:33:53 +01:00
Michael Z
9034c5a57a REQ-680: Merge master to feature branch.
Signed-off-by: Michael Z <michael.zhao@citrix.com>
2018-09-17 20:00:30 +10:00
Michael Z
5e37264185 CA-297617: Change Citrix Hypervisor Tools to Citrix VM Tools.
Signed-off-by: Michael Z <michael.zhao@citrix.com>
2018-09-14 15:54:04 +01:00
Darren Matthews
f7859a1596 L10N: Translation updates
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-08-23 08:41:13 +01:00
Darren Matthews
0e7057d067 L10N: Translation updates and Re-Sync JA & CN resx files to match the new English resx
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-08-22 09:02:08 +01:00
Konstantina Chremmou
1c2845697c Fixed tab order; renamed the radio buttons because it was difficult to tell what each one referred to.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-17 08:23:04 +01:00
Konstantina Chremmou
6885c21b5e Removed unnecessary control VMMemoryControlsBase and moved the logic of the VMs
property to the derived classes (they don't share much of it anyway) and the method
CalcMemoryUsed to the VMShinyBar class where it is needed. Also made the latter's
property Increment non-browsable.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-17 08:23:04 +01:00
Konstantina Chremmou
c67f85ebaa CA-210190: Fixed various layout and truncation issues on the VM/template memory
setting controls. Also removed the various types of ballooning dialogs since
the only thing changing was the contained memory settings control.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-17 08:23:04 +01:00
serenc
1b0338d36b CP-28926: Add additional error message for >2TB VDIs
Signed-off-by: serenc <seren.corbett@citrix.com>
2018-08-15 10:02:15 +01:00
serencorbett1
bf088cb944 CP-27825: Remove restriction on creating >2TB disk (#2160)
* Remove restriction on creating >2TB disk
* Changed restrictions for resizing VDI
* Removed old method and replaced it with direct calls to new method

Signed-off-by: serenc <seren.corbett@citrix.com>
2018-08-06 15:28:32 +01:00
Mihaela Stoica
61ee71dac1 CA-290536: Fix XenCenter uncaught exception in VM console when losing host connection
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-08-06 15:14:24 +01:00
Darren Matthews
a6991596a5 L10N Bug Fixes (CA-294292 & CA-294333) (#2163)
* L10N: CA-294292 Fixed truncation issue in language files.
* L10N: CA-294333 Fixed overlapping issue in Japanese file.
* L10N: CA-294333 Fixed overlapping issue in Japanese file.

Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-08-02 10:13:54 +01:00