Commit Graph

1110 Commits

Author SHA1 Message Date
Gabor Apati-Nagy
1c5ba794b4 CA-217232: Fixed regression caused by the fix for CA-216935
Changes following the code review
2016-08-18 16:00:50 +01:00
Gabor Apati-Nagy
53619c775d Merge remote-tracking branch 'github_xenadmin/master' into REQ-156_github_master
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

Conflicts:
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_SelectServers.cs
	XenModel/Actions/ParallelAction.cs
	XenModel/FriendlyNames.resx
	XenModel/Messages.Designer.cs
	XenModel/Messages.resx
2016-08-18 12:22:40 +01:00
Konstantina Chremmou
73a549a4d0 Improvements made while investigating CA-218953:
- when the cd drive or the tools iso cannot be found, the action should fail.
- if the tools SR is broken, do not show the error on a pop-up because the UX is
bad when installation is attempted on multiple VMS.
- added one more entry to the list of possible tools iso names.
- small performance improvement.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-17 22:35:01 +01:00
Gabor Apati-Nagy
a069e177c3 Merge pull request #1118 from MihaelaStoica/CA-147142
CA-147142: ReadOnly user should not be allowed to delete crash dump f…
2016-08-16 16:16:56 +01:00
Gabor Apati-Nagy
3fc9c3edb6 Merge pull request #1111 from MihaelaStoica/CA-210549
CA-210551: Non-modal action progress bar on the Pre-Checks page of th…
2016-08-16 16:08:54 +01:00
Callum McIntyre
a41c76a0ba CA-217821: Remove unused TARGET_SERVER_MENU_ITEM key from Japanese+Chinese resources
Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-15 16:38:48 +01:00
Callum McIntyre
05efba8b9f CA-217821: Rename command back to CrossPoolMigrateToHomeCommand 2016-08-15 16:13:35 +01:00
Mihaela Stoica
b35564cb85 CA-147142: ReadOnly user should not be allowed to delete crash dump files
- Made the action PureAsyncAction, so that it automatically checks if the current user can perform all the necessary api calls

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-15 14:27:43 +01:00
Callum McIntyre
3a5444ceb2 CA-217821: Specified home server in cross pool migration should behave as home server
Mostly just terminology changes from home server to target server in the CPM wizard. Changes in shared component SelectMultipleVMDestinationPage (shared with ImportWizard) to allow CPM wizard to rename the Home Server column (as it can the VM/template one - using the same pattern).

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-15 14:22:18 +01:00
Gabor Apati-Nagy
c90582a72e Merge pull request #1116 from GaborApatiNagy/master_livepatch
CP-18012: Fixed the Jenkins build, regenerated resources
2016-08-12 18:31:27 +01:00
Gabor Apati-Nagy
b835090338 CP-18012: Fixed the Jenkins build, regenerated resources
Fixed test:
1) Test Failure : XenAdminTests.UnitTests.MiscTests.NamesAndMessagesTests.XapiFriendlyNameStaticMethodsReturnStrings
     Null value returned for get_SR_BACKEND_FAILURE_457
  Expected: not null
  But was:  null

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-12 18:26:30 +01:00
Gabor Apati-Nagy
9dd3a41857 Revert "Cp 18011: [XenCenter] Add live patching checkbox" 2016-08-12 17:19:34 +01:00
Mihaela Stoica
aeeb1260e7 Merge pull request #1110 from mcintyre94/CP-18011
Cp 18011: [XenCenter] Add live patching checkbox
2016-08-12 17:17:37 +01:00
Mihaela Stoica
e5ab6fe06d Add ElyOrGreater function
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-12 17:03:49 +01:00
Callum McIntyre
1cfa2f6df0 CP-18011: Change the restrict_live_patching check to use BoolKeyPrefer true
This means that if license_params doesn't contain this key we consider it restricted.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-12 16:05:50 +01:00
Callum McIntyre
cc25e3ec45 CP-18011: [XenCenter] Add live patching checkbox
UI changes to add rubric label and radio buttons instead of a checkbox.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-12 15:58:49 +01:00
Mihaela Stoica
549bcd8480 CA-210551: Non-modal action progress bar on the Pre-Checks page of the Hotfix and RPU wizards
- Moved progress bar at the bottom of the page and made it the same height as on Upload page; This progress bar is now used when the prechecks are performed (existing functionality) and also for the "resolve" actions (new functionality).
- Added a label for displaying action progress.
- The icon and label saying that you need to resolve problems is hidden when there are no issues found and when an action is in progress (when the progress label is shown instead).
- When a resolve action is in progress, all controls on the page are disabled, apart from Cancel; pressing Cancel will cancel the "resolve" action and the wizard.
- Also put everything in a TableLayoutPanel (hence all the designer changes)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-12 13:27:47 +01:00
Callum McIntyre
82092adee4 CP-18011: Add licensing check for live patching before showing the new page
Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-12 11:55:12 +01:00
Callum McIntyre
d3f4a4aa99 CP-18011: [XenCenter] Add live patching checkbox
Add the Live Patching tab as a new part of PropertiesDialog, shown for pools and standalone hosts. Tab contains one checkbox which toggles the live_patching_disabled XenServer API property. Not yet implemented: license check ("The option should only be shown if the pool is licensed")

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-12 09:51:20 +01:00
Konstantina Chremmou
61640d6435 CA-217846: Fixed two more tooltip texts with fullstops.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-12 09:15:42 +01:00
Callum McIntyre
f67c0e0a6b CP-18011: Add live patching checkbox
Bringing in XenAPI changes for live patching

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-11 13:17:36 +01:00
Gabor Apati-Nagy
9f7a635da1 Merge remote-tracking branch 'github_xenadmin/REQ-156' into REQ-156
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

Conflicts:
	XenAdmin/Core/Updates.cs
2016-08-10 12:50:45 +01:00
Gabor Apati-Nagy
f9d8b4dea9 CA-217862: Batch updates: Install dundee released hotfixes in Batch fails when pool slave is not reachable and pool partially upgraded
Partially upgraded pools are not supported. If the versions of servers mismatch in a pool, Automatic updating will be disabled with the appropriate info message.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-10 10:48:22 +01:00
Konstantina Chremmou
5f75c0dd74 CA-217847: Fixed issue where servers were marked as unable to be updated automatically
even when automatic mode was supported for them. The problem was that the xenserver
versions were not retrieved from the DownloadUpdatesXmlAction once the latter had run.
Also, minor refactoring.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-09 16:53:02 +01:00
Konstantina Chremmou
62543bcf26 Merge pull request #1094 from MihaelaStoica/CA-210549
CA-210549: Make MultipleAction and ParallelAction cancellable
2016-08-09 15:13:58 +01:00
Mihaela Stoica
4046ce0f95 Merge pull request #1096 from GaborApatiNagy/master_batch_new2
CA-217382: Batch updates: Install batch updates is not showing low di…
2016-08-09 14:17:48 +01:00
Konstantina Chremmou
208d4aa1f9 Merge pull request #1099 from GaborApatiNagy/CA-217844
CA-217844: Handling Automatic update not supported
2016-08-09 14:05:12 +01:00
Gabor Apati-Nagy
7289a771fb CA-217844: Handling Automatic update not supported
Fixed tooltip following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-09 13:40:39 +01:00
Konstantina Chremmou
5ccea31130 CA-217846: Removed full stop from tooltip.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-09 12:51:18 +01:00
Mihaela Stoica
f914f03c21 CA-210549: Make MultipleAction and ParallelAction cancellable
- Fixed the way we calculate PercentComplete for ParallelAction: use the sum of actions in actionsByConnection and actionsWithNoConnection instead of subActions.Count, to avoid waiting for the completion of actions that we never start, because we exclude actions with disconnected connections from actionsByConnections
2016-08-09 10:03:11 +01:00
Gabor Apati-Nagy
e28ca1ded1 CA-217844: Handling Automatic update not supported
If there is no <minimalpatches /> tag, the version is not supported. This check has priority over licensed state when displaying the reason why a server is not supported.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-08 18:30:54 +01:00
Gabor Apati-Nagy
16afbd3bed CA-217382: Batch updates: Install batch updates is not showing low disk space error in pre-checks when host dom0 is full
Fixes following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-08 18:05:42 +01:00
Konstantina Chremmou
e9ca8b529a CA-217843 best effort: Run RestoreDismissedUpdates action asynchronously to prevent UI hiccups.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-08 14:37:47 +01:00
Gabor Apati-Nagy
f93a977ddf CA-217382: Batch updates: Install batch updates is not showing low disk space error in pre-checks when host dom0 is full
Implemented pre-check to check whether there is enough free disk space
before starting updating a pool.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-05 18:05:09 +01:00
Konstantina Chremmou
9d05bcdce5 CA-33357: Improvements: show the disk name on the New VM storage page so it is
more obvious to the user that they can edit it. To this purpose change the button
Properties to Edit (and do the same on the Networking page for consistence). Also
show the name of the disk (ellipsized if too long) on the wizard's finish page.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-05 16:02:03 +01:00
Mihaela Stoica
56038e3eba CA-210549: Make MultipleAction and ParallelAction cancellable
- The multiple action is cancellable if is at least one sub action is not completed
- When a multiple action is cancelled, we try to cancel all sub actions that are not completed
- Also changed the way we calculate the percent complete for the parent action, to report partial progress of the sub actions

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-05 15:46:07 +01:00
Gabor Apati-Nagy
8e30dc32b7 Merge pull request #1087 from Frezzle/CA-214622
CA-214622: Confusing info shown on Install Update screen
2016-08-01 11:41:20 +01:00
Frezzle
9dd0c41e7a [CA-214622] XenCenter Install update Wizard Confusing Info shown on Install update screen
Changed message to "Deleting update installation file ..." to match wording in previous page of the wizard.

Signed-off-by: Frezzle <frederico.mazzone@citrix.com>
2016-07-28 13:50:09 +01:00
Gabor Apati-Nagy
3ca0db4b98 Merge pull request #1072 from Frezzle/CA-209198
CA-209198: Allowed to attempt to install hotfix when it is already applied
2016-07-25 15:04:21 +01:00
CITRITE\sriharshak
853f01b961 L10N:Fix:[CTXS] (IN-215) Translate fail for the description when create a new disk 2016-07-25 13:47:55 +05:30
Konstantina Chremmou
b9b00ca4cd CA-149814: Added short description to fill in the redundant space on the top of the
FolderBrowser dialogs. Fixed text which caused label to look unaligned. Prevent
crash when attempting to launch the DownloadAppliance dialog with "http://" as URI.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-07-22 08:31:58 +01:00
Konstantina Chremmou
dae95e1065 CA-207901: Fixed grammar in the vGPU description (error manifested itself on the Assign vGPU page in the NewVM wizard).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-07-21 22:21:26 +01:00
Mihaela Stoica
6078612916 Merge pull request #1071 from Frezzle/CA-214622
CA-214622: XenCenter Install update Wizard Confusing Info shown on Install update screen
2016-07-20 10:37:19 +01:00
Konstantina Chremmou
917754c937 CA-192541: Added detail to the Import/Export OVF/OVA and Import Disk Image actions
title so we can tell the one from the other. For consistency I used a format similar
to Import/export XVA. I also removed the gerund from the latter as it cannot be
used when the action is completed.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-07-19 23:53:17 +01:00
Frezzle
5555709337 [CA-209198] Allowed to attempt to install hotfix when it is already applied
XenCenter no longer ignores checking if the master host already has the specified patch applied; it now checks before trying to apply it, which means we get no error in the Patching Wizard's Patching Page.

Signed-off-by: Frezzle <frederico.mazzone@citrix.com>
2016-07-19 17:49:40 +01:00
Frezzle
0e133fb415 [CA-214622] XenCenter Install update Wizard Confusing Info shown on Install update screen
Changed confusing message from "Removing update ..." to "Removing update file ...".

Signed-off-by: Frezzle <frederico.mazzone@citrix.com>
2016-07-19 14:18:58 +01:00
Gabor Apati-Nagy
a007eec882 CA-216162: Batch updates: Wrong hover message on install update wizard when installing batch updates
Better messages on Select Server Page

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-19 09:12:30 +01:00
Konstantina Chremmou
91d2715a00 Merge pull request #1059 from MihaelaStoica/CA-203345
CA-203345: Exporting snapshot jams and cant be cancelled (when export…
2016-07-14 11:26:17 +01:00
Mihaela Stoica
1352be8612 CA-203345: Use DestroyTask() in WlbReportAction
Replaced the call to Task.destroy() with the DestroyTask() method, which additionally sets RelatedTask to null. This ensures that we stop polling the task for its progress and report the error.
2016-07-14 10:01:45 +01:00
Konstantina Chremmou
ea60eaa24e Merge pull request #1065 from xenserver/CAR-2217
Request to merge CAR-2217 into master
2016-07-11 14:11:00 +01:00