Commit Graph

3949 Commits

Author SHA1 Message Date
Gabor Apati-Nagy
79311b7546 Merge pull request #137 from MihaelaStoica/CA-136173
CA-136173: Getting several notifications for one user-level action
2014-07-22 17:42:52 +01:00
Mihaela Stoica
c58ad08894 Merge pull request #136 from GaborApatiNagy/xs64bit_CA-140636
CA-140636: Creedence XenCenter threw an unexpected error (build 87029)
2014-07-22 17:04:48 +01:00
Gabor Apati-Nagy
a5b0731e8f Merge pull request #139 from MihaelaStoica/xs64bit
PhysicalStoragePage: In the sr_PropertyChanged event handler we need to ...
2014-07-22 17:02:27 +01:00
Gabor Apati-Nagy
41228753dd Merge pull request #138 from MihaelaStoica/CA-140336
CA-140336: Hide the Windows menu item at all times
2014-07-22 16:37:48 +01:00
Mihaela Stoica
9772a4a97b PhysicalStoragePage: In the sr_PropertyChanged event handler we need to invoke the refresh function on the UI thread, to avoid cross thread operation exception.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-07-22 13:31:35 +01:00
Mihaela Stoica
7ab3243980 CA-140336: Hide the Windows menu item at all times
- cannot remove completely because of the plugin specification, but it is not be visible even if they were plugins trying to use it

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-07-22 13:20:21 +01:00
Mihaela Stoica
c6a7f17ec4 CA-136173: Getting several notifications for one user-level action (e.g. Updating network operation creates 4 entries in the Notifications/Events view)
-  Suppress history for sub-actions in the Edit tags command

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-07-21 11:47:14 +01:00
Mihaela Stoica
cb7dcc81f4 CA-136173: Getting several notifications for one user-level action (e.g. Updating network operation creates 4 entries in the Notifications/Events view)
- Set the pool details in the action to allow proper filtering by location on the Events page
- Also, when possible, set the Host property: when setting the SR in the action, we also set the Host to SR.Home

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-07-21 11:40:26 +01:00
Mihaela Stoica
b544924559 CA-136173: Getting several notifications for one user-level action (e.g. Updating network operation creates 4 entries in the Notifications/Events view)
- Multiple action: propagate error messages back up the action tree to the parent action.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-07-21 11:24:33 +01:00
Mihaela Stoica
3c051654d6 CA-136173: Getting several notifications for one user-level action (e.g. Updating network operation creates 4 entries in the Notifications/Events view)
-  Suppress reporting of success and failure for sub-actions:
The suppress history flag is set when the action is created and if is false (by default) the action is added to the history (the Events list).
In order to suppress history for the subactions, we need change all actions used in Edit pages so their constructor can set the SuppressHistory flag and then use these constructors with suppressHistory = true on all the implementations of IEditPage.SaveSettings() where an action is created
(then we need to remember to do the same everytime we introduce a new page and / or "save" action).

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-07-21 11:19:04 +01:00
Gabor Apati-Nagy
f137d19ffe CA-140636: Creedence XenCenter threw an unexpected error (build 87029)
-According to the call stack this is the place where the exception can come.  Although I was not able to reproduce the exception, this fix solves a possible argument (index) out of range exception. With this check, point merging is not going to be done if it would be unnecessary anyway when there were an empty list to be merged (count==0).

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2014-07-17 19:16:56 +01:00
Gabor Apati-Nagy
71d956a40f Merge pull request #135 from MihaelaStoica/xs64bit
CP-8120 Cores-per-socket: When building the topology list ignore the max...
2014-07-17 15:08:59 +01:00
Mihaela Stoica
8692c7ae19 Merge pull request #131 from GaborApatiNagy/xs64bit-CA140647_2
CA-140647: Customer is not getting the list of updates when ever they se...
2014-07-17 13:05:43 +01:00
Gabor Apati-Nagy
613bb22809 Merge pull request #134 from MihaelaStoica/CA-138293
CA-138293: Added vCPUs_max to the VM General tab (shown only if is diffe...
2014-07-17 13:01:22 +01:00
Gabor Apati-Nagy
4e9327d1af Merge pull request #130 from MihaelaStoica/CA-138822
CA-138822: Improvements to the Host/Pool Storage tab, following on from ...
2014-07-17 12:47:00 +01:00
Mihaela Stoica
8c6f9eebc1 CP-8120 Cores-per-socket: When building the topology list ignore the maximum number of cores-per-socket (i.e. number of cores per socket on the underlying server) if this is zero, for example because the socket information is not available on 6.1 servers.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-07-17 12:46:59 +01:00
Mihaela Stoica
08d4db4d30 Merge pull request #132 from GaborApatiNagy/xs64bit-VMWizardFixBIOS
CA-140265: EN: New VM wizard still stay at “Template” with enable Copy h...
2014-07-17 09:37:47 +01:00
Mihaela Stoica
e2f8830792 Merge pull request #133 from GaborApatiNagy/xs64bit-spellingfix
CA-137306: Missing resources
2014-07-17 09:26:26 +01:00
Gabor Apati-Nagy
8ceb6fe2e8 CA-137306: Missing resources
-typo

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2014-07-16 19:07:21 +01:00
Gabor Apati-Nagy
ea1b6e0f67 CA-140265: EN: New VM wizard still stay at “Template” with enable Copy host BIOS strings to VM.
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2014-07-16 18:13:18 +01:00
Gabor Apati-Nagy
58649f9916 CA-140647: Customer is not getting the list of updates when ever they select the "Check for Updates" option from the tools menu within Xencenter.
-Added 'Host:' to HTTP headers for all the HTTP GET and PUT requests sent by XenCenter.
This change will presumably fix network issues occurring when going through certain corporate firewalls/proxies.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2014-07-16 17:37:40 +01:00
Mihaela Stoica
202f1b8e97 CA-138293: Added vCPUs_max to the VM General tab (shown only if is different than VCPUs_at_startup) 2014-07-16 14:55:22 +01:00
Mihaela Stoica
7d50b22e94 CA-138822: Improvements to the Host/Pool Storage tab, following on from the TRIM work
- Show tooltip on "Reclaim freed space" button on multiselect

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-07-16 14:24:49 +01:00
Mihaela Stoica
104d4445e1 Merge pull request #129 from GaborApatiNagy/xs64bit-CA-137306
CA-137306: Missing resources
2014-07-15 15:13:33 +01:00
Gabor Apati-Nagy
c7106322a0 Merge branch 'xs64bit' of https://github.com/xenserver/xenadmin into xs64bit-CA-137306
Conflicts:
	XenModel/FriendlyNames.resx
2014-07-15 15:11:54 +01:00
Gabor Apati-Nagy
46dd32362c Merge pull request #127 from MihaelaStoica/CA-108379
CA-108379: Hotfix prechecks encourage VMs to be suspended unnecessarily ...
2014-07-15 15:06:43 +01:00
Mihaela Stoica
da87dd2fe2 CA-108379: Hotfix prechecks encourage VMs to be suspended unnecessarily if HA is enabled - Fixed
- Added the "host not live" check and warning to the StorageLink status check

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-07-15 15:04:18 +01:00
Gabor Apati-Nagy
64a51020ec Merge pull request #126 from MihaelaStoica/CA-138293
CA-138293: Added CPU information (number of vCPUs and cores-per-socket) ...
2014-07-15 14:49:57 +01:00
Gabor Apati-Nagy
5826395f00 Merge pull request #123 from MihaelaStoica/CA-138822
CA-138822: Improvements to the Host/Pool Storage tab, following on from ...
2014-07-15 14:42:38 +01:00
Gabor Apati-Nagy
fcb40b6c2a Merge pull request #122 from MihaelaStoica/CA-118423
CA-118423: Fix the issue where a non-management bond was shown as discon...
2014-07-15 14:01:49 +01:00
Gabor Apati-Nagy
29fa59e1f9 Merge pull request #119 from MihaelaStoica/CA-139888
CA-139888: Changing window size should not change the number of items mi...
2014-07-15 13:50:54 +01:00
Gabor Apati-Nagy
8aa0dcb1a0 CA-137306: Missing resources
-Added friendly names for RRDd logs

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2014-07-15 11:43:36 +01:00
Mihaela Stoica
231898fab0 Merge pull request #128 from GaborApatiNagy/xs64bit-fixed-CA-137047
CA-137047: StorageXenMotion not offering all hosts in drop down menu
2014-07-14 18:04:58 +01:00
Gabor Apati-Nagy
72e88af867 CA-137047: StorageXenMotion not offering all hosts in drop down menu
+1 change after code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2014-07-14 18:02:48 +01:00
Gabor Apati-Nagy
b78cb5d8fe CA-137047: StorageXenMotion not offering all hosts in drop down menu
Some changes after code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2014-07-14 17:53:34 +01:00
Gabor Apati-Nagy
134f621db9 CA-137047: StorageXenMotion not offering all hosts in drop down menu
-Fixed Home server's commands to try to use both versions of migration when deciding to enable or disable the menu item

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2014-07-14 17:53:20 +01:00
Mihaela Stoica
9dfeba8be3 Merge pull request #124 from GaborApatiNagy/netmask
CA-116005: validation of the SN mask doesn't appear to be working correctly on the last two values of the mask.
2014-07-14 16:25:40 +01:00
Mihaela Stoica
80348d854e CA-108379: Hotfix prechecks encourage VMs to be suspended unnecessarily if HA is enabled - Fixed
- Added three Warning classes (HAEnabledWarning, WLBEnabledWarning, HostNotLiveWarning), used in the Pre-checks page of the Install wizard (also in the Rolling Pool Upgrade wizard) to indicate that a check was skipped and the reason why.
- If HA or WLB is on, we show this as an error in the "HA and WLB status" check and the "VM migration status" checks will be skipped (with a warning displayed) for all the hosts in the pool.
- Similarly, if a host if unreachable, we show this as an error in the "Host liveness status" check and the following checks for that host will be skipped (and warning displayed).

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-07-14 16:00:43 +01:00
Mihaela Stoica
963f21b074 CA-138293: Added CPU information (number of vCPUs and cores-per-socket) to the VM General tab
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-07-14 15:17:47 +01:00
Gabor Apati-Nagy
e3c2b66feb CA-116005: validation of the SN mask doesn't appear to be working correctly on the last two values of the mask.
-Unit tests added for Subnetwork mask validation (31 tests)

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2014-07-11 12:37:32 +01:00
Mihaela Stoica
005cb8e709 CA-138822: Improvements to the Host/Pool Storage tab, following on from the TRIM work
- Make "Reclaim freed space" a CommandButton (will appear as disabled if the command cannot execute)
- Add tooltip to "Reclaim freed space" button to show the reason it is disabled
- Hide "Reclaim freed space" button on old servers
- Allow multiselect
- "Reclaim freed space" button enabled if at least one SR can be trimmed

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-07-11 12:24:58 +01:00
Gabor Apati-Nagy
205ffe16d9 CA-116005: validation of the SN mask doesn't appear to be working correctly on the last two values of the mask.
-New IPv4 subnet mask validator added.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2014-07-11 11:41:38 +01:00
Stephen Turner
9825ffc41f Merge pull request #121 from GaborApatiNagy/login_originator_CA-140330
CA-140330: Use originator in session.login_with_password
2014-07-10 16:14:57 +01:00
Mihaela Stoica
aaa31357fa CA-118423: Fix the issue where a non-management bond was shown as disconnected in XenCenter because the NICs tab was not refreshed when the properties of the new bond changed.
- Register a PIF CollectionChanged event, so the page is refreshed when a bond is added / deleted.
- Register the PIF PropertyChanged event to each PIF when the grid is populated; this ensures that all the PIFs displayed will be refreshed when their properties change.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-07-10 15:41:33 +01:00
Gabor Apati-Nagy
fe37c06ab6 CA-140330: Use originator in session.login_with_password
-Calling new overload of the session.login_with_password() XAPI function (+originator field). This lets XenServer to group all sessions from a given XenCenter instance.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2014-07-10 14:58:36 +01:00
Stephen Turner
8deb94d290 Merge pull request #120 from MihaelaStoica/CA-139588
CA-139588: Try to prevent Index was out of range exception by invoking o...
2014-07-10 14:44:26 +01:00
Mihaela Stoica
58b240bcde CA-139888: Changing window size should not change the number of items minimized in Outlook-style navigation panel
This fixes the following problem:
When the main window is resized, we set the minimum width of the right side panel (Panel2MinSize) to half the size of the window so that the tab contents are visible. This is fine on most situations, but on a higher screen resolution (e.g. 1920x1080) the following problem occurs:
- starting with the main window at minimum size, when the window is maximized, the Panel2MinSize is set to half window's size (e.g. 960)
- when the main window is restored back to the minimum size, the split container is not resized because there is a conflict between Panel2MinSize and the size of the window itself (Panel1MinSize + Panel2MinSize > window's width)
- therefore the navigation panel is not visible and also the content of the tab control may appear out of scale.

To fix this, we set the Panel2MinSize to half of the window's minimum width. This way the right side panel will always fit in the window, including when it is restored to minimum size.
This also fixes [CA-137956] - Restoring Maximised XenCenter does not resize the main panel properly.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-07-10 12:04:32 +01:00
Gabor Apati-Nagy
a0d31920c5 Merge pull request #118 from xenserver/xs64bit
Xs64bit
2014-07-10 11:17:13 +01:00
Mihaela Stoica
eeb86b7956 CA-139588: Try to prevent Index was out of range exception by invoking on the event thread
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-07-09 14:55:19 +01:00
Gabor Apati-Nagy
fdbfbb3453 Merge pull request #113 from MihaelaStoica/CA-139888
CA-139888: Changing window size should not change the number of items mi...
2014-07-09 09:50:11 +01:00