Commit Graph

1216 Commits

Author SHA1 Message Date
Konstantina Chremmou
65fa1b3033 Removed copyright from resx files. Text corrections.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-22 12:49:03 +01:00
Konstantina Chremmou
fc07e2344e Missing comma. Wrong AutoScaleMode.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-22 11:48:14 +01:00
Konstantina Chremmou
9157735803 CP-30958: Initial implementation of the Conversion Manager in XenCenter. (#2481)
* CP-30958: Initial implementation of the Conversion Manager in XenCenter.
* Corrections following review and improvements.
* Further corrections and improvements.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-22 10:47:43 +01:00
Mihaela Stoica
76c806c0b3 CA-322790: Fix unhandled exception when the host cannot be reached to execute an API call.
In the CrossPoolMigrateCanMigrateFilter a WebException can be raised if the host cannot be reached to execute the API call that asserts is the VM can be migrated there. With these changes, we catch any exception (not just Failure) and mark the VM as not migratable (because we couldn't assert if it can be migrated to that host).

Also fixed other places where the same error might occur.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-07-24 09:46:00 +01:00
Konstantina Chremmou
8f2794b89d Prevent crash and improve behaviour when the user tries to configure/disable HA in a pool that has lost the HA statefile.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-23 10:28:01 +01:00
Mihaela Stoica
c137b4a6ea CA-317752: Take live-patching qualification into consideration in the Install Update pre-checks
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-07-22 17:49:18 +01:00
Konstantina Chremmou
85654a4f36 CA-314720: Replaced "Still waiting" dialog popping up during RPU with a message displayed in the upgrade output.
Also, fixed issue where uploading a supp-pack resulted in a perpetually
pending action if the file had disappeared from the disk.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-22 13:15:59 +01:00
Mihaela Stoica
3d3a96fbe6 CA-323766: Show the upgrade version in the RPU wizard, if available
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-07-22 12:24:07 +01:00
Darren Matthews
60b4282aba L10N : Resx resync and translation update
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-07-18 14:49:51 +01:00
Mihaela Stoica
79c9a7ecbc CA-320203: Fixed the update wizard failure when installing two cumula… (#2466)
CA-320203: Fixed the update wizard failure when installing two cumulative updates

The issue was that when installing 2 new versions in one go (e.g. two cumulative updates), the installation succeeds on master but it cannot continue on slaves, because it cannot find the first CU update anymore.
The fix is to refresh the update record before applying the update, with the record found in the cache. Also, if there is no update in the cache, try to re-introduce the update.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-07-12 14:43:48 +01:00
Konstantina Chremmou
866eae0edc Minor improvements on ImportWizard pages.
- Made storage selector blurb for XVA import a bit more informative.
- A simple checkbox for starting the new VMS on the finish page is adequate.
- Typos. Property modernisation.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-11 11:25:37 +01:00
Konstantina Chremmou
db02d206cb Duplicate hotkey. Layout simplification trying to leverage CA-209149.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-11 11:11:47 +01:00
Mihaela Stoica
71333fcf90 CA-304656: Stop users from applying automated updates that will bring the server to a verson incompatible with the current XenCenter version.
When running the XenCenter version precheck, calculate the higher server version that will be installed (by looking at the update sequence) and use this for checking the XenCenter version compatibility.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-06-11 09:34:25 +01:00
Mihaela Stoica
23b0517cb7 CA-314346: Fix Next button enablement on the Destination page of the VM migrate and VM import wizards.
- if there is only one host in the selected pool, then preselect it.
- make sure that  the Next button is enabled when a target host is selected.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-06-11 09:07:07 +01:00
Michael
99af56ac94 REQ-720: Initial implementation of GPUEditPage and AddVgpuDialog. (#2422)
* CP-31063: Add support for multiple vGPU
(incomplete)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* CP-31063: Add support for multiple vGPU
(part 2)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* AddVGPUDialog

Signed-off-by: Michael Z <michael.zhao@citrix.com>

* Update bindings.

Signed-off-by: Michael Z <michael.zhao@citrix.com>

* REQ-720: Initial implementation of AddVgpuDialog.

Signed-off-by: Michael Z <michael.zhao@citrix.com>

* Improve the handling of buttons and combobox. Fix comments.

Signed-off-by: Michael Z <michael.zhao@citrix.com>

* Fix comments.

Signed-off-by: Michael Z <michael.zhao@citrix.com>
2019-06-10 14:49:31 +08:00
Mihaela Stoica
aaa573dd21
Merge pull request #2438 from xenserver/feature/REQ-745
Merge feature/REQ-745 branch into master
2019-05-20 10:48:48 +01:00
Mihaela Stoica
36b1e44030 CA-310177: Use a new tooltip message when the selected iso is neither corrupted nor an update
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-05-17 12:37:02 +01:00
Mihaela Stoica
6075f5185d CA-310177: Check if the selected iso file contains a valid ISO file system.
Also removed unnecessary call to OnPageUpdated.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-05-17 12:37:02 +01:00
Mihaela Stoica
32a41236a8 CA-317856: Ensure that VMs are repatriated after all hotfixes are appl… (#2436)
* CA-317856: Ensure that VMs are repatriated after all hotfixes are applied and the host has been rebooted.
- there is no need to remove the "reboot host" plan actions from the delayed actions list, because the action itself has code to check if a reboot is actually needed.
* CA-317856: Only add the "Exit maintenance mode" progress step if the host is in maintenance mode at that point.
- moved the AddProgressStep() call inside the function that checks if anything needs to be done (i.e. is host needs to be enables)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-05-17 12:32:25 +01:00
Mihaela Stoica
c96bf94f8c CA-318280: Add a null check for the VM.appliance property, as it could be null when read from the DR metadata
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-05-15 13:16:21 +01:00
Mihaela Stoica
8e5db5ce58 Merge branch 'master' into feature/REQ-745
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

# Conflicts:
#	XenAdmin/Wizards/PatchingWizard/AutomatedUpdatesBasePage.cs
#	XenAdmin/Wizards/PatchingWizard/PlanActions/RestartHostPlanAction.cs
2019-05-14 16:46:02 +01:00
Mihaela Stoica
f3064173e3 CA-304786: Fix the error where the Patching wizard cannot display available hosts when patch ISO is used by another process
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-04-26 12:14:38 +01:00
Konstantina Chremmou
4ce9878b45 Refactored the VIFDialog to fix various problems: (#2398)
* Refactored the VIFDialog to fix various problems:
- Launch the dialog in using blocks.
- Event GotFocus is not meant to be handled directly in the code.
- Populate the dialog in the OnLoad override instead of the constructor
  as this causes problems at design time.
- Popping up an error message for duplicate MAC on combobox item
  selection or textbox text change is not optimal UX. Perform this
  check once when closing the form. Additionally the parent form of the
  pop up should be the dialog, not the main window.
- The validation messages are not obvious to the user because they are
  hidden in the tooltip of a disabled button. Show them inline instead.
- There is no need to create commands for VIF creation/change; use
  the relevant actions instead.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* Corrections as per code review plus some more code tidy and refactoring.

- Added option to suppress Create/DeleteVIFActions
- Use property RebootRequired to indicate hot-plugging is unavailable
  (assigning various objects of different types to the Result of the action
  during its run may cause confusion).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-04-25 08:23:09 +01:00
Konstantina Chremmou
7c2c970423 Fixed typo.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-04-24 15:03:20 +01:00
Mihaela Stoica
273c9f3394 CA-314346: Fix Next button enablement on the Destination page of the VM migrate and VM import wizards
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-04-16 23:01:11 +01:00
Darren Matthews
bc009bda2c L10N : Translation and resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-04-04 09:05:50 +01:00
Darren Matthews
3e4108cef8 L10N : translation and resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-03-26 12:08:55 +00:00
Konstantina Chremmou
b33e08b73e CP-30918: Show warnings if GFS2 SRs are not used with multipath.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-03-25 06:48:41 +00:00
Aaron Robson
cdc8de930f CA-301907: Improvements to the VMSS dialog, the VMSS frequency properties/wizard page and the VMSS finish wizard page (#2358)
- On the dialog show the next run time in both the client's and the server's local time zone.
- On the VMSS frequency page allow the user to pick the schedule in the client's
  local time zone and show then next run time in both the client's and the server's local time zone.
- Refactoring to fix workflow and class design, reduce amount of code and simplify logic.
- Various layout improvements.

Signed-off-by: Aaron Robson aaron.robson@citrix.com
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-03-15 14:10:42 +00:00
Konstantina Chremmou
788421f3f8 Removed specific version example as it is outdated.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-03-13 15:59:04 +00:00
Konstantina Chremmou
3c730a0c01 CA-310980: Show successful completed status on the patching page when no action is to be taken.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-03-13 15:58:24 +00:00
Mihaela Stoica
94ecd4f21c Fix RestartHostPlanAction
- if we decided to skip the host restart, then we should really skip it

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-03-12 11:22:04 +00:00
Mihaela Stoica
dc333963b6
Merge pull request #2406 from xenserver/master
Merge master into REQ-745
2019-03-12 09:41:39 +00:00
Mihaela Stoica
2d1d1fe5a7 CA-309758: Change the order of filters
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-03-04 11:06:59 +00:00
Mihaela Stoica
4abe4ddb30 CA-309758: Optimisations to the way we assert if Vms can be migrated to a destination pool in the Cross Pool Migrate wizard
- When asserting if a VM can be migrated to a pool we don't have to check all the hosts in the pool at this point, we can enable the pool when we find the first host where migration is possible; we will check the rest of the hosts only if that pool is selected.
- If the destination pool is older than the source, then we don't need to do any server calls because we know that migration to an older host is not allowed.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-03-04 11:06:59 +00:00
Mihaela Stoica
0df39a9d83 CA-310766: Use a dictionary instead of multiple lists
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-02-26 17:38:37 +00:00
Ji Jiang
ea1cd77306 CA-310766: Fix format SR type bug in Hardware HBA new SR wizard
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2019-02-26 17:38:37 +00:00
Mihaela Stoica
130dfe7b55 CA-310250: Improvements to the guest UEFI UI
-  hide the boot mode control if there is only one option (BIOS boot);
- add text "(experimental)" to the experimental options (in the radio button text);
- if an option is disabled, then hide the experimantal warning, as there is already a note saying why it is disabled;
- more detailed experimental warning.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-02-21 12:40:22 +00:00
Mihaela Stoica
adbc768851 CA-309037: If live patching fails, do not attempt to reboot the host, but show a warning in the wizard
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-02-15 11:18:28 +00:00
Mihaela Stoica
788f0cd9df CA-309037: Do the host evacuation before applying the updates
If a host needs to be rebooted after the update application, and the update is not a live patch, then do the host evacuation before applying the update.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-02-15 11:18:28 +00:00
Mihaela Stoica
0fd9897529 Fix RestartHostPlanAction
- if we decided to skip the host restart, then we should really skip it

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-02-15 11:18:28 +00:00
Mihaela Stoica
5da6edaf7e CA-310765: Reset the lostConnection flag, so that a retry of this action runs correctly.
Thsi fixes the bug where XenCenter shows connection failure in the RPU when retrying an upgrade

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-02-14 08:32:05 +00:00
Mihaela Stoica
d2f62111f7 CA-309753: If the user decides not to proceed with cancelling the wizard, then the wizard shouln't do the cleanup actions
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-02-06 15:13:32 +00:00
Konstantina Chremmou
eef3320eca Removed code applicable to servers earlier than dundee since connection to them is now blocked.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-02-06 09:25:38 +00:00
Darren Matthews
e5e82b5496 L10N: Translation and Resx Resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-02-06 09:24:50 +00:00
Konstantina Chremmou
7836717a56 CA-308212: The prepare_host_upgrade plugin should be called on each
of the hosts to be upgraded and not only on the first one in the list.
For this purpose, the test has been moved to the prechecks, and the
failures are now shown as a non-fixable problem.
Further, specification of the network location of the installer files
has moved closer to the upgrade mode selection.
Also, moved the hotfix and upgrade related checks immediately after the
host liveness check.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-31 15:04:03 +00:00
Mihaela Stoica
df534e3f70 CP-30335: Make all warnings in prechecks non-fixable, to avoid opening a modal dialog (for more info) or an URL when Resolve all is pressed
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-01-28 17:44:12 +00:00
Konstantina Chremmou
544bcb4978 CP-29923: Provide user friendly descriptions for errors thrown by the host upgrade plugin.
Moved these errors to the FriendlyNames, which is reserved for resources with
keys coming verbatim from the server.
Some code efficiency corrections to the page's workflow.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-28 14:49:48 +00:00
Konstantina Chremmou
7a4d5719c7 Renamed class and file PropertyManager to FriendlyNameManager to avoid confusion,
because it only manages friendly names; moved it closer to the relevant resource files.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-28 14:49:48 +00:00
Mihaela Stoica
6d44fd0350 CP-30335 - Part 2: Add a new precheck + Part 3: Enhance the error message displayed in case of migration failure during the RPU (#2371)
* CP-30335: Fix RPU wizard tests

* CP-30335: Add abstract class WarningWithMoreInfo and use it for two of the existing Warnings

* CP-30335: Add a new precheck which produces a warning if the Dom0 memory after the upgrade will be increased.

- if the Dom0 memory after the upgrade is known, then a warning is shown if this is higher than the current memory, regardless of the version of the upgrade
- if the Dom0 memory after the upgrade is not known (e.g. because the rpu plugin does not have the function that returns this), then a warning is shown if upgrading from a pre-Naples version

* CP-30335: Add a more detailed error message if the host evacuation fails due to not enough memory in the RPU and Patching wizards

* CP-30335: Add branding variable for version 8.0

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-01-28 14:44:58 +00:00