Commit Graph

488 Commits

Author SHA1 Message Date
Bengang Yuan
5815dfa086 For pool, add a CheckBox for decide if to sync the NRPE configuration to all hosts. 2023-10-24 15:47:40 +01:00
Bengang Yuan
a720105fb9 Rename private instance class fields name, add parameters changing check, etc. 2023-10-24 15:47:40 +01:00
Konstantina Chremmou
d941e0f533 Some layout and wording tweaks.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-10-24 15:47:40 +01:00
Bengang Yuan
64c8f43961 CP-44372: Integrate NRPE UI with backend interface 2023-10-24 15:47:40 +01:00
Konstantina Chremmou
efbc55c9b6 CA-383376: Fixed layout issue on the Installation media page of the New VM wizard. Also, disabled unit test for localized resources.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-10-06 00:13:32 +01:00
Konstantina Chremmou
dd98fe6732
CP-45071: Convert XenCenter build scripts to PowerShell. (#3219)
* CP-45071: Convert XenCenter build scripts to PowerShell.
* Removed obsolete variable.
* Pass the timestamp server and the certificate thumbprint as parameters to the build and sign scripts.
* Added further logging and made the verbose output of cmdlets optional.
* Updated README.
* Improved script readability.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-09-06 15:48:12 +01:00
Konstantina Chremmou
54c2fbb3f1 Manifest updates:
- Removed target to add manifest using mt.exe. The manifest is already in the project and embedded in the executable after the build.
- Removed Windows Vista and Windows 8 as .NET Framework 4.8 is not installable there.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-24 14:19:07 +01:00
Konstantina Chremmou
adec15e2ac CP-40739: Build with VS 2022.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-24 14:19:07 +01:00
Konstantina Chremmou
de1120f18b
More fixes including CA-381728, CA-381618, CA-381225 (#3205)
* CA-381728: If no post-update tasks exist, XenCenter should explicitly state so.

Also, livepatches should be shown if other guidance is absent.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Missing placeholders for building locally without applying branding.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Missing help links.

Also removed scripts that are not used any more.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* CA-381618: The HA/WLB off check is a pool, not a host check.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* CA-381225: Corrected order of running update guidance (also uses input from CA-381718).

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* UPDATES_URL has been renamed to XC_UPDATES_URL.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

---------

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-21 13:35:49 +01:00
Konstantina Chremmou
e4b2b67cf5
Merge pull request #3198 from kc284/master
UX improvements: CA-381442, XSI-1476, CA-375740
2023-08-18 10:35:05 +01:00
Konstantina Chremmou
6cfba9fe5a
Merge pull request #3169 from danilo-delbusso/bug/rdp-crash_CA-379640_XSI-1454
CA-379640, CA-356178, CA-370866: Do not reset remote consoles if they're still attempting connection to a VM
2023-08-17 15:50:22 +01:00
Konstantina Chremmou
2a81e63eba Use different image for the RPM packages to distinguish them from the updates.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-15 02:07:35 +01:00
Konstantina Chremmou
a231ca0876 Added context menu option to configure updates and synchronize.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-09 13:54:15 +01:00
Konstantina Chremmou
ae81d5738a CP-43267: Apply updates from CDN
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-01 13:56:54 +01:00
Konstantina Chremmou
87f1fa3e81 CP-43266: Account for live patches in the update list.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-01 13:56:54 +01:00
Konstantina Chremmou
60284077e3 CP-43266: Added new notifications page to list updates from CDN.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-07-31 11:33:25 +01:00
Konstantina Chremmou
b0c23a2c36 Merge remote-tracking branch 'upstream/master' into feature/cdn-updates
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

# Conflicts:
#	XenAdmin/Properties/Resources.resx
2023-07-31 11:03:23 +01:00
Konstantina Chremmou
3afaff18f8
Merge pull request #3163 from danilo-delbusso/dev/trial-edition-CP-43000
CP-43000: Add edition and CSS upsell messages
2023-07-31 11:00:17 +01:00
Chris
172d87889b
CP-43070 adds leaf coalesce alert (#3164)
Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>
2023-07-28 13:55:05 +01:00
Konstantina Chremmou
9473452657 Restored icons showing updated state of pools and hosts.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-07-28 09:36:54 +01:00
Konstantina Chremmou
385130fef6 CP-43265: Added new dialog to configure updates for servers.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-07-28 09:36:54 +01:00
Danilo Del Busso
1819a46ae8
CP-43000: Add custom icon for trial edition hosts in preview
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-26 14:11:20 +01:00
Konstantina Chremmou
fcc51a0c2d CP-43264: Handle new alert for CSS agreement expiry. Also:
For alerts that have an action link show this before the dismiss item.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-07-24 21:21:48 +01:00
Konstantina Chremmou
9950996db2
Merge pull request #3171 from xenserver/master
Merge master into feature/merge
2023-07-12 10:19:07 +01:00
Danilo Del Busso
7067629b29
Add IRdpClient to abstract some common functionality of RDP clients
The reason this wasn't added to the `AxMsRdpClientX` classes is that I thought it best to not touch `AxMSTSCLib` classes as they are likely generated.

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-11 10:47:01 +01:00
Konstantina Chremmou
cfd0216bf4 CP-43770: Removed images from the WLB credentials dialog. Minor text and layout tweaks:
- The checkbox should be above the credential textboxes.
- Some controls were not aligned correctly.
- Place the controls in tableLayout panels.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-06-29 18:10:29 +01:00
Danilo Del Busso
c463601e52 CP-41573: Add blocking problem if POST82X hosts cannot fetch the EUA
Also:
- Remove unused `button_click` event handler in `AcceptEuaDialog`
- Load EUAs within the `UpgradeRequiresEua` `Check` and removed the spinner from `AcceptEuaDialog`
- Remove `_errors` from `AcceptEuaDialog`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-06-26 10:11:19 +01:00
Danilo Del Busso
49b8f8e16f CP-41573: Add UpgradeRequiresEua and EuaNotAcceptedProblem
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-06-26 10:11:19 +01:00
Konstantina Chremmou
6d83365cfc Merge branch 'master' into feature/merge
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

# Conflicts:
#	XenAdmin/Dialogs/PropertiesDialog.cs
2023-06-13 15:08:36 +01:00
Konstantina Chremmou
56357dc4bc Removed obsolete filter as per code review.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-06-13 14:48:23 +01:00
Konstantina Chremmou
7e78dc898c CP-41473: Restore installation of server updates on the Patching and RPU wizards.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-06-13 14:48:23 +01:00
Konstantina Chremmou
0c1ace1aaf CP-41473: Restored the Notifications>Updates TabPage.
Also, moved the filter indication label from the Alerts/Updates/Events page
to the main window because the Updates page top toolstrip looked too clattered.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-06-13 14:48:23 +01:00
Konstantina Chremmou
eff3cc6030 CP-41473: Restored CfuAvailabilityCheck class.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-06-13 14:48:23 +01:00
Konstantina Chremmou
02ded9ba71 CP-41474: Added setting on the Options dialog to import a client ID for downloading hotfixes for LCM servers.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-06-13 14:48:23 +01:00
Konstantina Chremmou
82ed9b19d3 CP-41473: Restored option to disable live patching for pre-cloud servers.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2023-06-13 14:48:23 +01:00
Konstantina Chremmou
968d2253fb CP-43102: Removed leftover code relevant to EOL XS 5.6.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2023-06-13 14:48:23 +01:00
Danilo Del Busso
6c584bb351
CA-375532, CA-336510, and CP-41825: Add warnings when user selects too many vCPUs (#3119)
* Tidy up `SelectMultipleVMDestinationPage.cs`
* CA-375532 & CA-336510: Add warning when importing VMs with too many vCPUs
* CA-375532 & CA-336510: Prevent users from starting appliance if a VM has too many vCPUs
* Tidy up `Page_CpuMem`: use expression-bodied properties
* Tidy up `Page_CpuMem`: use conventional naming scheme
* Tidy up `Page_CpuMem`: use explicit modifiers
* Tidy up `Page_CpuMem`: use `en-US` locale for names
* Tidy up `Page_CpuMem`: use `var` when possible
* Tidy up `Page_CpuMem`: rename `Vcpus` to `VCpus`
* Tidy up `Page_CpuMem`: reorder elements
* Tidy up `Page_CpuMem`: revert class renaming and fix `vCpus` typos
* CA-375532: Prevent users from starting VM if they select too many vCPUs
* Tidy up `Page_Finish`: use expression-bodied properties
* Tidy up `Page_Finish`: fix typo
* Tidy up `Page_CpuMem`: rename `CanStartVM` to `CanStartVm`
* Remove unnecessary using directives
* Anchor warning icon to the top-left corner of its parent
* CA-375532 & CA-336510: Warn users when selecting more vCPUs than pCPUs in the Properties page
* CP-41825: Add warning for imported VMs with > 32 vCPUs
* CP-41825: Add warning for new VMs with > 32 vCPUs
* CP-41825: Add warning for existing VMs when selecting > 32 vCPUs
* CP-41825: Update wording used to alert users running VMs with > 32vCPUs
* Remove unused local variable in `VappStartCommand.cs`
* Reword some vCPUs messages
* Simplify assignment of `CanStartImmediately` in `Page_Finish.cs`
* Simplify assignment of `CanStartVmsAutomatically` in `ImportFinishPage.cs`
* Remove useless `Count` check in `VappStartCommand`
* Rename `pictureBox1` to `warningPictureBox` and change its `SizeMode`
* Separate CPU and memory warnings in `Page_CpuMem`
* Shorten warning messages shown in `Page_CpuMem`
* Disable option to start VM when memory configuration isn't valid
* Report number of vCPUs and pCPUs when showing warning in New VM wizard
* Tidy up `CpuMemoryEditPage`: rename elements
* Tidy up `CpuMemoryEditPage`: use explicity modifiers
* Tidy up `CpuMemoryEditPage`: Rename `CPUMemoryEditPage` to `CpuMemoryEditPage`
* Tidy up `CpuMemoryEditPage`: Miscellaneous renames and improvements
* Tidy up `CpuMemoryEditPage`: Fix whitespace
* Tidy up `CpuMemoryEditPage`: Use ReSharper code formatter
* Tidy up `CpuMemoryEditPage`: Move events to own region
* Tidy up `CpuMemoryEditPage`: Move `IEditPage` members to own region
* Tidy up `CpuMemoryEditPage`: Order members outside of regions
* Replace topology and vCPU warning labels with structured warnings
* Ensure warnings ends with a dot
* Allow multiple CPU warnings to show at the same time
* Remove warning link for vCPUS > pCPUS Option is not achievable
* Enable option to force unit used in `MemorySpinner`
* Replace `NumericUpDown` with `MemorySpinner` and show warnings at bottom of control
* Check destination pCPUs count when destination is not a pool
* Do not disable option to start VMs after import if user selects a shared SR
* Add memory warning when importing appliance with too much memory
* Sort vCPUs and memory warning strings
* Remove target from `ImportWizard`'s summary
Target is not useful and can cause confusion as appliance VMs could start on non-target hosts
* The home server is needed in the summary when importing XVA. The target server is not needed in the summary when migrating a VM.
* Update warnings when the server selection changes. Corrected memory calculation.
* Show all warnings for vCPUs. Moved topology warning to the bottom. Separated methods for showing memory and vCPU warnings.
* Removed the memory setting from the VM Properties dialog. Split running VM info to a separate panel.
* Corrections to the logic for starting the VM automatically. Also, Fixed a bit the layout of the Finish page to make better use of the available space.
* Corrections as per code review.

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Co-authored-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-06-08 11:24:39 +01:00
Konstantina Chremmou
09611a806e Removed DMC deprecation banner and RPU precheck when upgrading a system with DMC VMs.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-05-05 14:43:12 +01:00
Konstantina Chremmou
947f938016 Corrected typo in filename.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-04-25 13:39:54 +01:00
Konstantina Chremmou
8375754a5b CP-40407: Removed fakeAPI and usage of XmlRpcProxy classes in the application.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-03-31 14:17:55 +01:00
Konstantina Chremmou
dfeb347485 Removed integrated storage link code. The feature was removed long ago.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-03-30 16:38:56 +01:00
Konstantina Chremmou
66bd90662d Removed unnecessary AddServerTask class. Add the new connection once notified by the dialog's CachePopulated event.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-03-22 14:25:45 +00:00
Konstantina Chremmou
3ee2e7e571 Removed obsolete code/hidden functionality and related outdated sample xapi databases.
- Removed sample databases. They are outdated, hence unloadable, and loading

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-03-21 15:51:59 +00:00
Konstantina Chremmou
8cf8e6289a
Merge pull request #3086 from danilo-delbusso/FCoE-CP-41737
CP-41737: Add FCoE deprecation warnings
2023-03-06 15:25:25 +00:00
Konstantina Chremmou
5c70cbfd3d CA-84612: Rewrote the CustomFields Property page to fix some issues:
- The CustomFieldsDialog was an unnecessary intermediate step deteriorating the user experience.
- Fixed layout issues when we have a long list of custom fields.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-28 21:03:16 +00:00
Konstantina Chremmou
423ee7bd81 Added RBAC checks to the actions adding/removing custom fields. Also:
- Converted them to proper AsyncActions to facilitate further refactoring.
- Moved SaveCustomFieldsAction to the same folder as the above.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-28 21:03:15 +00:00
Danilo Del Busso
11328e86b9
CP-41737: Add FCoE SR deprecation warning in RPU wizard
Support for Software FCoE deprecation has been announced in 8.2 CU1

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-28 08:07:27 +00:00
Konstantina Chremmou
7063b3e130 CP-42155: Removed HealthCheck service and related dialogs.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-21 16:05:09 +00:00
Danilo Del Busso
6f6bddd755
CP-40842: Remove CIS upload from Server Status Report wizard (#3087)
* Remove credentials controls from `BugToolPageDestination`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* Explicitly call dispose in `BugToolPageDestination.cs`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* Tidy up code in `BugToolPageDestination.cs`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* Move `StatusReportRow` to its own file

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* Move `ClientSideDataRow` and `HostStatusRow` to own files

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CP-40842: Update order of pages in `BugToolWizard`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CP-40842: Update action and create row for packaging status report in BugTool wizard

Instead of creating a new action, this males ZipStatusReportAction inherit StatusReportAction

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CP-40842: Allow for pending `StatusReportAction` to be cancelled

This avoids the need for a running action to update the status. i.e. an action that has been registered but hasn't started running can be cancelled, too.

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CP-40842: Update content of `ACTION_SYSTEM_STATUS_SUCCESSFUL` message

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CP-40842: Add link to `labelBlurb` in `BugToolPageRetrieveData.cs`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CP-40842: Add report packaging logic to `BugToolPageRetrieveData.cs`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CP-40842: Open CIS URL when clicking on `linkLabelBlurb`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CP-40842: Report packaged data amount in `ZipStatusReportAction`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* Remove unused `using`s

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* Minor layout tweaks.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Renamed folder and namespace to match the ones for the other wizards.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Renamed wizard's private fields. Some code efficiency corrections.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Keep the row classes as private within the BugToolPageRetrieveData class.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Removed leftover unused action.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Tidy up status report messages. Use more relevant icon.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Made blurb localisable.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Renamed private fields.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Simplified the stages of the compilation of the status report.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Renamed row classes again to match the action names.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Simplify reporting the progress of the zipping action.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Recursive call is not necessary. Tweaked message.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* Sort strings

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* Update copyright notices

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

---------

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Co-authored-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
Co-authored-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2023-02-13 13:47:21 +00:00
Konstantina Chremmou
d9a603629f Moved common assembly properties to a separate file.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-25 12:50:49 +00:00