Commit Graph

801 Commits

Author SHA1 Message Date
Konstantina Chremmou
8644ed3d83 CA-381212 : The protocol is not always HTTP/1.1
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-21 13:52:32 +01:00
Konstantina Chremmou
e485a0a803 CA-381215: Try waiting on host.apply_updates if it is not immediately available.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-18 14:06:38 +01:00
Konstantina Chremmou
fe8a28e970 CA-381212, CA-381664: Corrections when fetching list of available updates:
- Try waiting on get_updates if it is not immediately available.
- Log instead of failing when a known (404/500) BadServerResponseException occurs.
- Ensure the UI is refreshed after fetching the list of updates.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-18 14:06:38 +01:00
Konstantina Chremmou
03eb2f08d1 Various corrections:
- Added pool name in the action descriptions.
- Fixed host order on the updates list.
- Synchronize selected was not working for standalone hosts.
- Removed stray call to save settings.
- Null check.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-09 13:53:21 +01:00
Konstantina Chremmou
a55d2340a5 CA-380744: Corrected RBAC permission check for CheckForCdnUpdatesAction.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-03 13:46:52 +01:00
Konstantina Chremmou
c822c87af2 Renamed method to match C# conventions.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-03 13:46:52 +01:00
Konstantina Chremmou
ae81d5738a CP-43267: Apply updates from CDN
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-01 13:56:54 +01:00
Konstantina Chremmou
87f1fa3e81 CP-43266: Account for live patches in the update list.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-01 13:56:54 +01:00
Konstantina Chremmou
98165b9f02 CP-44285: Added new hotfix type Foundational.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-07-31 23:18:04 +01:00
Konstantina Chremmou
c4892897dd Several corrections:
- Last sync date was not shown for standalone hosts.
- Unlocalised string and incomplete release info.
- Converted Synchronise button to a split button to synchronize all/selected pools.
- Update the label above the updates from CDN page when filters are on.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-07-31 23:18:04 +01:00
Konstantina Chremmou
b0c23a2c36 Merge remote-tracking branch 'upstream/master' into feature/cdn-updates
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

# Conflicts:
#	XenAdmin/Properties/Resources.resx
2023-07-31 11:03:23 +01:00
Konstantina Chremmou
36c5b940cc Allow using test locations for downloading LCM hotfixes.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-07-28 10:14:27 +01:00
Konstantina Chremmou
8f18678acc Retrieve the list of available updates for a synchronised pool.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-07-28 09:36:54 +01:00
Konstantina Chremmou
385130fef6 CP-43265: Added new dialog to configure updates for servers.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-07-28 09:36:54 +01:00
Konstantina Chremmou
6d83365cfc Merge branch 'master' into feature/merge
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

# Conflicts:
#	XenAdmin/Dialogs/PropertiesDialog.cs
2023-06-13 15:08:36 +01:00
Konstantina Chremmou
1c5c63feee Renamed methods and fields as per code review.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-06-13 14:48:23 +01:00
Konstantina Chremmou
b998cdad6c CP-41474: Authenticate for downloading updates.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-06-13 14:48:23 +01:00
Konstantina Chremmou
6bed1dcde3 CP-41473: Restored options to check for server updates and new versions automatically.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-06-13 14:48:23 +01:00
Konstantina Chremmou
02ded9ba71 CP-41474: Added setting on the Options dialog to import a client ID for downloading hotfixes for LCM servers.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-06-13 14:48:23 +01:00
Konstantina Chremmou
c694ed26d7 CA-359700: Fixed issue whereby hotfixes applied after an upgrade in parallel were downloaded multiple times.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2023-06-13 14:48:23 +01:00
Konstantina Chremmou
82940850e9 CP-43102: Removed Dundee code.
The check DundeeOrGreater always returns true since we disallow connection to anything earlier than Havana.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2023-06-13 14:48:23 +01:00
Konstantina Chremmou
60bb234f7b Renamed Post2X version to Cloud. Added more Xml docs.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-06-13 14:48:23 +01:00
Konstantina Chremmou
da38f45a36 Removed HostActionKind enum as it does not offer real value.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-06-13 14:48:23 +01:00
Konstantina Chremmou
17b3406639
Merge pull request #3155 from kc284/two_bugs
Fixed two issues when saving pool properties
2023-06-13 13:39:37 +01:00
Konstantina Chremmou
ff869c8ade CA-375805: Fixed various issues when an unprivileged user tries to add a disk to a VM:
- Adding a disk on local SR to an HA protected VM was crashing.
- The user could not plug the disk to the VM even after providing credentials on the role elevation dialog.
- The user had to enter credentials for each of the sub-actions involved in adding a disk.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-06-08 14:02:22 +01:00
Danilo Del Busso
6c584bb351
CA-375532, CA-336510, and CP-41825: Add warnings when user selects too many vCPUs (#3119)
* Tidy up `SelectMultipleVMDestinationPage.cs`
* CA-375532 & CA-336510: Add warning when importing VMs with too many vCPUs
* CA-375532 & CA-336510: Prevent users from starting appliance if a VM has too many vCPUs
* Tidy up `Page_CpuMem`: use expression-bodied properties
* Tidy up `Page_CpuMem`: use conventional naming scheme
* Tidy up `Page_CpuMem`: use explicit modifiers
* Tidy up `Page_CpuMem`: use `en-US` locale for names
* Tidy up `Page_CpuMem`: use `var` when possible
* Tidy up `Page_CpuMem`: rename `Vcpus` to `VCpus`
* Tidy up `Page_CpuMem`: reorder elements
* Tidy up `Page_CpuMem`: revert class renaming and fix `vCpus` typos
* CA-375532: Prevent users from starting VM if they select too many vCPUs
* Tidy up `Page_Finish`: use expression-bodied properties
* Tidy up `Page_Finish`: fix typo
* Tidy up `Page_CpuMem`: rename `CanStartVM` to `CanStartVm`
* Remove unnecessary using directives
* Anchor warning icon to the top-left corner of its parent
* CA-375532 & CA-336510: Warn users when selecting more vCPUs than pCPUs in the Properties page
* CP-41825: Add warning for imported VMs with > 32 vCPUs
* CP-41825: Add warning for new VMs with > 32 vCPUs
* CP-41825: Add warning for existing VMs when selecting > 32 vCPUs
* CP-41825: Update wording used to alert users running VMs with > 32vCPUs
* Remove unused local variable in `VappStartCommand.cs`
* Reword some vCPUs messages
* Simplify assignment of `CanStartImmediately` in `Page_Finish.cs`
* Simplify assignment of `CanStartVmsAutomatically` in `ImportFinishPage.cs`
* Remove useless `Count` check in `VappStartCommand`
* Rename `pictureBox1` to `warningPictureBox` and change its `SizeMode`
* Separate CPU and memory warnings in `Page_CpuMem`
* Shorten warning messages shown in `Page_CpuMem`
* Disable option to start VM when memory configuration isn't valid
* Report number of vCPUs and pCPUs when showing warning in New VM wizard
* Tidy up `CpuMemoryEditPage`: rename elements
* Tidy up `CpuMemoryEditPage`: use explicity modifiers
* Tidy up `CpuMemoryEditPage`: Rename `CPUMemoryEditPage` to `CpuMemoryEditPage`
* Tidy up `CpuMemoryEditPage`: Miscellaneous renames and improvements
* Tidy up `CpuMemoryEditPage`: Fix whitespace
* Tidy up `CpuMemoryEditPage`: Use ReSharper code formatter
* Tidy up `CpuMemoryEditPage`: Move events to own region
* Tidy up `CpuMemoryEditPage`: Move `IEditPage` members to own region
* Tidy up `CpuMemoryEditPage`: Order members outside of regions
* Replace topology and vCPU warning labels with structured warnings
* Ensure warnings ends with a dot
* Allow multiple CPU warnings to show at the same time
* Remove warning link for vCPUS > pCPUS Option is not achievable
* Enable option to force unit used in `MemorySpinner`
* Replace `NumericUpDown` with `MemorySpinner` and show warnings at bottom of control
* Check destination pCPUs count when destination is not a pool
* Do not disable option to start VMs after import if user selects a shared SR
* Add memory warning when importing appliance with too much memory
* Sort vCPUs and memory warning strings
* Remove target from `ImportWizard`'s summary
Target is not useful and can cause confusion as appliance VMs could start on non-target hosts
* The home server is needed in the summary when importing XVA. The target server is not needed in the summary when migrating a VM.
* Update warnings when the server selection changes. Corrected memory calculation.
* Show all warnings for vCPUs. Moved topology warning to the bottom. Separated methods for showing memory and vCPU warnings.
* Removed the memory setting from the VM Properties dialog. Split running VM info to a separate panel.
* Corrections to the logic for starting the VM automatically. Also, Fixed a bit the layout of the Finish page to make better use of the available space.
* Corrections as per code review.

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Co-authored-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-06-08 11:24:39 +01:00
Konstantina Chremmou
d6a11cee77 Rewrote the PerfmonAlertOptionsPage to simplify the code and fix issue whereby the settings were saved even if nothing had changed.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-06-05 18:47:18 +01:00
Konstantina Chremmou
0e0160645c CA-376894: The allowed_operations are not refreshed after vTPM removal in xapi 23.10.0.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-05-05 14:43:12 +01:00
Konstantina Chremmou
d148956a1b CA-376686: There is no API call "live_migrate".
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-04-28 10:12:04 +01:00
Konstantina Chremmou
6a06d5b8d9 CP-42691: Use allowed operations to enable/disable vTPM create/destroy.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-04-25 13:39:54 +01:00
Konstantina Chremmou
8e756dbe5f
Merge pull request #3124 from danilo-delbusso/dev/internal-stage-token
Do not prepend key to `InternalStageAuthToken` query parameters
2023-04-13 21:11:37 +01:00
Danilo Del Busso
44d4482513
Specify caching policy for XML/MSI downloads
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-04-13 11:44:23 +01:00
Danilo Del Busso
dc1e001a8a
Use full URL when downloading updates XML
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-04-13 09:58:23 +01:00
Konstantina Chremmou
f8ab0a1414
Merge pull request #3127 from kc284/proxy_removal
CP-40407: Removal of IXmlRpcProxy related classes and simulation infrastructure
2023-04-12 09:54:17 +01:00
Danilo Del Busso
7b18b3b105
Update DownloadAndUpdateClientAction to not prepend param name when downloading
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-04-12 08:43:42 +01:00
Danilo Del Busso
1b3b4b218d
Move AddAuthTokenToQueryString to Helpers
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-04-12 08:31:05 +01:00
Konstantina Chremmou
9d6d1a185d Simplified SrAction by splitting it to four different actions. Fixed RBAC permissions when detaching SR and destroying PBDs.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-04-03 13:55:02 +01:00
Konstantina Chremmou
8375754a5b CP-40407: Removed fakeAPI and usage of XmlRpcProxy classes in the application.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-03-31 14:17:55 +01:00
Konstantina Chremmou
dfeb347485 Removed integrated storage link code. The feature was removed long ago.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-03-30 16:38:56 +01:00
Danilo Del Busso
16ce163e7f
Remove whitespace only keys from query string
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-03-30 13:31:58 +01:00
Danilo Del Busso
a888ed9274
Only add InternalStageAuthToken if URI isn't pointing to a file
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-03-30 13:31:06 +01:00
Danilo Del Busso
732d1f4a30
Do not pre-pend key to InternalStageAuthToken query parameters
Use of `InternalStageAuthToken=foo` is not needed anymore. Furthermore, we can now provide any token format.

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-03-27 09:28:21 +01:00
Danilo Del Busso
65da63755f
[master] CA-375556: Pass non-compressed file stream to HTTP.CopyStream (#3115)
* CA-375556: Pass non-compressed file stream to `HTTP.CopyStream`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CA-375556: Use `sourcefile` instead of `filePath`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

---------

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-03-24 10:24:10 +00:00
Konstantina Chremmou
488f27e2ae Revised Rbac checks for addition/removal of custom fields.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-28 21:25:02 +00:00
Konstantina Chremmou
423ee7bd81 Added RBAC checks to the actions adding/removing custom fields. Also:
- Converted them to proper AsyncActions to facilitate further refactoring.
- Moved SaveCustomFieldsAction to the same folder as the above.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-28 21:03:15 +00:00
Konstantina Chremmou
87ff42086f Missing RBAC permission checks for CreateDiskAction.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-28 15:36:13 +00:00
Konstantina Chremmou
8c42b0428e Refactored the actions creating disks.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-28 15:36:13 +00:00
Danilo Del Busso
ea9669ce1b
CP-42186: Update XML tag name in DownloadUpdatesXmlAction
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-22 10:30:05 +00:00
Konstantina Chremmou
c70116691a Corrections as per code review:
- Bumped branding to v4.11.
- Reverted VS version in the solution file.
- Removed brand override registry entry.
- Converted HealthCheck warning pop-up to info pop-up.
- Moved status report actions to a separate folder.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-21 16:05:10 +00:00
Konstantina Chremmou
7063b3e130 CP-42155: Removed HealthCheck service and related dialogs.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-21 16:05:09 +00:00